5:23 p.m.
Built-in constraint parameter validation
----------------------------------------
Key: HV-134
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-134
Project: Hibernate Validator
Issue Type: Bug
Components: validators
Affects Versions: 4.0.0.Alpha3
Reporter: Emmanuel Bernard
When params are invalid (ie max < min), the ConstraintValidator raises a
ValidationException.
While not wrong from a spec POV, I don't think the impl has to use VE. It probably
amkes more sense to use IllegalArgumentException
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:10 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-134) Built-in constraint parameter validation
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-134?page=com...
]
Hardy Ferentschik commented on HV-134:
--------------------------------------
At the moment ConstraintDeclarationException is used. I think that should be correct.
Built-in constraint parameter validation
----------------------------------------
Key: HV-134
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-134
Project: Hibernate Validator
Issue Type: Bug
Components: validators
Affects Versions: 4.0.0.Alpha3
Reporter: Emmanuel Bernard
When params are invalid (ie max < min), the ConstraintValidator raises a
ValidationException.
While not wrong from a spec POV, I don't think the impl has to use VE. It probably
amkes more sense to use IllegalArgumentException
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:31 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-134) Built-in constraint parameter validation
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-134?page=com...
]
Emmanuel Bernard commented on HV-134:
-------------------------------------
We can discuss that by IM but I don't think forcing a Bean Validation exception is the
right thing. As a matter of fact, the spec says that every exception raised by the CV
implementation will be wrapped into a ValidationException. It would be more meaningful to
return an IAE in this case.
Built-in constraint parameter validation
----------------------------------------
Key: HV-134
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-134
Project: Hibernate Validator
Issue Type: Bug
Components: validators
Affects Versions: 4.0.0.Alpha3
Reporter: Emmanuel Bernard
When params are invalid (ie max < min), the ConstraintValidator raises a
ValidationException.
While not wrong from a spec POV, I don't think the impl has to use VE. It probably
amkes more sense to use IllegalArgumentException
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:07 a.m.
New subject: [Hibernate-JIRA] Updated: (HV-134) Built-in constraint parameter validation
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-134?page=com...
]
Hardy Ferentschik updated HV-134:
---------------------------------
Assignee: Hardy Ferentschik
Fix Version/s: 4.0.0.GA
Built-in constraint parameter validation
----------------------------------------
Key: HV-134
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-134
Project: Hibernate Validator
Issue Type: Bug
Components: legacy
Affects Versions: 4.0.0.Alpha3
Reporter: Emmanuel Bernard
Assignee: Hardy Ferentschik
Fix For: 4.0.0.GA
When params are invalid (ie max < min), the ConstraintValidator raises a
ValidationException.
While not wrong from a spec POV, I don't think the impl has to use VE. It probably
amkes more sense to use IllegalArgumentException
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:59 a.m.
New subject: [Hibernate-JIRA] Updated: (HV-134) Built-in constraint parameter validation
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-134?page=com...
]
Hardy Ferentschik updated HV-134:
---------------------------------
Component/s: (was: legacy)
engine
Built-in constraint parameter validation
----------------------------------------
Key: HV-134
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-134
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.0.0.Alpha3
Reporter: Emmanuel Bernard
Assignee: Hardy Ferentschik
Fix For: 4.0.0.GA
When params are invalid (ie max < min), the ConstraintValidator raises a
ValidationException.
While not wrong from a spec POV, I don't think the impl has to use VE. It probably
amkes more sense to use IllegalArgumentException
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:35 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-134) Built-in constraint parameter validation
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-134?page=com...
]
Hardy Ferentschik commented on HV-134:
--------------------------------------
Do you still prefer IllegalArguementException?
The spec says in 8.3 "When a constraint declaration is illegal,
ConstraintDeclarationException is raised."
Adding a constraint to an entity including specifying the constraint attributes is in my
eyes a "declaring a constraint". Hence I used ConstraintDeclarationException
(admittedly not consistently yet). I need to make this consistent now and I am wondering
if you changed your mind.
If this is not a case to use ConstraintDeclarationException - where do you use this
exception then anyway?
Built-in constraint parameter validation
----------------------------------------
Key: HV-134
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-134
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.0.0.Alpha3
Reporter: Emmanuel Bernard
Assignee: Hardy Ferentschik
Fix For: 4.0.0.GA
When params are invalid (ie max < min), the ConstraintValidator raises a
ValidationException.
While not wrong from a spec POV, I don't think the impl has to use VE. It probably
amkes more sense to use IllegalArgumentException
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:41 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-134) Built-in constraint parameter validation
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-134?page=com...
]
Hardy Ferentschik commented on HV-134:
--------------------------------------
BTW, ConstraintDeclarationExceptinon is a subclass of ValidationException
Built-in constraint parameter validation
----------------------------------------
Key: HV-134
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-134
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.0.0.Alpha3
Reporter: Emmanuel Bernard
Assignee: Hardy Ferentschik
Fix For: 4.0.0.GA
When params are invalid (ie max < min), the ConstraintValidator raises a
ValidationException.
While not wrong from a spec POV, I don't think the impl has to use VE. It probably
amkes more sense to use IllegalArgumentException
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:51 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-134) Built-in constraint parameter validation
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-134?page=com...
]
Emmanuel Bernard commented on HV-134:
-------------------------------------
A constraint /declaration/ is about putting a constraint on a field. A constraint
/definition/ is about creating the constraint annotation and its constraint validation
implementation.
I still prefer IllegalArgumentException.
Built-in constraint parameter validation
----------------------------------------
Key: HV-134
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-134
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.0.0.Alpha3
Reporter: Emmanuel Bernard
Assignee: Hardy Ferentschik
Fix For: 4.0.0.GA
When params are invalid (ie max < min), the ConstraintValidator raises a
ValidationException.
While not wrong from a spec POV, I don't think the impl has to use VE. It probably
amkes more sense to use IllegalArgumentException
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:51 a.m.
New subject: [Hibernate-JIRA] Resolved: (HV-134) Built-in constraint parameter validation
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-134?page=com...
]
Hardy Ferentschik resolved HV-134.
----------------------------------
Resolution: Fixed
Built-in constraint parameter validation
----------------------------------------
Key: HV-134
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-134
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.0.0.Alpha3
Reporter: Emmanuel Bernard
Assignee: Hardy Ferentschik
Fix For: 4.0.0.GA
When params are invalid (ie max < min), the ConstraintValidator raises a
ValidationException.
While not wrong from a spec POV, I don't think the impl has to use VE. It probably
amkes more sense to use IllegalArgumentException
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:51 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-134) Built-in constraint parameter validation
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-134?page=com...
]
Hardy Ferentschik commented on HV-134:
--------------------------------------
Updated the ConstraintValidator implementations and test to use IllegalArgumentException
Built-in constraint parameter validation
----------------------------------------
Key: HV-134
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-134
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.0.0.Alpha3
Reporter: Emmanuel Bernard
Assignee: Hardy Ferentschik
Fix For: 4.0.0.GA
When params are invalid (ie max < min), the ConstraintValidator raises a
ValidationException.
While not wrong from a spec POV, I don't think the impl has to use VE. It probably
amkes more sense to use IllegalArgumentException
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5599
days inactive
5769
days old
hibernate-issues@lists.jboss.org
9 comments
2 participants
participants (2)
-
Emmanuel Bernard (JIRA) -
Hardy Ferentschik (JIRA)