[Hibernate-JIRA] Created: (JPA-7) JPA Support of Enum as Primary Key

[Hibernate-JIRA] Created:...

Bernard (JIRA)

Friday, 1 October 2010 Fri, 1 Oct '10

1:04 a.m.

JPA Support of Enum as Primary Key ---------------------------------- Key: JPA-7 URL: http://opensource.atlassian.com/projects/hibernate/browse/JPA-7 Project: Java Persistence API Issue Type: Improvement Affects Versions: 1.0.1 Environment: java version "1.6.0_21" Java(TM) SE Runtime Environment (build 1.6.0_21-b07) Java HotSpot(TM) Client VM (build 17.0-b17, mixed mode, sharing) Hibernate JPA as installed with latest NetBeans release 6.9.1 Reporter: Bernard Priority: Critical Attachments: TestCase.zip Enums work as primary keys in TopLink and EclipseLink. DataNucleus supports them, too: http://www.datanucleus.org/products/accessplatform/jpa/primary_key.html In the attached testcase, JPA, via persistence.xml, creates a database column type of VARBINARY. The data contained in it is like: 10101100111011010000000000000101~r0000000000011000main.MyEntity$EntityType0000000000000000000000000000000000000000000000000000000000000000000100100000000000000000xr0000000000001110java.lang.Enum0000000000000000000000000000000000000000000000000000000000000000000100100000000000000000xpt0000000000000110TYPE_1 Type 1 That is not what we need. We need an integer because in the entity class, we specify @Enumerated(value = EnumType.ORDINAL) While Enum as ID field is not specifically supported in the JPA specs, it is not specifically excluded, either. It would be desirable to have the new version of the spec include this feature, too. The attached testcase (zip file) runs with NetBeans out of the box. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

Show replies by date

Karsten Wutzke (JIRA)

Monday, 14 February Mon, 14 Feb

5:47 a.m.

New subject: [Hibernate-JIRA] Commented: (JPA-7) JPA Support of Enum as Primary Key

[ http://opensource.atlassian.com/projects/hibernate/browse/JPA-7?page=com.... ] Karsten Wutzke commented on JPA-7: ---------------------------------- We really need this.

...

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

Karsten Wutzke (JIRA)

Monday, 16 May Mon, 16 May

6:42 p.m.

New subject: [Hibernate-JIRA] Commented: (JPA-7) JPA Support of Enum as Primary Key

[ http://opensource.atlassian.com/projects/hibernate/browse/JPA-7?page=com.... ] Karsten Wutzke commented on JPA-7: ---------------------------------- I've just successfully used a Java ENUM in em.find(...) to find an entity whose PK contains an ENUM in its ID class. This enhancement may be obsolete.

...

Bernard (JIRA)

Tuesday, 17 May Tue, 17 May

1:25 a.m.

New subject: [Hibernate-JIRA] Commented: (JPA-7) JPA Support of Enum as Primary Key

[ http://opensource.atlassian.com/projects/hibernate/browse/JPA-7?page=com.... ] Bernard commented on JPA-7: --------------------------- Karsten, are you able to run the attached testcase successfully? If yes then please report the Hibernate version and we could say that this enhancement is obsolete.

...

Karsten Wutzke (JIRA)

Friday, 20 May Fri, 20 May

12:56 p.m.

New subject: [Hibernate-JIRA] Commented: (JPA-7) JPA Support of Enum as Primary Key

[ http://opensource.atlassian.com/projects/hibernate/browse/JPA-7?page=com.... ] Karsten Wutzke commented on JPA-7: ---------------------------------- Honestly the test case attached isn't very good. It depends on Netbeans and doesn't come without a Netbeans-unspecific Ant script. Note from the code the test case uses only EnumType.ORDINAL whereas my confirmation was only about EnumType.STRING. I'll see what I can do to figure out.

...

Bernard (JIRA)

2:06 p.m.

New subject: [Hibernate-JIRA] Commented: (JPA-7) JPA Support of Enum as Primary Key

[ http://opensource.atlassian.com/projects/hibernate/browse/JPA-7?page=com.... ] Bernard commented on JPA-7: --------------------------- Please read the initial description, "The attached testcase (zip file) runs with NetBeans out of the box." NetBeans writes build scripts for you. If you prefer not to work on this level of integration you may want to hand-code a build script.

...

Karsten Wutzke (JIRA)

Saturday, 21 May Sat, 21 May

4:38 a.m.

New subject: [Hibernate-JIRA] Issue Comment Edited: (JPA-7) JPA Support of Enum as Primary Key

[ http://opensource.atlassian.com/projects/hibernate/browse/JPA-7?page=com.... ] Karsten Wutzke edited comment on JPA-7 at 5/21/11 4:37 AM: ----------------------------------------------------------- The test case *doesn't* run out of the box. The person who attached the test case didn't include *any* DDL or DML scripts to show what the actual data looks like. You can only guess about that. This makes it a completely unusable test case. You should flag this feature as whatever applies. I'm giving up on that test case, I couldn't find out. Note: I will attach my own test case that demonstrates that at least EnumType.String used in a PK works. was (Author: kwutzke): The test case *doesn't* run out of the box. The person who attached the test case didn't include *any* DDL or DML scripts to show what the actual data looks like. You can only guess about that. This makes it a completely unusable test case. You should flag this feature as whatever applies. I'm giving up on that test case, I couldn't find out. I will attach a test case that demonstrates that at least EnumType.String used in a PK works.

...

Karsten Wutzke (JIRA)

4:38 a.m.

New subject: [Hibernate-JIRA] Commented: (JPA-7) JPA Support of Enum as Primary Key

[ http://opensource.atlassian.com/projects/hibernate/browse/JPA-7?page=com.... ] Karsten Wutzke commented on JPA-7: ---------------------------------- The test case *doesn't* run out of the box. The person who attached the test case didn't include *any* DDL or DML scripts to show what the actual data looks like. You can only guess about that. This makes it a completely unusable test case. You should flag this feature as whatever applies. I'm giving up on that test case, I couldn't find out. I will attach a test case that demonstrates that at least EnumType.String used in a PK works.

...

Karsten Wutzke (JIRA)

4:56 a.m.

New subject: [Hibernate-JIRA] Issue Comment Edited: (JPA-7) JPA Support of Enum as Primary Key

[ http://opensource.atlassian.com/projects/hibernate/browse/JPA-7?page=com.... ] Karsten Wutzke edited comment on JPA-7 at 5/21/11 4:55 AM: ----------------------------------------------------------- The test case doesn't run out of the box for me since I'm using Eclipse. A test case should be free of Netbeans or Eclipse garbage. I'll try once more. was (Author: kwutzke): The test case *doesn't* run out of the box. The person who attached the test case didn't include *any* DDL or DML scripts to show what the actual data looks like. You can only guess about that. This makes it a completely unusable test case. You should flag this feature as whatever applies. I'm giving up on that test case, I couldn't find out. Note: I will attach my own test case that demonstrates that at least EnumType.String used in a PK works.

...

Karsten Wutzke (JIRA)

4:58 a.m.

New subject: [Hibernate-JIRA] Issue Comment Edited: (JPA-7) JPA Support of Enum as Primary Key

[ http://opensource.atlassian.com/projects/hibernate/browse/JPA-7?page=com.... ] Karsten Wutzke edited comment on JPA-7 at 5/21/11 4:58 AM: ----------------------------------------------------------- The test case doesn't run out of the box for me since I'm using Eclipse. A test case should be free of Netbeans or Eclipse garbage. Can you post the generated DDL? Then I'll try once more. was (Author: kwutzke): The test case doesn't run out of the box for me since I'm using Eclipse. A test case should be free of Netbeans or Eclipse garbage. I'll try once more.

...

Karsten Wutzke (JIRA)

5:06 a.m.

New subject: [Hibernate-JIRA] Issue Comment Edited: (JPA-7) JPA Support of Enum as Primary Key

[ http://opensource.atlassian.com/projects/hibernate/browse/JPA-7?page=com.... ] Karsten Wutzke edited comment on JPA-7 at 5/21/11 5:05 AM: ----------------------------------------------------------- The test case doesn't run out of the box for me since I'm using Eclipse. A test case should be free of Netbeans or Eclipse garbage. I'll try once more. was (Author: kwutzke): The test case doesn't run out of the box for me since I'm using Eclipse. A test case should be free of Netbeans or Eclipse garbage. Can you post the generated DDL? Then I'll try once more.

...

Karsten Wutzke (JIRA)

5:12 a.m.

New subject: [Hibernate-JIRA] Commented: (JPA-7) JPA Support of Enum as Primary Key

[ http://opensource.atlassian.com/projects/hibernate/browse/JPA-7?page=com.... ] Karsten Wutzke commented on JPA-7: ---------------------------------- I was able to run the test case with Hibernate 3.6.0! Maybe Hibernate 3.5.x already works, too. As I said, EnumType.STRING (a MySQL ENUM('Type 1', 'Type 2')) works without problems. We might consider this feature obsolete.

...

Karsten Wutzke (JIRA)

5:22 a.m.

New subject: [Hibernate-JIRA] Updated: (JPA-7) JPA Support of Enum as Primary Key

[ http://opensource.atlassian.com/projects/hibernate/browse/JPA-7?page=com.... ] Karsten Wutzke updated JPA-7: ----------------------------- Attachment: enum-pks-hibtestcase.zip See the slightly changed test case including the Hibernate 3.6 JARs (the ones I used) and the Hibernate schema generation (in setUp() method).

...

JPA Support of Enum as Primary Key ---------------------------------- Key: JPA-7 URL: http://opensource.atlassian.com/projects/hibernate/browse/JPA-7 Project: Java Persistence API Issue Type: Improvement Affects Versions: 1.0.1 Environment: java version "1.6.0_21" Java(TM) SE Runtime Environment (build 1.6.0_21-b07) Java HotSpot(TM) Client VM (build 17.0-b17, mixed mode, sharing) Hibernate JPA as installed with latest NetBeans release 6.9.1 Reporter: Bernard Priority: Critical Attachments: enum-pks-hibtestcase.zip, TestCase.zip Enums work as primary keys in TopLink and EclipseLink. DataNucleus supports them, too: http://www.datanucleus.org/products/accessplatform/jpa/primary_key.html In the attached testcase, JPA, via persistence.xml, creates a database column type of VARBINARY. The data contained in it is like: 10101100111011010000000000000101~r0000000000011000main.MyEntity$EntityType0000000000000000000000000000000000000000000000000000000000000000000100100000000000000000xr0000000000001110java.lang.Enum0000000000000000000000000000000000000000000000000000000000000000000100100000000000000000xpt0000000000000110TYPE_1 Type 1 That is not what we need. We need an integer because in the entity class, we specify @Enumerated(value = EnumType.ORDINAL) While Enum as ID field is not specifically supported in the JPA specs, it is not specifically excluded, either. It would be desirable to have the new version of the spec include this feature, too. The attached testcase (zip file) runs with NetBeans out of the box.

Karsten Wutzke (JIRA)

5:27 a.m.

New subject: [Hibernate-JIRA] Issue Comment Edited: (JPA-7) JPA Support of Enum as Primary Key

[ http://opensource.atlassian.com/projects/hibernate/browse/JPA-7?page=com.... ] Karsten Wutzke edited comment on JPA-7 at 5/21/11 5:26 AM: ----------------------------------------------------------- I was able to run the test case with Hibernate 3.6.0! Maybe Hibernate 3.5.x already works, too. As I said, EnumType.STRING (tried with a MySQL column_name ENUM(...) *and* HSQLDB column_name VARCHAR(...) CHECK (column_name IN (...))) works without problems. We might consider this feature obsolete. was (Author: kwutzke): I was able to run the test case with Hibernate 3.6.0! Maybe Hibernate 3.5.x already works, too. As I said, EnumType.STRING (a MySQL ENUM('Type 1', 'Type 2')) works without problems. We might consider this feature obsolete.

...

JPA Support of Enum as Primary Key ---------------------------------- Key: JPA-7 URL: http://opensource.atlassian.com/projects/hibernate/browse/JPA-7 Project: Java Persistence API Issue Type: Improvement Affects Versions: 1.0.1 Environment: java version "1.6.0_21" Java(TM) SE Runtime Environment (build 1.6.0_21-b07) Java HotSpot(TM) Client VM (build 17.0-b17, mixed mode, sharing) Hibernate JPA as installed with latest NetBeans release 6.9.1 Reporter: Bernard Priority: Critical Attachments: enum-pks-hibtestcase.zip, TestCase.zip Enums work as primary keys in TopLink and EclipseLink. DataNucleus supports them, too: http://www.datanucleus.org/products/accessplatform/jpa/primary_key.html In the attached testcase, JPA, via persistence.xml, creates a database column type of VARBINARY. The data contained in it is like: 10101100111011010000000000000101~r0000000000011000main.MyEntity$EntityType0000000000000000000000000000000000000000000000000000000000000000000100100000000000000000xr0000000000001110java.lang.Enum0000000000000000000000000000000000000000000000000000000000000000000100100000000000000000xpt0000000000000110TYPE_1 Type 1 That is not what we need. We need an integer because in the entity class, we specify @Enumerated(value = EnumType.ORDINAL) While Enum as ID field is not specifically supported in the JPA specs, it is not specifically excluded, either. It would be desirable to have the new version of the spec include this feature, too. The attached testcase (zip file) runs with NetBeans out of the box.

Bernard (JIRA)

4:01 p.m.

New subject: [Hibernate-JIRA] Commented: (JPA-7) JPA Support of Enum as Primary Key

[ http://opensource.atlassian.com/projects/hibernate/browse/JPA-7?page=com.... ] Bernard commented on JPA-7: --------------------------- Karsten, you are missing the point of this issue which is the failure to map @Id @Enumerated(value = EnumType.ORDINAL) to a numeric field. You are cheating when you use EnumType.STRING. The testcase includes persistence.xml which creates the table via <property name="hibernate.hbm2ddl.auto" value="update"/>, so we don't need to hand-code DDL as you suggest. You would need to update your build script to reflect that. Successful table generation with the correct column type is part of the test - please read the description. You add an incomplete six Megabyte zip file where in comparison the tiny original 13kb testcase just works. I wonder where the garbage (as you say) really is?

...

JPA Support of Enum as Primary Key ---------------------------------- Key: JPA-7 URL: http://opensource.atlassian.com/projects/hibernate/browse/JPA-7 Project: Java Persistence API Issue Type: Improvement Affects Versions: 1.0.1 Environment: java version "1.6.0_21" Java(TM) SE Runtime Environment (build 1.6.0_21-b07) Java HotSpot(TM) Client VM (build 17.0-b17, mixed mode, sharing) Hibernate JPA as installed with latest NetBeans release 6.9.1 Reporter: Bernard Priority: Critical Attachments: enum-pks-hibtestcase.zip, TestCase.zip Enums work as primary keys in TopLink and EclipseLink. DataNucleus supports them, too: http://www.datanucleus.org/products/accessplatform/jpa/primary_key.html In the attached testcase, JPA, via persistence.xml, creates a database column type of VARBINARY. The data contained in it is like: 10101100111011010000000000000101~r0000000000011000main.MyEntity$EntityType0000000000000000000000000000000000000000000000000000000000000000000100100000000000000000xr0000000000001110java.lang.Enum0000000000000000000000000000000000000000000000000000000000000000000100100000000000000000xpt0000000000000110TYPE_1 Type 1 That is not what we need. We need an integer because in the entity class, we specify @Enumerated(value = EnumType.ORDINAL) While Enum as ID field is not specifically supported in the JPA specs, it is not specifically excluded, either. It would be desirable to have the new version of the spec include this feature, too. The attached testcase (zip file) runs with NetBeans out of the box.

Bernard (JIRA)

Sunday, 22 May Sun, 22 May

3:17 a.m.

New subject: [Hibernate-JIRA] Commented: (JPA-7) JPA Support of Enum as Primary Key

[ http://opensource.atlassian.com/projects/hibernate/browse/JPA-7?page=com.... ] Bernard commented on JPA-7: --------------------------- After all, this is fixed in the latest version - can be closed. Karsten, thank you for your help. Why doesn't Jira let the reporter close an issue?

...

JPA Support of Enum as Primary Key ---------------------------------- Key: JPA-7 URL: http://opensource.atlassian.com/projects/hibernate/browse/JPA-7 Project: Java Persistence API Issue Type: Improvement Affects Versions: 1.0.1 Environment: java version "1.6.0_21" Java(TM) SE Runtime Environment (build 1.6.0_21-b07) Java HotSpot(TM) Client VM (build 17.0-b17, mixed mode, sharing) Hibernate JPA as installed with latest NetBeans release 6.9.1 Reporter: Bernard Priority: Critical Attachments: enum-pks-hibtestcase.zip, TestCase.zip Enums work as primary keys in TopLink and EclipseLink. DataNucleus supports them, too: http://www.datanucleus.org/products/accessplatform/jpa/primary_key.html In the attached testcase, JPA, via persistence.xml, creates a database column type of VARBINARY. The data contained in it is like: 10101100111011010000000000000101~r0000000000011000main.MyEntity$EntityType0000000000000000000000000000000000000000000000000000000000000000000100100000000000000000xr0000000000001110java.lang.Enum0000000000000000000000000000000000000000000000000000000000000000000100100000000000000000xpt0000000000000110TYPE_1 Type 1 That is not what we need. We need an integer because in the entity class, we specify @Enumerated(value = EnumType.ORDINAL) While Enum as ID field is not specifically supported in the JPA specs, it is not specifically excluded, either. It would be desirable to have the new version of the spec include this feature, too. The attached testcase (zip file) runs with NetBeans out of the box.

Karsten Wutzke (JIRA)

Monday, 23 May Mon, 23 May

5:14 a.m.

New subject: [Hibernate-JIRA] Commented: (JPA-7) JPA Support of Enum as Primary Key

[ http://opensource.atlassian.com/projects/hibernate/browse/JPA-7?page=com.... ] Karsten Wutzke commented on JPA-7: ---------------------------------- Note my test case was just to demonstrate another way of mapping ENUMs. And yes the test case may be big, because I added the Hibernate JARs so anybody would only have to call "ant run". Sorry for the "garbage" I mentioned. I might use the auto schema generation next time.

...

JPA Support of Enum as Primary Key ---------------------------------- Key: JPA-7 URL: http://opensource.atlassian.com/projects/hibernate/browse/JPA-7 Project: Java Persistence API Issue Type: Improvement Affects Versions: 1.0.1 Environment: java version "1.6.0_21" Java(TM) SE Runtime Environment (build 1.6.0_21-b07) Java HotSpot(TM) Client VM (build 17.0-b17, mixed mode, sharing) Hibernate JPA as installed with latest NetBeans release 6.9.1 Reporter: Bernard Priority: Critical Attachments: enum-pks-hibtestcase.zip, TestCase.zip Enums work as primary keys in TopLink and EclipseLink. DataNucleus supports them, too: http://www.datanucleus.org/products/accessplatform/jpa/primary_key.html In the attached testcase, JPA, via persistence.xml, creates a database column type of VARBINARY. The data contained in it is like: 10101100111011010000000000000101~r0000000000011000main.MyEntity$EntityType0000000000000000000000000000000000000000000000000000000000000000000100100000000000000000xr0000000000001110java.lang.Enum0000000000000000000000000000000000000000000000000000000000000000000100100000000000000000xpt0000000000000110TYPE_1 Type 1 That is not what we need. We need an integer because in the entity class, we specify @Enumerated(value = EnumType.ORDINAL) While Enum as ID field is not specifically supported in the JPA specs, it is not specifically excluded, either. It would be desirable to have the new version of the spec include this feature, too. The attached testcase (zip file) runs with NetBeans out of the box.

4969

days inactive

5203

days old

hibernate-issues@lists.jboss.org

Manage subscription

16 comments

2 participants

tags (0)

participants (2)

Bernard (JIRA)
Karsten Wutzke (JIRA)

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

[Hibernate-JIRA] Created: (JPA-7) JPA Support of Enum as Primary Key