[Hibernate-JIRA] Created: (HHH-3747) Memory leak in EnumType class.

[Hibernate-JIRA] Created:...

[Hibernate-JIRA] Reopened:...

Paweł Kępka (JIRA)

Tuesday, 3 February 2009 Tue, 3 Feb '09

4:16 a.m.

Memory leak in EnumType class. ------------------------------ Key: HHH-3747 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3747 Project: Hibernate Core Issue Type: Bug Components: core, metamodel Reporter: Paweł Kępka Priority: Critical Holding enum values in static enumValues map in EnumType class causes memory leaks on application server where hibernate is loaded by application server's common classloader (like for default configuration of JBoss4). SoftReference or SessionFactory based caching should be used instead. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

Show replies by date

Paweł Kępka (JIRA)

Tuesday, 3 February Tue, 3 Feb

4:32 a.m.

New subject: [Hibernate-JIRA] Moved: (ANN-800) Memory leak in EnumType class.

[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-800?page=co... ] Paweł Kępka moved HHH-3747 to ANN-800: -------------------------------------- Component/s: (was: metamodel) (was: core) Key: ANN-800 (was: HHH-3747) Project: Hibernate Annotations (was: Hibernate Core)

...

Memory leak in EnumType class. ------------------------------ Key: ANN-800 URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-800 Project: Hibernate Annotations Issue Type: Bug Reporter: Paweł Kępka Priority: Critical Holding enum values in static enumValues map in EnumType class causes memory leaks on application server where hibernate is loaded by application server's common classloader (like for default configuration of JBoss4). SoftReference or SessionFactory based caching should be used instead.

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

Ondrej Medek (JIRA)

Thursday, 21 January Thu, 21 Jan

8:40 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-4317) Memory leak in EnumType class.

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317?page=c... ] Ondrej Medek commented on HHH-4317: ----------------------------------- IMO soft reference is not good, weak reference should be used. Maybe it has to be a map with weak keys and values, too. BTW. I do not understand the core of Hibernate, but why this static map exists? Would be enough to cache the values in a simple instance variable: private Object[] enumValues?

...

Memory leak in EnumType class. ------------------------------ Key: HHH-4317 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317 Project: Hibernate Core Issue Type: Bug Components: annotations Reporter: Paweł Kępka Priority: Critical Holding enum values in static enumValues map in EnumType class causes memory leaks on application server where hibernate is loaded by application server's common classloader (like for default configuration of JBoss4). SoftReference or SessionFactory based caching should be used instead.

Ondrej Medek (JIRA)

Friday, 22 January Fri, 22 Jan

3:22 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-4317) Memory leak in EnumType class.

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317?page=c... ] Ondrej Medek commented on HHH-4317: ----------------------------------- A simple workaround: deploy EnumType togather with the web app in the WEB-INF/lib dir.

...

Ondrej Medek (JIRA)

7:32 a.m.

New subject: [Hibernate-JIRA] Updated: (HHH-4317) Memory leak in EnumType class.

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317?page=c... ] Ondrej Medek updated HHH-4317: ------------------------------ Attachment: enumtypeleak.war A test case. Redeploy it several times, start Eclipse MAT, use a link "Duplicate Classes: Detect classes loaded by multiple class loaders." Right click "EntityWithEnumType" and choose "shortest path to ROOT GC excluding soft/weak references.

...

Memory leak in EnumType class. ------------------------------ Key: HHH-4317 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317 Project: Hibernate Core Issue Type: Bug Components: annotations Reporter: Paweł Kępka Priority: Critical Attachments: enumtypeleak.war Holding enum values in static enumValues map in EnumType class causes memory leaks on application server where hibernate is loaded by application server's common classloader (like for default configuration of JBoss4). SoftReference or SessionFactory based caching should be used instead.

Pablo Saavedra (JIRA)

7:37 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-4317) Memory leak in EnumType class.

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317?page=c... ] Pablo Saavedra commented on HHH-4317: ------------------------------------- Ondrej, your workaround is fine but it won't work on JBoss, since it includes the hibernate jar in it's lib directory. In that case, adding hibernate jar to the war will probably result in classloading issues. BTW, does this cache actually yield a significant performance gain?

...

Memory leak in EnumType class. ------------------------------ Key: HHH-4317 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317 Project: Hibernate Core Issue Type: Bug Components: annotations Reporter: Paweł Kępka Priority: Critical Attachments: enumtypeleak.war Holding enum values in static enumValues map in EnumType class causes memory leaks on application server where hibernate is loaded by application server's common classloader (like for default configuration of JBoss4). SoftReference or SessionFactory based caching should be used instead.

Ondrej Medek (JIRA)

Tuesday, 2 February Tue, 2 Feb

8:31 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-4317) Memory leak in EnumType class.

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317?page=c... ] Ondrej Medek commented on HHH-4317: ----------------------------------- Pablo, that workaround has worked for me. I have not added whole hibernate-annotation.jar, just the EnumType class. I have tried it with just one simple application, though. My simple testing with JRE 6 has shown, that HashMap.get() (for a small HashMap, just 4 entries) is approx. 100-times faster then calling a static method by reflection (which is used to get the values of enum). Anyway, calling Class.forName (which is in the EnumType.setParameterValues()) method is approx. as fast as calling a static method by reflection. So, if the question is whether to cache or not to cache, I think it should be cached either both enumClass and enumValues, or nothing. I am attaching an EnumType without caching. Regarding this (quick) patch: it does early init of enumClass and lazy init of enumValues. I am not sure if it is right or not.

...

Memory leak in EnumType class. ------------------------------ Key: HHH-4317 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317 Project: Hibernate Core Issue Type: Bug Components: annotations Reporter: Paweł Kępka Priority: Critical Attachments: enumtypeleak.war Holding enum values in static enumValues map in EnumType class causes memory leaks on application server where hibernate is loaded by application server's common classloader (like for default configuration of JBoss4). SoftReference or SessionFactory based caching should be used instead.

Ondrej Medek (JIRA)

8:35 a.m.

New subject: [Hibernate-JIRA] Updated: (HHH-4317) Memory leak in EnumType class.

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317?page=c... ] Ondrej Medek updated HHH-4317: ------------------------------ Attachment: EnumType.java An EnumType withut caching, suitable for JBoss. Note: I have simplified the initEnumValues(), too. The Class.getDeclaredMethod and Method.invoke do not need the second parameter - less memory garbage.

...

Memory leak in EnumType class. ------------------------------ Key: HHH-4317 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317 Project: Hibernate Core Issue Type: Bug Components: annotations Reporter: Paweł Kępka Priority: Critical Attachments: EnumType.java, enumtypeleak.war Holding enum values in static enumValues map in EnumType class causes memory leaks on application server where hibernate is loaded by application server's common classloader (like for default configuration of JBoss4). SoftReference or SessionFactory based caching should be used instead.

Paweł Kępka (JIRA)

10:11 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-4317) Memory leak in EnumType class.

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317?page=c... ] Paweł Kępka commented on HHH-4317: ---------------------------------- Ondrej, on JRE5 and JRE6 calling a method by reflection works much better then 100 times slower but it takes some time JIT complier to optimize it. I believe that your solution should solve the issue.

...

Memory leak in EnumType class. ------------------------------ Key: HHH-4317 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317 Project: Hibernate Core Issue Type: Bug Components: annotations Reporter: Paweł Kępka Priority: Critical Attachments: EnumType.java, enumtypeleak.war Holding enum values in static enumValues map in EnumType class causes memory leaks on application server where hibernate is loaded by application server's common classloader (like for default configuration of JBoss4). SoftReference or SessionFactory based caching should be used instead.

Ondrej Medek (JIRA)

Wednesday, 3 February Wed, 3 Feb

3:24 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-4317) Memory leak in EnumType class.

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317?page=c... ] Ondrej Medek commented on HHH-4317: ----------------------------------- Pablo, calling a method by reflection is cheap, but a method lookup by Class.getDeclaredMethod() is expensive (the lookup Class.forName() is expensive, too.) I mean "expensive" comparing with HashMap.get(), probably much much cheaper then DB access :-) Also the other problem with the original implementation of EnumType is a thread-safety. I guess the caching in enumValues is not a thread safe.

...

Memory leak in EnumType class. ------------------------------ Key: HHH-4317 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317 Project: Hibernate Core Issue Type: Bug Components: annotations Reporter: Paweł Kępka Priority: Critical Attachments: EnumType.java, enumtypeleak.war Holding enum values in static enumValues map in EnumType class causes memory leaks on application server where hibernate is loaded by application server's common classloader (like for default configuration of JBoss4). SoftReference or SessionFactory based caching should be used instead.

Strong Liu (JIRA)

6:06 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-4317) Memory leak in EnumType class.

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317?page=c... ] Strong Liu commented on HHH-4317: --------------------------------- would you please reattach your patch with a diff version?

...

Memory leak in EnumType class. ------------------------------ Key: HHH-4317 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317 Project: Hibernate Core Issue Type: Bug Components: annotations Reporter: Paweł Kępka Priority: Critical Attachments: EnumType.java, enumtypeleak.war Holding enum values in static enumValues map in EnumType class causes memory leaks on application server where hibernate is loaded by application server's common classloader (like for default configuration of JBoss4). SoftReference or SessionFactory based caching should be used instead.

Ondrej Medek (JIRA)

6:43 a.m.

New subject: [Hibernate-JIRA] Updated: (HHH-4317) Memory leak in EnumType class.

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317?page=c... ] Ondrej Medek updated HHH-4317: ------------------------------ Attachment: EnumType.java.patch Here you are.

...

Memory leak in EnumType class. ------------------------------ Key: HHH-4317 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317 Project: Hibernate Core Issue Type: Bug Components: annotations Reporter: Paweł Kępka Priority: Critical Attachments: EnumType.java, EnumType.java.patch, enumtypeleak.war Holding enum values in static enumValues map in EnumType class causes memory leaks on application server where hibernate is loaded by application server's common classloader (like for default configuration of JBoss4). SoftReference or SessionFactory based caching should be used instead.

Strong Liu (JIRA)

11:07 a.m.

New subject: [Hibernate-JIRA] Assigned: (HHH-4317) Memory leak in EnumType class.

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317?page=c... ] Strong Liu reassigned HHH-4317: ------------------------------- Assignee: Strong Liu

...

Memory leak in EnumType class. ------------------------------ Key: HHH-4317 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317 Project: Hibernate Core Issue Type: Bug Components: annotations Reporter: Paweł Kępka Assignee: Strong Liu Priority: Critical Attachments: EnumType.java, EnumType.java.patch, enumtypeleak.war Holding enum values in static enumValues map in EnumType class causes memory leaks on application server where hibernate is loaded by application server's common classloader (like for default configuration of JBoss4). SoftReference or SessionFactory based caching should be used instead.

Strong Liu (JIRA)

Thursday, 4 February Thu, 4 Feb

4:58 a.m.

New subject: [Hibernate-JIRA] Resolved: (HHH-4317) Memory leak in EnumType class.

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317?page=c... ] Strong Liu resolved HHH-4317. ----------------------------- Resolution: Fixed Fix Version/s: 3.5.0-Next your patch looks good, i have applied it to trunk, thanks

...

Memory leak in EnumType class. ------------------------------ Key: HHH-4317 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317 Project: Hibernate Core Issue Type: Bug Components: annotations Reporter: Paweł Kępka Assignee: Strong Liu Priority: Critical Fix For: 3.5.0-Next Attachments: EnumType.java, EnumType.java.patch, enumtypeleak.war Holding enum values in static enumValues map in EnumType class causes memory leaks on application server where hibernate is loaded by application server's common classloader (like for default configuration of JBoss4). SoftReference or SessionFactory based caching should be used instead.

Fyrn Jilot (JIRA)

Friday, 23 September Fri, 23 Sep

8:12 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-4317) Memory leak in EnumType class.

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317?page=c... ] Fyrn Jilot commented on HHH-4317: --------------------------------- know about [Flexi | http://retractable-dog-leashes.net/flexi-dog-leashes.html]

...

Memory leak in EnumType class. ------------------------------ Key: HHH-4317 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317 Project: Hibernate Core Issue Type: Bug Components: annotations Reporter: Paweł Kępka Assignee: Strong Liu Priority: Critical Fix For: 3.5.0-CR-1 Attachments: EnumType.java, EnumType.java.patch, enumtypeleak.war Holding enum values in static enumValues map in EnumType class causes memory leaks on application server where hibernate is loaded by application server's common classloader (like for default configuration of JBoss4). SoftReference or SessionFactory based caching should be used instead.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Ondrej Medek (JIRA)

8:40 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-4317) Memory leak in EnumType class.

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317?page=c... ] Ondrej Medek commented on HHH-4317: ----------------------------------- The previous comment by Fyrn Jilot is SPAM!

...

Memory leak in EnumType class. ------------------------------ Key: HHH-4317 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317 Project: Hibernate Core Issue Type: Bug Components: annotations Reporter: Paweł Kępka Assignee: Strong Liu Priority: Critical Fix For: 3.5.0-CR-1 Attachments: EnumType.java, EnumType.java.patch, enumtypeleak.war Holding enum values in static enumValues map in EnumType class causes memory leaks on application server where hibernate is loaded by application server's common classloader (like for default configuration of JBoss4). SoftReference or SessionFactory based caching should be used instead.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Steve Ebersole (JIRA)

11:45 a.m.

New subject: [Hibernate-JIRA] Updated: (HHH-4317) Memory leak in EnumType class.

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317?page=c... ] Steve Ebersole updated HHH-4317: -------------------------------- Comment: was deleted (was: know about [Flexi | http://retractable-dog-leashes.net/flexi-dog-leashes.html])

...

Memory leak in EnumType class. ------------------------------ Key: HHH-4317 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317 Project: Hibernate Core Issue Type: Bug Components: annotations Reporter: Paweł Kępka Assignee: Strong Liu Priority: Critical Fix For: 3.5.0-CR-1 Attachments: EnumType.java, EnumType.java.patch, enumtypeleak.war Holding enum values in static enumValues map in EnumType class causes memory leaks on application server where hibernate is loaded by application server's common classloader (like for default configuration of JBoss4). SoftReference or SessionFactory based caching should be used instead.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Steve Ebersole (JIRA)

11:45 a.m.

New subject: [Hibernate-JIRA] Reopened: (HHH-4317) Memory leak in EnumType class.

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317?page=c... ] Steve Ebersole reopened HHH-4317: ---------------------------------

...

Memory leak in EnumType class. ------------------------------ Key: HHH-4317 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317 Project: Hibernate Core Issue Type: Bug Components: annotations Reporter: Paweł Kępka Assignee: Strong Liu Priority: Critical Fix For: 3.5.0-CR-1 Attachments: EnumType.java, EnumType.java.patch, enumtypeleak.war Holding enum values in static enumValues map in EnumType class causes memory leaks on application server where hibernate is loaded by application server's common classloader (like for default configuration of JBoss4). SoftReference or SessionFactory based caching should be used instead.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Steve Ebersole (JIRA)

11:45 a.m.

New subject: [Hibernate-JIRA] Updated: (HHH-4317) Memory leak in EnumType class.

...

Memory leak in EnumType class. ------------------------------ Key: HHH-4317 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317 Project: Hibernate Core Issue Type: Bug Components: annotations Reporter: Paweł Kępka Assignee: Strong Liu Priority: Critical Fix For: 3.5.0-CR-1 Attachments: EnumType.java, EnumType.java.patch, enumtypeleak.war Holding enum values in static enumValues map in EnumType class causes memory leaks on application server where hibernate is loaded by application server's common classloader (like for default configuration of JBoss4). SoftReference or SessionFactory based caching should be used instead.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Steve Ebersole (JIRA)

11:45 a.m.

New subject: [Hibernate-JIRA] Closed: (HHH-4317) Memory leak in EnumType class.

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317?page=c... ] Steve Ebersole closed HHH-4317. ------------------------------- Resolution: Fixed

...

Memory leak in EnumType class. ------------------------------ Key: HHH-4317 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4317 Project: Hibernate Core Issue Type: Bug Components: annotations Reporter: Paweł Kępka Assignee: Strong Liu Priority: Critical Fix For: 3.5.0-CR-1 Attachments: EnumType.java, EnumType.java.patch, enumtypeleak.war Holding enum values in static enumValues map in EnumType class causes memory leaks on application server where hibernate is loaded by application server's common classloader (like for default configuration of JBoss4). SoftReference or SessionFactory based caching should be used instead.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

4670

days inactive

5632

days old

hibernate-issues@lists.jboss.org

Manage subscription

19 comments

6 participants

tags (0)

participants (6)

Fyrn Jilot (JIRA)
Ondrej Medek (JIRA)
Pablo Saavedra (JIRA)
Paweł Kępka (JIRA)
Steve Ebersole (JIRA)
Strong Liu (JIRA)

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

[Hibernate-JIRA] Created: (HHH-3747) Memory leak in EnumType class.