[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-323?pag... ] Emmanuel Bernard commented on HSEARCH-323: ------------------------------------------ hi, That would be a nice to have. Do you think you could contribute a patch for that? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-323?pag... ] Oliver Siegmar edited comment on HSEARCH-323 at 1/7/11 3:46 AM: ---------------------------------------------------------------- Here it is (diff is against version 3.3.0). Unfortunately I had to do some workarounds to not change DirectoryProvider's API - so the code is somewhat bloaty. was (Author: ojs): Here it is. Unfortunately I had to do some workarounds to not change DirectoryProvider's API - so the code is somewhat bloaty. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-323?pag... ] Oliver Siegmar commented on HSEARCH-323: ---------------------------------------- I agree that the dummy directory is a dirty hack but the way HSEARCH-532 solve this issue doesn't help me. In our environment the application that provides the master repository is deployed in the same appserver and is (could be) started after the client-apps. Because the appserver starts the applications in sequence (an not in parallel), the implementation of HSEARCH-532 would just do some retries and cause longer startup period. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-323?pag... ] Oliver Siegmar updated HSEARCH-323: ----------------------------------- Attachment: FSSlaveDirectoryProvider2.java.diff bq. 1. could you please avoid changing all whitespaces? it doesn't apply on our code as-is, and I'm having an hard time trying to fix it by editing myself. Sure, here's a patch against upstream using git, without any whitespace changes. bq. 2. "throw new IllegalStateException(e);", I'd suggest to keep the IOException, or if you really need to wrap it in a runtime exception it's better to use the SearchException which we consistently use for those cases. I wouldn't consider it illegal to have a disk full I don't need an exception anymore, because I use a RAMDirectory. bq. 3. dummyDirectory: this one will always be empty, right? Why not using a RAMDirectory instead of physically writing an index to disk? Also I wouldn't close it in the TriggerTask, some IndexReader might still be using it and cause collateral errors. If you where sure no reader could be using it yet, there would be no point in using a dummy at all - so I guess that in your use case it's actually being used. I think you could have it closed at the next task period, or if it gets too complex just leave it open. I didn't closed the Directory in the TriggerTask, but thanks for the advice - I use a RAMDirectory, now. bq. 4. Why starting a new TimerTask, couldn't we reuse the existing one? every time it triggers, it could check if we already performed proper initialization. It would make sense to have a separate InitTask if you wanted to configure initial retry periods on a different time base than the copy task, but it doesn't seem the case in the current patch. If you want you can add a new configuration property, make sure to document it. We do have two tasks now, a InitTask (which one is only used if we need to *retry* initialization) and a UpdateTask (former known as TriggerTask). The UpdateTask is scheduled as soon as the initialization is finished. I think this is the cleanest approach of initialization and update management. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-323?pag... ] Sanne Grinovero commented on HSEARCH-323: ----------------------------------------- btw closing a RAMDirectory is a no-op, so you could keep it simple and make it volatile. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-323?pag... ] Sanne Grinovero commented on HSEARCH-323: ----------------------------------------- thanks! as soon as you tell me about the https://cla.jboss.org I'll apply it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-323?pag... ] Sanne Grinovero updated HSEARCH-323: ------------------------------------ Assignee: Sanne Grinovero Fix Version/s: 3.4.0.Beta1 Summary: Fault tolerant FSSlaveDirectoryProvider (Oliver Siegmar) (was: Fault tolerant FSSlaveDirectoryProvider) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-323?pag... ] Emmanuel Bernard resolved HSEARCH-323. -------------------------------------- Resolution: Fixed Many thanks Oliver -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-323?pag... ] Sanne Grinovero commented on HSEARCH-323: ----------------------------------------- thanks again. we expect to release this approximately next week. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira