[ http://opensource.atlassian.com/projects/hibernate/browse/EJB-456?page=co... ] Steve Ebersole commented on EJB-456: ------------------------------------ I played with it a bit in some of my criteria tests. It works ok, as long as we stick to your guidelines above for the time being (using decalred vs non-declared etc). Some thoughts on your points: 1) wrt distinguishing many-to-many and one-to-many, that is not true -> CollectionPersister#isOneToMany() and CollectionPersister#isManyToMany() 2) wrt distinguishing many-to-one versus one-to-one, that is much more accurate. It is doable, but there is not a simple, single contract method one can call to determine it. 3) for Member, do you mean java.lang.reflect.Member? or javax.persistence.metamodel.Member? In either case we need to be able to report the java.lang.reflect.Member, which was not clear to me from javax.persistence.metamodel.Member what is expected in the case of method access: the getter I assume? At any rate, for Hibernate this is all contained in the underlying PropertyAccessor contract for said property. The problem here is that the PropertyAccessor contract only allows (optionally) reporting the Method. So we would need to update this contract a bit to support this requirement. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/EJB-456?page=co... ] Steve Ebersole commented on EJB-456: ------------------------------------ 1) I don't understand what "is mapped ..." means. AFAIK, you mean that you interpret that as many-to-many in the annotation binder??? Obviously, if you tell core that something is a many-to-many, it treats it as a many-to-many :) javax.persistence.ManyToMany is the proper corollary to <many-to-many/>. In my limited knowledge, it looks like @OneToMany @JoinTable would map more naturally to: <join ...> <[collection type] ...> ... <one-to-many .../> </[collection type] ...> </join> which is not currently supported by core (collections within a <join/>). But, if that is a construct that needs to be supported then it should have been and should be accounted for in the hibernate metamodel properly. 3) It was in the PFD. Looks like it is since removed and its members pulled up into Attribute (Attribute had extended Member). But the same concern remains; now from Attribute: /** * Return the java.lang.reflect.Member for the represented * attribute. * * @return corresponding java.lang.reflect.Member */ java.lang.reflect.Member getJavaMember(); Ok, great... java.lang.reflect.Member can be either a Field or a Method. So what are we returning when? I mean the logical answer seems to be based on the access. For field access return the Field. But what about method access? The getter? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4202?page=c... ] Steve Ebersole updated HHH-4202: -------------------------------- Fix Version/s: 3.5 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4202?page=c... ] Steve Ebersole commented on HHH-4202: ------------------------------------- This is blocking my criteria work now... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4202?page=c... ] Steve Ebersole reopened HHH-4202: --------------------------------- -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira