[Hibernate-JIRA] Created: (HHH-4787) AuditProperty.isNull() doesn't generate "tab.col is null" SQL clause as expected
3:10 p.m.
AuditProperty.isNull() doesn't generate "tab.col is null" SQL clause as
expected
--------------------------------------------------------------------------------
Key: HHH-4787
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4787
Project: Hibernate Core
Issue Type: Bug
Components: envers
Affects Versions: 3.3.0.GA
Environment: Hibernate 3.3.0.GA, Envers 1.2.2, HSQLDB Database
Reporter: Eric Citaire
Priority: Critical
AuditProperty.isNull() generate a SQL condition like this :
"tab.col=?"
where the bind variable is mapped to a null value.
This doesn't work : most database engines will return false in every case.
It should use the "is null" test instead :
"tab.col is null"
http://en.wikipedia.org/wiki/SQL#Null_and_Three-Valued_Logic_.283VL.29
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:04 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4787) AuditProperty.isNull() doesn't generate "tab.col is null" SQL clause as expected
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4787?page=c...
]
Eric Citaire commented on HHH-4787:
-----------------------------------
This single test fail :
(tested in org.hibernate.envers.test.integration.query.SimpleQuery integration test)
{noformat}
@Test
public void testEntitiesIsNullQuery() {
EntityManager em = getEntityManager();
em.getTransaction().begin();
StrIntTestEntity site = new StrIntTestEntity(null, 10);
em.persist(site);
Integer id = site.getId();
em.getTransaction().commit();
StrIntTestEntity ver = (StrIntTestEntity) getAuditReader().createQuery()
.forEntitiesAtRevision(StrIntTestEntity.class, 2)
.add(AuditEntity.id().eq(id))
.add(AuditEntity.property("str1").isNull())
.getSingleResult();
assert ver.equals(new StrIntTestEntity(null, 10, id2));
}
{noformat}
AuditProperty.isNull() doesn't generate "tab.col is
null" SQL clause as expected
--------------------------------------------------------------------------------
Key: HHH-4787
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4787
Project: Hibernate Core
Issue Type: Bug
Components: envers
Affects Versions: 3.3.0.GA
Environment: Hibernate 3.3.0.GA, Envers 1.2.2, HSQLDB Database
Reporter: Eric Citaire
Priority: Critical
AuditProperty.isNull() generate a SQL condition like this :
"tab.col=?"
where the bind variable is mapped to a null value.
This doesn't work : most database engines will return false in every case.
It should use the "is null" test instead :
"tab.col is null"
http://en.wikipedia.org/wiki/SQL#Null_and_Three-Valued_Logic_.283VL.29
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:21 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4787) AuditProperty.isNull() doesn't generate "tab.col is null" SQL clause as expected
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4787?page=c...
]
Eric Citaire commented on HHH-4787:
-----------------------------------
corrections in first test :
{{.forEntitiesAtRevision(StrIntTestEntity.class, *5*)}}
{{assert ver.equals(new StrIntTestEntity(null, 10, *id1*));}}
same test for AuditProperty.isNotNull() fails as well :
{noformat}
@Test
public void testEntitiesIsNotNullQuery() {
StrIntTestEntity ver = (StrIntTestEntity) getAuditReader().createQuery()
.forEntitiesAtRevision(StrIntTestEntity.class, 2)
.add(AuditEntity.id().eq(id1))
.add(AuditEntity.property("str1").isNotNull())
.getSingleResult();
assert ver.equals(new StrIntTestEntity("a", 10, id1));
}
{noformat}
AuditProperty.isNull() doesn't generate "tab.col is
null" SQL clause as expected
--------------------------------------------------------------------------------
Key: HHH-4787
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4787
Project: Hibernate Core
Issue Type: Bug
Components: envers
Affects Versions: 3.3.0.GA
Environment: Hibernate 3.3.0.GA, Envers 1.2.2, HSQLDB Database
Reporter: Eric Citaire
Priority: Critical
AuditProperty.isNull() generate a SQL condition like this :
"tab.col=?"
where the bind variable is mapped to a null value.
This doesn't work : most database engines will return false in every case.
It should use the "is null" test instead :
"tab.col is null"
http://en.wikipedia.org/wiki/SQL#Null_and_Three-Valued_Logic_.283VL.29
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:09 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4787) AuditProperty.isNull() doesn't generate "tab.col is null" SQL clause as expected
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4787?page=c...
]
Eric Citaire commented on HHH-4787:
-----------------------------------
I found a workaround :
{noformat}
class IsNullCriterion implements AuditCriterion {
private String propertyName;
public IsNullCriterion(String propertyName) {
this.propertyName = propertyName;
}
public void addToQuery(AuditConfiguration auditCfg,
String entityName, QueryBuilder qb,
Parameters parameters) {
RelationDescription relatedEntity = CriteriaTools.getRelatedEntity(auditCfg, entityName,
propertyName);
if (relatedEntity == null) {
parameters.addWhere(propertyName, true, " is ", "null", false);
} else {
List<QueryParameterData> parametersData =
relatedEntity.getIdMapper().mapToQueryParametersFromId(null);
for (QueryParameterData parameterData : parametersData) {
parameters.addWhere(parameterData.getQueryParameterName(), true, " is ",
"null", false);
}
}
}
}
{noformat}
you can use it by replacing this :
{noformat}
.add(AuditEntity.property("str1").isNotNull())
{noformat}
by this :
{noformat}
.add(new IsNullCriterion("str1"))
{noformat}
AuditProperty.isNull() doesn't generate "tab.col is
null" SQL clause as expected
--------------------------------------------------------------------------------
Key: HHH-4787
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4787
Project: Hibernate Core
Issue Type: Bug
Components: envers
Affects Versions: 3.3.0.GA
Environment: Hibernate 3.3.0.GA, Envers 1.2.2, HSQLDB Database
Reporter: Eric Citaire
Priority: Critical
AuditProperty.isNull() generate a SQL condition like this :
"tab.col=?"
where the bind variable is mapped to a null value.
This doesn't work : most database engines will return false in every case.
It should use the "is null" test instead :
"tab.col is null"
http://en.wikipedia.org/wiki/SQL#Null_and_Three-Valued_Logic_.283VL.29
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:19 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4787) AuditProperty.isNull() doesn't generate "tab.col is null" SQL clause as expected
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4787?page=c...
]
Lukasz Antoniak commented on HHH-4787:
--------------------------------------
Pull request submitted: https://github.com/hibernate/hibernate-core/pull/68
AuditProperty.isNull() doesn't generate "tab.col is
null" SQL clause as expected
--------------------------------------------------------------------------------
Key: HHH-4787
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4787
Project: Hibernate Core
Issue Type: Bug
Components: envers
Affects Versions: 3.3.0.GA
Environment: Hibernate 3.3.0.GA, Envers 1.2.2, HSQLDB Database
Reporter: Eric Citaire
Priority: Critical
AuditProperty.isNull() generate a SQL condition like this :
"tab.col=?"
where the bind variable is mapped to a null value.
This doesn't work : most database engines will return false in every case.
It should use the "is null" test instead :
"tab.col is null"
http://en.wikipedia.org/wiki/SQL#Null_and_Three-Valued_Logic_.283VL.29
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:01 a.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-4787) AuditProperty.isNull() doesn't generate "tab.col is null" SQL clause as expected
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4787?page=c...
]
Adam Warski resolved HHH-4787.
------------------------------
Assignee: Adam Warski
Resolution: Fixed
Fix Version/s: 4.0.0.Alpha3
3.6.4
AuditProperty.isNull() doesn't generate "tab.col is
null" SQL clause as expected
--------------------------------------------------------------------------------
Key: HHH-4787
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4787
Project: Hibernate Core
Issue Type: Bug
Components: envers
Affects Versions: 3.3.0.GA
Environment: Hibernate 3.3.0.GA, Envers 1.2.2, HSQLDB Database
Reporter: Eric Citaire
Assignee: Adam Warski
Priority: Critical
Fix For: 3.6.4, 4.0.0.Alpha3
AuditProperty.isNull() generate a SQL condition like this :
"tab.col=?"
where the bind variable is mapped to a null value.
This doesn't work : most database engines will return false in every case.
It should use the "is null" test instead :
"tab.col is null"
http://en.wikipedia.org/wiki/SQL#Null_and_Three-Valued_Logic_.283VL.29
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4990
days inactive
5459
days old
hibernate-issues@lists.jboss.org
5 comments
3 participants
participants (3)
-
Adam Warski (JIRA) -
Eric Citaire (JIRA)
-
Lukasz Antoniak (JIRA)