6:57 a.m.
Make some optional dependencies mandatory
-----------------------------------------
Key: HSEARCH-491
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491
Project: Hibernate Search
Issue Type: Improvement
Components: build, documentation
Reporter: Emmanuel Bernard
Assignee: Emmanuel Bernard
Fix For: 3.2.0.CR1
Need to change the pom, the artifact and the documentation (esp the getting started one).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:52 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-491) Make some optional dependencies mandatory
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491?pag...
]
Sanne Grinovero commented on HSEARCH-491:
-----------------------------------------
I agree about the Solr analyzer framework, but we should also consider adding several
exclusions.
Currently Solr is pulling in many jars not needed as transitive dependencies of Solr
features we don't use (example: commons-fileupload); users are free to use them
directly if they want but should declare a direct dependency in that case.
Make some optional dependencies mandatory
-----------------------------------------
Key: HSEARCH-491
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491
Project: Hibernate Search
Issue Type: Improvement
Components: build, documentation
Reporter: Emmanuel Bernard
Assignee: Emmanuel Bernard
Fix For: 3.2.0.CR1
Need to change the pom, the artifact and the documentation (esp the getting started one).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:23 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-491) Make some optional dependencies mandatory
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491?pag...
]
Emmanuel Bernard commented on HSEARCH-491:
------------------------------------------
Do you think Gustavo could compile a list of those? He is more familiar with Solr than I
am.
Make some optional dependencies mandatory
-----------------------------------------
Key: HSEARCH-491
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491
Project: Hibernate Search
Issue Type: Improvement
Components: build, documentation
Reporter: Emmanuel Bernard
Assignee: Emmanuel Bernard
Fix For: 3.2.0.CR1
Need to change the pom, the artifact and the documentation (esp the getting started one).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:02 p.m.
New subject: [Hibernate-JIRA] Updated: (HSEARCH-491) Make some optional dependencies mandatory
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491?pag...
]
G Fernandes updated HSEARCH-491:
--------------------------------
Attachment: solrNotOptional.patch
Most Solr 1.4 dependencies are not really necessary. I've put some exclusions, and
marked Solr 1.4 as mandatory. Docs changed as well.
Make some optional dependencies mandatory
-----------------------------------------
Key: HSEARCH-491
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491
Project: Hibernate Search
Issue Type: Improvement
Components: build, documentation
Reporter: Emmanuel Bernard
Assignee: Emmanuel Bernard
Fix For: 3.2.0.CR1
Attachments: solrNotOptional.patch
Need to change the pom, the artifact and the documentation (esp the getting started one).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:24 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-491) Make some optional dependencies mandatory
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491?pag...
]
Emmanuel Bernard commented on HSEARCH-491:
------------------------------------------
Hi gustavo,
- Wiki.</ulink> Note that depending on the chosen factory class additional
- libraries on top of the Solr dependencies might be required. For example,
- the <classname>PhoneticFilterFactory</classname> depends on <ulink
-
url="http://commons.apache.org/codec">commons-codec</ulin...
Doesn't that stay true?
In general, I wonder if we should recommend or even make mandatory these two:
- lucene-analyzers
- lucene-snowball
thoughts?
Make some optional dependencies mandatory
-----------------------------------------
Key: HSEARCH-491
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491
Project: Hibernate Search
Issue Type: Improvement
Components: build, documentation
Reporter: Emmanuel Bernard
Assignee: Emmanuel Bernard
Fix For: 3.2.0.CR1
Attachments: solrNotOptional.patch
Need to change the pom, the artifact and the documentation (esp the getting started one).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:48 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-491) Make some optional dependencies mandatory
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491?pag...
]
G Fernandes commented on HSEARCH-491:
-------------------------------------
Hi, the snippet above will be not true anymore for Maven users, in the sense that Solr
deps are already resolved including commons-codec and commons-io:
hibernate-search$ mvn dependency:tree
[INFO] ------------------------------------------------------------------------
[INFO] Building Hibernate Search
[INFO] task-segment: [dependency:tree]
[INFO] ------------------------------------------------------------------------
...
[INFO] +- org.apache.lucene:lucene-core:jar:2.9.2:compile
[INFO] +- org.apache.solr:solr-core:jar:1.4.0:compile
[INFO] | +- org.apache.solr:solr-solrj:jar:1.4.0:compile
[INFO] | +- commons-codec:commons-codec:jar:1.3:compile
[INFO] | \- commons-io:commons-io:jar:1.4:compile
[INFO] +- org.apache.lucene:lucene-snowball:jar:2.9.2:compile
[INFO] +- org.apache.lucene:lucene-analyzers:jar:2.9.2:compile
...
For non-maven users, yes, it stays true, but all deps are being packaged in the dist
assembly anyway.
Regarding lucene-analyzers and lucene-snowball, I think since Solr 1.4 deps will be
mandatory, it won't hurt to make them also mandatory, since they are very small and
have no transitive dependencies at all.
Make some optional dependencies mandatory
-----------------------------------------
Key: HSEARCH-491
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491
Project: Hibernate Search
Issue Type: Improvement
Components: build, documentation
Reporter: Emmanuel Bernard
Assignee: Emmanuel Bernard
Fix For: 3.2.0.CR1
Attachments: solrNotOptional.patch
Need to change the pom, the artifact and the documentation (esp the getting started one).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:54 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-491) Make some optional dependencies mandatory
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491?pag...
]
Emmanuel Bernard commented on HSEARCH-491:
------------------------------------------
Are you familiar 2with Maven archetypes.
It seems our current archetype in hibernate-search-archetype should be simplified as we
know pull deps from HSearch as mandatory.
ie removing
{code}
<dependency>
<groupId>org.apache.solr</groupId>
<artifactId>solr-core</artifactId>
<exclusions>
<exclusion>
<groupId>commons-httpclient</groupId>
<artifactId>commons-httpclient</artifactId>
</exclusion>
<exclusion>
<groupId>woodstox</groupId>
<artifactId>wstx-asl</artifactId>
</exclusion>
<exclusion>
<groupId>net.java.dev.stax-utils</groupId>
<artifactId>stax-utils</artifactId>
</exclusion>
<exclusion>
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.solr</groupId>
<artifactId>solr-lucene-core</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.apache.lucene</groupId>
<artifactId>lucene-snowball</artifactId>
</dependency>
<dependency>
<groupId>org.apache.lucene</groupId>
<artifactId>lucene-analyzers</artifactId>
</dependency>
{code}
Make some optional dependencies mandatory
-----------------------------------------
Key: HSEARCH-491
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491
Project: Hibernate Search
Issue Type: Improvement
Components: build, documentation
Reporter: Emmanuel Bernard
Assignee: Emmanuel Bernard
Fix For: 3.2.0.CR1
Attachments: solrNotOptional.patch
Need to change the pom, the artifact and the documentation (esp the getting started one).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:57 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-491) Make some optional dependencies mandatory
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491?pag...
]
Emmanuel Bernard commented on HSEARCH-491:
------------------------------------------
I've committed your patch and made lucene-analyzers and lucene-snowball mandatory.
The last remaining question is the simplification of the artifact pom.
Make some optional dependencies mandatory
-----------------------------------------
Key: HSEARCH-491
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491
Project: Hibernate Search
Issue Type: Improvement
Components: build, documentation
Reporter: Emmanuel Bernard
Assignee: Emmanuel Bernard
Fix For: 3.2.0.CR1
Attachments: solrNotOptional.patch
Need to change the pom, the artifact and the documentation (esp the getting started one).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:55 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-491) Make some optional dependencies mandatory
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491?pag...
]
G Fernandes commented on HSEARCH-491:
-------------------------------------
Here you are:
Index: hibernate-search-archetype/pom.xml
===================================================================
--- hibernate-search-archetype/pom.xml (revision 19206)
+++ hibernate-search-archetype/pom.xml (working copy)
@@ -31,40 +31,6 @@
<artifactId>hibernate-entitymanager</artifactId>
</dependency>
<dependency>
- <groupId>org.apache.solr</groupId>
- <artifactId>solr-core</artifactId>
- <exclusions>
- <exclusion>
- <groupId>commons-httpclient</groupId>
- <artifactId>commons-httpclient</artifactId>
- </exclusion>
- <exclusion>
- <groupId>woodstox</groupId>
- <artifactId>wstx-asl</artifactId>
- </exclusion>
- <exclusion>
- <groupId>net.java.dev.stax-utils</groupId>
- <artifactId>stax-utils</artifactId>
- </exclusion>
- <exclusion>
- <groupId>commons-logging</groupId>
- <artifactId>commons-logging</artifactId>
- </exclusion>
- <exclusion>
- <groupId>org.apache.solr</groupId>
- <artifactId>solr-lucene-core</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
- <dependency>
- <groupId>org.apache.lucene</groupId>
- <artifactId>lucene-snowball</artifactId>
- </dependency>
- <dependency>
- <groupId>org.apache.lucene</groupId>
- <artifactId>lucene-analyzers</artifactId>
- </dependency>
- <dependency>
<groupId>hsqldb</groupId>
<artifactId>hsqldb</artifactId>
<version>1.8.0.2</version>
Make some optional dependencies mandatory
-----------------------------------------
Key: HSEARCH-491
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491
Project: Hibernate Search
Issue Type: Improvement
Components: build, documentation
Reporter: Emmanuel Bernard
Assignee: Emmanuel Bernard
Fix For: 3.2.0.CR1
Attachments: solrNotOptional.patch
Need to change the pom, the artifact and the documentation (esp the getting started one).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:57 p.m.
New subject: [Hibernate-JIRA] Updated: (HSEARCH-491) Make some optional dependencies mandatory
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491?pag...
]
G Fernandes updated HSEARCH-491:
--------------------------------
Attachment: archetype.patch
Removal of optional deps from archetype's pom.xml
Make some optional dependencies mandatory
-----------------------------------------
Key: HSEARCH-491
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491
Project: Hibernate Search
Issue Type: Improvement
Components: build, documentation
Reporter: Emmanuel Bernard
Assignee: Emmanuel Bernard
Fix For: 3.2.0.CR1
Attachments: archetype.patch, solrNotOptional.patch
Need to change the pom, the artifact and the documentation (esp the getting started one).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:44 a.m.
New subject: [Hibernate-JIRA] Resolved: (HSEARCH-491) Make some optional dependencies mandatory
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491?pag...
]
Emmanuel Bernard resolved HSEARCH-491.
--------------------------------------
Resolution: Fixed
Fixed except the archetype. See HSEARCH-503 for more details.
Make some optional dependencies mandatory
-----------------------------------------
Key: HSEARCH-491
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491
Project: Hibernate Search
Issue Type: Improvement
Components: build, documentation
Reporter: Emmanuel Bernard
Assignee: Emmanuel Bernard
Fix For: 3.2.0.CR1
Attachments: archetype.patch, solrNotOptional.patch
Need to change the pom, the artifact and the documentation (esp the getting started one).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5372
days inactive
5381
days old
hibernate-issues@lists.jboss.org
10 comments
3 participants
participants (3)
-
Emmanuel Bernard (JIRA) -
G Fernandes (JIRA)
-
Sanne Grinovero (JIRA)