[ http://opensource.atlassian.com/projects/hibernate/browse/HV-229?page=com... ] Hardy Ferentschik commented on HV-229: -------------------------------------- An @Url constraint makes sense. I guess we really should add it to the 4.x version of Hibernate Validator. That said, the code should easily be backportable in case we also want it in the 3.x legacy code base. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-229?page=com... ] Hardy Ferentschik commented on HV-229: -------------------------------------- Maybe instead of using regular expression one could utilize the java.net.URL class? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-229?page=com... ] Hardy Ferentschik updated HV-229: --------------------------------- Fix Version/s: 4.1.0 Component/s: validators -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-229?page=com... ] Ted Bergeron commented on HV-229: --------------------------------- I initially reported this feature request in HV-19, which I've now linked to this issue. I just commented in HV-19 that we should look to the HTML 5 spec as the source for Email and URL validation patterns. Web apps today can use input type="email" and type="url" with no ill effects from old browsers. They ignore unrecognized type values and default to input type="text". A benefit from the new types you can realize today is on the iPhone. Mobile Safari renders an optimized keyboard layout for these types. In the future, browsers will implement the validation logic for these types, making the javascript solutions unnecessary. Users will bind these fields to beans annotated with @Email and @URL, so its important the validation logic is compatible. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-229?page=com... ] Hardy Ferentschik commented on HV-229: -------------------------------------- Why not just rely on the URL constructor for the ConstraintValidator implementation: {code} public boolean isValid(String value, ConstraintValidatorContext constraintValidatorContext) { if ( value == null ) { return true; } try { new java.net.URL( value ); return true; } catch ( MalformedURLException e ) { return false; } } {code} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira