[Hibernate-JIRA] Created: (HSEARCH-492) FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't shutdown the Executor
1:51 a.m.
FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't shutdown the Executor
----------------------------------------------------------------------------------
Key: HSEARCH-492
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492
Project: Hibernate Search
Issue Type: Bug
Components: directory provider
Affects Versions: 3.1.1.GA
Environment: Java 1.6.0
Reporter: Sylvain Charton
Priority: Minor
I'm using Hibernate Search clustering feature in a stand alone Java application (not a
webapp).
My problem is the application never stops: many threads are still living.
Both FSMasterDirectoryProvider and FSSlaveDirectoryProvider use a Single Thread Executor
to perform the CopyTask.
When the FSSlaveDirectoryProvider.stop() is called, the timer is stopped, but not the
Executor in the TimerTask.
Consequence is the process can't stop, because some threads are still living,
endlessly.
This happens after the first CopyDirectory task was executed.
My fix was to copy this class in my code, and replace the Executor in TriggerTask class by
an ExecutorService in FSSlaveDirectoryProvider class.
The ExecutorService is initialized in the start() method:
{code:Java}this.executor = Executors.newSingleThreadExecutor() ;{code}
And properly shut down in the stop() method:
{code:java}
executor.shutdown();
boolean terminated = false ;
try{
terminated = executor.awaitTermination(20, TimeUnit.SECONDS);
} catch (InterruptedException e1) {
terminated = false ;
}
if (!terminated) {
executor.shutdownNow() ;
}
{code}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:14 a.m.
New subject: [Hibernate-JIRA] Updated: (HSEARCH-492) FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't shutdown the Executor
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492?pag...
]
Sanne Grinovero updated HSEARCH-492:
------------------------------------
Fix Version/s: 3.2.0.CR1
FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't
shutdown the Executor
----------------------------------------------------------------------------------
Key: HSEARCH-492
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492
Project: Hibernate Search
Issue Type: Bug
Components: directory provider
Affects Versions: 3.1.1.GA
Environment: Java 1.6.0
Reporter: Sylvain Charton
Priority: Minor
Fix For: 3.2.0.CR1
I'm using Hibernate Search clustering feature in a stand alone Java application (not
a webapp).
My problem is the application never stops: many threads are still living.
Both FSMasterDirectoryProvider and FSSlaveDirectoryProvider use a Single Thread Executor
to perform the CopyTask.
When the FSSlaveDirectoryProvider.stop() is called, the timer is stopped, but not the
Executor in the TimerTask.
Consequence is the process can't stop, because some threads are still living,
endlessly.
This happens after the first CopyDirectory task was executed.
My fix was to copy this class in my code, and replace the Executor in TriggerTask class
by an ExecutorService in FSSlaveDirectoryProvider class.
The ExecutorService is initialized in the start() method:
{code:Java}this.executor = Executors.newSingleThreadExecutor() ;{code}
And properly shut down in the stop() method:
{code:java}
executor.shutdown();
boolean terminated = false ;
try{
terminated = executor.awaitTermination(20, TimeUnit.SECONDS);
} catch (InterruptedException e1) {
terminated = false ;
}
if (!terminated) {
executor.shutdownNow() ;
}
{code}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:37 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-492) FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't shutdown the Executor
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492?pag...
]
Sanne Grinovero commented on HSEARCH-492:
-----------------------------------------
why are you giving it a 20 seconds ultimatum before kill?
I was thinking to use just executor.shutdown() , and if eventually a copy is being made it
will get whatever time it takes to finish properly.
FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't
shutdown the Executor
----------------------------------------------------------------------------------
Key: HSEARCH-492
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492
Project: Hibernate Search
Issue Type: Bug
Components: directory provider
Affects Versions: 3.1.1.GA
Environment: Java 1.6.0
Reporter: Sylvain Charton
Priority: Minor
Fix For: 3.2.0.CR1
I'm using Hibernate Search clustering feature in a stand alone Java application (not
a webapp).
My problem is the application never stops: many threads are still living.
Both FSMasterDirectoryProvider and FSSlaveDirectoryProvider use a Single Thread Executor
to perform the CopyTask.
When the FSSlaveDirectoryProvider.stop() is called, the timer is stopped, but not the
Executor in the TimerTask.
Consequence is the process can't stop, because some threads are still living,
endlessly.
This happens after the first CopyDirectory task was executed.
My fix was to copy this class in my code, and replace the Executor in TriggerTask class
by an ExecutorService in FSSlaveDirectoryProvider class.
The ExecutorService is initialized in the start() method:
{code:Java}this.executor = Executors.newSingleThreadExecutor() ;{code}
And properly shut down in the stop() method:
{code:java}
executor.shutdown();
boolean terminated = false ;
try{
terminated = executor.awaitTermination(20, TimeUnit.SECONDS);
} catch (InterruptedException e1) {
terminated = false ;
}
if (!terminated) {
executor.shutdownNow() ;
}
{code}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:21 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-492) FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't shutdown the Executor
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492?pag...
]
Sylvain Charton commented on HSEARCH-492:
-----------------------------------------
Just to put an arbitrary limit when stopping the process. In my case 20 sec is enough to
complete the copy if any should happen. For a proper implementation, it should be
configurable. It's good to put a limit, to prevent from blocking threads.
FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't
shutdown the Executor
----------------------------------------------------------------------------------
Key: HSEARCH-492
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492
Project: Hibernate Search
Issue Type: Bug
Components: directory provider
Affects Versions: 3.1.1.GA
Environment: Java 1.6.0
Reporter: Sylvain Charton
Priority: Minor
Fix For: 3.2.0.CR1
I'm using Hibernate Search clustering feature in a stand alone Java application (not
a webapp).
My problem is the application never stops: many threads are still living.
Both FSMasterDirectoryProvider and FSSlaveDirectoryProvider use a Single Thread Executor
to perform the CopyTask.
When the FSSlaveDirectoryProvider.stop() is called, the timer is stopped, but not the
Executor in the TimerTask.
Consequence is the process can't stop, because some threads are still living,
endlessly.
This happens after the first CopyDirectory task was executed.
My fix was to copy this class in my code, and replace the Executor in TriggerTask class
by an ExecutorService in FSSlaveDirectoryProvider class.
The ExecutorService is initialized in the start() method:
{code:Java}this.executor = Executors.newSingleThreadExecutor() ;{code}
And properly shut down in the stop() method:
{code:java}
executor.shutdown();
boolean terminated = false ;
try{
terminated = executor.awaitTermination(20, TimeUnit.SECONDS);
} catch (InterruptedException e1) {
terminated = false ;
}
if (!terminated) {
executor.shutdownNow() ;
}
{code}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:06 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-492) FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't shutdown the Executor
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492?pag...
]
Sanne Grinovero commented on HSEARCH-492:
-----------------------------------------
So assuming we add the configuration parameter, should this always be configured to a
reasonably large amount of time to guarantee the the copy finishes correctly? In that case
I could better not have a timeout and wait for whatever time it takes to finish.
If on the other side our standpoint is that it isn't dangerous to interrupt the copy,
that means we can interrupt the copy whenever we like, then we should be interrupting
immediately; I believe the copy process was designed to be safe enough, and a program
start would start with a fresh copy anyway.
FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't
shutdown the Executor
----------------------------------------------------------------------------------
Key: HSEARCH-492
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492
Project: Hibernate Search
Issue Type: Bug
Components: directory provider
Affects Versions: 3.1.1.GA
Environment: Java 1.6.0
Reporter: Sylvain Charton
Priority: Minor
Fix For: 3.2.0.CR1
I'm using Hibernate Search clustering feature in a stand alone Java application (not
a webapp).
My problem is the application never stops: many threads are still living.
Both FSMasterDirectoryProvider and FSSlaveDirectoryProvider use a Single Thread Executor
to perform the CopyTask.
When the FSSlaveDirectoryProvider.stop() is called, the timer is stopped, but not the
Executor in the TimerTask.
Consequence is the process can't stop, because some threads are still living,
endlessly.
This happens after the first CopyDirectory task was executed.
My fix was to copy this class in my code, and replace the Executor in TriggerTask class
by an ExecutorService in FSSlaveDirectoryProvider class.
The ExecutorService is initialized in the start() method:
{code:Java}this.executor = Executors.newSingleThreadExecutor() ;{code}
And properly shut down in the stop() method:
{code:java}
executor.shutdown();
boolean terminated = false ;
try{
terminated = executor.awaitTermination(20, TimeUnit.SECONDS);
} catch (InterruptedException e1) {
terminated = false ;
}
if (!terminated) {
executor.shutdownNow() ;
}
{code}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:32 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-492) FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't shutdown the Executor
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492?pag...
]
Emmanuel Bernard commented on HSEARCH-492:
------------------------------------------
If we want to be flexible, we could add a property timeout_on_stop = [0|n|never]
But I tend to agree with Sanne, it's either we wait or we don't: a timeout is for
undecided people ;)
Let's have a second read at the copy algo but I'm almost certain it's safe to
kill it. In this case, the no_wait option is the most user friendly.
What would be the use case for explicitly waiting? If they are not strong enough,
let's just always kill.
FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't
shutdown the Executor
----------------------------------------------------------------------------------
Key: HSEARCH-492
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492
Project: Hibernate Search
Issue Type: Bug
Components: directory provider
Affects Versions: 3.1.1.GA
Environment: Java 1.6.0
Reporter: Sylvain Charton
Priority: Minor
Fix For: 3.2.0.CR1
I'm using Hibernate Search clustering feature in a stand alone Java application (not
a webapp).
My problem is the application never stops: many threads are still living.
Both FSMasterDirectoryProvider and FSSlaveDirectoryProvider use a Single Thread Executor
to perform the CopyTask.
When the FSSlaveDirectoryProvider.stop() is called, the timer is stopped, but not the
Executor in the TimerTask.
Consequence is the process can't stop, because some threads are still living,
endlessly.
This happens after the first CopyDirectory task was executed.
My fix was to copy this class in my code, and replace the Executor in TriggerTask class
by an ExecutorService in FSSlaveDirectoryProvider class.
The ExecutorService is initialized in the start() method:
{code:Java}this.executor = Executors.newSingleThreadExecutor() ;{code}
And properly shut down in the stop() method:
{code:java}
executor.shutdown();
boolean terminated = false ;
try{
terminated = executor.awaitTermination(20, TimeUnit.SECONDS);
} catch (InterruptedException e1) {
terminated = false ;
}
if (!terminated) {
executor.shutdownNow() ;
}
{code}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:14 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-492) FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't shutdown the Executor
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492?pag...
]
Emmanuel Bernard commented on HSEARCH-492:
------------------------------------------
Oh and nice to see you contributing Sly :)
FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't
shutdown the Executor
----------------------------------------------------------------------------------
Key: HSEARCH-492
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492
Project: Hibernate Search
Issue Type: Bug
Components: directory provider
Affects Versions: 3.1.1.GA
Environment: Java 1.6.0
Reporter: Sylvain Charton
Priority: Minor
Fix For: 3.2.0.CR1
I'm using Hibernate Search clustering feature in a stand alone Java application (not
a webapp).
My problem is the application never stops: many threads are still living.
Both FSMasterDirectoryProvider and FSSlaveDirectoryProvider use a Single Thread Executor
to perform the CopyTask.
When the FSSlaveDirectoryProvider.stop() is called, the timer is stopped, but not the
Executor in the TimerTask.
Consequence is the process can't stop, because some threads are still living,
endlessly.
This happens after the first CopyDirectory task was executed.
My fix was to copy this class in my code, and replace the Executor in TriggerTask class
by an ExecutorService in FSSlaveDirectoryProvider class.
The ExecutorService is initialized in the start() method:
{code:Java}this.executor = Executors.newSingleThreadExecutor() ;{code}
And properly shut down in the stop() method:
{code:java}
executor.shutdown();
boolean terminated = false ;
try{
terminated = executor.awaitTermination(20, TimeUnit.SECONDS);
} catch (InterruptedException e1) {
terminated = false ;
}
if (!terminated) {
executor.shutdownNow() ;
}
{code}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:20 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-492) FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't shutdown the Executor
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492?pag...
]
Sylvain Charton commented on HSEARCH-492:
-----------------------------------------
eh eh no-option is the decision of dictators ;-)
but you're right, actually.
I used the timeout as a generic pattern to shutdown an ExecutorService, in the mind of
"let it time to complete".
It is not required, as the copy algorithm is safe for the next reader: the marker file is
not updated unless all files are correctly copied.
So killing is ok, and much simpler.
FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't
shutdown the Executor
----------------------------------------------------------------------------------
Key: HSEARCH-492
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492
Project: Hibernate Search
Issue Type: Bug
Components: directory provider
Affects Versions: 3.1.1.GA
Environment: Java 1.6.0
Reporter: Sylvain Charton
Priority: Minor
Fix For: 3.2.0.CR1
I'm using Hibernate Search clustering feature in a stand alone Java application (not
a webapp).
My problem is the application never stops: many threads are still living.
Both FSMasterDirectoryProvider and FSSlaveDirectoryProvider use a Single Thread Executor
to perform the CopyTask.
When the FSSlaveDirectoryProvider.stop() is called, the timer is stopped, but not the
Executor in the TimerTask.
Consequence is the process can't stop, because some threads are still living,
endlessly.
This happens after the first CopyDirectory task was executed.
My fix was to copy this class in my code, and replace the Executor in TriggerTask class
by an ExecutorService in FSSlaveDirectoryProvider class.
The ExecutorService is initialized in the start() method:
{code:Java}this.executor = Executors.newSingleThreadExecutor() ;{code}
And properly shut down in the stop() method:
{code:java}
executor.shutdown();
boolean terminated = false ;
try{
terminated = executor.awaitTermination(20, TimeUnit.SECONDS);
} catch (InterruptedException e1) {
terminated = false ;
}
if (!terminated) {
executor.shutdownNow() ;
}
{code}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:26 a.m.
New subject: [Hibernate-JIRA] Assigned: (HSEARCH-492) FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't shutdown the Executor
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492?pag...
]
Sanne Grinovero reassigned HSEARCH-492:
---------------------------------------
Assignee: Sanne Grinovero
FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't
shutdown the Executor
----------------------------------------------------------------------------------
Key: HSEARCH-492
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492
Project: Hibernate Search
Issue Type: Bug
Components: directory provider
Affects Versions: 3.1.1.GA
Environment: Java 1.6.0
Reporter: Sylvain Charton
Assignee: Sanne Grinovero
Priority: Minor
Fix For: 3.2.0.CR1
I'm using Hibernate Search clustering feature in a stand alone Java application (not
a webapp).
My problem is the application never stops: many threads are still living.
Both FSMasterDirectoryProvider and FSSlaveDirectoryProvider use a Single Thread Executor
to perform the CopyTask.
When the FSSlaveDirectoryProvider.stop() is called, the timer is stopped, but not the
Executor in the TimerTask.
Consequence is the process can't stop, because some threads are still living,
endlessly.
This happens after the first CopyDirectory task was executed.
My fix was to copy this class in my code, and replace the Executor in TriggerTask class
by an ExecutorService in FSSlaveDirectoryProvider class.
The ExecutorService is initialized in the start() method:
{code:Java}this.executor = Executors.newSingleThreadExecutor() ;{code}
And properly shut down in the stop() method:
{code:java}
executor.shutdown();
boolean terminated = false ;
try{
terminated = executor.awaitTermination(20, TimeUnit.SECONDS);
} catch (InterruptedException e1) {
terminated = false ;
}
if (!terminated) {
executor.shutdownNow() ;
}
{code}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:26 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-492) FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't shutdown the Executor
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492?pag...
]
Sanne Grinovero commented on HSEARCH-492:
-----------------------------------------
thank you Sylvain for the input.
Emmanuel, so shall I commit it without configuration options and kill right away the
background thread?
FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't
shutdown the Executor
----------------------------------------------------------------------------------
Key: HSEARCH-492
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492
Project: Hibernate Search
Issue Type: Bug
Components: directory provider
Affects Versions: 3.1.1.GA
Environment: Java 1.6.0
Reporter: Sylvain Charton
Priority: Minor
Fix For: 3.2.0.CR1
I'm using Hibernate Search clustering feature in a stand alone Java application (not
a webapp).
My problem is the application never stops: many threads are still living.
Both FSMasterDirectoryProvider and FSSlaveDirectoryProvider use a Single Thread Executor
to perform the CopyTask.
When the FSSlaveDirectoryProvider.stop() is called, the timer is stopped, but not the
Executor in the TimerTask.
Consequence is the process can't stop, because some threads are still living,
endlessly.
This happens after the first CopyDirectory task was executed.
My fix was to copy this class in my code, and replace the Executor in TriggerTask class
by an ExecutorService in FSSlaveDirectoryProvider class.
The ExecutorService is initialized in the start() method:
{code:Java}this.executor = Executors.newSingleThreadExecutor() ;{code}
And properly shut down in the stop() method:
{code:java}
executor.shutdown();
boolean terminated = false ;
try{
terminated = executor.awaitTermination(20, TimeUnit.SECONDS);
} catch (InterruptedException e1) {
terminated = false ;
}
if (!terminated) {
executor.shutdownNow() ;
}
{code}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:29 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-492) FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't shutdown the Executor
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492?pag...
]
Emmanuel Bernard commented on HSEARCH-492:
------------------------------------------
yes. And if people complain too much, we will revisit.
FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't
shutdown the Executor
----------------------------------------------------------------------------------
Key: HSEARCH-492
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492
Project: Hibernate Search
Issue Type: Bug
Components: directory provider
Affects Versions: 3.1.1.GA
Environment: Java 1.6.0
Reporter: Sylvain Charton
Assignee: Sanne Grinovero
Priority: Minor
Fix For: 3.2.0.CR1
I'm using Hibernate Search clustering feature in a stand alone Java application (not
a webapp).
My problem is the application never stops: many threads are still living.
Both FSMasterDirectoryProvider and FSSlaveDirectoryProvider use a Single Thread Executor
to perform the CopyTask.
When the FSSlaveDirectoryProvider.stop() is called, the timer is stopped, but not the
Executor in the TimerTask.
Consequence is the process can't stop, because some threads are still living,
endlessly.
This happens after the first CopyDirectory task was executed.
My fix was to copy this class in my code, and replace the Executor in TriggerTask class
by an ExecutorService in FSSlaveDirectoryProvider class.
The ExecutorService is initialized in the start() method:
{code:Java}this.executor = Executors.newSingleThreadExecutor() ;{code}
And properly shut down in the stop() method:
{code:java}
executor.shutdown();
boolean terminated = false ;
try{
terminated = executor.awaitTermination(20, TimeUnit.SECONDS);
} catch (InterruptedException e1) {
terminated = false ;
}
if (!terminated) {
executor.shutdownNow() ;
}
{code}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:11 a.m.
New subject: [Hibernate-JIRA] Resolved: (HSEARCH-492) FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't shutdown the Executor
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492?pag...
]
Sanne Grinovero resolved HSEARCH-492.
-------------------------------------
Resolution: Fixed
FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't
shutdown the Executor
----------------------------------------------------------------------------------
Key: HSEARCH-492
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492
Project: Hibernate Search
Issue Type: Bug
Components: directory provider
Affects Versions: 3.1.1.GA
Environment: Java 1.6.0
Reporter: Sylvain Charton
Assignee: Sanne Grinovero
Priority: Minor
Fix For: 3.2.0.CR1
I'm using Hibernate Search clustering feature in a stand alone Java application (not
a webapp).
My problem is the application never stops: many threads are still living.
Both FSMasterDirectoryProvider and FSSlaveDirectoryProvider use a Single Thread Executor
to perform the CopyTask.
When the FSSlaveDirectoryProvider.stop() is called, the timer is stopped, but not the
Executor in the TimerTask.
Consequence is the process can't stop, because some threads are still living,
endlessly.
This happens after the first CopyDirectory task was executed.
My fix was to copy this class in my code, and replace the Executor in TriggerTask class
by an ExecutorService in FSSlaveDirectoryProvider class.
The ExecutorService is initialized in the start() method:
{code:Java}this.executor = Executors.newSingleThreadExecutor() ;{code}
And properly shut down in the stop() method:
{code:java}
executor.shutdown();
boolean terminated = false ;
try{
terminated = executor.awaitTermination(20, TimeUnit.SECONDS);
} catch (InterruptedException e1) {
terminated = false ;
}
if (!terminated) {
executor.shutdownNow() ;
}
{code}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:16 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-492) FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't shutdown the Executor
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492?pag...
]
Sylvain Charton commented on HSEARCH-492:
-----------------------------------------
great ! thanks.
FSMasterDirectoryProvider and FSSlaveDirectoryProvider don't
shutdown the Executor
----------------------------------------------------------------------------------
Key: HSEARCH-492
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-492
Project: Hibernate Search
Issue Type: Bug
Components: directory provider
Affects Versions: 3.1.1.GA
Environment: Java 1.6.0
Reporter: Sylvain Charton
Assignee: Sanne Grinovero
Priority: Minor
Fix For: 3.2.0.CR1
I'm using Hibernate Search clustering feature in a stand alone Java application (not
a webapp).
My problem is the application never stops: many threads are still living.
Both FSMasterDirectoryProvider and FSSlaveDirectoryProvider use a Single Thread Executor
to perform the CopyTask.
When the FSSlaveDirectoryProvider.stop() is called, the timer is stopped, but not the
Executor in the TimerTask.
Consequence is the process can't stop, because some threads are still living,
endlessly.
This happens after the first CopyDirectory task was executed.
My fix was to copy this class in my code, and replace the Executor in TriggerTask class
by an ExecutorService in FSSlaveDirectoryProvider class.
The ExecutorService is initialized in the start() method:
{code:Java}this.executor = Executors.newSingleThreadExecutor() ;{code}
And properly shut down in the stop() method:
{code:java}
executor.shutdown();
boolean terminated = false ;
try{
terminated = executor.awaitTermination(20, TimeUnit.SECONDS);
} catch (InterruptedException e1) {
terminated = false ;
}
if (!terminated) {
executor.shutdownNow() ;
}
{code}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5294
days inactive
5296
days old
hibernate-issues@lists.jboss.org
12 comments
3 participants
participants (3)
-
Emmanuel Bernard (JIRA) -
Sanne Grinovero (JIRA)
-
Sylvain Charton (JIRA)