1:44 p.m.
Remove package cycle between "core" and "descriptor" packages
-------------------------------------------------------------
Key: HV-532
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-532
Project: Hibernate Validator
Issue Type: Task
Components: engine
Affects Versions: 4.2.0.Final
Reporter: Gunnar Morling
Fix For: 4.3.0.next
There is a cyclic dependency between the packages
{{org.hibernate.validator.metadata.core}} and
{{org.hibernate.validator.metadata.descriptor}} which should be removed.
I think the general problem is that {{ConstraintDescriptorImpl}} (which is now part of the
"descriptor" model) is used globally in HV. Probably there should be a
corresponding node in the internal model (actually we already have this with
{{MetaConstraint}}), of which {{ConstraintDescriptorImpl}} would only be a light-weight
view for external meta-model users.
In {{ConstraintDescriptorImpl}} there is also a lot of logic related to annotation
retrieval, which we now might move into the provider hierarchy similar to
{{BeanMetaDataImpl}}.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:26 a.m.
New subject: [Hibernate-JIRA] Updated: (HV-532) Remove package cycle between "core" and "descriptor" packages
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-532?page=com...
]
Hardy Ferentschik updated HV-532:
---------------------------------
Fix Version/s: (was: 4.3.0.Alpha1)
4.3.0.next
Remove package cycle between "core" and
"descriptor" packages
-------------------------------------------------------------
Key: HV-532
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-532
Project: Hibernate Validator
Issue Type: Task
Components: engine
Affects Versions: 4.2.0.Final
Reporter: Gunnar Morling
Fix For: 4.3.0.next
There is a cyclic dependency between the packages
{{org.hibernate.validator.metadata.core}} and
{{org.hibernate.validator.metadata.descriptor}} which should be removed.
I think the general problem is that {{ConstraintDescriptorImpl}} (which is now part of
the "descriptor" model) is used globally in HV. Probably there should be a
corresponding node in the internal model (actually we already have this with
{{MetaConstraint}}), of which {{ConstraintDescriptorImpl}} would only be a light-weight
view for external meta-model users.
In {{ConstraintDescriptorImpl}} there is also a lot of logic related to annotation
retrieval, which we now might move into the provider hierarchy similar to
{{BeanMetaDataImpl}}.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:43 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-532) Remove package cycle between "core" and "descriptor" packages
[
https://hibernate.onjira.com/browse/HV-532?page=com.atlassian.jira.plugin...
]
Hardy Ferentschik commented on HV-532:
--------------------------------------
Would a fix mean breaking the current API. If so, we should move it to HV 5.
Remove package cycle between "core" and
"descriptor" packages
-------------------------------------------------------------
Key: HV-532
URL: https://hibernate.onjira.com/browse/HV-532
Project: Hibernate Validator
Issue Type: Task
Components: engine
Affects Versions: 4.2.0.Final
Reporter: Gunnar Morling
Fix For: 4.3.0.Beta1
There is a cyclic dependency between the packages
{{org.hibernate.validator.metadata.core}} and
{{org.hibernate.validator.metadata.descriptor}} which should be removed.
I think the general problem is that {{ConstraintDescriptorImpl}} (which is now part of
the "descriptor" model) is used globally in HV. Probably there should be a
corresponding node in the internal model (actually we already have this with
{{MetaConstraint}}), of which {{ConstraintDescriptorImpl}} would only be a light-weight
view for external meta-model users.
In {{ConstraintDescriptorImpl}} there is also a lot of logic related to annotation
retrieval, which we now might move into the provider hierarchy similar to
{{BeanMetaDataImpl}}.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:13 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-532) Remove package cycle between "core" and "descriptor" packages
[
https://hibernate.onjira.com/browse/HV-532?page=com.atlassian.jira.plugin...
]
Gunnar Morling commented on HV-532:
-----------------------------------
{quote}
If so, we should move it to HV 5.
{quote}
+1. I'll look into it and see what it would mean to remove the cycle.
Remove package cycle between "core" and
"descriptor" packages
-------------------------------------------------------------
Key: HV-532
URL: https://hibernate.onjira.com/browse/HV-532
Project: Hibernate Validator
Issue Type: Task
Components: engine
Affects Versions: 4.2.0.Final
Reporter: Gunnar Morling
Fix For: 4.3.0.Beta1
There is a cyclic dependency between the packages
{{org.hibernate.validator.metadata.core}} and
{{org.hibernate.validator.metadata.descriptor}} which should be removed.
I think the general problem is that {{ConstraintDescriptorImpl}} (which is now part of
the "descriptor" model) is used globally in HV. Probably there should be a
corresponding node in the internal model (actually we already have this with
{{MetaConstraint}}), of which {{ConstraintDescriptorImpl}} would only be a light-weight
view for external meta-model users.
In {{ConstraintDescriptorImpl}} there is also a lot of logic related to annotation
retrieval, which we now might move into the provider hierarchy similar to
{{BeanMetaDataImpl}}.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:50 p.m.
New subject: [Hibernate-JIRA] Assigned: (HV-532) Remove package cycle between "core" and "descriptor" packages
[
https://hibernate.onjira.com/browse/HV-532?page=com.atlassian.jira.plugin...
]
Gunnar Morling reassigned HV-532:
---------------------------------
Assignee: Gunnar Morling
Remove package cycle between "core" and
"descriptor" packages
-------------------------------------------------------------
Key: HV-532
URL: https://hibernate.onjira.com/browse/HV-532
Project: Hibernate Validator
Issue Type: Task
Components: engine
Affects Versions: 4.2.0.Final
Reporter: Gunnar Morling
Assignee: Gunnar Morling
Fix For: 4.3.0.Beta1
There is a cyclic dependency between the packages
{{org.hibernate.validator.metadata.core}} and
{{org.hibernate.validator.metadata.descriptor}} which should be removed.
I think the general problem is that {{ConstraintDescriptorImpl}} (which is now part of
the "descriptor" model) is used globally in HV. Probably there should be a
corresponding node in the internal model (actually we already have this with
{{MetaConstraint}}), of which {{ConstraintDescriptorImpl}} would only be a light-weight
view for external meta-model users.
In {{ConstraintDescriptorImpl}} there is also a lot of logic related to annotation
retrieval, which we now might move into the provider hierarchy similar to
{{BeanMetaDataImpl}}.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3 a.m.
New subject: [Hibernate-JIRA] Updated: (HV-532) Remove package cycle between "core" and "descriptor" packages
[
https://hibernate.onjira.com/browse/HV-532?page=com.atlassian.jira.plugin...
]
Hardy Ferentschik updated HV-532:
---------------------------------
Fix Version/s: (was: 4.3.0.Beta1)
4.3.0.CR1
Remove package cycle between "core" and
"descriptor" packages
-------------------------------------------------------------
Key: HV-532
URL: https://hibernate.onjira.com/browse/HV-532
Project: Hibernate Validator
Issue Type: Task
Components: engine
Affects Versions: 4.2.0.Final
Reporter: Gunnar Morling
Assignee: Gunnar Morling
Fix For: 4.3.0.CR1
There is a cyclic dependency between the packages
{{org.hibernate.validator.metadata.core}} and
{{org.hibernate.validator.metadata.descriptor}} which should be removed.
I think the general problem is that {{ConstraintDescriptorImpl}} (which is now part of
the "descriptor" model) is used globally in HV. Probably there should be a
corresponding node in the internal model (actually we already have this with
{{MetaConstraint}}), of which {{ConstraintDescriptorImpl}} would only be a light-weight
view for external meta-model users.
In {{ConstraintDescriptorImpl}} there is also a lot of logic related to annotation
retrieval, which we now might move into the provider hierarchy similar to
{{BeanMetaDataImpl}}.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-532) Remove package cycle between "core" and "descriptor" packages
[
https://hibernate.onjira.com/browse/HV-532?page=com.atlassian.jira.plugin...
]
Gunnar Morling commented on HV-532:
-----------------------------------
I had a short look into this issue. I think this needs a larger refactoring which will
likely take some time.
Therefore I'd also say let's move this to HV 5. Maybe we need some changes to the
meta-model due to method validation anyways, so that would be a good opportunity.
Only internal packages are concerned, I don't expect any impact on the public API.
Remove package cycle between "core" and
"descriptor" packages
-------------------------------------------------------------
Key: HV-532
URL: https://hibernate.onjira.com/browse/HV-532
Project: Hibernate Validator
Issue Type: Task
Components: engine
Affects Versions: 4.2.0.Final
Reporter: Gunnar Morling
Assignee: Gunnar Morling
Fix For: 4.3.0.CR1
There is a cyclic dependency between the packages
{{org.hibernate.validator.metadata.core}} and
{{org.hibernate.validator.metadata.descriptor}} which should be removed.
I think the general problem is that {{ConstraintDescriptorImpl}} (which is now part of
the "descriptor" model) is used globally in HV. Probably there should be a
corresponding node in the internal model (actually we already have this with
{{MetaConstraint}}), of which {{ConstraintDescriptorImpl}} would only be a light-weight
view for external meta-model users.
In {{ConstraintDescriptorImpl}} there is also a lot of logic related to annotation
retrieval, which we now might move into the provider hierarchy similar to
{{BeanMetaDataImpl}}.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:02 p.m.
New subject: [Hibernate-JIRA] Updated: (HV-532) Remove package cycle between "core" and "descriptor" packages
[
https://hibernate.onjira.com/browse/HV-532?page=com.atlassian.jira.plugin...
]
Gunnar Morling updated HV-532:
------------------------------
Fix Version/s: (was: 4.3.0.CR1)
5.x
Remove package cycle between "core" and
"descriptor" packages
-------------------------------------------------------------
Key: HV-532
URL: https://hibernate.onjira.com/browse/HV-532
Project: Hibernate Validator
Issue Type: Task
Components: engine
Affects Versions: 4.2.0.Final
Reporter: Gunnar Morling
Assignee: Gunnar Morling
Fix For: 5.x
There is a cyclic dependency between the packages
{{org.hibernate.validator.metadata.core}} and
{{org.hibernate.validator.metadata.descriptor}} which should be removed.
I think the general problem is that {{ConstraintDescriptorImpl}} (which is now part of
the "descriptor" model) is used globally in HV. Probably there should be a
corresponding node in the internal model (actually we already have this with
{{MetaConstraint}}), of which {{ConstraintDescriptorImpl}} would only be a light-weight
view for external meta-model users.
In {{ConstraintDescriptorImpl}} there is also a lot of logic related to annotation
retrieval, which we now might move into the provider hierarchy similar to
{{BeanMetaDataImpl}}.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4593
days inactive
4727
days old
hibernate-issues@lists.jboss.org
7 comments
2 participants
participants (2)
-
Gunnar Morling (JIRA) -
Hardy Ferentschik (JIRA)