[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6920?page=c... ] Steve Ebersole commented on HHH-6920: ------------------------------------- The difficulty (given the current code) is that the optimizer being used in conjunction with {{SequenceStyleGenerator}} becomes important. For example, if {{SequenceStyleGenerator}} is configured to use any of the hilo-based optimizers, it cannot support identifier generation as part of bulk insertion. {{HqlSqlWalker.supportsIdGenWithBulkInsertion}} is given the actual {{IdentifierGenerator}} instance, so this is at least workable. However, rather than a series of instanceof-type checks that could never be complete (think custom generators), I propose we instead add an optional contract for IdentifierGenerator impls to implement if they support id generation with bulk insertion. We just need to identify the pieces that need to be part of the contract. At the highest level, supporting id generation with bulk insertion comes down to requiring an "in-database" form of id value generation. There are 2 broad forms of these: * id column(s) is referenced in the insert-spec. ** This mainly includes sequences. ** This could also include calls to functions, etc * id column(s) is not referenced in the insert-spec ** This mainly includes IDENTITY ** This could also include id values assigned through DEFAULT column specs, triggers, etc So essentially, the information we need: # Do the id columns need to be referenced? If so we need to add the columns to the insert-spec, and: # What is the "id generation" fragment we need to add to the select expression list? Initial proposal on contract: {code:title=BulkInsertionSupportingIdentifierGenerator.java|borderStyle=solid} public interface BulkInsertionSupportingIdentifierGenerator extends IdentifierGenerator { /** * Given the configuration of this IdentifierGenerator, does it support identifier generation as part of * bulk insertion? * <p/> * IMPL NOTE : Mainly here to allow stuff like SequenceStyleGenerator which *can* support this based on * configuration * ... */ public boolean supportsBulkInsertionIdentifierGeneration(); /** * Return the select expression fragment, if any, that generates the identifier values. {@code null} indicates * that no fragment is needed. * ... */ public String determineBulkInsertionIdentifierGenerationSelectFragment(Dialect dialect); } {code} The code in HqlSqlWalker then becomes: {code} protected void postProcessInsert(AST insert) throws SemanticException, QueryException { ... if ( !insertStatement.getIntoClause().isExplicitIdInsertion() ) { final IdentifierGenerator generator = persister.getIdentifierGenerator(); if ( ! BulkInsertionSupportingIdentifierGenerator.class.isInstance( generator ) ) { throw new QueryException( ... ); } final BulkInsertionSupportingIdentifierGenerator goodGenerator = BulkInsertionSupportingIdentifierGenerator.class.cast( generator ); if ( ! goodGenerator.supportsBulkInsertionIdentifierGeneration() ) { throw new QueryException( ... ); } final String fragment = goodGenerator.determineBulkInsertionIdentifierGenerationSelectFragment( sessionFactoryHelper.getFactory().getDialect() ); if ( fragment != null ) { // we got a fragment from the generator, so alter the sql tree... // // first, wrap the fragment as a node AST fragmentNode = getASTFactory().create( HqlSqlTokenTypes.SQL_TOKEN, fragment ); // next, rearrange the SQL tree to add the fragment node as the first select expression AST currentFirstSelectExprNode = selectClause.getFirstChild(); selectClause.setFirstChild( idSelectExprNode ); idSelectExprNode.setNextSibling( currentFirstSelectExprNode ); // finally, prepend the id column name(s) to the insert-spec insertStatement.getIntoClause().prependIdColumnSpec(); } } } {code} Thoughts? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6920?page=c... ] Steve Ebersole updated HHH-6920: -------------------------------- Summary: HQL insert queries and identifier handling (was: Jboss7 with Insert into select query) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6920?page=c... ] Steve Ebersole commented on HHH-6920: ------------------------------------- This is done, however there are just certain instances where {{SequenceStyleGenerator}} will not be able to support implicit id generation as part of bulk insertions. Namely, if either (1) a physical table is used instead of a sequence or (2) any optimization strategies are applied. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6920?page=c... ] sabbirali kadiwala edited comment on HHH-6920 at 12/28/11 6:40 AM: ------------------------------------------------------------------- Thanx for all, Issue got resolved But How i can co-ordinate with jboss7 ? Should i wait for next release version of jboss7 ? Please appreciate your reply. was (Author: sabbirali): thanx for all issue got resolved but how i can co-ordinate with jboss7 or should i wait for next release version of jboss7 ? Please appreciate your reply -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira