[Hibernate-JIRA] Created: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass - hibernate-issues

[Hibernate-JIRA] Created: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[Hibernate-JIRA] Created:...

[Hibernate-JIRA] Resolved:...

Michelle Baert (JIRA)

Friday, 25 August 2006 Fri, 25 Aug '06

11:36 a.m.

hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass ------------------------------------------------------------------------------------- Key: HBX-737 URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-737 Project: Hibernate Tools Type: Bug Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Attachments: CustomExporter-20060825.zip I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

Show replies by date

Michelle Baert (JIRA)

Friday, 25 August Fri, 25 Aug

11:48 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=co... ] Michelle Baert commented on HBX-737: ------------------------------------ Hi all, Here is a summary of the patch (PATCH01.diff) on org.hibernate.tool.ant.GenericExporterTask.java - createExporter() now creates the custom exporter when specified --> no need now to run twice org.hibernate.tool.hbm2x.GenericExporter.start() --> no hassle with copying properties from an instance to another. - suppressed usage of GenericExporter.exporterClass property - getName(): added a space before exporterClass - started some javadoc ... hope this helps ... --- Best regards Michelle Baert, Brest, France

...

Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Attachments: CustomExporter-20060825.zip I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines.

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

Max Rydahl Andersen (JIRA)

Saturday, 26 August Sat, 26 Aug

12:57 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

...

Max Rydahl Andersen (JIRA)

12:57 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

...

Michelle Baert (JIRA)

1:57 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=co... ] Michelle Baert commented on HBX-737: ------------------------------------ Hi max, Before submitting that path, I carefully studied the class hierarchy of the concerned objects, looked for references and even in text search on all HibernateExt java sources. I also tried the junit tests but many already failed in original version (I don't have clover.jar) ... I didn't debug that. ... ;) I know all seem obvious at the time of writing, but then ... Never thought that commenting your code would help not only users (through api), contributors, but yourself too ? I'm now studiing hbm2x.GenericExporter, scanned for exporterClass usage, after the previous patch. None found except in the tests: HibernateExt\tools\src\test\org\hibernate\tool\hbm2x\GenericExporterTest.java I'll submit another patch soon. Have a nice day, Michelle

...

Michelle Baert (JIRA)

2:07 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=co... ] Michelle Baert commented on HBX-737: ------------------------------------ Yoops ! I just noticed a typo in the HBX description: one should read: There are 2 custom exporter classes: - MyExporter simply extends GenericExporter with nothing else - My VerboseExporter is similar but provides log messages. apologies; Michelle

...

Michelle Baert (JIRA)

2:48 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=co... ] Michelle Baert commented on HBX-737: ------------------------------------ Here's the patch for HibernateExt/tools/src/java/org/hibernate/tool/hbm2x/GenericExporter.java - suppressed exporterClass property, not used elsewhere in project (apart from HibernateExt\tools\src\test\org\hibernate\tool\hbm2x\GenericExporterTest.java) - suppressed start() method now useless. Superclass's method will be called instead. - added getter for filePattern, needed by custom subclasses. - added some javadoc: need to be clear for subclasses writers It assumes thats patch01.diff has been applied. I enclose also resulting files. Michelle

...

Michelle Baert (JIRA)

2:50 a.m.

New subject: [Hibernate-JIRA] Updated: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=all ] Michelle Baert updated HBX-737: ------------------------------- Attachment: Patch03.diff GenericExporter.java GenericExporterTask.java

...

Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Attachments: CustomExporter-20060825.zip, GenericExporter.java, GenericExporterTask.java, Patch03.diff I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines.

Michelle Baert (JIRA)

Sunday, 27 August Sun, 27 Aug

8:02 a.m.

New subject: [Hibernate-JIRA] Updated: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=all ] Michelle Baert updated HBX-737: ------------------------------- Attachment: GenericExporter.zip I corrected the patch to let the exporter set default values for template and filepattern. After corrections in build files(see HBX-740) , I could build and run tests (from the tools directory). I enclosed the xml results before and after patch : looks equivalent.

...

Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Attachments: CustomExporter-20060825.zip, GenericExporter.java, GenericExporter.zip, GenericExporterTask.java, Patch03.diff I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines.

Michelle Baert (JIRA)

8:02 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=co... ] Michelle Baert commented on HBX-737: ------------------------------------ Last attachment is named "GenericExporter.zip"

...

Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Attachments: CustomExporter-20060825.zip, GenericExporter.java, GenericExporter.zip, GenericExporterTask.java, Patch03.diff I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines.

Max Rydahl Andersen (JIRA)

Monday, 28 August Mon, 28 Aug

2:32 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

...

Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Attachments: CustomExporter-20060825.zip, GenericExporter.java, GenericExporter.zip, GenericExporterTask.java, Patch03.diff I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines.

Michelle Baert (JIRA)

3:29 a.m.

New subject: [Hibernate-JIRA] Updated: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=all ] Michelle Baert updated HBX-737: ------------------------------- Attachment: CustomExporter-20060825.zip Hi Max, Sorry for the omission. I resend the archive, including build.xml, plus build.properties to be edited to correct the paths. I'm working on a further patch, where exporter properties refered to from GenericExporterTask are "pulled up" to the Exporter interface. I'll test it before submitting. Have a good day. Michelle

...

Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Attachments: CustomExporter-20060825.zip, CustomExporter-20060825.zip, GenericExporter.java, GenericExporter.zip, GenericExporterTask.java, Patch03.diff I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines.

Max Rydahl Andersen (JIRA)

3:44 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=co... ] Max Rydahl Andersen commented on HBX-737: ----------------------------------------- i finally realized what your "problem" is. the exception is thrown because neither the filepattern nor templateName is set on the genericexporter and currently that is *correct* behavior in my book ;) there is a bug that the properties is actually not initalized to the values given from "above", but then there is still the issue of the two values actually being set from the properties ...that is fixable. I don't see a reason for pulling these parameters *up* in the exporter interface (at least not blindly) since they *only* makes sense for GenericExporter. Anyhow the whole reason for this issue is that the property fields on exporters are not generally aligned with the properties and that should be fixed together with defining a proper lifecycle for the Exporters.

...

Max Rydahl Andersen (JIRA)

3:48 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=co... ] Max Rydahl Andersen commented on HBX-737: ----------------------------------------- btw. if you look at all subclasses of genericexporter then they have an init method that sets these. I know its not optimal, but that is how its fixable for the moment.

...

Michelle Baert (JIRA)

5:27 a.m.

New subject: [Hibernate-JIRA] Updated: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=all ] Michelle Baert updated HBX-737: ------------------------------- Attachment: Work03.diff Here's my proposal patch. The test runs fines. IMHO, you can't tell it *only* makes sense for GenericExporter since you provide the feature of providing a custom exporter, and the required interface is Exporter. This exporter should implement a minimum interface being able to generate files, so it seems reasonable to me that the properties FilePattern and TemplateName are needed. The GenericExporter, as it is, seems very tied to POJO generation, which may not be needed for some user exporters.

...

Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Attachments: CustomExporter-20060825.zip, CustomExporter-20060825.zip, GenericExporter.java, GenericExporter.zip, GenericExporterTask.java, Patch03.diff, Work03.diff I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines.

Max Rydahl Andersen (JIRA)

5:34 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=co... ] Max Rydahl Andersen commented on HBX-737: ----------------------------------------- If I fix the bug by setting templatename and filepattern on GenericExporter then everything works fine, right ? I hear what you are saying but templatename and filepattern doesn't make sense unless you are using *templates*; and that is not the case for an Exporter only for GenericExporter. anyhow i'll look into this before the next release.

...

Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Attachments: CustomExporter-20060825.zip, CustomExporter-20060825.zip, GenericExporter.java, GenericExporter.zip, GenericExporterTask.java, Patch03.diff, Work03.diff I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines.

Michelle Baert (JIRA)

6:20 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=co... ] Michelle Baert commented on HBX-737: ------------------------------------ Thank you. I'm back working on my new Exporter class, which implement ImportContext and provide the ability to generates classes in any destination package, with correct imports. It may be a subject for a new HBX (improvement or feature). I use my patched hibernate-tools version, which may evolve. Best regards, Michelle

...

Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Attachments: CustomExporter-20060825.zip, CustomExporter-20060825.zip, GenericExporter.java, GenericExporter.zip, GenericExporterTask.java, Patch03.diff, Work03.diff I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines.

Max Rydahl Andersen (JIRA)

6:26 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=co... ] Max Rydahl Andersen commented on HBX-737: ----------------------------------------- my current conclusion is that i'll move the creation of the exporterclass to the task...it makes sense and it will also initialize the "forgotten" properties. i'm not so keen on GenericExporter moving up into AbstractExporter since it shouldn't be so "pojo-fixated". and please don't submit patches with patches i already said were not the right solution ;) (e.g. all the changes of 3.2 to hibernate3 is wrong, especially since it is 3.2 branch/release we should be working against) thanks.

...

Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Attachments: CustomExporter-20060825.zip, CustomExporter-20060825.zip, GenericExporter.java, GenericExporter.zip, GenericExporterTask.java, Patch03.diff, Work03.diff I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines.

Max Rydahl Andersen (JIRA)

6:28 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=co... ] Max Rydahl Andersen commented on HBX-737: ----------------------------------------- that said it would be interesting to see your importcontext fix in *isolation* if at all possible. (and yes, it should go into a hbx of its own)

...

Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Attachments: CustomExporter-20060825.zip, CustomExporter-20060825.zip, GenericExporter.java, GenericExporter.zip, GenericExporterTask.java, Patch03.diff, Work03.diff I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines.

Michelle Baert (JIRA)

6:35 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=co... ] Michelle Baert commented on HBX-737: ------------------------------------ It's easier for me to generate a global patch for may working copy (I *do* need this 3.2 fix, and don't understand your conclusion to HBX740). It shouldn't be that difficult for you to select the patches you want or not. Free contributors are not your slaves !

...

Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Attachments: CustomExporter-20060825.zip, CustomExporter-20060825.zip, GenericExporter.java, GenericExporter.zip, GenericExporterTask.java, Patch03.diff, Work03.diff I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines.

Max Rydahl Andersen (JIRA)

6:39 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=co... ] Max Rydahl Andersen commented on HBX-737: ----------------------------------------- did you try and run the target I told you about in HBX-740 ? And no, free contributors are not slaves and neither am i ;) It just gets extremely time consuming to choose the right things to apply when fixes for more than one thing is getting fixed in a patch and only one of them is wanted or applicable for the time being.

...

Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Attachments: CustomExporter-20060825.zip, CustomExporter-20060825.zip, GenericExporter.java, GenericExporter.zip, GenericExporterTask.java, Patch03.diff, Work03.diff I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines.

Max Rydahl Andersen (JIRA)

6:41 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

...

Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Attachments: CustomExporter-20060825.zip, CustomExporter-20060825.zip, GenericExporter.java, GenericExporter.zip, GenericExporterTask.java, Patch03.diff, Work03.diff I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines.

Michelle Baert (JIRA)

6:48 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=co... ] Michelle Baert commented on HBX-737: ------------------------------------ I re-updated my svn checkout. the prepare-dir-up target still does not exist , as I told you in HBX-740

...

Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Attachments: CustomExporter-20060825.zip, CustomExporter-20060825.zip, GenericExporter.java, GenericExporter.zip, GenericExporterTask.java, Patch03.diff, Work03.diff I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines.

Max Rydahl Andersen (JIRA)

6:50 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

...

Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Attachments: CustomExporter-20060825.zip, CustomExporter-20060825.zip, GenericExporter.java, GenericExporter.zip, GenericExporterTask.java, Patch03.diff, Work03.diff I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines.

Michelle Baert (JIRA)

6:50 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=co... ] Michelle Baert commented on HBX-737: ------------------------------------ Don't worry. I can keep my improvements for myself.

...

Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Attachments: CustomExporter-20060825.zip, CustomExporter-20060825.zip, GenericExporter.java, GenericExporter.zip, GenericExporterTask.java, Patch03.diff, Work03.diff I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines.

Michelle Baert (JIRA)

7:04 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=co... ] Michelle Baert commented on HBX-737: ------------------------------------ Maybe there a special layout required. And here's the output: --- E:\Public\OpenSource\Hibernate-3.2>build prepare-dir-up build prepare-dir-up E:\Public\OpenSource\Hibernate-3.2>java -cp "lib/ant-launcher-1.6.5.jar" org.apache.tools.ant.launch.Launcher -lib lib prepare-dir-up Buildfile: build.xml [taskdef] Could not load definitions from resource clovertasks. It could not be found. splash: init: [echo] Build Hibernate-3.2.0.cr3 (2006-08-28 01:53:47) [echo] JDK version: 1.5 init.antlr: antlr: compile: jar: prepare-dir-up: [copy] Copying 1 file to E:\Public\OpenSource\hibernate-3.2 BUILD SUCCESSFUL Total time: 4 seconds --- I suppose I have to dive into the build files to find out what should be done whith this target. But I'll have a break now.

...

Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Attachments: CustomExporter-20060825.zip, CustomExporter-20060825.zip, GenericExporter.java, GenericExporter.zip, GenericExporterTask.java, Patch03.diff, Work03.diff I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines.

Max Rydahl Andersen (JIRA)

7:07 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=co... ] Max Rydahl Andersen commented on HBX-737: ----------------------------------------- yes, and now that target has executed you have a hibernate-3.2 directory and that should be just next to your hibernateext as explained in the "How to build and contribute" section under tools.hibernate.org

...

Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Attachments: CustomExporter-20060825.zip, CustomExporter-20060825.zip, GenericExporter.java, GenericExporter.zip, GenericExporterTask.java, Patch03.diff, Work03.diff I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines.

Michelle Baert (JIRA)

7:09 a.m.

New subject: [Hibernate-JIRA] Commented: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=co... ] Michelle Baert commented on HBX-737: ------------------------------------ I had not received your post label [28/Aug/06 06:40 AM] when I wrote the next one. same thing happened with [28/Aug/06 06:26 AM]

...

Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Attachments: CustomExporter-20060825.zip, CustomExporter-20060825.zip, GenericExporter.java, GenericExporter.zip, GenericExporterTask.java, Patch03.diff, Work03.diff I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines.

Max Rydahl Andersen (JIRA)

2:58 p.m.

New subject: [Hibernate-JIRA] Closed: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-737?page=all ] Max Rydahl Andersen closed HBX-737: ----------------------------------- Fix Version: 3.2beta8 Resolution: Fixed i've fixed this issue by instantiating the exporterclass directly in genericexportertask. filepattern might be moved up to handle that more generically (especially to allow more flexible control, eg. via templates)

...

Components: ant Versions: 3.2beta7 Environment: Hibernate 3.2 cr3, July 7, 2006 Reporter: Michelle Baert Priority: Minor Fix For: 3.2beta8 Attachments: CustomExporter-20060825.zip, CustomExporter-20060825.zip, GenericExporter.java, GenericExporter.zip, GenericExporterTask.java, Patch03.diff, Work03.diff I enclose a minimal project with ant build file, and a patch proposal for GenericExporterTask. There are 2 custom exporter classes: - MyExplorer simply extends GenericExporter with nothing else - My VerboseExplorer is similar but provides log messages. When run with current version of hibernate-tools, it fails because filepattern has been lost. build.xml:66: org.hibernate.tool.hbm2x.ExporterException: File pattern not set on GenericExporter When run after patching and jar rebuild, it runs fines.

6710

days inactive

6713

days old

hibernate-issues@lists.jboss.org

Manage subscription

28 comments

2 participants

tags (0)

participants (2)

Max Rydahl Andersen (JIRA)
Michelle Baert (JIRA)

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

[Hibernate-JIRA] Created: (HBX-737) hbmtemplate tool - GenericExporter omits task attributes when used with exporterClass