[Hibernate-JIRA] Created: (HHH-7073) Audited entities with Many-to-Many relationships fail with NullPointerException
9:28 p.m.
Audited entities with Many-to-Many relationships fail with NullPointerException
-------------------------------------------------------------------------------
Key: HHH-7073
URL: https://hibernate.onjira.com/browse/HHH-7073
Project: Hibernate ORM
Issue Type: Bug
Components: envers
Affects Versions: 4.1.0
Reporter: Clement Pang
The entity contains the following field:
@ManyToMany(cascade = {CascadeType.PERSIST})
@JoinTable(
name = "Apples",
joinColumns = {@JoinColumn(name = "storeId", nullable = false)},
inverseJoinColumns = {@JoinColumn(name = "appleId", nullable = false)}
)
public Set<Apple> apples = new HashSet<Apple>();
An exception is thrown when saving the entity:
java.lang.NullPointerException
at
org.hibernate.envers.entities.EntitiesConfigurations.getToPropertyNames(EntitiesConfigurations.java:155)
at
org.hibernate.envers.event.BaseEnversEventListener.addCollectionChangeWorkUnit(BaseEnversEventListener.java:121)
at
org.hibernate.envers.event.BaseEnversEventListener.generateBidirectionalCollectionChangeWorkUnits(BaseEnversEventListener.java:90)
at
org.hibernate.envers.event.EnversPostInsertEventListenerImpl.onPostInsert(EnversPostInsertEventListenerImpl.java:60)
at
org.hibernate.action.internal.EntityIdentityInsertAction.postInsert(EntityIdentityInsertAction.java:149)
at
org.hibernate.action.internal.EntityIdentityInsertAction.execute(EntityIdentityInsertAction.java:102)
In that particular method:
public Set<String> getToPropertyNames(String fromEntityName, String
fromPropertyName, String toEntityName) {
Set<String> entityAndParentsNames = getEntityAndParentsNames(fromEntityName);
Set<String> toPropertyNames = new HashSet<String>();
for (RelationDescription relationDescription : getRelationDescriptions(toEntityName)) {
String relToEntityName = relationDescription.getToEntityName();
String mappedByPropertyName = relationDescription.getMappedByPropertyName();
if (entityAndParentsNames.contains(relToEntityName) &&
mappedByPropertyName.equals(fromPropertyName)) {
toPropertyNames.add(relationDescription.getFromPropertyName());
}
}
return toPropertyNames;
}
mappedByPropertyName is null since RelationDescription can have null mappedByPropertyName
when invoked at: EntityConfiguration
public void addToManyMiddleRelation(String fromPropertyName, String toEntityName) {
relations.put(fromPropertyName, new RelationDescription(fromPropertyName,
RelationType.TO_MANY_MIDDLE,
toEntityName, null, null, null, null, true));
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:25 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7073) Audited entities with Many-to-Many relationships fail with NullPointerException
[
https://hibernate.onjira.com/browse/HHH-7073?page=com.atlassian.jira.plug...
]
Lukasz Antoniak commented on HHH-7073:
--------------------------------------
Please see my comment at the end of HHH-6661 issue.
Could you please be more specific, and post here the whole mapping of both related
entities? I am unable to reproduce reported exception with the following mapping.
{code:title=Person.java|borderStyle=solid}
@Entity
@Audited
public class Person implements Serializable {
@Id
@GeneratedValue
private Long id;
@ManyToMany(cascade = {CascadeType.PERSIST})
@JoinTable(name = "PERSON_ADDRESS",
joinColumns = {@JoinColumn(name = "personId", nullable =
false)},
inverseJoinColumns = {@JoinColumn(name = "addressId", nullable =
false)})
private Set<Address> addresses = new HashSet<Address>();
...
}
{code}
{code:title=Address.java|borderStyle=solid}
@Entity
@Audited
public class Address implements Serializable {
@Id
@GeneratedValue
private Long id;
@ManyToMany(cascade = {CascadeType.PERSIST})
private Set<Person> tenants = new HashSet<Person>();
...
}
{code}
Regards,
Lukasz Antoniak
Audited entities with Many-to-Many relationships fail with
NullPointerException
-------------------------------------------------------------------------------
Key: HHH-7073
URL: https://hibernate.onjira.com/browse/HHH-7073
Project: Hibernate ORM
Issue Type: Bug
Components: envers
Affects Versions: 4.1.0
Reporter: Clement Pang
The entity contains the following field:
@ManyToMany(cascade = {CascadeType.PERSIST})
@JoinTable(
name = "Apples",
joinColumns = {@JoinColumn(name = "storeId", nullable = false)},
inverseJoinColumns = {@JoinColumn(name = "appleId", nullable = false)}
)
public Set<Apple> apples = new HashSet<Apple>();
An exception is thrown when saving the entity:
java.lang.NullPointerException
at
org.hibernate.envers.entities.EntitiesConfigurations.getToPropertyNames(EntitiesConfigurations.java:155)
at
org.hibernate.envers.event.BaseEnversEventListener.addCollectionChangeWorkUnit(BaseEnversEventListener.java:121)
at
org.hibernate.envers.event.BaseEnversEventListener.generateBidirectionalCollectionChangeWorkUnits(BaseEnversEventListener.java:90)
at
org.hibernate.envers.event.EnversPostInsertEventListenerImpl.onPostInsert(EnversPostInsertEventListenerImpl.java:60)
at
org.hibernate.action.internal.EntityIdentityInsertAction.postInsert(EntityIdentityInsertAction.java:149)
at
org.hibernate.action.internal.EntityIdentityInsertAction.execute(EntityIdentityInsertAction.java:102)
In that particular method:
public Set<String> getToPropertyNames(String fromEntityName, String
fromPropertyName, String toEntityName) {
Set<String> entityAndParentsNames = getEntityAndParentsNames(fromEntityName);
Set<String> toPropertyNames = new HashSet<String>();
for (RelationDescription relationDescription : getRelationDescriptions(toEntityName))
{
String relToEntityName = relationDescription.getToEntityName();
String mappedByPropertyName = relationDescription.getMappedByPropertyName();
if (entityAndParentsNames.contains(relToEntityName) &&
mappedByPropertyName.equals(fromPropertyName)) {
toPropertyNames.add(relationDescription.getFromPropertyName());
}
}
return toPropertyNames;
}
mappedByPropertyName is null since RelationDescription can have null mappedByPropertyName
when invoked at: EntityConfiguration
public void addToManyMiddleRelation(String fromPropertyName, String toEntityName) {
relations.put(fromPropertyName, new RelationDescription(fromPropertyName,
RelationType.TO_MANY_MIDDLE,
toEntityName, null, null, null, null, true));
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:04 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7073) Audited entities with Many-to-Many relationships fail with NullPointerException
[
https://hibernate.onjira.com/browse/HHH-7073?page=com.atlassian.jira.plug...
]
Clement Pang commented on HHH-7073:
-----------------------------------
Thanks for the help. Here are the two entities.
{code:title=Apple.java}
@Entity
@Audited
public class Apple {
@Id
@GeneratedValue
public long id;
@ManyToMany(cascade = {CascadeType.PERSIST})
@JoinTable(
name = "ApplesAndOranges",
joinColumns = {@JoinColumn(name = "appleId", nullable = false)},
inverseJoinColumns = {@JoinColumn(name = "orangeId", nullable = false)}
)
public Set<Orange> oranges = new HashSet<Orange>();
}
{code}
{code:title=Orange.java}
@Entity
@Audited
public class Orange {
@Id
@GeneratedValue
public long id;
@ManyToMany(cascade = {CascadeType.PERSIST})
public Set<Apple> apples = new HashSet<Apple>();
}
{code}
The code fails when calling:
{code}
Orange orange = new Orange();
entityManager.persist(orange);
{code}
We have also tried:
{code:title=Orange.java}
@Entity
@Audited
public class Orange {
@Id
@GeneratedValue
public long id;
@ManyToMany(cascade = {CascadeType.PERSIST})
@NotAudited
public Set<Apple> apples = new HashSet<Apple>();
}
{code}
and:
{code:title=Orange.java}
@Entity
@Audited
public class Orange {
@Id
@GeneratedValue
public long id;
@ManyToMany(mappedBy = "oranges", cascade = {CascadeType.PERSIST})
@NotAudited
public Set<Apple> apples = new HashSet<Apple>();
}
{code}
Again, the issue seems to be the fact that RelationDescription can have null
mappedByPropertyName when the RelationType is TO_MANY_MIDDLE.
Note that the exact same code works in Hibernate 3.0. We are migrating to 4.0 and it
started failing.
Audited entities with Many-to-Many relationships fail with
NullPointerException
-------------------------------------------------------------------------------
Key: HHH-7073
URL: https://hibernate.onjira.com/browse/HHH-7073
Project: Hibernate ORM
Issue Type: Bug
Components: envers
Affects Versions: 4.1.0
Reporter: Clement Pang
The entity contains the following field:
@ManyToMany(cascade = {CascadeType.PERSIST})
@JoinTable(
name = "Apples",
joinColumns = {@JoinColumn(name = "storeId", nullable = false)},
inverseJoinColumns = {@JoinColumn(name = "appleId", nullable = false)}
)
public Set<Apple> apples = new HashSet<Apple>();
An exception is thrown when saving the entity:
java.lang.NullPointerException
at
org.hibernate.envers.entities.EntitiesConfigurations.getToPropertyNames(EntitiesConfigurations.java:155)
at
org.hibernate.envers.event.BaseEnversEventListener.addCollectionChangeWorkUnit(BaseEnversEventListener.java:121)
at
org.hibernate.envers.event.BaseEnversEventListener.generateBidirectionalCollectionChangeWorkUnits(BaseEnversEventListener.java:90)
at
org.hibernate.envers.event.EnversPostInsertEventListenerImpl.onPostInsert(EnversPostInsertEventListenerImpl.java:60)
at
org.hibernate.action.internal.EntityIdentityInsertAction.postInsert(EntityIdentityInsertAction.java:149)
at
org.hibernate.action.internal.EntityIdentityInsertAction.execute(EntityIdentityInsertAction.java:102)
In that particular method:
public Set<String> getToPropertyNames(String fromEntityName, String
fromPropertyName, String toEntityName) {
Set<String> entityAndParentsNames = getEntityAndParentsNames(fromEntityName);
Set<String> toPropertyNames = new HashSet<String>();
for (RelationDescription relationDescription : getRelationDescriptions(toEntityName))
{
String relToEntityName = relationDescription.getToEntityName();
String mappedByPropertyName = relationDescription.getMappedByPropertyName();
if (entityAndParentsNames.contains(relToEntityName) &&
mappedByPropertyName.equals(fromPropertyName)) {
toPropertyNames.add(relationDescription.getFromPropertyName());
}
}
return toPropertyNames;
}
mappedByPropertyName is null since RelationDescription can have null mappedByPropertyName
when invoked at: EntityConfiguration
public void addToManyMiddleRelation(String fromPropertyName, String toEntityName) {
relations.put(fromPropertyName, new RelationDescription(fromPropertyName,
RelationType.TO_MANY_MIDDLE,
toEntityName, null, null, null, null, true));
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:10 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7073) Audited entities with Many-to-Many relationships fail with NullPointerException
[
https://hibernate.onjira.com/browse/HHH-7073?page=com.atlassian.jira.plug...
]
Clement Pang commented on HHH-7073:
-----------------------------------
Also, by the look of it, your commit in HHH-6661 should fix the problem (as least by
looking at the debugger output). Is that in a particular snapshot release that we can
try?
Audited entities with Many-to-Many relationships fail with
NullPointerException
-------------------------------------------------------------------------------
Key: HHH-7073
URL: https://hibernate.onjira.com/browse/HHH-7073
Project: Hibernate ORM
Issue Type: Bug
Components: envers
Affects Versions: 4.1.0
Reporter: Clement Pang
The entity contains the following field:
@ManyToMany(cascade = {CascadeType.PERSIST})
@JoinTable(
name = "Apples",
joinColumns = {@JoinColumn(name = "storeId", nullable = false)},
inverseJoinColumns = {@JoinColumn(name = "appleId", nullable = false)}
)
public Set<Apple> apples = new HashSet<Apple>();
An exception is thrown when saving the entity:
java.lang.NullPointerException
at
org.hibernate.envers.entities.EntitiesConfigurations.getToPropertyNames(EntitiesConfigurations.java:155)
at
org.hibernate.envers.event.BaseEnversEventListener.addCollectionChangeWorkUnit(BaseEnversEventListener.java:121)
at
org.hibernate.envers.event.BaseEnversEventListener.generateBidirectionalCollectionChangeWorkUnits(BaseEnversEventListener.java:90)
at
org.hibernate.envers.event.EnversPostInsertEventListenerImpl.onPostInsert(EnversPostInsertEventListenerImpl.java:60)
at
org.hibernate.action.internal.EntityIdentityInsertAction.postInsert(EntityIdentityInsertAction.java:149)
at
org.hibernate.action.internal.EntityIdentityInsertAction.execute(EntityIdentityInsertAction.java:102)
In that particular method:
public Set<String> getToPropertyNames(String fromEntityName, String
fromPropertyName, String toEntityName) {
Set<String> entityAndParentsNames = getEntityAndParentsNames(fromEntityName);
Set<String> toPropertyNames = new HashSet<String>();
for (RelationDescription relationDescription : getRelationDescriptions(toEntityName))
{
String relToEntityName = relationDescription.getToEntityName();
String mappedByPropertyName = relationDescription.getMappedByPropertyName();
if (entityAndParentsNames.contains(relToEntityName) &&
mappedByPropertyName.equals(fromPropertyName)) {
toPropertyNames.add(relationDescription.getFromPropertyName());
}
}
return toPropertyNames;
}
mappedByPropertyName is null since RelationDescription can have null mappedByPropertyName
when invoked at: EntityConfiguration
public void addToManyMiddleRelation(String fromPropertyName, String toEntityName) {
relations.put(fromPropertyName, new RelationDescription(fromPropertyName,
RelationType.TO_MANY_MIDDLE,
toEntityName, null, null, null, null, true));
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:27 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-7073) Audited entities with Many-to-Many relationships fail with NullPointerException
[
https://hibernate.onjira.com/browse/HHH-7073?page=com.atlassian.jira.plug...
]
Lukasz Antoniak updated HHH-7073:
---------------------------------
Attachment: HHH-7073.ZIP
I don't see any significant difference between your mapping and mine. That's why I
am unable to reproduce this issue.
Please review attached Maven project and develop it, so that JUnit test case fails with
reported exception. I suppose that I will commit my changes from HHH-6661 before 4.1.1
release (07/Mar/12). However, it would be nice for me to reproduce your bug and be sure
that it gets resolved in 4.1.1.
Audited entities with Many-to-Many relationships fail with
NullPointerException
-------------------------------------------------------------------------------
Key: HHH-7073
URL: https://hibernate.onjira.com/browse/HHH-7073
Project: Hibernate ORM
Issue Type: Bug
Components: envers
Affects Versions: 4.1.0
Reporter: Clement Pang
Attachments: HHH-7073.ZIP
The entity contains the following field:
@ManyToMany(cascade = {CascadeType.PERSIST})
@JoinTable(
name = "Apples",
joinColumns = {@JoinColumn(name = "storeId", nullable = false)},
inverseJoinColumns = {@JoinColumn(name = "appleId", nullable = false)}
)
public Set<Apple> apples = new HashSet<Apple>();
An exception is thrown when saving the entity:
java.lang.NullPointerException
at
org.hibernate.envers.entities.EntitiesConfigurations.getToPropertyNames(EntitiesConfigurations.java:155)
at
org.hibernate.envers.event.BaseEnversEventListener.addCollectionChangeWorkUnit(BaseEnversEventListener.java:121)
at
org.hibernate.envers.event.BaseEnversEventListener.generateBidirectionalCollectionChangeWorkUnits(BaseEnversEventListener.java:90)
at
org.hibernate.envers.event.EnversPostInsertEventListenerImpl.onPostInsert(EnversPostInsertEventListenerImpl.java:60)
at
org.hibernate.action.internal.EntityIdentityInsertAction.postInsert(EntityIdentityInsertAction.java:149)
at
org.hibernate.action.internal.EntityIdentityInsertAction.execute(EntityIdentityInsertAction.java:102)
In that particular method:
public Set<String> getToPropertyNames(String fromEntityName, String
fromPropertyName, String toEntityName) {
Set<String> entityAndParentsNames = getEntityAndParentsNames(fromEntityName);
Set<String> toPropertyNames = new HashSet<String>();
for (RelationDescription relationDescription : getRelationDescriptions(toEntityName))
{
String relToEntityName = relationDescription.getToEntityName();
String mappedByPropertyName = relationDescription.getMappedByPropertyName();
if (entityAndParentsNames.contains(relToEntityName) &&
mappedByPropertyName.equals(fromPropertyName)) {
toPropertyNames.add(relationDescription.getFromPropertyName());
}
}
return toPropertyNames;
}
mappedByPropertyName is null since RelationDescription can have null mappedByPropertyName
when invoked at: EntityConfiguration
public void addToManyMiddleRelation(String fromPropertyName, String toEntityName) {
relations.put(fromPropertyName, new RelationDescription(fromPropertyName,
RelationType.TO_MANY_MIDDLE,
toEntityName, null, null, null, null, true));
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:28 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7073) Audited entities with Many-to-Many relationships fail with NullPointerException
[
https://hibernate.onjira.com/browse/HHH-7073?page=com.atlassian.jira.plug...
]
Clement Pang commented on HHH-7073:
-----------------------------------
I checked out your sources and apparently it needs at least a TO_ONE relation for the bug
to manifest, I modified your source code so that the problem would appear:
https://github.com/panghy/envers-HHH-7073
Thanks for the effort!
Audited entities with Many-to-Many relationships fail with
NullPointerException
-------------------------------------------------------------------------------
Key: HHH-7073
URL: https://hibernate.onjira.com/browse/HHH-7073
Project: Hibernate ORM
Issue Type: Bug
Components: envers
Affects Versions: 4.1.0
Reporter: Clement Pang
Attachments: HHH-7073.ZIP
The entity contains the following field:
@ManyToMany(cascade = {CascadeType.PERSIST})
@JoinTable(
name = "Apples",
joinColumns = {@JoinColumn(name = "storeId", nullable = false)},
inverseJoinColumns = {@JoinColumn(name = "appleId", nullable = false)}
)
public Set<Apple> apples = new HashSet<Apple>();
An exception is thrown when saving the entity:
java.lang.NullPointerException
at
org.hibernate.envers.entities.EntitiesConfigurations.getToPropertyNames(EntitiesConfigurations.java:155)
at
org.hibernate.envers.event.BaseEnversEventListener.addCollectionChangeWorkUnit(BaseEnversEventListener.java:121)
at
org.hibernate.envers.event.BaseEnversEventListener.generateBidirectionalCollectionChangeWorkUnits(BaseEnversEventListener.java:90)
at
org.hibernate.envers.event.EnversPostInsertEventListenerImpl.onPostInsert(EnversPostInsertEventListenerImpl.java:60)
at
org.hibernate.action.internal.EntityIdentityInsertAction.postInsert(EntityIdentityInsertAction.java:149)
at
org.hibernate.action.internal.EntityIdentityInsertAction.execute(EntityIdentityInsertAction.java:102)
In that particular method:
public Set<String> getToPropertyNames(String fromEntityName, String
fromPropertyName, String toEntityName) {
Set<String> entityAndParentsNames = getEntityAndParentsNames(fromEntityName);
Set<String> toPropertyNames = new HashSet<String>();
for (RelationDescription relationDescription : getRelationDescriptions(toEntityName))
{
String relToEntityName = relationDescription.getToEntityName();
String mappedByPropertyName = relationDescription.getMappedByPropertyName();
if (entityAndParentsNames.contains(relToEntityName) &&
mappedByPropertyName.equals(fromPropertyName)) {
toPropertyNames.add(relationDescription.getFromPropertyName());
}
}
return toPropertyNames;
}
mappedByPropertyName is null since RelationDescription can have null mappedByPropertyName
when invoked at: EntityConfiguration
public void addToManyMiddleRelation(String fromPropertyName, String toEntityName) {
relations.put(fromPropertyName, new RelationDescription(fromPropertyName,
RelationType.TO_MANY_MIDDLE,
toEntityName, null, null, null, null, true));
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:53 p.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-7073) Audited entities with Many-to-Many relationships fail with NullPointerException
[
https://hibernate.onjira.com/browse/HHH-7073?page=com.atlassian.jira.plug...
]
Lukasz Antoniak resolved HHH-7073.
----------------------------------
Resolution: Fixed
Fix Version/s: 4.1.1
Assignee: Lukasz Antoniak
Thank you for the clear test case. Not null check that was mentioned previously seems to
resolve this issue. I have developed more complex test and committed it with actual fix to
the master branch. If you'd like, you can checkout source code from Hibernate's
Git repository and build your own snapshot instead of waiting till 07/Mar/12 for 4.1.1
release.
Audited entities with Many-to-Many relationships fail with
NullPointerException
-------------------------------------------------------------------------------
Key: HHH-7073
URL: https://hibernate.onjira.com/browse/HHH-7073
Project: Hibernate ORM
Issue Type: Bug
Components: envers
Affects Versions: 4.1.0
Reporter: Clement Pang
Assignee: Lukasz Antoniak
Fix For: 4.1.1
Attachments: HHH-7073.ZIP
The entity contains the following field:
@ManyToMany(cascade = {CascadeType.PERSIST})
@JoinTable(
name = "Apples",
joinColumns = {@JoinColumn(name = "storeId", nullable = false)},
inverseJoinColumns = {@JoinColumn(name = "appleId", nullable = false)}
)
public Set<Apple> apples = new HashSet<Apple>();
An exception is thrown when saving the entity:
java.lang.NullPointerException
at
org.hibernate.envers.entities.EntitiesConfigurations.getToPropertyNames(EntitiesConfigurations.java:155)
at
org.hibernate.envers.event.BaseEnversEventListener.addCollectionChangeWorkUnit(BaseEnversEventListener.java:121)
at
org.hibernate.envers.event.BaseEnversEventListener.generateBidirectionalCollectionChangeWorkUnits(BaseEnversEventListener.java:90)
at
org.hibernate.envers.event.EnversPostInsertEventListenerImpl.onPostInsert(EnversPostInsertEventListenerImpl.java:60)
at
org.hibernate.action.internal.EntityIdentityInsertAction.postInsert(EntityIdentityInsertAction.java:149)
at
org.hibernate.action.internal.EntityIdentityInsertAction.execute(EntityIdentityInsertAction.java:102)
In that particular method:
public Set<String> getToPropertyNames(String fromEntityName, String
fromPropertyName, String toEntityName) {
Set<String> entityAndParentsNames = getEntityAndParentsNames(fromEntityName);
Set<String> toPropertyNames = new HashSet<String>();
for (RelationDescription relationDescription : getRelationDescriptions(toEntityName))
{
String relToEntityName = relationDescription.getToEntityName();
String mappedByPropertyName = relationDescription.getMappedByPropertyName();
if (entityAndParentsNames.contains(relToEntityName) &&
mappedByPropertyName.equals(fromPropertyName)) {
toPropertyNames.add(relationDescription.getFromPropertyName());
}
}
return toPropertyNames;
}
mappedByPropertyName is null since RelationDescription can have null mappedByPropertyName
when invoked at: EntityConfiguration
public void addToManyMiddleRelation(String fromPropertyName, String toEntityName) {
relations.put(fromPropertyName, new RelationDescription(fromPropertyName,
RelationType.TO_MANY_MIDDLE,
toEntityName, null, null, null, null, true));
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:27 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7073) Audited entities with Many-to-Many relationships fail with NullPointerException
[
https://hibernate.onjira.com/browse/HHH-7073?page=com.atlassian.jira.plug...
]
Clement Pang commented on HHH-7073:
-----------------------------------
Thanks a lot!
Audited entities with Many-to-Many relationships fail with
NullPointerException
-------------------------------------------------------------------------------
Key: HHH-7073
URL: https://hibernate.onjira.com/browse/HHH-7073
Project: Hibernate ORM
Issue Type: Bug
Components: envers
Affects Versions: 4.1.0
Reporter: Clement Pang
Assignee: Lukasz Antoniak
Fix For: 4.1.1
Attachments: HHH-7073.ZIP
The entity contains the following field:
@ManyToMany(cascade = {CascadeType.PERSIST})
@JoinTable(
name = "Apples",
joinColumns = {@JoinColumn(name = "storeId", nullable = false)},
inverseJoinColumns = {@JoinColumn(name = "appleId", nullable = false)}
)
public Set<Apple> apples = new HashSet<Apple>();
An exception is thrown when saving the entity:
java.lang.NullPointerException
at
org.hibernate.envers.entities.EntitiesConfigurations.getToPropertyNames(EntitiesConfigurations.java:155)
at
org.hibernate.envers.event.BaseEnversEventListener.addCollectionChangeWorkUnit(BaseEnversEventListener.java:121)
at
org.hibernate.envers.event.BaseEnversEventListener.generateBidirectionalCollectionChangeWorkUnits(BaseEnversEventListener.java:90)
at
org.hibernate.envers.event.EnversPostInsertEventListenerImpl.onPostInsert(EnversPostInsertEventListenerImpl.java:60)
at
org.hibernate.action.internal.EntityIdentityInsertAction.postInsert(EntityIdentityInsertAction.java:149)
at
org.hibernate.action.internal.EntityIdentityInsertAction.execute(EntityIdentityInsertAction.java:102)
In that particular method:
public Set<String> getToPropertyNames(String fromEntityName, String
fromPropertyName, String toEntityName) {
Set<String> entityAndParentsNames = getEntityAndParentsNames(fromEntityName);
Set<String> toPropertyNames = new HashSet<String>();
for (RelationDescription relationDescription : getRelationDescriptions(toEntityName))
{
String relToEntityName = relationDescription.getToEntityName();
String mappedByPropertyName = relationDescription.getMappedByPropertyName();
if (entityAndParentsNames.contains(relToEntityName) &&
mappedByPropertyName.equals(fromPropertyName)) {
toPropertyNames.add(relationDescription.getFromPropertyName());
}
}
return toPropertyNames;
}
mappedByPropertyName is null since RelationDescription can have null mappedByPropertyName
when invoked at: EntityConfiguration
public void addToManyMiddleRelation(String fromPropertyName, String toEntityName) {
relations.put(fromPropertyName, new RelationDescription(fromPropertyName,
RelationType.TO_MANY_MIDDLE,
toEntityName, null, null, null, null, true));
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4686
days inactive
4694
days old
hibernate-issues@lists.jboss.org
7 comments
2 participants
participants (2)
-
Clement Pang (JIRA) -
Lukasz Antoniak (JIRA)