6:35 p.m.
Bugs affecting seam-gen and JBoss Tools
---------------------------------------
Key: HBX-1004
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Assignee: Max Rydahl Andersen
Priority: Critical
The following problems need to be solved for JBoss tools:
* @Id @GeneratedValue attributes should NEVER have @NotNull generated!
* MySQL internally stores columns of type NUMERIC as DECIMAL - we should change
MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport to consider
NUMERIC and DECIMAL is "equal" for the purposes of validation
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:06 p.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1004) Bugs affecting seam-gen and JBoss Tools
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004?page=c...
]
Diego Pires Plentz commented on HBX-1004:
-----------------------------------------
MySQL internally stores columns of type NUMERIC as DECIMAL - we
should change MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport
to consider NUMERIC and DECIMAL is "equal" for the purposes of validation
I already fixed it in HHH-2261
Bugs affecting seam-gen and JBoss Tools
---------------------------------------
Key: HBX-1004
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Assignee: Max Rydahl Andersen
Priority: Critical
The following problems need to be solved for JBoss tools:
* @Id @GeneratedValue attributes should NEVER have @NotNull generated!
* MySQL internally stores columns of type NUMERIC as DECIMAL - we should change
MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport to consider
NUMERIC and DECIMAL is "equal" for the purposes of validation
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:41 p.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1004) Bugs affecting seam-gen and JBoss Tools
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004?page=c...
]
Gavin King commented on HBX-1004:
---------------------------------
OK, thanks, but the other issue is actually more critical.
Bugs affecting seam-gen and JBoss Tools
---------------------------------------
Key: HBX-1004
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Assignee: Max Rydahl Andersen
Priority: Critical
The following problems need to be solved for JBoss tools:
* @Id @GeneratedValue attributes should NEVER have @NotNull generated!
* MySQL internally stores columns of type NUMERIC as DECIMAL - we should change
MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport to consider
NUMERIC and DECIMAL is "equal" for the purposes of validation
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:54 p.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1004) Bugs affecting seam-gen and JBoss Tools
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004?page=c...
]
Max Rydahl Andersen commented on HBX-1004:
------------------------------------------
what does it prevent ? Is it just stylistic ?
I'm just asking since emmanuel was the one that did the initial annotation
generation.
The other fix requires a release of hibernate to get fixed.
Bugs affecting seam-gen and JBoss Tools
---------------------------------------
Key: HBX-1004
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Assignee: Max Rydahl Andersen
Priority: Critical
The following problems need to be solved for JBoss tools:
* @Id @GeneratedValue attributes should NEVER have @NotNull generated!
* MySQL internally stores columns of type NUMERIC as DECIMAL - we should change
MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport to consider
NUMERIC and DECIMAL is "equal" for the purposes of validation
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:56 p.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1004) Bugs affecting seam-gen and JBoss Tools
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004?page=c...
]
Gavin King commented on HBX-1004:
---------------------------------
It prevents you from being able to call persist() on your object. ie. it is totally
broken
Bugs affecting seam-gen and JBoss Tools
---------------------------------------
Key: HBX-1004
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Assignee: Max Rydahl Andersen
Priority: Critical
The following problems need to be solved for JBoss tools:
* @Id @GeneratedValue attributes should NEVER have @NotNull generated!
* MySQL internally stores columns of type NUMERIC as DECIMAL - we should change
MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport to consider
NUMERIC and DECIMAL is "equal" for the purposes of validation
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:19 p.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1004) Bugs affecting seam-gen and JBoss Tools
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004?page=c...
]
Max Rydahl Andersen commented on HBX-1004:
------------------------------------------
okeey - I wonder how that could have survived for over a year ;(
hmm.. @NotNull is a validator annotation correct ? then this is actually an issue in
seamgen since it is in seamgen the validator annotations gets inserted.
Bugs affecting seam-gen and JBoss Tools
---------------------------------------
Key: HBX-1004
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Assignee: Max Rydahl Andersen
Priority: Critical
The following problems need to be solved for JBoss tools:
* @Id @GeneratedValue attributes should NEVER have @NotNull generated!
* MySQL internally stores columns of type NUMERIC as DECIMAL - we should change
MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport to consider
NUMERIC and DECIMAL is "equal" for the purposes of validation
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:27 p.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1004) Bugs affecting seam-gen and JBoss Tools
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004?page=c...
]
Max Rydahl Andersen commented on HBX-1004:
------------------------------------------
here is quick fix (out of memory) could you try and replace
seam-gen/pojo/GetPropertyAnnotation.ftl with this one:
<#include "Ejb3PropertyGetAnnotation.ftl"/>
<#if !property.optional && !pojo.identifierProperty.equals(property)>
@${pojo.importType("org.hibernate.validator.NotNull")}
</#if>
<#if property.columnSpan==1>
<#assign column = property.getColumnIterator().next()/>
<#if !c2h.isManyToOne(property) && !c2h.isTemporalValue(property) &&
column.length!=255>
@${pojo.importType("org.hibernate.validator.Length")}(max=${column.length?c})
</#if>
</#if>
Let me know how that works out.
Bugs affecting seam-gen and JBoss Tools
---------------------------------------
Key: HBX-1004
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Assignee: Max Rydahl Andersen
Priority: Critical
The following problems need to be solved for JBoss tools:
* @Id @GeneratedValue attributes should NEVER have @NotNull generated!
* MySQL internally stores columns of type NUMERIC as DECIMAL - we should change
MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport to consider
NUMERIC and DECIMAL is "equal" for the purposes of validation
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:43 p.m.
New subject: [Hibernate-JIRA] Closed: (HBX-1004) Bugs affecting seam-gen and JBoss Tools
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004?page=c...
]
Gavin King closed HBX-1004.
---------------------------
Resolution: Rejected
Yep, looks like that fixed it, did not know it was in Seam.
Bugs affecting seam-gen and JBoss Tools
---------------------------------------
Key: HBX-1004
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Assignee: Max Rydahl Andersen
Priority: Critical
The following problems need to be solved for JBoss tools:
* @Id @GeneratedValue attributes should NEVER have @NotNull generated!
* MySQL internally stores columns of type NUMERIC as DECIMAL - we should change
MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport to consider
NUMERIC and DECIMAL is "equal" for the purposes of validation
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:49 p.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1004) Bugs affecting seam-gen and JBoss Tools
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004?page=c...
]
Viorel Andronic commented on HBX-1004:
--------------------------------------
Hello,
At a first glance it seems to work ... but it doesn't in all cases ... I believe that
is something with composite keys
This is the stack trace i get when runing a seam CRUD generation with this
GetPropertyAnnotation.ftl
2007-10-26 15:37:45,390 ERROR ModalContext freemarker.runtime -
Expression pojo.identifierProperty is undefined on line 2, column 29 in
pojo/GetPropertyAnnotation.ftl.
The problematic instruction:
----------
==> if !property.optional && !pojo.identifierProperty.equals(property) [on line
2, column 1 in pojo/GetPropertyAnnotation.ftl]
in include "GetPropertyAnnotation.ftl" [on line 9, column 5 in
pojo/PojoPropertyAccessors.ftl]
in include "PojoPropertyAccessors.ftl" [on line 12, column 1 in pojo/Pojo.ftl]
----------
Java backtrace for programmers:
----------
freemarker.core.InvalidReferenceException: Expression pojo.identifierProperty is undefined
on line 2, column 29 in pojo/GetPropertyAnnotation.ftl.
at freemarker.core.TemplateObject.assertNonNull(TemplateObject.java:124)
at freemarker.core.TemplateObject.invalidTypeException(TemplateObject.java:134)
at freemarker.core.Dot._getAsTemplateModel(Dot.java:78)
at freemarker.core.Expression.getAsTemplateModel(Expression.java:89)
at freemarker.core.MethodCall._getAsTemplateModel(MethodCall.java:86)
at freemarker.core.Expression.getAsTemplateModel(Expression.java:89)
at freemarker.core.Expression.isTrue(Expression.java:138)
at freemarker.core.NotExpression.isTrue(NotExpression.java:66)
at freemarker.core.AndExpression.isTrue(AndExpression.java:68)
at freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:77)
at freemarker.core.Environment.visit(Environment.java:196)
at freemarker.core.MixedContent.accept(MixedContent.java:92)
at freemarker.core.Environment.visit(Environment.java:196)
at freemarker.core.Environment.include(Environment.java:1375)
at freemarker.core.Include.accept(Include.java:155)
at freemarker.core.Environment.visit(Environment.java:196)
at freemarker.core.MixedContent.accept(MixedContent.java:92)
at freemarker.core.Environment.visit(Environment.java:196)
at freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:79)
at freemarker.core.Environment.visit(Environment.java:196)
at freemarker.core.IteratorBlock$Context.runLoop(IteratorBlock.java:160)
at freemarker.core.Environment.visit(Environment.java:351)
at freemarker.core.IteratorBlock.accept(IteratorBlock.java:95)
at freemarker.core.Environment.visit(Environment.java:196)
at freemarker.core.MixedContent.accept(MixedContent.java:92)
at freemarker.core.Environment.visit(Environment.java:196)
at freemarker.core.Environment.include(Environment.java:1375)
at freemarker.core.Include.accept(Include.java:155)
at freemarker.core.Environment.visit(Environment.java:196)
at freemarker.core.MixedContent.accept(MixedContent.java:92)
at freemarker.core.Environment.visit(Environment.java:196)
at freemarker.core.IfBlock.accept(IfBlock.java:82)
at freemarker.core.Environment.visit(Environment.java:196)
at freemarker.core.MixedContent.accept(MixedContent.java:92)
at freemarker.core.Environment.visit(Environment.java:196)
at freemarker.core.Environment.visit(Environment.java:233)
at freemarker.core.BlockAssignment.accept(BlockAssignment.java:83)
at freemarker.core.Environment.visit(Environment.java:196)
at freemarker.core.MixedContent.accept(MixedContent.java:92)
at freemarker.core.Environment.visit(Environment.java:196)
at freemarker.core.Environment.process(Environment.java:176)
at freemarker.template.Template.process(Template.java:232)
at org.hibernate.tool.hbm2x.TemplateHelper.processTemplate(TemplateHelper.java:251)
at org.hibernate.tool.hbm2x.TemplateProducer.produceToString(TemplateProducer.java:67)
at org.hibernate.tool.hbm2x.TemplateProducer.produce(TemplateProducer.java:28)
at org.hibernate.tool.hbm2x.TemplateProducer.produce(TemplateProducer.java:97)
at org.hibernate.tool.hbm2x.GenericExporter.exportPOJO(GenericExporter.java:146)
at org.hibernate.tool.hbm2x.GenericExporter.exportComponent(GenericExporter.java:131)
at org.hibernate.tool.hbm2x.GenericExporter$3.process(GenericExporter.java:61)
at org.hibernate.tool.hbm2x.GenericExporter.doStart(GenericExporter.java:126)
at org.hibernate.tool.hbm2x.AbstractExporter.start(AbstractExporter.java:95)
at
org.hibernate.eclipse.launch.CodeGenerationLaunchDelegate$1.execute(CodeGenerationLaunchDelegate.java:245)
at
org.hibernate.console.execution.DefaultExecutionContext.execute(DefaultExecutionContext.java:65)
at org.hibernate.console.ConsoleConfiguration.execute(ConsoleConfiguration.java:88)
at
org.hibernate.eclipse.launch.CodeGenerationLaunchDelegate.runExporters(CodeGenerationLaunchDelegate.java:215)
at
org.hibernate.eclipse.launch.CodeGenerationLaunchDelegate.launch(CodeGenerationLaunchDelegate.java:130)
at
org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:766)
at
org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:608)
at org.eclipse.debug.internal.ui.DebugUIPlugin.buildAndLaunch(DebugUIPlugin.java:899)
at org.eclipse.debug.internal.ui.DebugUIPlugin$6.run(DebugUIPlugin.java:985)
at
org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:113)
Actually, I'm sure it has something to do with composite ids, as when excluding that
table i don't get the exception any more
This is the table that generates the trouble
CREATE TABLE smp.good
(
product_id integer NOT NULL,
document_id integer NOT NULL,
price numeric(9,2), -- the price of the product in this document
quantity numeric(7,2), -- the quantity of the product in this document
discount numeric(5,2), -- special discount percentage for the product in this document
unit character varying(20), -- the measurement unit for the current quantity
observations text, -- special observations for the product in this document
CONSTRAINT good_pkey PRIMARY KEY (product_id, document_id),
CONSTRAINT good_document_id_fkey FOREIGN KEY (document_id)
REFERENCES smp.document (id) MATCH SIMPLE
ON UPDATE CASCADE ON DELETE RESTRICT,
CONSTRAINT good_product_id_fkey FOREIGN KEY (product_id)
REFERENCES smp.product (id) MATCH SIMPLE
ON UPDATE CASCADE ON DELETE RESTRICT
)
WITH (OIDS=TRUE);
ALTER TABLE smp.good OWNER TO root;
Bugs affecting seam-gen and JBoss Tools
---------------------------------------
Key: HBX-1004
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Assignee: Max Rydahl Andersen
Priority: Critical
The following problems need to be solved for JBoss tools:
* @Id @GeneratedValue attributes should NEVER have @NotNull generated!
* MySQL internally stores columns of type NUMERIC as DECIMAL - we should change
MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport to consider
NUMERIC and DECIMAL is "equal" for the purposes of validation
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:59 p.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1004) Bugs affecting seam-gen and JBoss Tools
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004?page=c...
]
Viorel Andronic commented on HBX-1004:
--------------------------------------
If you manage to get the @NotNull annotation out of the ID property, shouldn't you
remove the nullable="false" attribute from the @Column annotation ?
I did some researching and I found out that the nullable attribute is generated by
hibernate-tools.jar. Is there any posibility to remove/overwrite it from
pojo/GetPropertyAnnotation.ftl file ?
Bugs affecting seam-gen and JBoss Tools
---------------------------------------
Key: HBX-1004
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Assignee: Max Rydahl Andersen
Priority: Critical
The following problems need to be solved for JBoss tools:
* @Id @GeneratedValue attributes should NEVER have @NotNull generated!
* MySQL internally stores columns of type NUMERIC as DECIMAL - we should change
MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport to consider
NUMERIC and DECIMAL is "equal" for the purposes of validation
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:01 p.m.
New subject: [Hibernate-JIRA] Reopened: (HBX-1004) Bugs affecting seam-gen and JBoss Tools
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004?page=c...
]
Max Rydahl Andersen reopened HBX-1004:
--------------------------------------
could you try with this change:
<#include "Ejb3PropertyGetAnnotation.ftl"/>
<#if !property.optional && !property.equals(pojo.identifierProperty)>
@${pojo.importType("org.hibernate.validator.NotNull")}
</#if>
<#if property.columnSpan==1>
<#assign column = property.getColumnIterator().next()/>
<#if !c2h.isManyToOne(property) && !c2h.isTemporalValue(property) &&
column.length!=255>
@${pojo.importType("org.hibernate.validator.Length")}(max=${column.length?c})
</#if>
</#if>
Bugs affecting seam-gen and JBoss Tools
---------------------------------------
Key: HBX-1004
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Assignee: Max Rydahl Andersen
Priority: Critical
The following problems need to be solved for JBoss tools:
* @Id @GeneratedValue attributes should NEVER have @NotNull generated!
* MySQL internally stores columns of type NUMERIC as DECIMAL - we should change
MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport to consider
NUMERIC and DECIMAL is "equal" for the purposes of validation
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:06 p.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1004) Bugs affecting seam-gen and JBoss Tools
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004?page=c...
]
Max Rydahl Andersen commented on HBX-1004:
------------------------------------------
well the column cannot be null in this case so it is just redundant - not wrong ;) but yes
this is something that should be fixed in the annotation generation parts of hibernate
tools - report that in a seperate issue.
Bugs affecting seam-gen and JBoss Tools
---------------------------------------
Key: HBX-1004
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Assignee: Max Rydahl Andersen
Priority: Critical
The following problems need to be solved for JBoss tools:
* @Id @GeneratedValue attributes should NEVER have @NotNull generated!
* MySQL internally stores columns of type NUMERIC as DECIMAL - we should change
MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport to consider
NUMERIC and DECIMAL is "equal" for the purposes of validation
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:36 p.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1004) Bugs affecting seam-gen and JBoss Tools
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004?page=c...
]
Viorel Andronic commented on HBX-1004:
--------------------------------------
Thanks, that works ... I will do a separate issue with that annotation generation ... and
another one regarding the length attribute in a temporal type ... the condition
!c2h.isTemporalValue(property) deosn't seem to work ... and, yet, another one:
when I have @Id annotation on a @Temporal(TemporalType.DATE) annotated property, the
validator says that he is expecting a timestamp column in the database!
Bugs affecting seam-gen and JBoss Tools
---------------------------------------
Key: HBX-1004
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Assignee: Max Rydahl Andersen
Priority: Critical
The following problems need to be solved for JBoss tools:
* @Id @GeneratedValue attributes should NEVER have @NotNull generated!
* MySQL internally stores columns of type NUMERIC as DECIMAL - we should change
MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport to consider
NUMERIC and DECIMAL is "equal" for the purposes of validation
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:40 p.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1004) Bugs affecting seam-gen and JBoss Tools
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004?page=c...
]
Max Rydahl Andersen commented on HBX-1004:
------------------------------------------
note: afaik the rest of seamgen does not handle composite keys ....if they do please let
me know ;)
Bugs affecting seam-gen and JBoss Tools
---------------------------------------
Key: HBX-1004
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Assignee: Max Rydahl Andersen
Priority: Critical
The following problems need to be solved for JBoss tools:
* @Id @GeneratedValue attributes should NEVER have @NotNull generated!
* MySQL internally stores columns of type NUMERIC as DECIMAL - we should change
MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport to consider
NUMERIC and DECIMAL is "equal" for the purposes of validation
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:21 p.m.
New subject: [Hibernate-JIRA] Closed: (HBX-1004) Bugs affecting seam-gen and JBoss Tools
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004?page=c...
]
Gavin King closed HBX-1004.
---------------------------
Resolution: Fixed
Guys, check the code in CR3. Norman already found that bug and I told him the fix.
And seam-gen *does* handle composite keys!
Bugs affecting seam-gen and JBoss Tools
---------------------------------------
Key: HBX-1004
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Assignee: Max Rydahl Andersen
Priority: Critical
The following problems need to be solved for JBoss tools:
* @Id @GeneratedValue attributes should NEVER have @NotNull generated!
* MySQL internally stores columns of type NUMERIC as DECIMAL - we should change
MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport to consider
NUMERIC and DECIMAL is "equal" for the purposes of validation
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:24 p.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1004) Bugs affecting seam-gen and JBoss Tools
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004?page=c...
]
Gavin King commented on HBX-1004:
---------------------------------
P.S. NEVER use dates in primary keys. This is not even supported by JPA, AFAIR, and is
simply very bad practice.
Bugs affecting seam-gen and JBoss Tools
---------------------------------------
Key: HBX-1004
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Assignee: Max Rydahl Andersen
Priority: Critical
The following problems need to be solved for JBoss tools:
* @Id @GeneratedValue attributes should NEVER have @NotNull generated!
* MySQL internally stores columns of type NUMERIC as DECIMAL - we should change
MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport to consider
NUMERIC and DECIMAL is "equal" for the purposes of validation
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:39 p.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1004) Bugs affecting seam-gen and JBoss Tools
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004?page=c...
]
Diego Pires Plentz commented on HBX-1004:
-----------------------------------------
P.P.S: Specially in case of Ingres "database", where you have 3
"states" for date collumns. A date, null and '' (and '' = null
returns false) ;-)
Bugs affecting seam-gen and JBoss Tools
---------------------------------------
Key: HBX-1004
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Assignee: Max Rydahl Andersen
Priority: Critical
The following problems need to be solved for JBoss tools:
* @Id @GeneratedValue attributes should NEVER have @NotNull generated!
* MySQL internally stores columns of type NUMERIC as DECIMAL - we should change
MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport to consider
NUMERIC and DECIMAL is "equal" for the purposes of validation
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:50 p.m.
New subject: [Hibernate-JIRA] Commented: (HBX-1004) Bugs affecting seam-gen and JBoss Tools
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004?page=c...
]
Gavin King commented on HBX-1004:
---------------------------------
Actually the completely correct code is here:
http://fisheye.jboss.com/browse/JBoss/jboss-seam/seam-gen/pojo/GetPropert...
which is not what Max just committed on the EAP branch. Please update the EAP branch
again.
Bugs affecting seam-gen and JBoss Tools
---------------------------------------
Key: HBX-1004
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Assignee: Max Rydahl Andersen
Priority: Critical
The following problems need to be solved for JBoss tools:
* @Id @GeneratedValue attributes should NEVER have @NotNull generated!
* MySQL internally stores columns of type NUMERIC as DECIMAL - we should change
MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport to consider
NUMERIC and DECIMAL is "equal" for the purposes of validation
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:12 p.m.
New subject: [Hibernate-JIRA] Reopened: (HBX-1004) Bugs affecting seam-gen and JBoss Tools
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004?page=c...
]
Max Rydahl Andersen reopened HBX-1004:
--------------------------------------
grr - that file was updatedafter I did the fix ...I'll get it updated in eap and
rhds...
Bugs affecting seam-gen and JBoss Tools
---------------------------------------
Key: HBX-1004
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Reporter: Gavin King
Assignee: Max Rydahl Andersen
Priority: Critical
The following problems need to be solved for JBoss tools:
* @Id @GeneratedValue attributes should NEVER have @NotNull generated!
* MySQL internally stores columns of type NUMERIC as DECIMAL - we should change
MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport to consider
NUMERIC and DECIMAL is "equal" for the purposes of validation
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:59 a.m.
New subject: [Hibernate-JIRA] Updated: (HBX-1004) Bugs affecting seam-gen and JBoss Tools
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004?page=c...
]
Max Rydahl Andersen updated HBX-1004:
-------------------------------------
Affects Version/s: 3.2.beta11
Bugs affecting seam-gen and JBoss Tools
---------------------------------------
Key: HBX-1004
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Affects Versions: 3.2.beta11
Reporter: Gavin King
Assignee: Max Rydahl Andersen
Priority: Critical
The following problems need to be solved for JBoss tools:
* @Id @GeneratedValue attributes should NEVER have @NotNull generated!
* MySQL internally stores columns of type NUMERIC as DECIMAL - we should change
MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport to consider
NUMERIC and DECIMAL is "equal" for the purposes of validation
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:42 p.m.
New subject: [Hibernate-JIRA] Closed: (HBX-1004) Bugs affecting seam-gen and JBoss Tools
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004?page=c...
]
Max Rydahl Andersen closed HBX-1004.
------------------------------------
Resolution: Fixed
Fix Version/s: 3.2.beta12
ok - this is now done in EAP seam too.
Bugs affecting seam-gen and JBoss Tools
---------------------------------------
Key: HBX-1004
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1004
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Affects Versions: 3.2.beta11
Reporter: Gavin King
Assignee: Max Rydahl Andersen
Priority: Critical
Fix For: 3.2.beta12
The following problems need to be solved for JBoss tools:
* @Id @GeneratedValue attributes should NEVER have @NotNull generated!
* MySQL internally stores columns of type NUMERIC as DECIMAL - we should change
MySQLDialect to generate DECIMAL in the DDL, or we should hack SchemaExport to consider
NUMERIC and DECIMAL is "equal" for the purposes of validation
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6085
days inactive
6092
days old
hibernate-issues@lists.jboss.org
20 comments
4 participants
participants (4)
-
Diego Pires Plentz (JIRA) -
Gavin King (JIRA)
-
Max Rydahl Andersen (JIRA)
-
Viorel Andronic (JIRA)