[Hibernate-JIRA] Created: (HHH-5288) Envers auditReader.find() returns wrong data for embedded components using fields with default values
9:13 a.m.
Envers auditReader.find() returns wrong data for embedded components using fields with
default values
-----------------------------------------------------------------------------------------------------
Key: HHH-5288
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5288
Project: Hibernate Core
Issue Type: Bug
Components: envers
Affects Versions: 3.5.2, 3.5.1, 3.5.0-Final
Reporter: Erik-Berndt Scheper
I have found that using auditReader.find() to retrieve audit information for entities
containing embedded components with default values. This is a regression issue (also
occurs in 1.2.2.GA release of Envers - Hibernate 3.3 compatible, but did not occur not in
1.2.1 GA) that started occurring since HHH-3957.
Sample entity and embeddable:
{code:title=DefaultValueComponentTestEntity.java|borderStyle=solid}
@Id
@GeneratedValue
private Integer id;
@Embedded
@Audited
@AttributeOverrides( { @AttributeOverride(name = "comp2.str1", column =
@Column(name = "COMP2_STR1")) })
private DefaultValueComponent1 comp1 = null;
{code}
{code:title=DefaultValueComponent1.java|borderStyle=solid}
private String str1;
@Embedded
private DefaultValueComponent2 comp2 = new DefaultValueComponent2();
{code}
{code:title=DefaultValueComponent2.java|borderStyle=solid}
private String str1 = "defaultValue";
private String str2;
{code}
When I try to persist an instance of DefaultValueComponentTestEntity, with comp1 = null
and subsequently call auditReader.find(), an instance is returned where:
{noformat} "defaultValue".equals(comp1.comp2.str1){noformat}
(using java bean notation for simplicity).
I will attach a complete testcase.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:52 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-5288) Envers auditReader.find() returns wrong data for embedded components using fields with default values
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5288?page=c...
]
Erik-Berndt Scheper updated HHH-5288:
-------------------------------------
Attachment: Envers--HHH-5288-testcase.patch
Patch file with complete testcase for this issue
Envers auditReader.find() returns wrong data for embedded components
using fields with default values
-----------------------------------------------------------------------------------------------------
Key: HHH-5288
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5288
Project: Hibernate Core
Issue Type: Bug
Components: envers
Affects Versions: 3.5.0-Final, 3.5.1, 3.5.2
Reporter: Erik-Berndt Scheper
Attachments: Envers--HHH-5288-testcase.patch
I have found that using auditReader.find() to retrieve audit information for entities
containing embedded components with default values. This is a regression issue (also
occurs in 1.2.2.GA release of Envers - Hibernate 3.3 compatible, but did not occur not in
1.2.1 GA) that started occurring since HHH-3957.
Sample entity and embeddable:
{code:title=DefaultValueComponentTestEntity.java|borderStyle=solid}
@Id
@GeneratedValue
private Integer id;
@Embedded
@Audited
@AttributeOverrides( { @AttributeOverride(name = "comp2.str1", column =
@Column(name = "COMP2_STR1")) })
private DefaultValueComponent1 comp1 = null;
{code}
{code:title=DefaultValueComponent1.java|borderStyle=solid}
private String str1;
@Embedded
private DefaultValueComponent2 comp2 = new DefaultValueComponent2();
{code}
{code:title=DefaultValueComponent2.java|borderStyle=solid}
private String str1 = "defaultValue";
private String str2;
{code}
When I try to persist an instance of DefaultValueComponentTestEntity, with comp1 = null
and subsequently call auditReader.find(), an instance is returned where:
{noformat} "defaultValue".equals(comp1.comp2.str1){noformat}
(using java bean notation for simplicity).
I will attach a complete testcase.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:04 a.m.
New subject: [Hibernate-JIRA] Assigned: (HHH-5288) Envers auditReader.find() returns wrong data for embedded components using fields with default values
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5288?page=c...
]
Gail Badner reassigned HHH-5288:
--------------------------------
Assignee: Adam Warski
Envers auditReader.find() returns wrong data for embedded components
using fields with default values
-----------------------------------------------------------------------------------------------------
Key: HHH-5288
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5288
Project: Hibernate Core
Issue Type: Bug
Components: envers
Affects Versions: 3.5.0-Final, 3.5.1, 3.5.2
Reporter: Erik-Berndt Scheper
Assignee: Adam Warski
Attachments: Envers--HHH-5288-testcase.patch
I have found that using auditReader.find() to retrieve audit information for entities
containing embedded components with default values. This is a regression issue (also
occurs in 1.2.2.GA release of Envers - Hibernate 3.3 compatible, but did not occur not in
1.2.1 GA) that started occurring since HHH-3957.
Sample entity and embeddable:
{code:title=DefaultValueComponentTestEntity.java|borderStyle=solid}
@Id
@GeneratedValue
private Integer id;
@Embedded
@Audited
@AttributeOverrides( { @AttributeOverride(name = "comp2.str1", column =
@Column(name = "COMP2_STR1")) })
private DefaultValueComponent1 comp1 = null;
{code}
{code:title=DefaultValueComponent1.java|borderStyle=solid}
private String str1;
@Embedded
private DefaultValueComponent2 comp2 = new DefaultValueComponent2();
{code}
{code:title=DefaultValueComponent2.java|borderStyle=solid}
private String str1 = "defaultValue";
private String str2;
{code}
When I try to persist an instance of DefaultValueComponentTestEntity, with comp1 = null
and subsequently call auditReader.find(), an instance is returned where:
{noformat} "defaultValue".equals(comp1.comp2.str1){noformat}
(using java bean notation for simplicity).
I will attach a complete testcase.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:03 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-5288) Envers auditReader.find() returns wrong data for embedded components using fields with default values
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5288?page=c...
]
Erik-Berndt Scheper updated HHH-5288:
-------------------------------------
Attachment: HHH-5288-testcase-and-fix.patch
Updated patch file containing testcases and fix
Envers auditReader.find() returns wrong data for embedded components
using fields with default values
-----------------------------------------------------------------------------------------------------
Key: HHH-5288
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5288
Project: Hibernate Core
Issue Type: Bug
Components: envers
Affects Versions: 3.5.0-Final, 3.5.1, 3.5.2
Reporter: Erik-Berndt Scheper
Assignee: Adam Warski
Attachments: Envers--HHH-5288-testcase.patch, HHH-5288-testcase-and-fix.patch
I have found that using auditReader.find() to retrieve audit information for entities
containing embedded components with default values. This is a regression issue (also
occurs in 1.2.2.GA release of Envers - Hibernate 3.3 compatible, but did not occur not in
1.2.1 GA) that started occurring since HHH-3957.
Sample entity and embeddable:
{code:title=DefaultValueComponentTestEntity.java|borderStyle=solid}
@Id
@GeneratedValue
private Integer id;
@Embedded
@Audited
@AttributeOverrides( { @AttributeOverride(name = "comp2.str1", column =
@Column(name = "COMP2_STR1")) })
private DefaultValueComponent1 comp1 = null;
{code}
{code:title=DefaultValueComponent1.java|borderStyle=solid}
private String str1;
@Embedded
private DefaultValueComponent2 comp2 = new DefaultValueComponent2();
{code}
{code:title=DefaultValueComponent2.java|borderStyle=solid}
private String str1 = "defaultValue";
private String str2;
{code}
When I try to persist an instance of DefaultValueComponentTestEntity, with comp1 = null
and subsequently call auditReader.find(), an instance is returned where:
{noformat} "defaultValue".equals(comp1.comp2.str1){noformat}
(using java bean notation for simplicity).
I will attach a complete testcase.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:12 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5288) Envers auditReader.find() returns wrong data for embedded components using fields with default values
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5288?page=c...
]
Erik-Berndt Scheper commented on HHH-5288:
------------------------------------------
There's a simple fix for this issue:
org.hibernate.envers.entities.mapper.ComponentPropertyMapper.java
{noformat}
public void mapToEntityFromMap(AuditConfiguration verCfg, Object obj, Map data, Object
primaryKey, AuditReaderImplementor versionsReader, Number revision) {
if (data == null || obj == null) {
return;
}
Setter setter = ReflectionTools.getSetter(obj.getClass(), propertyData);
// If all properties are null and single, then the component has to be null also.
boolean allNullAndSingle = true;
for (Map.Entry<PropertyData, PropertyMapper> property :
delegate.getProperties().entrySet()) {
if (data.get(property.getKey().getName()) != null || !(property.getValue() instanceof
SinglePropertyMapper)) {
allNullAndSingle = false;
break;
}
}
// And we don't have to set anything on the object - the default value is null
if (!allNullAndSingle) {
// set the component
try {
Object subObj = ReflectHelper.getDefaultConstructor(
Thread.currentThread().getContextClassLoader().loadClass(componentClassName)).newInstance();
setter.set(obj, subObj, null);
delegate.mapToEntityFromMap(verCfg, subObj, data, primaryKey, versionsReader,
revision);
} catch (Exception e) {
throw new AuditException(e);
}
}
}
{noformat}
should be changed to:
{noformat}
public void mapToEntityFromMap(AuditConfiguration verCfg, Object obj, Map data, Object
primaryKey, AuditReaderImplementor versionsReader, Number revision) {
if (data == null || obj == null) {
return;
}
Setter setter = ReflectionTools.getSetter(obj.getClass(), propertyData);
// If all properties are null and single, then the component has to be null also.
boolean allNullAndSingle = true;
for (Map.Entry<PropertyData, PropertyMapper> property :
delegate.getProperties().entrySet()) {
if (data.get(property.getKey().getName()) != null || !(property.getValue() instanceof
SinglePropertyMapper)) {
allNullAndSingle = false;
break;
}
}
if (allNullAndSingle) {
// single property, but default value need not be null, so we'll set it to null
anyway
setter.set(obj, null, null);
} else {
// set the component
try {
Object subObj = ReflectHelper.getDefaultConstructor(
Thread.currentThread().getContextClassLoader().loadClass(componentClassName)).newInstance();
setter.set(obj, subObj, null);
delegate.mapToEntityFromMap(verCfg, subObj, data, primaryKey, versionsReader,
revision);
} catch (Exception e) {
throw new AuditException(e);
}
}
}
{noformat}
Envers auditReader.find() returns wrong data for embedded components
using fields with default values
-----------------------------------------------------------------------------------------------------
Key: HHH-5288
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5288
Project: Hibernate Core
Issue Type: Bug
Components: envers
Affects Versions: 3.5.0-Final, 3.5.1, 3.5.2
Reporter: Erik-Berndt Scheper
Assignee: Adam Warski
Attachments: Envers--HHH-5288-testcase.patch, HHH-5288-testcase-and-fix.patch
I have found that using auditReader.find() to retrieve audit information for entities
containing embedded components with default values. This is a regression issue (also
occurs in 1.2.2.GA release of Envers - Hibernate 3.3 compatible, but did not occur not in
1.2.1 GA) that started occurring since HHH-3957.
Sample entity and embeddable:
{code:title=DefaultValueComponentTestEntity.java|borderStyle=solid}
@Id
@GeneratedValue
private Integer id;
@Embedded
@Audited
@AttributeOverrides( { @AttributeOverride(name = "comp2.str1", column =
@Column(name = "COMP2_STR1")) })
private DefaultValueComponent1 comp1 = null;
{code}
{code:title=DefaultValueComponent1.java|borderStyle=solid}
private String str1;
@Embedded
private DefaultValueComponent2 comp2 = new DefaultValueComponent2();
{code}
{code:title=DefaultValueComponent2.java|borderStyle=solid}
private String str1 = "defaultValue";
private String str2;
{code}
When I try to persist an instance of DefaultValueComponentTestEntity, with comp1 = null
and subsequently call auditReader.find(), an instance is returned where:
{noformat} "defaultValue".equals(comp1.comp2.str1){noformat}
(using java bean notation for simplicity).
I will attach a complete testcase.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:22 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5288) Envers auditReader.find() returns wrong data for embedded components using fields with default values
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5288?page=c...
]
Erik-Berndt Scheper commented on HHH-5288:
------------------------------------------
This bug affects both 3.5.x and current trunk (3.6.0 snapshot).
Envers auditReader.find() returns wrong data for embedded components
using fields with default values
-----------------------------------------------------------------------------------------------------
Key: HHH-5288
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5288
Project: Hibernate Core
Issue Type: Bug
Components: envers
Affects Versions: 3.5.0-Final, 3.5.1, 3.5.2
Reporter: Erik-Berndt Scheper
Assignee: Adam Warski
Attachments: Envers--HHH-5288-testcase.patch, HHH-5288-testcase-and-fix.patch
I have found that using auditReader.find() to retrieve audit information for entities
containing embedded components with default values. This is a regression issue (also
occurs in 1.2.2.GA release of Envers - Hibernate 3.3 compatible, but did not occur not in
1.2.1 GA) that started occurring since HHH-3957.
Sample entity and embeddable:
{code:title=DefaultValueComponentTestEntity.java|borderStyle=solid}
@Id
@GeneratedValue
private Integer id;
@Embedded
@Audited
@AttributeOverrides( { @AttributeOverride(name = "comp2.str1", column =
@Column(name = "COMP2_STR1")) })
private DefaultValueComponent1 comp1 = null;
{code}
{code:title=DefaultValueComponent1.java|borderStyle=solid}
private String str1;
@Embedded
private DefaultValueComponent2 comp2 = new DefaultValueComponent2();
{code}
{code:title=DefaultValueComponent2.java|borderStyle=solid}
private String str1 = "defaultValue";
private String str2;
{code}
When I try to persist an instance of DefaultValueComponentTestEntity, with comp1 = null
and subsequently call auditReader.find(), an instance is returned where:
{noformat} "defaultValue".equals(comp1.comp2.str1){noformat}
(using java bean notation for simplicity).
I will attach a complete testcase.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:12 p.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-5288) Envers auditReader.find() returns wrong data for embedded components using fields with default values
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5288?page=c...
]
Adam Warski resolved HHH-5288.
------------------------------
Resolution: Fixed
Fix Version/s: 3.6
3.5.3
Envers auditReader.find() returns wrong data for embedded components
using fields with default values
-----------------------------------------------------------------------------------------------------
Key: HHH-5288
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5288
Project: Hibernate Core
Issue Type: Bug
Components: envers
Affects Versions: 3.5.0-Final, 3.5.1, 3.5.2
Reporter: Erik-Berndt Scheper
Assignee: Adam Warski
Fix For: 3.5.3, 3.6
Attachments: Envers--HHH-5288-testcase.patch, HHH-5288-testcase-and-fix.patch
I have found that using auditReader.find() to retrieve audit information for entities
containing embedded components with default values. This is a regression issue (also
occurs in 1.2.2.GA release of Envers - Hibernate 3.3 compatible, but did not occur not in
1.2.1 GA) that started occurring since HHH-3957.
Sample entity and embeddable:
{code:title=DefaultValueComponentTestEntity.java|borderStyle=solid}
@Id
@GeneratedValue
private Integer id;
@Embedded
@Audited
@AttributeOverrides( { @AttributeOverride(name = "comp2.str1", column =
@Column(name = "COMP2_STR1")) })
private DefaultValueComponent1 comp1 = null;
{code}
{code:title=DefaultValueComponent1.java|borderStyle=solid}
private String str1;
@Embedded
private DefaultValueComponent2 comp2 = new DefaultValueComponent2();
{code}
{code:title=DefaultValueComponent2.java|borderStyle=solid}
private String str1 = "defaultValue";
private String str2;
{code}
When I try to persist an instance of DefaultValueComponentTestEntity, with comp1 = null
and subsequently call auditReader.find(), an instance is returned where:
{noformat} "defaultValue".equals(comp1.comp2.str1){noformat}
(using java bean notation for simplicity).
I will attach a complete testcase.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5304
days inactive
5317
days old
hibernate-issues@lists.jboss.org
6 comments
3 participants
participants (3)
-
Adam Warski (JIRA) -
Erik-Berndt Scheper (JIRA)
-
Gail Badner (JIRA)