6:10 a.m.
Upgrade/Update Solr analyzer framework
--------------------------------------
Key: HSEARCH-593
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-593
Project: Hibernate Search
Issue Type: Sub-task
Components: analyzer
Affects Versions: 3.3.0.Beta1
Reporter: Hardy Ferentschik
Assignee: Hardy Ferentschik
Fix For: 3.3.0
Related to the fact that analyzers don't have a default constructor anymore (go
figure!). Not only do we have to take care of this on our side, but we also need to find a
solution to update the solr analyzer framework. Unfortunately, the latest Solr releast
(1.4.1) is not supporting Lucene 3.x yet. So we cannot just update a dependency. Using
Lucene's brnach_3x branch the problem seems to be fixed. The remaining question is how
to get these changes into Search.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:54 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-593) Upgrade/Update Solr analyzer framework
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-593?pag...
]
Hardy Ferentschik commented on HSEARCH-593:
-------------------------------------------
Added a new module hibernate-search-solr-analyzers and starting from the Solr 1.4
development branch backported the Solr trunk changes. Now we have a choice of:
* Leave things as they are (giving us the option to remove the module later when a new
Solr release comes out)
* Rename the classes and put them into the org.hibernate namespace. This might break some
existing code, but we would introduce some buffer between Search and Solr. This is
effectively a "fork" of the Solr framework and we have to make sure to maintain
it ourselves and keep it in sync with the latest Solr code.
* Use the shading plugin to include the dependencies directly into the main jar
Upgrade/Update Solr analyzer framework
--------------------------------------
Key: HSEARCH-593
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-593
Project: Hibernate Search
Issue Type: Sub-task
Components: analyzer
Affects Versions: 3.3.0.Beta1
Reporter: Hardy Ferentschik
Assignee: Hardy Ferentschik
Fix For: 3.3.0
Related to the fact that analyzers don't have a default constructor anymore (go
figure!). Not only do we have to take care of this on our side, but we also need to find a
solution to update the solr analyzer framework. Unfortunately, the latest Solr releast
(1.4.1) is not supporting Lucene 3.x yet. So we cannot just update a dependency. Using
Lucene's brnach_3x branch the problem seems to be fixed. The remaining question is how
to get these changes into Search.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:05 a.m.
New subject: [Hibernate-JIRA] Updated: (HSEARCH-593) Upgrade/Update Solr analyzer framework
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-593?pag...
]
Emmanuel Bernard updated HSEARCH-593:
-------------------------------------
Fix Version/s: (was: 3.3.0)
3.3.0.Beta2
Let's try and close this and follow your plan for beta2 so people can test.
I don't have a strong opinion on jarjar'ing
Upgrade/Update Solr analyzer framework
--------------------------------------
Key: HSEARCH-593
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-593
Project: Hibernate Search
Issue Type: Sub-task
Components: analyzer
Affects Versions: 3.3.0.Beta1
Reporter: Hardy Ferentschik
Assignee: Hardy Ferentschik
Fix For: 3.3.0.Beta2
Related to the fact that analyzers don't have a default constructor anymore (go
figure!). Not only do we have to take care of this on our side, but we also need to find a
solution to update the solr analyzer framework. Unfortunately, the latest Solr releast
(1.4.1) is not supporting Lucene 3.x yet. So we cannot just update a dependency. Using
Lucene's brnach_3x branch the problem seems to be fixed. The remaining question is how
to get these changes into Search.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:21 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-593) Upgrade/Update Solr analyzer framework
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-593?pag...
]
Hardy Ferentschik commented on HSEARCH-593:
-------------------------------------------
Added comments to the Solr source files. I think best to not using the maven-shade-plugin
for now, but have a normal dependency from _hibernate-search_ to
_hibernate-search-analyzers_ (is is containing the ported Solr code). The question is
whether to make this dependency optional or not. A non-optional dependencu will also pull
in the following jars ('mvn dependency:tree'):
{code}
[INFO] +- org.hibernate:hibernate-search-analyzers:jar:3.3.0-SNAPSHOT:compile
[INFO] | +- org.apache.lucene:lucene-snowball:jar:3.0.2:compile
[INFO] | +- org.apache.lucene:lucene-collation:jar:3.0.2:compile
[INFO] | +- commons-codec:commons-codec:jar:1.4:compile
[INFO] | \- commons-io:commons-io:jar:1.4:compile
{code}
Upgrade/Update Solr analyzer framework
--------------------------------------
Key: HSEARCH-593
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-593
Project: Hibernate Search
Issue Type: Sub-task
Components: analyzer
Affects Versions: 3.3.0.Beta1
Reporter: Hardy Ferentschik
Assignee: Hardy Ferentschik
Fix For: 3.3.0.Beta2
Related to the fact that analyzers don't have a default constructor anymore (go
figure!). Not only do we have to take care of this on our side, but we also need to find a
solution to update the solr analyzer framework. Unfortunately, the latest Solr releast
(1.4.1) is not supporting Lucene 3.x yet. So we cannot just update a dependency. Using
Lucene's brnach_3x branch the problem seems to be fixed. The remaining question is how
to get these changes into Search.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:45 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-593) Upgrade/Update Solr analyzer framework
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-593?pag...
]
Emmanuel Bernard commented on HSEARCH-593:
------------------------------------------
Would it be possible to make lucene-snowball and co optional dependencies. And if yes do
you think it's a good/better idea?
Upgrade/Update Solr analyzer framework
--------------------------------------
Key: HSEARCH-593
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-593
Project: Hibernate Search
Issue Type: Sub-task
Components: analyzer
Affects Versions: 3.3.0.Beta1
Reporter: Hardy Ferentschik
Assignee: Hardy Ferentschik
Fix For: 3.3.0.Beta2
Related to the fact that analyzers don't have a default constructor anymore (go
figure!). Not only do we have to take care of this on our side, but we also need to find a
solution to update the solr analyzer framework. Unfortunately, the latest Solr releast
(1.4.1) is not supporting Lucene 3.x yet. So we cannot just update a dependency. Using
Lucene's brnach_3x branch the problem seems to be fixed. The remaining question is how
to get these changes into Search.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-593) Upgrade/Update Solr analyzer framework
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-593?pag...
]
Sanne Grinovero commented on HSEARCH-593:
-----------------------------------------
nice side-effect of managing our own pom.xml of Solr is that you can remove some
dependencies :)
Last time I looked at it - but things might have changed - commons-io and commons-codec
where not needed for the functionality used by Hibernate Search.
I'd try removing them all and verify nothing breaks, then put them back as optional,
at least snowball and collation.
Upgrade/Update Solr analyzer framework
--------------------------------------
Key: HSEARCH-593
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-593
Project: Hibernate Search
Issue Type: Sub-task
Components: analyzer
Affects Versions: 3.3.0.Beta1
Reporter: Hardy Ferentschik
Assignee: Hardy Ferentschik
Fix For: 3.3.0.Beta2
Related to the fact that analyzers don't have a default constructor anymore (go
figure!). Not only do we have to take care of this on our side, but we also need to find a
solution to update the solr analyzer framework. Unfortunately, the latest Solr releast
(1.4.1) is not supporting Lucene 3.x yet. So we cannot just update a dependency. Using
Lucene's brnach_3x branch the problem seems to be fixed. The remaining question is how
to get these changes into Search.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:15 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-593) Upgrade/Update Solr analyzer framework
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-593?pag...
]
Hardy Ferentschik commented on HSEARCH-593:
-------------------------------------------
All the listed dependencies are needed to compile the _hibernate-search-analyzer_ module.
_commons-io_ is eg used by {{PatternTokenizer}} and {{PhoneticFilter}} uses
_commons-codec_. Of course depending on which tokenizer/filter you are using you won't
need all dependencies. For this reason we could do what Emmanuel suggests. We could mark
all dependencies as optional in the _hibernate-search-analyzer_ module, but use the module
within _hibernate-search_ as a normal runtime dependency. This way the base Solr classes
are always available, but depending on which tokenizer/filter is used you would have to
add additional jars. Might be the best trade off.
Upgrade/Update Solr analyzer framework
--------------------------------------
Key: HSEARCH-593
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-593
Project: Hibernate Search
Issue Type: Sub-task
Components: analyzer
Affects Versions: 3.3.0.Beta1
Reporter: Hardy Ferentschik
Assignee: Hardy Ferentschik
Fix For: 3.3.0.Beta2
Related to the fact that analyzers don't have a default constructor anymore (go
figure!). Not only do we have to take care of this on our side, but we also need to find a
solution to update the solr analyzer framework. Unfortunately, the latest Solr releast
(1.4.1) is not supporting Lucene 3.x yet. So we cannot just update a dependency. Using
Lucene's brnach_3x branch the problem seems to be fixed. The remaining question is how
to get these changes into Search.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:20 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-593) Upgrade/Update Solr analyzer framework
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-593?pag...
]
Sanne Grinovero commented on HSEARCH-593:
-----------------------------------------
right, forgot about compiling it :)
+1 to set them all optional
Upgrade/Update Solr analyzer framework
--------------------------------------
Key: HSEARCH-593
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-593
Project: Hibernate Search
Issue Type: Sub-task
Components: analyzer
Affects Versions: 3.3.0.Beta1
Reporter: Hardy Ferentschik
Assignee: Hardy Ferentschik
Fix For: 3.3.0.Beta2
Related to the fact that analyzers don't have a default constructor anymore (go
figure!). Not only do we have to take care of this on our side, but we also need to find a
solution to update the solr analyzer framework. Unfortunately, the latest Solr releast
(1.4.1) is not supporting Lucene 3.x yet. So we cannot just update a dependency. Using
Lucene's brnach_3x branch the problem seems to be fixed. The remaining question is how
to get these changes into Search.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:12 a.m.
New subject: [Hibernate-JIRA] Resolved: (HSEARCH-593) Upgrade/Update Solr analyzer framework
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-593?pag...
]
Hardy Ferentschik resolved HSEARCH-593.
---------------------------------------
Resolution: Fixed
Made transitive dependencies of _hibernate-search-analyzers_ optional. Updated the
documentation about {{AnalyzerDef}}.
Upgrade/Update Solr analyzer framework
--------------------------------------
Key: HSEARCH-593
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-593
Project: Hibernate Search
Issue Type: Sub-task
Components: analyzer
Affects Versions: 3.3.0.Beta1
Reporter: Hardy Ferentschik
Assignee: Hardy Ferentschik
Fix For: 3.3.0.Beta2
Related to the fact that analyzers don't have a default constructor anymore (go
figure!). Not only do we have to take care of this on our side, but we also need to find a
solution to update the solr analyzer framework. Unfortunately, the latest Solr releast
(1.4.1) is not supporting Lucene 3.x yet. So we cannot just update a dependency. Using
Lucene's brnach_3x branch the problem seems to be fixed. The remaining question is how
to get these changes into Search.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5207
days inactive
5249
days old
hibernate-issues@lists.jboss.org
8 comments
3 participants
participants (3)
-
Emmanuel Bernard (JIRA) -
Hardy Ferentschik (JIRA)
-
Sanne Grinovero (JIRA)