9:30 a.m.
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this case
null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
<pre></code>
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
</code>
</pre>
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:22 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Emmanuel Bernard commented on HSEARCH-115:
------------------------------------------
It is possible today to do what you want, but you need to provide a custom fieldbridge.
Maybe we could add a parameter to define the null value in the built-in bridges.
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
<pre></code>
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
</code>
</pre>
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:36 p.m.
New subject: [Hibernate-JIRA] Updated: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Emmanuel Bernard updated HSEARCH-115:
-------------------------------------
Fix Version/s: 3.1.0
3.0.1
I don't know the impact, but we should at least introduce that to 3.1.0
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Fix For: 3.0.1, 3.1.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
<pre></code>
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
</code>
</pre>
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:06 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Julien Brulin commented on HSEARCH-115:
---------------------------------------
Thanks a lot !
http://juliusdev.blogspot.com/2007/10/hibernate-search-and-null-value.html
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Fix For: 3.0.1, 3.1.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
<pre></code>
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
</code>
</pre>
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:13 a.m.
New subject: [Hibernate-JIRA] Assigned: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Hardy Ferentschik reassigned HSEARCH-115:
-----------------------------------------
Assignee: Hardy Ferentschik
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.0.1, 3.1.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
<pre></code>
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
</code>
</pre>
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:10 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Hardy Ferentschik commented on HSEARCH-115:
-------------------------------------------
As far as I can see there should be no problem to add a 'default' parameter to the
Field annotation. We could then pick up this annotation in BridgeFactory.guessType( ) and
pass it to the build in bridge (provided no custom bridge is provided). Since so many
buildin bridges extend the NumberBridge you pretty much only have to change this bridge
together with the StringBridge.
So technically it should be straight forward, but before I would go ahead I have a few
questions.
The buildin bridges are all implementing TwoWayStringBridge. How would you resolve
ambiguities? If I for example use the string 'null' as default for a null object
(as suggested in the example), but one of my objects also contains 'null' as a
value, how do I map the string 'null' for stringToObject()? I guess since the
default anntotation would be sepcified you would map the string 'null' always to
null. This would mean that it is up to the user to ensure that her data does not contain
any ambiguities.
Given the potential problems wouldn't it be better to not add this feature to the
build in bridges? As said user can always use/implement a custom bridge. Or we introduce
additional custom bridges which don't implement TwoWayStringBridge?
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.0.1, 3.1.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
<pre></code>
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
</code>
</pre>
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:41 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Emmanuel Bernard commented on HSEARCH-115:
------------------------------------------
And that's why I imagined it probably must be postponned to 3.1 We will have to break
the bridge API to introduce the default null value (or maybe an implementation). This is
really the fieldbridge's responsibility to do this job. All HSearch can do is to give
a hint about the default value if the object is null.
We can't fight ambiguity, and we can't fight crypto analyzers either. When a user
pick up a specific 'null' value, then it's his responsibility. The default
should still be no indexing as it is today as this is the right semantic.
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.0.1, 3.1.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
<pre></code>
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
</code>
</pre>
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:15 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Hardy Ferentschik commented on HSEARCH-115:
-------------------------------------------
So you think we should change the set(String name, Object value, Document document,
Field.Store store, Field.Index index, Float boost) method of the FieldBridge interface?
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.0.1, 3.1.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
<pre></code>
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
</code>
</pre>
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:55 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Emmanuel Bernard commented on HSEARCH-115:
------------------------------------------
That's was my initial thought, but if you have a better idea... :)
If you write that down, don't apply it on trunk since it still supports the 3.0.x
codebase.
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.0.1, 3.1.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
<pre></code>
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
</code>
</pre>
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:19 p.m.
New subject: [Hibernate-JIRA] Updated: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Emmanuel Bernard updated HSEARCH-115:
-------------------------------------
Fix Version/s: (was: 3.0.1)
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.1.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
<pre></code>
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
</code>
</pre>
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:04 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Hardy Ferentschik commented on HSEARCH-115:
-------------------------------------------
Ok, here are a few suggestions:
1. This is the simplest way. Basically just add a new property named 'indexNullAs'
to @Field and @ClassBridge. Accordingly extend the FieldBridge interface to set(String
name, Object value, Document document, Field.Store store, Field.Index index,
Field.TermVector termVector, Float boost, String indexNullAs).
2. Alternatively one could change the FieldBridge API to actually pass in the Field
annotation itself: set(String name, Object value, Document document, Field
fieldAnnotation, Float boost). This would reduce the amount of parameters and might
actually be more transparent for users implementing custom bridges. Unfortunately, one
would have to introduce a ClassBridge interface as well in this case. I am not sure
whether it is a good design choice to pass annotation instances around.
3. We ccould also change the API into something like this: set(String name, Object value,
Document document, IndexProperties props), where IndexProperties is just a wrapper class
for Field.Store, Field.Index, ... The drawback is that this just increases the number of
classes.
Any comments?
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.1.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
<pre></code>
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
</code>
</pre>
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:21 a.m.
New subject: [Hibernate-JIRA] Updated: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Emmanuel Bernard updated HSEARCH-115:
-------------------------------------
Fix Version/s: (was: 3.1.0.Beta1)
3.2.0
Last I recall, the discussion on the dev list said we were not fan of the feature.
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.2.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
<pre></code>
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
</code>
</pre>
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:49 a.m.
New subject: [Hibernate-JIRA] Updated: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Emmanuel Bernard updated HSEARCH-115:
-------------------------------------
Fix Version/s: (was: 3.2.0.Beta1)
3.2.0.Beta3
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.2.0.Beta3
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
<pre></code>
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
</code>
</pre>
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:34 a.m.
New subject: [Hibernate-JIRA] Updated: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Emmanuel Bernard updated HSEARCH-115:
-------------------------------------
Fix Version/s: (was: 3.2.0.Beta3)
3.3.0
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.3.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
<pre></code>
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
</code>
</pre>
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:16 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Emmanuel Bernard commented on HSEARCH-115:
------------------------------------------
HArdy and I explored a couple of ideas:
- use Payload as a marker but aside fomr the fact that payload is a bit weird, queries
would have to take that into account which is a real issue
- add a new method to LuceneOptions#representsNullAs
But we would also need the same info on TwoWayFieldBridge#get (adding a ExtractOptions
parameter?)
And would we need it on objectToString, what about StringBuilder#objectToString /
StringToObject ? (in particular concerned about
DocumentBuilderindexedEntity#objectToString
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.3.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
<pre></code>
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
</code>
</pre>
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:53 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Sanne Grinovero commented on HSEARCH-115:
-----------------------------------------
I've no strong opinion about this, but using the payload doesn't seem right as we
can use it to encode many other useful things, and btw you would still need a term to
attach the payload to. I'm still of the idea that people should be able to define any
marker string.
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.3.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
<pre></code>
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
</code>
</pre>
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:06 a.m.
New subject: [Hibernate-JIRA] Updated: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Hardy Ferentschik updated HSEARCH-115:
--------------------------------------
Description:
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this case
null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
{code}
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
{code}
What do you think about that ?
Ps: sorry for english write, i am a french guy.
was:
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this case
null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
<pre></code>
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
</code>
</pre>
What do you think about that ?
Ps: sorry for english write, i am a french guy.
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.3.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
{code}
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
{code}
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:06 a.m.
New subject: [Hibernate-JIRA] Updated: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Hardy Ferentschik updated HSEARCH-115:
--------------------------------------
Description:
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this case
null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
{code}
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
{code}
What do you think about that ?
Ps: sorry for english write, i am a french guy.
was:
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this case
null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
{code}
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
{code}
What do you think about that ?
Ps: sorry for english write, i am a french guy.
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.3.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
{code}
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
{code}
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:57 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Hardy Ferentschik commented on HSEARCH-115:
-------------------------------------------
Why introducing a new parameter {{ExtractOptions}}? Couldn't we just use
{{LuceneOptions}}? Basically we would add them to
{code:title=TwoWayFieldBridge.java|borderStyle=solid}
public interface TwoWayFieldBridge extends FieldBridge {
Object get(String name, Document document);
String objectToString(Object object);
}
{code}
so that the interface becomes:
{code:title=TwoWayFieldBridge.java|borderStyle=solid}
public interface TwoWayFieldBridge extends FieldBridge {
Object get(String name, Document document, LuceneOptions options);
String objectToString(Object object, LuceneOptions options);
}
{code}
We would have to keep the old methods around for backward compatibility, but we could
deprecate them.
In this context I am wondering about the name of {{LuceneOptions}}. Really the class is
already more than
a simple options container. Maybe we should look for a better name.
Related to this work, I noticed we have quite a few static methods in
{{DocumentBuilderIndexedEntity}}. I
think it would make sense to move them into their own helper class.
Comments?
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.3.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
{code}
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
{code}
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:31 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Sanne Grinovero commented on HSEARCH-115:
-----------------------------------------
+1 to use LuceneOptions, as it stores already other field options so it could also store
the eventually user-chosen marker value.
Also it's currently LuceneOptions to be responsible to take a decision according to a
!=null test (_LuceneOptionsImpl:62_)
I didn't get why we should change the TwoWayFieldBridge interface; the {{get()}}
method is invoked in two well known places and we can wrap that to eventually replace any
token with a null value. while the {{objectToString()}} wouldn't need any special
care, as we opted to implement the encoding in LuceneOptionsImpl, which performs all final
encoding before adding to Document.
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.3.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
{code}
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
{code}
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:33 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Sanne Grinovero commented on HSEARCH-115:
-----------------------------------------
Do we also want to support query for _empty string_ , as a different criteria than _null_
? It might make sense to implement them together, and also provide options to query for
"empty or null" (in addition to empty only or null)
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.3.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
{code}
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
{code}
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:44 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Emmanuel Bernard commented on HSEARCH-115:
------------------------------------------
i was thinking of ExtractOptions because some LuceneOptions methods do not make sense this
way around.
A better naming of LuceneOptions could have been a good idea but is it worth annoying our
users and break compatibility just for that? I'd say no.
About the static helper methods on DocumentBuilderIndexedEntity: why not but it has to be
obvious for people in need for such methods that this helper class will host them
otherwise that could lead to code duplication.
@Sanne:
we don't know what value should replace null (or empty string for that matter). So we
need a way for the bridge or whatever setting to pass it along. Remember a bridge is free
to do many things. Does that alter your view on the need for altering get /
objectToString?
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.3.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
{code}
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
{code}
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:19 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Sanne Grinovero commented on HSEARCH-115:
-----------------------------------------
Just to illustrate what I was thinking about (didn't test, I might be missing
something), I paste the code;
basically when reading the annotations we can wrap any TwoWayFieldBridge we would
otherwise use (if two-way)
with an adapter like this:
{noformat}
public class NullEncodingTwoWayFieldBridge implements TwoWayFieldBridge {
private final TwoWayFieldBridge fieldBridge;
private final String nullMarker;
public NullEncodingTwoWayFieldBridge(TwoWayFieldBridge fieldBridge, String nullMarker) {
this.fieldBridge = fieldBridge;
this.nullMarker = nullMarker;
}
public Object get(String name, Document document) {
Field field = document.getField( name );
String stringValue = field.stringValue();
if ( nullMarker.equals( stringValue ) ) {
return null;
}
else {
return fieldBridge.get( name, document );
}
}
public String objectToString(Object object) {
if ( object == null ) {
return nullMarker;
}
else {
return fieldBridge.objectToString( object );
}
}
public void set(String name, Object value, Document document, LuceneOptions
luceneOptions) {
fieldBridge.set( name, value, document, luceneOptions );
}
}
{noformat}
Only downside is that field.stringValue() might be invoked twice for the same field, in
both this impl and the wrapped impl; afaik that shouldn't be expensive.
Considering "a bridge is free to do many things" (quoting Emmanuel), do you
foresee breaking anything?
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.3.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
{code}
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
{code}
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:30 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Emmanuel Bernard commented on HSEARCH-115:
------------------------------------------
When I looked last week I thought there was an issue and that was not covering all cases.
I don't remember though.
But I was in a different mindset, I could have been wrong.
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.3.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
{code}
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
{code}
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:43 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Hardy Ferentschik commented on HSEARCH-115:
-------------------------------------------
Nice one. I think that could work. I will go through the code to see if this approach
would break down anywhere.
One thing we should think about as well is how we can expose the null token
programmatically. To use this feature you will have to use the null token directly in your
queries. This can lead to problems when you for example change the token in the
annotation, but not in the matching query. I created HSEARCH-436 with this type of things
in mind. I think it would be nice to be able to programmatically get metainformation about
the configuration.
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.3.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
{code}
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
{code}
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:07 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Sanne Grinovero commented on HSEARCH-115:
-----------------------------------------
true, querying needs some help. Ideally the programmatic query building should be able to
build a query for "null" valued fields.
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.3.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
{code}
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
{code}
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:16 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Emmanuel Bernard commented on HSEARCH-115:
------------------------------------------
yep the DSL is here to hide people from that. The API will be a bit complext to expose but
that's doable as well. That can wait though since we do have the DSL :)
BTW, are we exposing the diff between null and empty strings? Sanne, "" is not a
valid token value in Lucene (can't remember)?
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.3.0
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
{code}
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
{code}
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:12 p.m.
New subject: [Hibernate-JIRA] Updated: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Hardy Ferentschik updated HSEARCH-115:
--------------------------------------
Fix Version/s: (was: 3.3.0)
3.3.0.CR1
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.3.0.CR1
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
{code}
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
{code}
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:57 a.m.
New subject: [Hibernate-JIRA] Resolved: (HSEARCH-115) Add a default value for indexing null value
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115?pag...
]
Hardy Ferentschik resolved HSEARCH-115.
---------------------------------------
Resolution: Fixed
Add a default value for indexing null value
-------------------------------------------
Key: HSEARCH-115
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-115
Project: Hibernate Search
Issue Type: Improvement
Components: mapping
Reporter: Julien Brulin
Assignee: Hardy Ferentschik
Fix For: 3.3.0.CR1
Hi,
Null elements are not indexed by lucene then it's not easy to use a nullable property
in lucene query.
I have a TagTranslation entity in my model with a nullable property language. In this
case null is used as default language for tag translation.
Each translation may have many variations like synonyms.
Because I can specified a default value for null value in the @Field annotation like this
@Field(index=Index.UN_TOKENIZED, store=Store.NO, default='null'), i can't
search a cat tag with a default translation like this : +value:cat* +lang:null
{code}
@Entity()
@Table(name="indexing_tag_trans")
@org.hibernate.annotations.Cache(usage=org.hibernate.annotations.CacheConcurrencyStrategy.READ_WRITE)
@Indexed
public class TagTranslation implements java.io.Serializable {
private static final long serialVersionUID = -1065316566731456110L;
@Id
@GeneratedValue(strategy=GenerationType.IDENTITY)
@DocumentId
private Integer id;
@Field(index=Index.UN_TOKENIZED, store=Store.NO)
private String language;
@Field(index=Index.TOKENIZED, store=Store.YES)
private String value;
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@org.hibernate.annotations.Fetch(org.hibernate.annotations.FetchMode.SUBSELECT)
@JoinColumn(name="translation_id")
@IndexedEmbedded
private List<TagVariation> variations = new LinkedList<TagVariation>();
public TagTranslation() { }
...
{code}
What do you think about that ?
Ps: sorry for english write, i am a french guy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5159
days inactive
6318
days old
hibernate-issues@lists.jboss.org
28 comments
4 participants
participants (4)
-
Emmanuel Bernard (JIRA) -
Hardy Ferentschik (JIRA)
-
Julien Brulin (JIRA)
-
Sanne Grinovero (JIRA)