[Hibernate-JIRA] Created: (HHH-7017) Envers does not work in case of resource-local transactions and manual session flush mode
2:13 a.m.
Envers does not work in case of resource-local transactions and manual session flush mode
-----------------------------------------------------------------------------------------
Key: HHH-7017
URL: https://hibernate.onjira.com/browse/HHH-7017
Project: Hibernate ORM
Issue Type: Bug
Components: envers
Affects Versions: 3.6.9
Environment: Hibernate 3.6.9, MySQL 5.1.44-community, mysql-connector-java-5.1.6,
Inno DB tables
Reporter: Vladimir Velikiy
When I set a manual hibernate session flush mode envers does not write data in database.
With FlushMode.AUTO all works ok. I think the problem in in a method
doBeforeTransactionCompletion of the AuditProcess.java:
if (FlushMode.isManualFlushMode(session.getFlushMode())) {
Session temporarySession = null;
try {
temporarySession = session.getFactory().openTemporarySession();
executeInSession(temporarySession);
temporarySession.flush();
} finally {
if (temporarySession != null) {
temporarySession.close();
}
}
} else {
executeInSession((Session) session);
// Explicity flushing the session, as the auto-flush may have already
happened.
session.flush();
}
In non-jta environment temporary session connection transaction is not commited.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:58 p.m.
New subject: [Hibernate-JIRA] Assigned: (HHH-7017) Envers does not work in case of resource-local transactions and manual session flush mode
[
https://hibernate.onjira.com/browse/HHH-7017?page=com.atlassian.jira.plug...
]
Gail Badner reassigned HHH-7017:
--------------------------------
Assignee: Adam Warski
Adam, please assign as appropriate.
Thanks,
Gail
Envers does not work in case of resource-local transactions and
manual session flush mode
-----------------------------------------------------------------------------------------
Key: HHH-7017
URL: https://hibernate.onjira.com/browse/HHH-7017
Project: Hibernate ORM
Issue Type: Bug
Components: envers
Affects Versions: 3.6.9
Environment: Hibernate 3.6.9, MySQL 5.1.44-community, mysql-connector-java-5.1.6,
Inno DB tables
Reporter: Vladimir Velikiy
Assignee: Adam Warski
Labels: auditing
When I set a manual hibernate session flush mode envers does not write data in database.
With FlushMode.AUTO all works ok. I think the problem in in a method
doBeforeTransactionCompletion of the AuditProcess.java:
if (FlushMode.isManualFlushMode(session.getFlushMode())) {
Session temporarySession = null;
try {
temporarySession = session.getFactory().openTemporarySession();
executeInSession(temporarySession);
temporarySession.flush();
} finally {
if (temporarySession != null) {
temporarySession.close();
}
}
} else {
executeInSession((Session) session);
// Explicity flushing the session, as the auto-flush may have already
happened.
session.flush();
}
In non-jta environment temporary session connection transaction is not commited.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:33 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7017) Envers does not work in case of resource-local transactions and manual session flush mode
[
https://hibernate.onjira.com/browse/HHH-7017?page=com.atlassian.jira.plug...
]
Vladimir Velikiy commented on HHH-7017:
---------------------------------------
A small addition: If I enable autocommit option for connection - all works fine, but this
is not a good practice. I think a temporary session must use the existing connection with
started transaction, instead of creating new in the code above.
Thus, the full description of the problem:
Envers does not write data in database in case of resource-local transactions, manual
session flush mode and disabled autocommit.
Envers does not work in case of resource-local transactions and
manual session flush mode
-----------------------------------------------------------------------------------------
Key: HHH-7017
URL: https://hibernate.onjira.com/browse/HHH-7017
Project: Hibernate ORM
Issue Type: Bug
Components: envers
Affects Versions: 3.6.9
Environment: Hibernate 3.6.9, MySQL 5.1.44-community, mysql-connector-java-5.1.6,
Inno DB tables
Reporter: Vladimir Velikiy
Assignee: Adam Warski
Labels: auditing
When I set a manual hibernate session flush mode envers does not write data in database.
With FlushMode.AUTO all works ok. I think the problem in in a method
doBeforeTransactionCompletion of the AuditProcess.java:
if (FlushMode.isManualFlushMode(session.getFlushMode())) {
Session temporarySession = null;
try {
temporarySession = session.getFactory().openTemporarySession();
executeInSession(temporarySession);
temporarySession.flush();
} finally {
if (temporarySession != null) {
temporarySession.close();
}
}
} else {
executeInSession((Session) session);
// Explicity flushing the session, as the auto-flush may have already
happened.
session.flush();
}
In non-jta environment temporary session connection transaction is not commited.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:24 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7017) Envers does not work in case of resource-local transactions and manual session flush mode
[
https://hibernate.onjira.com/browse/HHH-7017?page=com.atlassian.jira.plug...
]
Adam Warski commented on HHH-7017:
----------------------------------
Could you try creating a test case for that? There is a test for manual flush
(org.hibernate.envers.test.integration.flush.ManualFlush), and I'm curious how your
usage differs.
Adam
Envers does not work in case of resource-local transactions and
manual session flush mode
-----------------------------------------------------------------------------------------
Key: HHH-7017
URL: https://hibernate.onjira.com/browse/HHH-7017
Project: Hibernate ORM
Issue Type: Bug
Components: envers
Affects Versions: 3.6.9
Environment: Hibernate 3.6.9, MySQL 5.1.44-community, mysql-connector-java-5.1.6,
Inno DB tables
Reporter: Vladimir Velikiy
Assignee: Adam Warski
Labels: auditing
When I set a manual hibernate session flush mode envers does not write data in database.
With FlushMode.AUTO all works ok. I think the problem in in a method
doBeforeTransactionCompletion of the AuditProcess.java:
if (FlushMode.isManualFlushMode(session.getFlushMode())) {
Session temporarySession = null;
try {
temporarySession = session.getFactory().openTemporarySession();
executeInSession(temporarySession);
temporarySession.flush();
} finally {
if (temporarySession != null) {
temporarySession.close();
}
}
} else {
executeInSession((Session) session);
// Explicity flushing the session, as the auto-flush may have already
happened.
session.flush();
}
In non-jta environment temporary session connection transaction is not commited.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:18 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-7017) Envers does not work in case of resource-local transactions and manual session flush mode
[
https://hibernate.onjira.com/browse/HHH-7017?page=com.atlassian.jira.plug...
]
Vladimir Velikiy updated HHH-7017:
----------------------------------
Attachment: ManualFlushAutoCommitDisabled.java
Test case for issue
Envers does not work in case of resource-local transactions and
manual session flush mode
-----------------------------------------------------------------------------------------
Key: HHH-7017
URL: https://hibernate.onjira.com/browse/HHH-7017
Project: Hibernate ORM
Issue Type: Bug
Components: envers
Affects Versions: 3.6.9
Environment: Hibernate 3.6.9, MySQL 5.1.44-community, mysql-connector-java-5.1.6,
Inno DB tables
Reporter: Vladimir Velikiy
Assignee: Adam Warski
Labels: auditing
Attachments: ManualFlushAutoCommitDisabled.java
When I set a manual hibernate session flush mode envers does not write data in database.
With FlushMode.AUTO all works ok. I think the problem in in a method
doBeforeTransactionCompletion of the AuditProcess.java:
if (FlushMode.isManualFlushMode(session.getFlushMode())) {
Session temporarySession = null;
try {
temporarySession = session.getFactory().openTemporarySession();
executeInSession(temporarySession);
temporarySession.flush();
} finally {
if (temporarySession != null) {
temporarySession.close();
}
}
} else {
executeInSession((Session) session);
// Explicity flushing the session, as the auto-flush may have already
happened.
session.flush();
}
In non-jta environment temporary session connection transaction is not commited.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:25 a.m.
New subject: [Hibernate-JIRA] Issue Comment Edited: (HHH-7017) Envers does not work in case of resource-local transactions and manual session flush mode
[
https://hibernate.onjira.com/browse/HHH-7017?page=com.atlassian.jira.plug...
]
Vladimir Velikiy edited comment on HHH-7017 at 2/4/12 7:24 AM:
---------------------------------------------------------------
I attached test case. This file is copy of ManualFlush.java with one change in the
hibernate configuration:
@Override
public void configure(Ejb3Configuration cfg) {
super.configure(cfg);
cfg.setProperty("hibernate.connection.autocommit", "false");
}
With this change some tests are not passed:
Results :
Failed tests:
testRevisionTypes(org.hibernate.envers.test.integration.flush.ManualFlushAutoCommitDisabled)
testRevisionsCounts(org.hibernate.envers.test.integration.flush.ManualFlushAutoCommitDisabled)
testHistoryOfId(org.hibernate.envers.test.integration.flush.ManualFlushAutoCommitDisabled)
testRevisionTypes(org.hibernate.envers.test.integration.flush.ManualFlushAutoCommitDisabled)
testRevisionsCounts(org.hibernate.envers.test.integration.flush.ManualFlushAutoCommitDisabled)
testHistoryOfId(org.hibernate.envers.test.integration.flush.ManualFlushAutoCommitDisabled)
was (Author: vladvel):
Test case for issue
Envers does not work in case of resource-local transactions and
manual session flush mode
-----------------------------------------------------------------------------------------
Key: HHH-7017
URL: https://hibernate.onjira.com/browse/HHH-7017
Project: Hibernate ORM
Issue Type: Bug
Components: envers
Affects Versions: 3.6.9
Environment: Hibernate 3.6.9, MySQL 5.1.44-community, mysql-connector-java-5.1.6,
Inno DB tables
Reporter: Vladimir Velikiy
Assignee: Adam Warski
Labels: auditing
Attachments: ManualFlushAutoCommitDisabled.java
When I set a manual hibernate session flush mode envers does not write data in database.
With FlushMode.AUTO all works ok. I think the problem in in a method
doBeforeTransactionCompletion of the AuditProcess.java:
if (FlushMode.isManualFlushMode(session.getFlushMode())) {
Session temporarySession = null;
try {
temporarySession = session.getFactory().openTemporarySession();
executeInSession(temporarySession);
temporarySession.flush();
} finally {
if (temporarySession != null) {
temporarySession.close();
}
}
} else {
executeInSession((Session) session);
// Explicity flushing the session, as the auto-flush may have already
happened.
session.flush();
}
In non-jta environment temporary session connection transaction is not commited.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:46 p.m.
New subject: [Hibernate-JIRA] Assigned: (HHH-7017) Envers does not work in case of resource-local transactions and manual session flush mode
[
https://hibernate.onjira.com/browse/HHH-7017?page=com.atlassian.jira.plug...
]
Lukasz Antoniak reassigned HHH-7017:
------------------------------------
Assignee: Lukasz Antoniak (was: Adam Warski)
Envers does not work in case of resource-local transactions and
manual session flush mode
-----------------------------------------------------------------------------------------
Key: HHH-7017
URL: https://hibernate.onjira.com/browse/HHH-7017
Project: Hibernate ORM
Issue Type: Bug
Components: envers
Affects Versions: 3.6.9
Environment: Hibernate 3.6.9, MySQL 5.1.44-community, mysql-connector-java-5.1.6,
Inno DB tables
Reporter: Vladimir Velikiy
Assignee: Lukasz Antoniak
Labels: auditing
Fix For: 4.1.2
Attachments: ManualFlushAutoCommitDisabled.java
When I set a manual hibernate session flush mode envers does not write data in database.
With FlushMode.AUTO all works ok. I think the problem in in a method
doBeforeTransactionCompletion of the AuditProcess.java:
if (FlushMode.isManualFlushMode(session.getFlushMode())) {
Session temporarySession = null;
try {
temporarySession = session.getFactory().openTemporarySession();
executeInSession(temporarySession);
temporarySession.flush();
} finally {
if (temporarySession != null) {
temporarySession.close();
}
}
} else {
executeInSession((Session) session);
// Explicity flushing the session, as the auto-flush may have already
happened.
session.flush();
}
In non-jta environment temporary session connection transaction is not commited.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:46 p.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-7017) Envers does not work in case of resource-local transactions and manual session flush mode
[
https://hibernate.onjira.com/browse/HHH-7017?page=com.atlassian.jira.plug...
]
Lukasz Antoniak resolved HHH-7017.
----------------------------------
Resolution: Fixed
Fix Version/s: 4.1.2
Envers does not work in case of resource-local transactions and
manual session flush mode
-----------------------------------------------------------------------------------------
Key: HHH-7017
URL: https://hibernate.onjira.com/browse/HHH-7017
Project: Hibernate ORM
Issue Type: Bug
Components: envers
Affects Versions: 3.6.9
Environment: Hibernate 3.6.9, MySQL 5.1.44-community, mysql-connector-java-5.1.6,
Inno DB tables
Reporter: Vladimir Velikiy
Assignee: Lukasz Antoniak
Labels: auditing
Fix For: 4.1.2
Attachments: ManualFlushAutoCommitDisabled.java
When I set a manual hibernate session flush mode envers does not write data in database.
With FlushMode.AUTO all works ok. I think the problem in in a method
doBeforeTransactionCompletion of the AuditProcess.java:
if (FlushMode.isManualFlushMode(session.getFlushMode())) {
Session temporarySession = null;
try {
temporarySession = session.getFactory().openTemporarySession();
executeInSession(temporarySession);
temporarySession.flush();
} finally {
if (temporarySession != null) {
temporarySession.close();
}
}
} else {
executeInSession((Session) session);
// Explicity flushing the session, as the auto-flush may have already
happened.
session.flush();
}
In non-jta environment temporary session connection transaction is not commited.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4666
days inactive
4713
days old
hibernate-issues@lists.jboss.org
7 comments
4 participants
participants (4)
-
Adam Warski (JIRA) -
Gail Badner (JIRA)
-
Lukasz Antoniak (JIRA)
-
Vladimir Velikiy (JIRA)