[ http://opensource.atlassian.com/projects/hibernate/browse/HV-267?page=com... ] Hardy Ferentschik commented on HV-267: -------------------------------------- I guess we could use the Felix Bundle Plugin and do something like this: <plugin> <artifactId>maven-jar-plugin</artifactId> <configuration> <archive> <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile> </archive> </configuration> </plugin> <plugin> <groupId>org.apache.felix</groupId> <artifactId>maven-bundle-plugin</artifactId> <executions> <execution> <id>bundle-manifest</id> <phase>process-classes</phase> <goals> <goal>manifest</goal> </goals> </execution> </executions> </plugin> However, this also lists jtype as dependency which means that the bundle plugin works so well together with the shade plugin. I guess the bundle manifest should be created from the dependency reduced pom. I also need to understand the Import/Export Package entries better and what these different versions mean. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-267?page=com... ] Jaro Kuruc updated HV-267: -------------------------- Attachment: maven-bundle-plugin.patch Please find a patch for hibernate-validator module. All package imports are required apart from the javax.persistence, as far as I am concerned. Import for package com.googlecode.jtype is also required, as otherwise org.hibernate.validator.util.ValidatorTypeHelper would fail with java.lang.ClassNotFoundException whenever it's being used in OSGi environment. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-267?page=com... ] Hardy Ferentschik commented on HV-267: -------------------------------------- More information about why we use the shade plugin together with its relocation functionality can be found here - HV-90 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-267?page=com... ] Hardy Ferentschik edited comment on HV-267 at 3/15/10 1:59 PM: --------------------------------------------------------------- I guess we could use the Felix Bundle Plugin and do something like this: {code} <plugin> <artifactId>maven-jar-plugin</artifactId> <configuration> <archive> <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile> </archive> </configuration> </plugin> <plugin> <groupId>org.apache.felix</groupId> <artifactId>maven-bundle-plugin</artifactId> <executions> <execution> <id>bundle-manifest</id> <phase>process-classes</phase> <goals> <goal>manifest</goal> </goals> </execution> </executions> </plugin> {code} However, this also lists jtype as dependency which means that the bundle plugin works so well together with the shade plugin. I guess the bundle manifest should be created from the dependency reduced pom. I also need to understand the Import/Export Package entries better and what these different versions mean. was (Author: hardy.ferentschik): I guess we could use the Felix Bundle Plugin and do something like this: <plugin> <artifactId>maven-jar-plugin</artifactId> <configuration> <archive> <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile> </archive> </configuration> </plugin> <plugin> <groupId>org.apache.felix</groupId> <artifactId>maven-bundle-plugin</artifactId> <executions> <execution> <id>bundle-manifest</id> <phase>process-classes</phase> <goals> <goal>manifest</goal> </goals> </execution> </executions> </plugin> However, this also lists jtype as dependency which means that the bundle plugin works so well together with the shade plugin. I guess the bundle manifest should be created from the dependency reduced pom. I also need to understand the Import/Export Package entries better and what these different versions mean. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-267?page=com... ] Hardy Ferentschik commented on HV-267: -------------------------------------- Applied the patch without the import of {{com.googlecode.jtype.*;version="[0.1.0,1.0.0)"}}. This way we get the OSGi manifest entries and keep the shading for now. I think this should work. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira