[Hibernate-JIRA] Created: (HSEARCH-753) fullTextQuery.getResultList().size() != fullTextQuery.getResultSize() when using criteria
11:35 a.m.
fullTextQuery.getResultList().size() != fullTextQuery.getResultSize() when using criteria
-----------------------------------------------------------------------------------------
Key: HSEARCH-753
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753
Project: Hibernate Search
Issue Type: Bug
Components: query
Affects Versions: 3.4.0.Final
Environment: hibernate 3.6.4.Final / postgresSQL
Reporter: Mathieu Perez
1) My indexes are up-to-date and optimised
2) I'm aware about this part of documentation: "Like Google, the number of
results is approximative if the index is not fully up-to-date with the database
(asynchronous cluster for example)."
3) Two types of queries:
3.1) Query with "keyword" (or
"below"/"above"/"fromTo")
{code}
QueryBuilder qb = fullTextSession.getSearchFactory().buildQueryBuilder().forEntity(
Book.class ).get();
org.apache.lucene.search.Query query = qb
.keyword()
.onFields("title", "subtitle", "authors.name",
"publicationDate")
.matching("Java rocks!");
.createQuery();
{code}
In this case, I don't meet any problem:
query.getResultSize() == query.getResultList().size()
3.2) Query with criteria
{code}
Criteria criteria = s.createCriteria( Book.class
).createCriteria('isbn').add(Restrictions.like('XXXXXX'))
Query q = s.createFullTextQuery( luceneQuery ).setCriteriaQuery( criteria );
{code}
In this case, the result is different:
{code}
query.getResultSize() != query.getResultList().size()
{code}
Actually, query.getResultSize() exactly returns the number of Book contained in my
Book's table. (select count(*) from Book;) without taking in consideration my
criteria.
I don't known if it's really a bug either it's the expected behaviour.
When inspecting the org.hibernate.search.query.engine.impl.HSQueryImpl java class, I
realized that
{code}
QueryHits queryHits = getQueryHits( searcher, 0 ) :
{code}
- 3.1) Takes in charge my keyword
- 3.2) Doesn't seem to use my criteria
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:58 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-753) fullTextQuery.getResultList().size() != fullTextQuery.getResultSize() when using criteria
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753?pag...
]
Sanne Grinovero commented on HSEARCH-753:
-----------------------------------------
Hi Mathieu,
sorry it's not supported to mix Criteria restrictions and fullText restrictions
(there's a warning in the docs.. I'm thinking we should highlight that more).
What's the luceneQuery you're running in 3.2 ? from the result it looks like
you're running a MatchAllDocsQuery.
fullTextQuery.getResultList().size() != fullTextQuery.getResultSize()
when using criteria
-----------------------------------------------------------------------------------------
Key: HSEARCH-753
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753
Project: Hibernate Search
Issue Type: Bug
Components: query
Affects Versions: 3.4.0.Final
Environment: hibernate 3.6.4.Final / postgresSQL
Reporter: Mathieu Perez
1) My indexes are up-to-date and optimised
2) I'm aware about this part of documentation: "Like Google, the number of
results is approximative if the index is not fully up-to-date with the database
(asynchronous cluster for example)."
3) Two types of queries:
3.1) Query with "keyword" (or
"below"/"above"/"fromTo")
{code}
QueryBuilder qb = fullTextSession.getSearchFactory().buildQueryBuilder().forEntity(
Book.class ).get();
org.apache.lucene.search.Query query = qb
.keyword()
.onFields("title", "subtitle", "authors.name",
"publicationDate")
.matching("Java rocks!");
.createQuery();
{code}
In this case, I don't meet any problem:
query.getResultSize() == query.getResultList().size()
3.2) Query with criteria
{code}
Criteria criteria = s.createCriteria( Book.class
).createCriteria('isbn').add(Restrictions.like('XXXXXX'))
Query q = s.createFullTextQuery( luceneQuery ).setCriteriaQuery( criteria );
{code}
In this case, the result is different:
{code}
query.getResultSize() != query.getResultList().size()
{code}
Actually, query.getResultSize() exactly returns the number of Book contained in my
Book's table. (select count(*) from Book;) without taking in consideration my
criteria.
I don't known if it's really a bug either it's the expected behaviour.
When inspecting the org.hibernate.search.query.engine.impl.HSQueryImpl java class, I
realized that
{code}
QueryHits queryHits = getQueryHits( searcher, 0 ) :
{code}
- 3.1) Takes in charge my keyword
- 3.2) Doesn't seem to use my criteria
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:16 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-753) fullTextQuery.getResultList().size() != fullTextQuery.getResultSize() when using criteria
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753?pag...
]
Mathieu Perez commented on HSEARCH-753:
---------------------------------------
Hi Sanne,
Thanks for your answer.
I didn't find any mention of this in the documentation. I'll read it again.
Yes, I'm running a MatchAllDocsQuery. If it's not supported, I understand why the
method returns the total.
fullTextQuery.getResultList().size() != fullTextQuery.getResultSize()
when using criteria
-----------------------------------------------------------------------------------------
Key: HSEARCH-753
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753
Project: Hibernate Search
Issue Type: Bug
Components: query
Affects Versions: 3.4.0.Final
Environment: hibernate 3.6.4.Final / postgresSQL
Reporter: Mathieu Perez
1) My indexes are up-to-date and optimised
2) I'm aware about this part of documentation: "Like Google, the number of
results is approximative if the index is not fully up-to-date with the database
(asynchronous cluster for example)."
3) Two types of queries:
3.1) Query with "keyword" (or
"below"/"above"/"fromTo")
{code}
QueryBuilder qb = fullTextSession.getSearchFactory().buildQueryBuilder().forEntity(
Book.class ).get();
org.apache.lucene.search.Query query = qb
.keyword()
.onFields("title", "subtitle", "authors.name",
"publicationDate")
.matching("Java rocks!");
.createQuery();
{code}
In this case, I don't meet any problem:
query.getResultSize() == query.getResultList().size()
3.2) Query with criteria
{code}
Criteria criteria = s.createCriteria( Book.class
).createCriteria('isbn').add(Restrictions.like('XXXXXX'))
Query q = s.createFullTextQuery( luceneQuery ).setCriteriaQuery( criteria );
{code}
In this case, the result is different:
{code}
query.getResultSize() != query.getResultList().size()
{code}
Actually, query.getResultSize() exactly returns the number of Book contained in my
Book's table. (select count(*) from Book;) without taking in consideration my
criteria.
I don't known if it's really a bug either it's the expected behaviour.
When inspecting the org.hibernate.search.query.engine.impl.HSQueryImpl java class, I
realized that
{code}
QueryHits queryHits = getQueryHits( searcher, 0 ) :
{code}
- 3.1) Takes in charge my keyword
- 3.2) Doesn't seem to use my criteria
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:48 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-753) fullTextQuery.getResultList().size() != fullTextQuery.getResultSize() when using criteria
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753?pag...
]
Sanne Grinovero commented on HSEARCH-753:
-----------------------------------------
On [http://docs.jboss.org/hibernate/stable/search/reference/en-US/html_single/], paragraph
_5.1.3.4. Fetching strategy_ there's an "important" blue box highligthing
this text:
??Only fetch mode can be adjusted, refrain from applying any other restriction.??
I guess we need to be more explicit, and the method name was not the best.
fullTextQuery.getResultList().size() != fullTextQuery.getResultSize()
when using criteria
-----------------------------------------------------------------------------------------
Key: HSEARCH-753
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753
Project: Hibernate Search
Issue Type: Bug
Components: query
Affects Versions: 3.4.0.Final
Environment: hibernate 3.6.4.Final / postgresSQL
Reporter: Mathieu Perez
1) My indexes are up-to-date and optimised
2) I'm aware about this part of documentation: "Like Google, the number of
results is approximative if the index is not fully up-to-date with the database
(asynchronous cluster for example)."
3) Two types of queries:
3.1) Query with "keyword" (or
"below"/"above"/"fromTo")
{code}
QueryBuilder qb = fullTextSession.getSearchFactory().buildQueryBuilder().forEntity(
Book.class ).get();
org.apache.lucene.search.Query query = qb
.keyword()
.onFields("title", "subtitle", "authors.name",
"publicationDate")
.matching("Java rocks!");
.createQuery();
{code}
In this case, I don't meet any problem:
query.getResultSize() == query.getResultList().size()
3.2) Query with criteria
{code}
Criteria criteria = s.createCriteria( Book.class
).createCriteria('isbn').add(Restrictions.like('XXXXXX'))
Query q = s.createFullTextQuery( luceneQuery ).setCriteriaQuery( criteria );
{code}
In this case, the result is different:
{code}
query.getResultSize() != query.getResultList().size()
{code}
Actually, query.getResultSize() exactly returns the number of Book contained in my
Book's table. (select count(*) from Book;) without taking in consideration my
criteria.
I don't known if it's really a bug either it's the expected behaviour.
When inspecting the org.hibernate.search.query.engine.impl.HSQueryImpl java class, I
realized that
{code}
QueryHits queryHits = getQueryHits( searcher, 0 ) :
{code}
- 3.1) Takes in charge my keyword
- 3.2) Doesn't seem to use my criteria
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-753) fullTextQuery.getResultList().size() != fullTextQuery.getResultSize() when using criteria
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753?pag...
]
Mathieu Perez commented on HSEARCH-753:
---------------------------------------
You're right, I read it just after posting my previous comment.
I also read in the javadoc "No where restriction can be defined either".
However, I see I can use where restrictions : data returned by getResultList() seem
correct, am I wrong? The only problem seems the getResultSize() method.
fullTextQuery.getResultList().size() != fullTextQuery.getResultSize()
when using criteria
-----------------------------------------------------------------------------------------
Key: HSEARCH-753
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753
Project: Hibernate Search
Issue Type: Bug
Components: query
Affects Versions: 3.4.0.Final
Environment: hibernate 3.6.4.Final / postgresSQL
Reporter: Mathieu Perez
1) My indexes are up-to-date and optimised
2) I'm aware about this part of documentation: "Like Google, the number of
results is approximative if the index is not fully up-to-date with the database
(asynchronous cluster for example)."
3) Two types of queries:
3.1) Query with "keyword" (or
"below"/"above"/"fromTo")
{code}
QueryBuilder qb = fullTextSession.getSearchFactory().buildQueryBuilder().forEntity(
Book.class ).get();
org.apache.lucene.search.Query query = qb
.keyword()
.onFields("title", "subtitle", "authors.name",
"publicationDate")
.matching("Java rocks!");
.createQuery();
{code}
In this case, I don't meet any problem:
query.getResultSize() == query.getResultList().size()
3.2) Query with criteria
{code}
Criteria criteria = s.createCriteria( Book.class
).createCriteria('isbn').add(Restrictions.like('XXXXXX'))
Query q = s.createFullTextQuery( luceneQuery ).setCriteriaQuery( criteria );
{code}
In this case, the result is different:
{code}
query.getResultSize() != query.getResultList().size()
{code}
Actually, query.getResultSize() exactly returns the number of Book contained in my
Book's table. (select count(*) from Book;) without taking in consideration my
criteria.
I don't known if it's really a bug either it's the expected behaviour.
When inspecting the org.hibernate.search.query.engine.impl.HSQueryImpl java class, I
realized that
{code}
QueryHits queryHits = getQueryHits( searcher, 0 ) :
{code}
- 3.1) Takes in charge my keyword
- 3.2) Doesn't seem to use my criteria
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:44 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-753) fullTextQuery.getResultList().size() != fullTextQuery.getResultSize() when using criteria
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753?pag...
]
Sanne Grinovero commented on HSEARCH-753:
-----------------------------------------
that's unexpected but interesting as you're not the first to ask for this
functionality.
Should be useful but was not intentional.. maybe due to some other recent change; would
you like to contribute some unit tests to verify this? In that case we could stop saying
it's not supported, and discuss if we should fix the getResultSize()
fullTextQuery.getResultList().size() != fullTextQuery.getResultSize()
when using criteria
-----------------------------------------------------------------------------------------
Key: HSEARCH-753
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753
Project: Hibernate Search
Issue Type: Bug
Components: query
Affects Versions: 3.4.0.Final
Environment: hibernate 3.6.4.Final / postgresSQL
Reporter: Mathieu Perez
1) My indexes are up-to-date and optimised
2) I'm aware about this part of documentation: "Like Google, the number of
results is approximative if the index is not fully up-to-date with the database
(asynchronous cluster for example)."
3) Two types of queries:
3.1) Query with "keyword" (or
"below"/"above"/"fromTo")
{code}
QueryBuilder qb = fullTextSession.getSearchFactory().buildQueryBuilder().forEntity(
Book.class ).get();
org.apache.lucene.search.Query query = qb
.keyword()
.onFields("title", "subtitle", "authors.name",
"publicationDate")
.matching("Java rocks!");
.createQuery();
{code}
In this case, I don't meet any problem:
query.getResultSize() == query.getResultList().size()
3.2) Query with criteria
{code}
Criteria criteria = s.createCriteria( Book.class
).createCriteria('isbn').add(Restrictions.like('XXXXXX'))
Query q = s.createFullTextQuery( luceneQuery ).setCriteriaQuery( criteria );
{code}
In this case, the result is different:
{code}
query.getResultSize() != query.getResultList().size()
{code}
Actually, query.getResultSize() exactly returns the number of Book contained in my
Book's table. (select count(*) from Book;) without taking in consideration my
criteria.
I don't known if it's really a bug either it's the expected behaviour.
When inspecting the org.hibernate.search.query.engine.impl.HSQueryImpl java class, I
realized that
{code}
QueryHits queryHits = getQueryHits( searcher, 0 ) :
{code}
- 3.1) Takes in charge my keyword
- 3.2) Doesn't seem to use my criteria
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:01 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-753) fullTextQuery.getResultList().size() != fullTextQuery.getResultSize() when using criteria
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753?pag...
]
Mathieu Perez commented on HSEARCH-753:
---------------------------------------
I prepare a test which will illustrate this.
fullTextQuery.getResultList().size() != fullTextQuery.getResultSize()
when using criteria
-----------------------------------------------------------------------------------------
Key: HSEARCH-753
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753
Project: Hibernate Search
Issue Type: Bug
Components: query
Affects Versions: 3.4.0.Final
Environment: hibernate 3.6.4.Final / postgresSQL
Reporter: Mathieu Perez
1) My indexes are up-to-date and optimised
2) I'm aware about this part of documentation: "Like Google, the number of
results is approximative if the index is not fully up-to-date with the database
(asynchronous cluster for example)."
3) Two types of queries:
3.1) Query with "keyword" (or
"below"/"above"/"fromTo")
{code}
QueryBuilder qb = fullTextSession.getSearchFactory().buildQueryBuilder().forEntity(
Book.class ).get();
org.apache.lucene.search.Query query = qb
.keyword()
.onFields("title", "subtitle", "authors.name",
"publicationDate")
.matching("Java rocks!");
.createQuery();
{code}
In this case, I don't meet any problem:
query.getResultSize() == query.getResultList().size()
3.2) Query with criteria
{code}
Criteria criteria = s.createCriteria( Book.class
).createCriteria('isbn').add(Restrictions.like('XXXXXX'))
Query q = s.createFullTextQuery( luceneQuery ).setCriteriaQuery( criteria );
{code}
In this case, the result is different:
{code}
query.getResultSize() != query.getResultList().size()
{code}
Actually, query.getResultSize() exactly returns the number of Book contained in my
Book's table. (select count(*) from Book;) without taking in consideration my
criteria.
I don't known if it's really a bug either it's the expected behaviour.
When inspecting the org.hibernate.search.query.engine.impl.HSQueryImpl java class, I
realized that
{code}
QueryHits queryHits = getQueryHits( searcher, 0 ) :
{code}
- 3.1) Takes in charge my keyword
- 3.2) Doesn't seem to use my criteria
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:22 a.m.
New subject: [Hibernate-JIRA] Updated: (HSEARCH-753) fullTextQuery.getResultList().size() != fullTextQuery.getResultSize() when using criteria
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753?pag...
]
Julie Ingignoli updated HSEARCH-753:
------------------------------------
Attachment: Tractor.java
ResultSizeOnCriteria.java
This is a unit test showing that getResultList is correct but not getResultSize() (it
return all the object matching the query without consider criteria)
fullTextQuery.getResultList().size() != fullTextQuery.getResultSize()
when using criteria
-----------------------------------------------------------------------------------------
Key: HSEARCH-753
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753
Project: Hibernate Search
Issue Type: Bug
Components: query
Affects Versions: 3.4.0.Final
Environment: hibernate 3.6.4.Final / postgresSQL
Reporter: Mathieu Perez
Attachments: ResultSizeOnCriteria.java, Tractor.java
1) My indexes are up-to-date and optimised
2) I'm aware about this part of documentation: "Like Google, the number of
results is approximative if the index is not fully up-to-date with the database
(asynchronous cluster for example)."
3) Two types of queries:
3.1) Query with "keyword" (or
"below"/"above"/"fromTo")
{code}
QueryBuilder qb = fullTextSession.getSearchFactory().buildQueryBuilder().forEntity(
Book.class ).get();
org.apache.lucene.search.Query query = qb
.keyword()
.onFields("title", "subtitle", "authors.name",
"publicationDate")
.matching("Java rocks!");
.createQuery();
{code}
In this case, I don't meet any problem:
query.getResultSize() == query.getResultList().size()
3.2) Query with criteria
{code}
Criteria criteria = s.createCriteria( Book.class
).createCriteria('isbn').add(Restrictions.like('XXXXXX'))
Query q = s.createFullTextQuery( luceneQuery ).setCriteriaQuery( criteria );
{code}
In this case, the result is different:
{code}
query.getResultSize() != query.getResultList().size()
{code}
Actually, query.getResultSize() exactly returns the number of Book contained in my
Book's table. (select count(*) from Book;) without taking in consideration my
criteria.
I don't known if it's really a bug either it's the expected behaviour.
When inspecting the org.hibernate.search.query.engine.impl.HSQueryImpl java class, I
realized that
{code}
QueryHits queryHits = getQueryHits( searcher, 0 ) :
{code}
- 3.1) Takes in charge my keyword
- 3.2) Doesn't seem to use my criteria
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:01 a.m.
New subject: [Hibernate-JIRA] Updated: (HSEARCH-753) fullTextQuery.getResultList().size() != fullTextQuery.getResultSize() when using criteria
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753?pag...
]
Emmanuel Bernard updated HSEARCH-753:
-------------------------------------
Fix Version/s: 4.0.0.Alpha1
fullTextQuery.getResultList().size() != fullTextQuery.getResultSize()
when using criteria
-----------------------------------------------------------------------------------------
Key: HSEARCH-753
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753
Project: Hibernate Search
Issue Type: Bug
Components: query
Affects Versions: 3.4.0.Final
Environment: hibernate 3.6.4.Final / postgresSQL
Reporter: Mathieu Perez
Fix For: 4.0.0.Alpha1
Attachments: ResultSizeOnCriteria.java, Tractor.java
1) My indexes are up-to-date and optimised
2) I'm aware about this part of documentation: "Like Google, the number of
results is approximative if the index is not fully up-to-date with the database
(asynchronous cluster for example)."
3) Two types of queries:
3.1) Query with "keyword" (or
"below"/"above"/"fromTo")
{code}
QueryBuilder qb = fullTextSession.getSearchFactory().buildQueryBuilder().forEntity(
Book.class ).get();
org.apache.lucene.search.Query query = qb
.keyword()
.onFields("title", "subtitle", "authors.name",
"publicationDate")
.matching("Java rocks!");
.createQuery();
{code}
In this case, I don't meet any problem:
query.getResultSize() == query.getResultList().size()
3.2) Query with criteria
{code}
Criteria criteria = s.createCriteria( Book.class
).createCriteria('isbn').add(Restrictions.like('XXXXXX'))
Query q = s.createFullTextQuery( luceneQuery ).setCriteriaQuery( criteria );
{code}
In this case, the result is different:
{code}
query.getResultSize() != query.getResultList().size()
{code}
Actually, query.getResultSize() exactly returns the number of Book contained in my
Book's table. (select count(*) from Book;) without taking in consideration my
criteria.
I don't known if it's really a bug either it's the expected behaviour.
When inspecting the org.hibernate.search.query.engine.impl.HSQueryImpl java class, I
realized that
{code}
QueryHits queryHits = getQueryHits( searcher, 0 ) :
{code}
- 3.1) Takes in charge my keyword
- 3.2) Doesn't seem to use my criteria
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:07 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-753) fullTextQuery.getResultList().size() != fullTextQuery.getResultSize() when using criteria
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753?pag...
]
Emmanuel Bernard commented on HSEARCH-753:
------------------------------------------
The major risk was that we could return null elements in a the getResultList() instead of
properly filtering results. If that has truly changed then we can:
* adjust the documentation still no recommending such use but letting people know that it
works ok except for getResultSize()
* we might even think about raising a exception when people use getResultSize on a
criteria with where clauses
fullTextQuery.getResultList().size() != fullTextQuery.getResultSize()
when using criteria
-----------------------------------------------------------------------------------------
Key: HSEARCH-753
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753
Project: Hibernate Search
Issue Type: Bug
Components: query
Affects Versions: 3.4.0.Final
Environment: hibernate 3.6.4.Final / postgresSQL
Reporter: Mathieu Perez
Fix For: 4.0.0.Alpha1
Attachments: ResultSizeOnCriteria.java, Tractor.java
1) My indexes are up-to-date and optimised
2) I'm aware about this part of documentation: "Like Google, the number of
results is approximative if the index is not fully up-to-date with the database
(asynchronous cluster for example)."
3) Two types of queries:
3.1) Query with "keyword" (or
"below"/"above"/"fromTo")
{code}
QueryBuilder qb = fullTextSession.getSearchFactory().buildQueryBuilder().forEntity(
Book.class ).get();
org.apache.lucene.search.Query query = qb
.keyword()
.onFields("title", "subtitle", "authors.name",
"publicationDate")
.matching("Java rocks!");
.createQuery();
{code}
In this case, I don't meet any problem:
query.getResultSize() == query.getResultList().size()
3.2) Query with criteria
{code}
Criteria criteria = s.createCriteria( Book.class
).createCriteria('isbn').add(Restrictions.like('XXXXXX'))
Query q = s.createFullTextQuery( luceneQuery ).setCriteriaQuery( criteria );
{code}
In this case, the result is different:
{code}
query.getResultSize() != query.getResultList().size()
{code}
Actually, query.getResultSize() exactly returns the number of Book contained in my
Book's table. (select count(*) from Book;) without taking in consideration my
criteria.
I don't known if it's really a bug either it's the expected behaviour.
When inspecting the org.hibernate.search.query.engine.impl.HSQueryImpl java class, I
realized that
{code}
QueryHits queryHits = getQueryHits( searcher, 0 ) :
{code}
- 3.1) Takes in charge my keyword
- 3.2) Doesn't seem to use my criteria
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:13 a.m.
New subject: [Hibernate-JIRA] Issue Comment Edited: (HSEARCH-753) fullTextQuery.getResultList().size() != fullTextQuery.getResultSize() when using criteria
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753?pag...
]
Emmanuel Bernard edited comment on HSEARCH-753 at 6/20/11 4:12 AM:
-------------------------------------------------------------------
The major risk was that we could return null elements in a the getResultList() instead of
properly filtering results. If that has truly changed then we can:
* adjust the documentation still no recommending such use but letting people know that it
works ok except for getResultSize()
* we might even think about:
** raising a exception when people use getResultSize on a criteria with where clauses AND
firstResult / maxResult is used
** return getResultList().size() if firstResult / maxResult is not used (that is
problematic though as it's way more costly than a Lucene size => probably not the
right thing to do
was (Author: emmanuel):
The major risk was that we could return null elements in a the getResultList() instead
of properly filtering results. If that has truly changed then we can:
* adjust the documentation still no recommending such use but letting people know that it
works ok except for getResultSize()
* we might even think about raising a exception when people use getResultSize on a
criteria with where clauses
fullTextQuery.getResultList().size() != fullTextQuery.getResultSize()
when using criteria
-----------------------------------------------------------------------------------------
Key: HSEARCH-753
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753
Project: Hibernate Search
Issue Type: Bug
Components: query
Affects Versions: 3.4.0.Final
Environment: hibernate 3.6.4.Final / postgresSQL
Reporter: Mathieu Perez
Fix For: 4.0.0.Alpha1
Attachments: ResultSizeOnCriteria.java, Tractor.java
1) My indexes are up-to-date and optimised
2) I'm aware about this part of documentation: "Like Google, the number of
results is approximative if the index is not fully up-to-date with the database
(asynchronous cluster for example)."
3) Two types of queries:
3.1) Query with "keyword" (or
"below"/"above"/"fromTo")
{code}
QueryBuilder qb = fullTextSession.getSearchFactory().buildQueryBuilder().forEntity(
Book.class ).get();
org.apache.lucene.search.Query query = qb
.keyword()
.onFields("title", "subtitle", "authors.name",
"publicationDate")
.matching("Java rocks!");
.createQuery();
{code}
In this case, I don't meet any problem:
query.getResultSize() == query.getResultList().size()
3.2) Query with criteria
{code}
Criteria criteria = s.createCriteria( Book.class
).createCriteria('isbn').add(Restrictions.like('XXXXXX'))
Query q = s.createFullTextQuery( luceneQuery ).setCriteriaQuery( criteria );
{code}
In this case, the result is different:
{code}
query.getResultSize() != query.getResultList().size()
{code}
Actually, query.getResultSize() exactly returns the number of Book contained in my
Book's table. (select count(*) from Book;) without taking in consideration my
criteria.
I don't known if it's really a bug either it's the expected behaviour.
When inspecting the org.hibernate.search.query.engine.impl.HSQueryImpl java class, I
realized that
{code}
QueryHits queryHits = getQueryHits( searcher, 0 ) :
{code}
- 3.1) Takes in charge my keyword
- 3.2) Doesn't seem to use my criteria
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:03 a.m.
New subject: [Hibernate-JIRA] Assigned: (HSEARCH-753) fullTextQuery.getResultList().size() != fullTextQuery.getResultSize() when using criteria
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753?pag...
]
Sanne Grinovero reassigned HSEARCH-753:
---------------------------------------
Assignee: Emmanuel Bernard
Seems you have it quite clear how you want this to be implemented.
fullTextQuery.getResultList().size() != fullTextQuery.getResultSize()
when using criteria
-----------------------------------------------------------------------------------------
Key: HSEARCH-753
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753
Project: Hibernate Search
Issue Type: Bug
Components: query
Affects Versions: 3.4.0.Final
Environment: hibernate 3.6.4.Final / postgresSQL
Reporter: Mathieu Perez
Assignee: Emmanuel Bernard
Fix For: 4.0.0.Alpha1
Attachments: ResultSizeOnCriteria.java, Tractor.java
1) My indexes are up-to-date and optimised
2) I'm aware about this part of documentation: "Like Google, the number of
results is approximative if the index is not fully up-to-date with the database
(asynchronous cluster for example)."
3) Two types of queries:
3.1) Query with "keyword" (or
"below"/"above"/"fromTo")
{code}
QueryBuilder qb = fullTextSession.getSearchFactory().buildQueryBuilder().forEntity(
Book.class ).get();
org.apache.lucene.search.Query query = qb
.keyword()
.onFields("title", "subtitle", "authors.name",
"publicationDate")
.matching("Java rocks!");
.createQuery();
{code}
In this case, I don't meet any problem:
query.getResultSize() == query.getResultList().size()
3.2) Query with criteria
{code}
Criteria criteria = s.createCriteria( Book.class
).createCriteria('isbn').add(Restrictions.like('XXXXXX'))
Query q = s.createFullTextQuery( luceneQuery ).setCriteriaQuery( criteria );
{code}
In this case, the result is different:
{code}
query.getResultSize() != query.getResultList().size()
{code}
Actually, query.getResultSize() exactly returns the number of Book contained in my
Book's table. (select count(*) from Book;) without taking in consideration my
criteria.
I don't known if it's really a bug either it's the expected behaviour.
When inspecting the org.hibernate.search.query.engine.impl.HSQueryImpl java class, I
realized that
{code}
QueryHits queryHits = getQueryHits( searcher, 0 ) :
{code}
- 3.1) Takes in charge my keyword
- 3.2) Doesn't seem to use my criteria
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:29 p.m.
New subject: [Hibernate-JIRA] Updated: (HSEARCH-753) fullTextQuery.getResultList().size() != fullTextQuery.getResultSize() when using criteria
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753?pag...
]
Sanne Grinovero updated HSEARCH-753:
------------------------------------
Fix Version/s: (was: 4.0.0.Alpha1)
4.0.0.Alpha2
fullTextQuery.getResultList().size() != fullTextQuery.getResultSize()
when using criteria
-----------------------------------------------------------------------------------------
Key: HSEARCH-753
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753
Project: Hibernate Search
Issue Type: Bug
Components: query
Affects Versions: 3.4.0.Final
Environment: hibernate 3.6.4.Final / postgresSQL
Reporter: Mathieu Perez
Assignee: Emmanuel Bernard
Fix For: 4.0.0.Alpha2
Attachments: ResultSizeOnCriteria.java, Tractor.java
1) My indexes are up-to-date and optimised
2) I'm aware about this part of documentation: "Like Google, the number of
results is approximative if the index is not fully up-to-date with the database
(asynchronous cluster for example)."
3) Two types of queries:
3.1) Query with "keyword" (or
"below"/"above"/"fromTo")
{code}
QueryBuilder qb = fullTextSession.getSearchFactory().buildQueryBuilder().forEntity(
Book.class ).get();
org.apache.lucene.search.Query query = qb
.keyword()
.onFields("title", "subtitle", "authors.name",
"publicationDate")
.matching("Java rocks!");
.createQuery();
{code}
In this case, I don't meet any problem:
query.getResultSize() == query.getResultList().size()
3.2) Query with criteria
{code}
Criteria criteria = s.createCriteria( Book.class
).createCriteria('isbn').add(Restrictions.like('XXXXXX'))
Query q = s.createFullTextQuery( luceneQuery ).setCriteriaQuery( criteria );
{code}
In this case, the result is different:
{code}
query.getResultSize() != query.getResultList().size()
{code}
Actually, query.getResultSize() exactly returns the number of Book contained in my
Book's table. (select count(*) from Book;) without taking in consideration my
criteria.
I don't known if it's really a bug either it's the expected behaviour.
When inspecting the org.hibernate.search.query.engine.impl.HSQueryImpl java class, I
realized that
{code}
QueryHits queryHits = getQueryHits( searcher, 0 ) :
{code}
- 3.1) Takes in charge my keyword
- 3.2) Doesn't seem to use my criteria
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:27 a.m.
New subject: [Hibernate-JIRA] Updated: (HSEARCH-753) Raise exception when there is a risk of having fullTextQuery.getResultList().size() != fullTextQuery.getResultSize()
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753?pag...
]
Emmanuel Bernard updated HSEARCH-753:
-------------------------------------
Summary: Raise exception when there is a risk of having
fullTextQuery.getResultList().size() != fullTextQuery.getResultSize() (was:
fullTextQuery.getResultList().size() != fullTextQuery.getResultSize() when using
criteria)
Raise exception when there is a risk of having
fullTextQuery.getResultList().size() != fullTextQuery.getResultSize()
--------------------------------------------------------------------------------------------------------------------
Key: HSEARCH-753
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753
Project: Hibernate Search
Issue Type: Bug
Components: query
Affects Versions: 3.4.0.Final
Environment: hibernate 3.6.4.Final / postgresSQL
Reporter: Mathieu Perez
Assignee: Emmanuel Bernard
Fix For: 4.0.0.Alpha2
Attachments: ResultSizeOnCriteria.java, Tractor.java
1) My indexes are up-to-date and optimised
2) I'm aware about this part of documentation: "Like Google, the number of
results is approximative if the index is not fully up-to-date with the database
(asynchronous cluster for example)."
3) Two types of queries:
3.1) Query with "keyword" (or
"below"/"above"/"fromTo")
{code}
QueryBuilder qb = fullTextSession.getSearchFactory().buildQueryBuilder().forEntity(
Book.class ).get();
org.apache.lucene.search.Query query = qb
.keyword()
.onFields("title", "subtitle", "authors.name",
"publicationDate")
.matching("Java rocks!");
.createQuery();
{code}
In this case, I don't meet any problem:
query.getResultSize() == query.getResultList().size()
3.2) Query with criteria
{code}
Criteria criteria = s.createCriteria( Book.class
).createCriteria('isbn').add(Restrictions.like('XXXXXX'))
Query q = s.createFullTextQuery( luceneQuery ).setCriteriaQuery( criteria );
{code}
In this case, the result is different:
{code}
query.getResultSize() != query.getResultList().size()
{code}
Actually, query.getResultSize() exactly returns the number of Book contained in my
Book's table. (select count(*) from Book;) without taking in consideration my
criteria.
I don't known if it's really a bug either it's the expected behaviour.
When inspecting the org.hibernate.search.query.engine.impl.HSQueryImpl java class, I
realized that
{code}
QueryHits queryHits = getQueryHits( searcher, 0 ) :
{code}
- 3.1) Takes in charge my keyword
- 3.2) Doesn't seem to use my criteria
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:29 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-753) Raise exception when there is a risk of having fullTextQuery.getResultList().size() != fullTextQuery.getResultSize()
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753?pag...
]
Emmanuel Bernard commented on HSEARCH-753:
------------------------------------------
Thank you Mathieu and Julie. I have used your unit test and decided to raise an exception
if a Criteria query with restriction is used in conjunction with getResultSize()
Raise exception when there is a risk of having
fullTextQuery.getResultList().size() != fullTextQuery.getResultSize()
--------------------------------------------------------------------------------------------------------------------
Key: HSEARCH-753
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753
Project: Hibernate Search
Issue Type: Bug
Components: query
Affects Versions: 3.4.0.Final
Environment: hibernate 3.6.4.Final / postgresSQL
Reporter: Mathieu Perez
Assignee: Emmanuel Bernard
Fix For: 4.0.0.Alpha2
Attachments: ResultSizeOnCriteria.java, Tractor.java
1) My indexes are up-to-date and optimised
2) I'm aware about this part of documentation: "Like Google, the number of
results is approximative if the index is not fully up-to-date with the database
(asynchronous cluster for example)."
3) Two types of queries:
3.1) Query with "keyword" (or
"below"/"above"/"fromTo")
{code}
QueryBuilder qb = fullTextSession.getSearchFactory().buildQueryBuilder().forEntity(
Book.class ).get();
org.apache.lucene.search.Query query = qb
.keyword()
.onFields("title", "subtitle", "authors.name",
"publicationDate")
.matching("Java rocks!");
.createQuery();
{code}
In this case, I don't meet any problem:
query.getResultSize() == query.getResultList().size()
3.2) Query with criteria
{code}
Criteria criteria = s.createCriteria( Book.class
).createCriteria('isbn').add(Restrictions.like('XXXXXX'))
Query q = s.createFullTextQuery( luceneQuery ).setCriteriaQuery( criteria );
{code}
In this case, the result is different:
{code}
query.getResultSize() != query.getResultList().size()
{code}
Actually, query.getResultSize() exactly returns the number of Book contained in my
Book's table. (select count(*) from Book;) without taking in consideration my
criteria.
I don't known if it's really a bug either it's the expected behaviour.
When inspecting the org.hibernate.search.query.engine.impl.HSQueryImpl java class, I
realized that
{code}
QueryHits queryHits = getQueryHits( searcher, 0 ) :
{code}
- 3.1) Takes in charge my keyword
- 3.2) Doesn't seem to use my criteria
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:54 p.m.
New subject: [Hibernate-JIRA] Resolved: (HSEARCH-753) Raise exception when there is a risk of having fullTextQuery.getResultList().size() != fullTextQuery.getResultSize()
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753?pag...
]
Sanne Grinovero resolved HSEARCH-753.
-------------------------------------
Resolution: Fixed
Raise exception when there is a risk of having
fullTextQuery.getResultList().size() != fullTextQuery.getResultSize()
--------------------------------------------------------------------------------------------------------------------
Key: HSEARCH-753
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753
Project: Hibernate Search
Issue Type: Bug
Components: query
Affects Versions: 3.4.0.Final
Environment: hibernate 3.6.4.Final / postgresSQL
Reporter: Mathieu Perez
Assignee: Emmanuel Bernard
Fix For: 4.0.0.Alpha2
Attachments: ResultSizeOnCriteria.java, Tractor.java
1) My indexes are up-to-date and optimised
2) I'm aware about this part of documentation: "Like Google, the number of
results is approximative if the index is not fully up-to-date with the database
(asynchronous cluster for example)."
3) Two types of queries:
3.1) Query with "keyword" (or
"below"/"above"/"fromTo")
{code}
QueryBuilder qb = fullTextSession.getSearchFactory().buildQueryBuilder().forEntity(
Book.class ).get();
org.apache.lucene.search.Query query = qb
.keyword()
.onFields("title", "subtitle", "authors.name",
"publicationDate")
.matching("Java rocks!");
.createQuery();
{code}
In this case, I don't meet any problem:
query.getResultSize() == query.getResultList().size()
3.2) Query with criteria
{code}
Criteria criteria = s.createCriteria( Book.class
).createCriteria('isbn').add(Restrictions.like('XXXXXX'))
Query q = s.createFullTextQuery( luceneQuery ).setCriteriaQuery( criteria );
{code}
In this case, the result is different:
{code}
query.getResultSize() != query.getResultList().size()
{code}
Actually, query.getResultSize() exactly returns the number of Book contained in my
Book's table. (select count(*) from Book;) without taking in consideration my
criteria.
I don't known if it's really a bug either it's the expected behaviour.
When inspecting the org.hibernate.search.query.engine.impl.HSQueryImpl java class, I
realized that
{code}
QueryHits queryHits = getQueryHits( searcher, 0 ) :
{code}
- 3.1) Takes in charge my keyword
- 3.2) Doesn't seem to use my criteria
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4867
days inactive
4977
days old
hibernate-issues@lists.jboss.org
15 comments
4 participants
participants (4)
-
Emmanuel Bernard (JIRA) -
Julie Ingignoli (JIRA)
-
Mathieu Perez (JIRA)
-
Sanne Grinovero (JIRA)