[Hibernate-JIRA] Created: (HHH-4065) Incorrect SQL is used for HQL if the number of values for a filter collection parameter is changed
6:44 a.m.
Incorrect SQL is used for HQL if the number of values for a filter collection parameter is
changed
--------------------------------------------------------------------------------------------------
Key: HHH-4065
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065
Project: Hibernate Core
Issue Type: Bug
Components: query-hql
Affects Versions: 3.3.2
Environment: Hibernate 3.3.2
Reporter: Nicklas Nordborg
Attachments: trace.txt
I think that maybe the fix for HHH-530 has introduced a problem with filters that has a
collection-type parameter. If the number of parameters in that collection changes during
the lifetime of a SessionFactory the SQL that is used becomes incorrect and either has too
many or too few parameter placeholders (eg. '?') in the SQL. There was no problem
in Hibernate 3.3.1. A typical error message is:
java.sql.SQLException: Parameter index out of bounds. 2 is not between valid values of 1
and 1
Below is some pseudo-code that shows what happens when the number of values in a
collection is increased from 1 to 2. The 'memberOf' is a simple filter on the `id`
column: `id` IN (:items)
String hql = "select n from NewsData n";
List idList = new ArrayList();
idList.add(1);
Session s = .... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list();
// SQL: select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
s.close();
idList.add(2);
s = ... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list(); // <--- error here with 3.3.2 but works with 3.3.1
// SQL (3.3.2): select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
// SQL (3.3.1): select .... `News` newsdata0_ where newsdata0_.`id` IN (?, ?)
I am attaching a file with TRACE-level output from both Hibernate 3.3.2 and 3.3.1. The
relevant difference seems to be that in Hibernate 3.3.2 the query plan is cached with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (?)'
but in Hibernate 3.3.1 with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (:memberOf.items)'
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:47 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4065) Incorrect SQL is used for HQL if the number of values for a filter collection parameter is changed
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065?page=c...
]
Nicklas Nordborg commented on HHH-4065:
---------------------------------------
Since this is a rather pressing issue for me I made a very ugly hack that in practice
disables the query plan cache. This might not be a good idea in general but since there
are other fixes in 3.3.2 that I need more it is a price I am willing to pay. The hack uses
reflection to replace the 'private final SoftLimitMRUCache planCache' variable
used in the QueryPlanCache by a subclass that simply ignores everything that is added to
it. Here is the code for the hack. It needs to be executed once right after that session
factory has been created.
SessionFactory sf = ....
try
{
SessionFactoryImpl sfi = (SessionFactoryImpl)sf;
QueryPlanCache qpc = sfi.getQueryPlanCache();
Field pcf = QueryPlanCache.class.getDeclaredField("planCache");
pcf.setAccessible(true);
pcf.set(qpc,
new SoftLimitMRUCache()
{
private static final long serialVersionUID = -7082205080525320488L;
@Override
public Object put(Object key, Object value)
{
return null;
}
}
);
}
catch (Exception ex)
{
log.warn("Could not replace query plan cache in Hibernate", ex);
}
Incorrect SQL is used for HQL if the number of values for a filter
collection parameter is changed
--------------------------------------------------------------------------------------------------
Key: HHH-4065
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065
Project: Hibernate Core
Issue Type: Bug
Components: query-hql
Affects Versions: 3.3.2
Environment: Hibernate 3.3.2
Reporter: Nicklas Nordborg
Attachments: trace.txt
I think that maybe the fix for HHH-530 has introduced a problem with filters that has a
collection-type parameter. If the number of parameters in that collection changes during
the lifetime of a SessionFactory the SQL that is used becomes incorrect and either has too
many or too few parameter placeholders (eg. '?') in the SQL. There was no problem
in Hibernate 3.3.1. A typical error message is:
java.sql.SQLException: Parameter index out of bounds. 2 is not between valid values of 1
and 1
Below is some pseudo-code that shows what happens when the number of values in a
collection is increased from 1 to 2. The 'memberOf' is a simple filter on the `id`
column: `id` IN (:items)
String hql = "select n from NewsData n";
List idList = new ArrayList();
idList.add(1);
Session s = .... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list();
// SQL: select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
s.close();
idList.add(2);
s = ... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list(); // <--- error here with 3.3.2 but works with 3.3.1
// SQL (3.3.2): select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
// SQL (3.3.1): select .... `News` newsdata0_ where newsdata0_.`id` IN (?, ?)
I am attaching a file with TRACE-level output from both Hibernate 3.3.2 and 3.3.1. The
relevant difference seems to be that in Hibernate 3.3.2 the query plan is cached with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (?)'
but in Hibernate 3.3.1 with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (:memberOf.items)'
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:51 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-4065) Incorrect SQL is used for HQL if the number of values for a filter collection parameter is changed
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065?page=c...
]
Nicklas Nordborg updated HHH-4065:
----------------------------------
Attachment: org.hibernate.test.filter.DynamicFilterTest-output.txt
org.hibernate.test.filter.DynamicFilterTest.txt
org.hibernate.test.filter.DynamicFilterTest-patch.txt
Updated the test 'org.hibernate.test.filter.DynamicFilterTest' with a test case
that triggers the problem. I am not sure how to create a specific method for this so I
added the test to one of the existing methods.
I am also attaching the output files generated from the tests. The patch and tests were
executed against Hibernate 3.3.2.GA.
Incorrect SQL is used for HQL if the number of values for a filter
collection parameter is changed
--------------------------------------------------------------------------------------------------
Key: HHH-4065
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065
Project: Hibernate Core
Issue Type: Bug
Components: query-hql
Affects Versions: 3.3.2
Environment: Hibernate 3.3.2
Reporter: Nicklas Nordborg
Attachments: org.hibernate.test.filter.DynamicFilterTest-output.txt,
org.hibernate.test.filter.DynamicFilterTest-patch.txt,
org.hibernate.test.filter.DynamicFilterTest.txt, trace.txt
I think that maybe the fix for HHH-530 has introduced a problem with filters that has a
collection-type parameter. If the number of parameters in that collection changes during
the lifetime of a SessionFactory the SQL that is used becomes incorrect and either has too
many or too few parameter placeholders (eg. '?') in the SQL. There was no problem
in Hibernate 3.3.1. A typical error message is:
java.sql.SQLException: Parameter index out of bounds. 2 is not between valid values of 1
and 1
Below is some pseudo-code that shows what happens when the number of values in a
collection is increased from 1 to 2. The 'memberOf' is a simple filter on the `id`
column: `id` IN (:items)
String hql = "select n from NewsData n";
List idList = new ArrayList();
idList.add(1);
Session s = .... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list();
// SQL: select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
s.close();
idList.add(2);
s = ... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list(); // <--- error here with 3.3.2 but works with 3.3.1
// SQL (3.3.2): select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
// SQL (3.3.1): select .... `News` newsdata0_ where newsdata0_.`id` IN (?, ?)
I am attaching a file with TRACE-level output from both Hibernate 3.3.2 and 3.3.1. The
relevant difference seems to be that in Hibernate 3.3.2 the query plan is cached with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (?)'
but in Hibernate 3.3.1 with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (:memberOf.items)'
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:16 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4065) Incorrect SQL is used for HQL if the number of values for a filter collection parameter is changed
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065?page=c...
]
Steve Ebersole commented on HHH-4065:
-------------------------------------
Does this only happen on HQL queries in your experience?
Incorrect SQL is used for HQL if the number of values for a filter
collection parameter is changed
--------------------------------------------------------------------------------------------------
Key: HHH-4065
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065
Project: Hibernate Core
Issue Type: Bug
Components: query-hql
Affects Versions: 3.3.2
Environment: Hibernate 3.3.2
Reporter: Nicklas Nordborg
Attachments: org.hibernate.test.filter.DynamicFilterTest-output.txt,
org.hibernate.test.filter.DynamicFilterTest-patch.txt,
org.hibernate.test.filter.DynamicFilterTest.txt, trace.txt
I think that maybe the fix for HHH-530 has introduced a problem with filters that has a
collection-type parameter. If the number of parameters in that collection changes during
the lifetime of a SessionFactory the SQL that is used becomes incorrect and either has too
many or too few parameter placeholders (eg. '?') in the SQL. There was no problem
in Hibernate 3.3.1. A typical error message is:
java.sql.SQLException: Parameter index out of bounds. 2 is not between valid values of 1
and 1
Below is some pseudo-code that shows what happens when the number of values in a
collection is increased from 1 to 2. The 'memberOf' is a simple filter on the `id`
column: `id` IN (:items)
String hql = "select n from NewsData n";
List idList = new ArrayList();
idList.add(1);
Session s = .... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list();
// SQL: select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
s.close();
idList.add(2);
s = ... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list(); // <--- error here with 3.3.2 but works with 3.3.1
// SQL (3.3.2): select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
// SQL (3.3.1): select .... `News` newsdata0_ where newsdata0_.`id` IN (?, ?)
I am attaching a file with TRACE-level output from both Hibernate 3.3.2 and 3.3.1. The
relevant difference seems to be that in Hibernate 3.3.2 the query plan is cached with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (?)'
but in Hibernate 3.3.1 with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (:memberOf.items)'
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:16 p.m.
New subject: [Hibernate-JIRA] Assigned: (HHH-4065) Incorrect SQL is used for HQL if the number of values for a filter collection parameter is changed
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065?page=c...
]
Steve Ebersole reassigned HHH-4065:
-----------------------------------
Assignee: Steve Ebersole
Incorrect SQL is used for HQL if the number of values for a filter
collection parameter is changed
--------------------------------------------------------------------------------------------------
Key: HHH-4065
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065
Project: Hibernate Core
Issue Type: Bug
Components: query-hql
Affects Versions: 3.3.2
Environment: Hibernate 3.3.2
Reporter: Nicklas Nordborg
Assignee: Steve Ebersole
Attachments: org.hibernate.test.filter.DynamicFilterTest-output.txt,
org.hibernate.test.filter.DynamicFilterTest-patch.txt,
org.hibernate.test.filter.DynamicFilterTest.txt, trace.txt
I think that maybe the fix for HHH-530 has introduced a problem with filters that has a
collection-type parameter. If the number of parameters in that collection changes during
the lifetime of a SessionFactory the SQL that is used becomes incorrect and either has too
many or too few parameter placeholders (eg. '?') in the SQL. There was no problem
in Hibernate 3.3.1. A typical error message is:
java.sql.SQLException: Parameter index out of bounds. 2 is not between valid values of 1
and 1
Below is some pseudo-code that shows what happens when the number of values in a
collection is increased from 1 to 2. The 'memberOf' is a simple filter on the `id`
column: `id` IN (:items)
String hql = "select n from NewsData n";
List idList = new ArrayList();
idList.add(1);
Session s = .... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list();
// SQL: select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
s.close();
idList.add(2);
s = ... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list(); // <--- error here with 3.3.2 but works with 3.3.1
// SQL (3.3.2): select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
// SQL (3.3.1): select .... `News` newsdata0_ where newsdata0_.`id` IN (?, ?)
I am attaching a file with TRACE-level output from both Hibernate 3.3.2 and 3.3.1. The
relevant difference seems to be that in Hibernate 3.3.2 the query plan is cached with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (?)'
but in Hibernate 3.3.1 with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (:memberOf.items)'
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:46 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4065) Incorrect SQL is used for HQL if the number of values for a filter collection parameter is changed
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065?page=c...
]
Brian Blasko commented on HHH-4065:
-----------------------------------
We are also having this problem. In our tests, it only occurs with HQL. When using
Criteria, we are not seeing this issue. We are using 3.2.7GA
Incorrect SQL is used for HQL if the number of values for a filter
collection parameter is changed
--------------------------------------------------------------------------------------------------
Key: HHH-4065
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065
Project: Hibernate Core
Issue Type: Bug
Components: query-hql
Affects Versions: 3.3.2
Environment: Hibernate 3.3.2
Reporter: Nicklas Nordborg
Assignee: Steve Ebersole
Attachments: org.hibernate.test.filter.DynamicFilterTest-output.txt,
org.hibernate.test.filter.DynamicFilterTest-patch.txt,
org.hibernate.test.filter.DynamicFilterTest.txt, trace.txt
I think that maybe the fix for HHH-530 has introduced a problem with filters that has a
collection-type parameter. If the number of parameters in that collection changes during
the lifetime of a SessionFactory the SQL that is used becomes incorrect and either has too
many or too few parameter placeholders (eg. '?') in the SQL. There was no problem
in Hibernate 3.3.1. A typical error message is:
java.sql.SQLException: Parameter index out of bounds. 2 is not between valid values of 1
and 1
Below is some pseudo-code that shows what happens when the number of values in a
collection is increased from 1 to 2. The 'memberOf' is a simple filter on the `id`
column: `id` IN (:items)
String hql = "select n from NewsData n";
List idList = new ArrayList();
idList.add(1);
Session s = .... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list();
// SQL: select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
s.close();
idList.add(2);
s = ... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list(); // <--- error here with 3.3.2 but works with 3.3.1
// SQL (3.3.2): select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
// SQL (3.3.1): select .... `News` newsdata0_ where newsdata0_.`id` IN (?, ?)
I am attaching a file with TRACE-level output from both Hibernate 3.3.2 and 3.3.1. The
relevant difference seems to be that in Hibernate 3.3.2 the query plan is cached with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (?)'
but in Hibernate 3.3.1 with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (:memberOf.items)'
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:53 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-4065) Incorrect SQL is used for HQL if the number of values for a filter collection parameter is changed
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065?page=c...
]
Steve Ebersole updated HHH-4065:
--------------------------------
Fix Version/s: 3.5
3.3.x
Incorrect SQL is used for HQL if the number of values for a filter
collection parameter is changed
--------------------------------------------------------------------------------------------------
Key: HHH-4065
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065
Project: Hibernate Core
Issue Type: Bug
Components: query-hql
Affects Versions: 3.3.2
Environment: Hibernate 3.3.2
Reporter: Nicklas Nordborg
Assignee: Steve Ebersole
Fix For: 3.3.x, 3.5
Attachments: org.hibernate.test.filter.DynamicFilterTest-output.txt,
org.hibernate.test.filter.DynamicFilterTest-patch.txt,
org.hibernate.test.filter.DynamicFilterTest.txt, trace.txt
I think that maybe the fix for HHH-530 has introduced a problem with filters that has a
collection-type parameter. If the number of parameters in that collection changes during
the lifetime of a SessionFactory the SQL that is used becomes incorrect and either has too
many or too few parameter placeholders (eg. '?') in the SQL. There was no problem
in Hibernate 3.3.1. A typical error message is:
java.sql.SQLException: Parameter index out of bounds. 2 is not between valid values of 1
and 1
Below is some pseudo-code that shows what happens when the number of values in a
collection is increased from 1 to 2. The 'memberOf' is a simple filter on the `id`
column: `id` IN (:items)
String hql = "select n from NewsData n";
List idList = new ArrayList();
idList.add(1);
Session s = .... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list();
// SQL: select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
s.close();
idList.add(2);
s = ... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list(); // <--- error here with 3.3.2 but works with 3.3.1
// SQL (3.3.2): select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
// SQL (3.3.1): select .... `News` newsdata0_ where newsdata0_.`id` IN (?, ?)
I am attaching a file with TRACE-level output from both Hibernate 3.3.2 and 3.3.1. The
relevant difference seems to be that in Hibernate 3.3.2 the query plan is cached with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (?)'
but in Hibernate 3.3.1 with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (:memberOf.items)'
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:20 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4065) Incorrect SQL is used for HQL if the number of values for a filter collection parameter is changed
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065?page=c...
]
Nicklas Nordborg commented on HHH-4065:
---------------------------------------
We are only using HQL so I can't tell if this happens in other types of queries.
Incorrect SQL is used for HQL if the number of values for a filter
collection parameter is changed
--------------------------------------------------------------------------------------------------
Key: HHH-4065
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065
Project: Hibernate Core
Issue Type: Bug
Components: query-hql
Affects Versions: 3.3.2
Environment: Hibernate 3.3.2
Reporter: Nicklas Nordborg
Assignee: Steve Ebersole
Fix For: 3.3.x, 3.5
Attachments: org.hibernate.test.filter.DynamicFilterTest-output.txt,
org.hibernate.test.filter.DynamicFilterTest-patch.txt,
org.hibernate.test.filter.DynamicFilterTest.txt, trace.txt
I think that maybe the fix for HHH-530 has introduced a problem with filters that has a
collection-type parameter. If the number of parameters in that collection changes during
the lifetime of a SessionFactory the SQL that is used becomes incorrect and either has too
many or too few parameter placeholders (eg. '?') in the SQL. There was no problem
in Hibernate 3.3.1. A typical error message is:
java.sql.SQLException: Parameter index out of bounds. 2 is not between valid values of 1
and 1
Below is some pseudo-code that shows what happens when the number of values in a
collection is increased from 1 to 2. The 'memberOf' is a simple filter on the `id`
column: `id` IN (:items)
String hql = "select n from NewsData n";
List idList = new ArrayList();
idList.add(1);
Session s = .... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list();
// SQL: select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
s.close();
idList.add(2);
s = ... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list(); // <--- error here with 3.3.2 but works with 3.3.1
// SQL (3.3.2): select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
// SQL (3.3.1): select .... `News` newsdata0_ where newsdata0_.`id` IN (?, ?)
I am attaching a file with TRACE-level output from both Hibernate 3.3.2 and 3.3.1. The
relevant difference seems to be that in Hibernate 3.3.2 the query plan is cached with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (?)'
but in Hibernate 3.3.1 with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (:memberOf.items)'
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:37 p.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-4065) Incorrect SQL is used for HQL if the number of values for a filter collection parameter is changed
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065?page=c...
]
Steve Ebersole resolved HHH-4065.
---------------------------------
Resolution: Fixed
Committed fix on both Branch_3_3 and trunk. Could one of y'all verify it please?
Thanks.
Incorrect SQL is used for HQL if the number of values for a filter
collection parameter is changed
--------------------------------------------------------------------------------------------------
Key: HHH-4065
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065
Project: Hibernate Core
Issue Type: Bug
Components: query-hql
Affects Versions: 3.3.2
Environment: Hibernate 3.3.2
Reporter: Nicklas Nordborg
Assignee: Steve Ebersole
Fix For: 3.3.x, 3.5
Attachments: org.hibernate.test.filter.DynamicFilterTest-output.txt,
org.hibernate.test.filter.DynamicFilterTest-patch.txt,
org.hibernate.test.filter.DynamicFilterTest.txt, trace.txt
I think that maybe the fix for HHH-530 has introduced a problem with filters that has a
collection-type parameter. If the number of parameters in that collection changes during
the lifetime of a SessionFactory the SQL that is used becomes incorrect and either has too
many or too few parameter placeholders (eg. '?') in the SQL. There was no problem
in Hibernate 3.3.1. A typical error message is:
java.sql.SQLException: Parameter index out of bounds. 2 is not between valid values of 1
and 1
Below is some pseudo-code that shows what happens when the number of values in a
collection is increased from 1 to 2. The 'memberOf' is a simple filter on the `id`
column: `id` IN (:items)
String hql = "select n from NewsData n";
List idList = new ArrayList();
idList.add(1);
Session s = .... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list();
// SQL: select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
s.close();
idList.add(2);
s = ... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list(); // <--- error here with 3.3.2 but works with 3.3.1
// SQL (3.3.2): select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
// SQL (3.3.1): select .... `News` newsdata0_ where newsdata0_.`id` IN (?, ?)
I am attaching a file with TRACE-level output from both Hibernate 3.3.2 and 3.3.1. The
relevant difference seems to be that in Hibernate 3.3.2 the query plan is cached with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (?)'
but in Hibernate 3.3.1 with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (:memberOf.items)'
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:48 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4065) Incorrect SQL is used for HQL if the number of values for a filter collection parameter is changed
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065?page=c...
]
Nicklas Nordborg commented on HHH-4065:
---------------------------------------
I have tested against Branch_3_3. The DynamicFilterTest passes with no failures and our
own code no longer has any problem. Thanks for fixing it!
Incorrect SQL is used for HQL if the number of values for a filter
collection parameter is changed
--------------------------------------------------------------------------------------------------
Key: HHH-4065
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065
Project: Hibernate Core
Issue Type: Bug
Components: query-hql
Affects Versions: 3.3.2
Environment: Hibernate 3.3.2
Reporter: Nicklas Nordborg
Assignee: Steve Ebersole
Fix For: 3.3.x, 3.5
Attachments: org.hibernate.test.filter.DynamicFilterTest-output.txt,
org.hibernate.test.filter.DynamicFilterTest-patch.txt,
org.hibernate.test.filter.DynamicFilterTest.txt, trace.txt
I think that maybe the fix for HHH-530 has introduced a problem with filters that has a
collection-type parameter. If the number of parameters in that collection changes during
the lifetime of a SessionFactory the SQL that is used becomes incorrect and either has too
many or too few parameter placeholders (eg. '?') in the SQL. There was no problem
in Hibernate 3.3.1. A typical error message is:
java.sql.SQLException: Parameter index out of bounds. 2 is not between valid values of 1
and 1
Below is some pseudo-code that shows what happens when the number of values in a
collection is increased from 1 to 2. The 'memberOf' is a simple filter on the `id`
column: `id` IN (:items)
String hql = "select n from NewsData n";
List idList = new ArrayList();
idList.add(1);
Session s = .... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list();
// SQL: select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
s.close();
idList.add(2);
s = ... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list(); // <--- error here with 3.3.2 but works with 3.3.1
// SQL (3.3.2): select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
// SQL (3.3.1): select .... `News` newsdata0_ where newsdata0_.`id` IN (?, ?)
I am attaching a file with TRACE-level output from both Hibernate 3.3.2 and 3.3.1. The
relevant difference seems to be that in Hibernate 3.3.2 the query plan is cached with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (?)'
but in Hibernate 3.3.1 with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (:memberOf.items)'
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:31 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4065) Incorrect SQL is used for HQL if the number of values for a filter collection parameter is changed
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065?page=c...
]
Brian Blasko commented on HHH-4065:
-----------------------------------
At this time we cannot upgrade to 3.3. Is there any chance we could get this patch on the
3.2.7 branch?
Incorrect SQL is used for HQL if the number of values for a filter
collection parameter is changed
--------------------------------------------------------------------------------------------------
Key: HHH-4065
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065
Project: Hibernate Core
Issue Type: Bug
Components: query-hql
Affects Versions: 3.3.2
Environment: Hibernate 3.3.2
Reporter: Nicklas Nordborg
Assignee: Steve Ebersole
Fix For: 3.3.x, 3.5
Attachments: org.hibernate.test.filter.DynamicFilterTest-output.txt,
org.hibernate.test.filter.DynamicFilterTest-patch.txt,
org.hibernate.test.filter.DynamicFilterTest.txt, trace.txt
I think that maybe the fix for HHH-530 has introduced a problem with filters that has a
collection-type parameter. If the number of parameters in that collection changes during
the lifetime of a SessionFactory the SQL that is used becomes incorrect and either has too
many or too few parameter placeholders (eg. '?') in the SQL. There was no problem
in Hibernate 3.3.1. A typical error message is:
java.sql.SQLException: Parameter index out of bounds. 2 is not between valid values of 1
and 1
Below is some pseudo-code that shows what happens when the number of values in a
collection is increased from 1 to 2. The 'memberOf' is a simple filter on the `id`
column: `id` IN (:items)
String hql = "select n from NewsData n";
List idList = new ArrayList();
idList.add(1);
Session s = .... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list();
// SQL: select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
s.close();
idList.add(2);
s = ... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list(); // <--- error here with 3.3.2 but works with 3.3.1
// SQL (3.3.2): select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
// SQL (3.3.1): select .... `News` newsdata0_ where newsdata0_.`id` IN (?, ?)
I am attaching a file with TRACE-level output from both Hibernate 3.3.2 and 3.3.1. The
relevant difference seems to be that in Hibernate 3.3.2 the query plan is cached with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (?)'
but in Hibernate 3.3.1 with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (:memberOf.items)'
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:39 a.m.
New subject: [Hibernate-JIRA] Closed: (HHH-4065) Incorrect SQL is used for HQL if the number of values for a filter collection parameter is changed
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065?page=c...
]
Steve Ebersole closed HHH-4065.
-------------------------------
Incorrect SQL is used for HQL if the number of values for a filter
collection parameter is changed
--------------------------------------------------------------------------------------------------
Key: HHH-4065
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065
Project: Hibernate Core
Issue Type: Bug
Components: query-hql
Affects Versions: 3.3.2
Environment: Hibernate 3.3.2
Reporter: Nicklas Nordborg
Assignee: Steve Ebersole
Fix For: 3.3.x, 3.5
Attachments: org.hibernate.test.filter.DynamicFilterTest-output.txt,
org.hibernate.test.filter.DynamicFilterTest-patch.txt,
org.hibernate.test.filter.DynamicFilterTest.txt, trace.txt
I think that maybe the fix for HHH-530 has introduced a problem with filters that has a
collection-type parameter. If the number of parameters in that collection changes during
the lifetime of a SessionFactory the SQL that is used becomes incorrect and either has too
many or too few parameter placeholders (eg. '?') in the SQL. There was no problem
in Hibernate 3.3.1. A typical error message is:
java.sql.SQLException: Parameter index out of bounds. 2 is not between valid values of 1
and 1
Below is some pseudo-code that shows what happens when the number of values in a
collection is increased from 1 to 2. The 'memberOf' is a simple filter on the `id`
column: `id` IN (:items)
String hql = "select n from NewsData n";
List idList = new ArrayList();
idList.add(1);
Session s = .... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list();
// SQL: select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
s.close();
idList.add(2);
s = ... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list(); // <--- error here with 3.3.2 but works with 3.3.1
// SQL (3.3.2): select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
// SQL (3.3.1): select .... `News` newsdata0_ where newsdata0_.`id` IN (?, ?)
I am attaching a file with TRACE-level output from both Hibernate 3.3.2 and 3.3.1. The
relevant difference seems to be that in Hibernate 3.3.2 the query plan is cached with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (?)'
but in Hibernate 3.3.1 with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (:memberOf.items)'
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:39 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4065) Incorrect SQL is used for HQL if the number of values for a filter collection parameter is changed
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065?page=c...
]
Steve Ebersole commented on HHH-4065:
-------------------------------------
I dont plan on doing any more 3.2 releases. On the bright side though that means you are
free to patch this yourself and not have to worry about upgrades :)
Incorrect SQL is used for HQL if the number of values for a filter
collection parameter is changed
--------------------------------------------------------------------------------------------------
Key: HHH-4065
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065
Project: Hibernate Core
Issue Type: Bug
Components: query-hql
Affects Versions: 3.3.2
Environment: Hibernate 3.3.2
Reporter: Nicklas Nordborg
Assignee: Steve Ebersole
Fix For: 3.3.x, 3.5
Attachments: org.hibernate.test.filter.DynamicFilterTest-output.txt,
org.hibernate.test.filter.DynamicFilterTest-patch.txt,
org.hibernate.test.filter.DynamicFilterTest.txt, trace.txt
I think that maybe the fix for HHH-530 has introduced a problem with filters that has a
collection-type parameter. If the number of parameters in that collection changes during
the lifetime of a SessionFactory the SQL that is used becomes incorrect and either has too
many or too few parameter placeholders (eg. '?') in the SQL. There was no problem
in Hibernate 3.3.1. A typical error message is:
java.sql.SQLException: Parameter index out of bounds. 2 is not between valid values of 1
and 1
Below is some pseudo-code that shows what happens when the number of values in a
collection is increased from 1 to 2. The 'memberOf' is a simple filter on the `id`
column: `id` IN (:items)
String hql = "select n from NewsData n";
List idList = new ArrayList();
idList.add(1);
Session s = .... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list();
// SQL: select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
s.close();
idList.add(2);
s = ... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list(); // <--- error here with 3.3.2 but works with 3.3.1
// SQL (3.3.2): select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
// SQL (3.3.1): select .... `News` newsdata0_ where newsdata0_.`id` IN (?, ?)
I am attaching a file with TRACE-level output from both Hibernate 3.3.2 and 3.3.1. The
relevant difference seems to be that in Hibernate 3.3.2 the query plan is cached with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (?)'
but in Hibernate 3.3.1 with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (:memberOf.items)'
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:36 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4065) Incorrect SQL is used for HQL if the number of values for a filter collection parameter is changed
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065?page=c...
]
Strong Liu commented on HHH-4065:
---------------------------------
https://jira.jboss.org/jira/browse/JBPAPP-3098
Incorrect SQL is used for HQL if the number of values for a filter
collection parameter is changed
--------------------------------------------------------------------------------------------------
Key: HHH-4065
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065
Project: Hibernate Core
Issue Type: Bug
Components: query-hql
Affects Versions: 3.3.2
Environment: Hibernate 3.3.2
Reporter: Nicklas Nordborg
Assignee: Steve Ebersole
Fix For: 3.3.x, 3.5
Attachments: org.hibernate.test.filter.DynamicFilterTest-output.txt,
org.hibernate.test.filter.DynamicFilterTest-patch.txt,
org.hibernate.test.filter.DynamicFilterTest.txt, trace.txt
I think that maybe the fix for HHH-530 has introduced a problem with filters that has a
collection-type parameter. If the number of parameters in that collection changes during
the lifetime of a SessionFactory the SQL that is used becomes incorrect and either has too
many or too few parameter placeholders (eg. '?') in the SQL. There was no problem
in Hibernate 3.3.1. A typical error message is:
java.sql.SQLException: Parameter index out of bounds. 2 is not between valid values of 1
and 1
Below is some pseudo-code that shows what happens when the number of values in a
collection is increased from 1 to 2. The 'memberOf' is a simple filter on the `id`
column: `id` IN (:items)
String hql = "select n from NewsData n";
List idList = new ArrayList();
idList.add(1);
Session s = .... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list();
// SQL: select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
s.close();
idList.add(2);
s = ... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list(); // <--- error here with 3.3.2 but works with 3.3.1
// SQL (3.3.2): select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
// SQL (3.3.1): select .... `News` newsdata0_ where newsdata0_.`id` IN (?, ?)
I am attaching a file with TRACE-level output from both Hibernate 3.3.2 and 3.3.1. The
relevant difference seems to be that in Hibernate 3.3.2 the query plan is cached with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (?)'
but in Hibernate 3.3.1 with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (:memberOf.items)'
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:02 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4065) Incorrect SQL is used for HQL if the number of values for a filter collection parameter is changed
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065?page=c...
]
Anderson Teymeny commented on HHH-4065:
---------------------------------------
Does anyone know if this issue is the same discribed here
https://forum.hibernate.org/viewtopic.php?f=1&t=1002162 ?
I have just updated from 3.3.1.GA to 3.3.2.GA and I got this problem, and it looks a lot
with the one addressed by this issue.
Thanks
Incorrect SQL is used for HQL if the number of values for a filter
collection parameter is changed
--------------------------------------------------------------------------------------------------
Key: HHH-4065
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4065
Project: Hibernate Core
Issue Type: Bug
Components: query-hql
Affects Versions: 3.3.2
Environment: Hibernate 3.3.2
Reporter: Nicklas Nordborg
Assignee: Steve Ebersole
Fix For: 3.3.x, 3.5.0-Beta-3
Attachments: org.hibernate.test.filter.DynamicFilterTest-output.txt,
org.hibernate.test.filter.DynamicFilterTest-patch.txt,
org.hibernate.test.filter.DynamicFilterTest.txt, trace.txt
I think that maybe the fix for HHH-530 has introduced a problem with filters that has a
collection-type parameter. If the number of parameters in that collection changes during
the lifetime of a SessionFactory the SQL that is used becomes incorrect and either has too
many or too few parameter placeholders (eg. '?') in the SQL. There was no problem
in Hibernate 3.3.1. A typical error message is:
java.sql.SQLException: Parameter index out of bounds. 2 is not between valid values of 1
and 1
Below is some pseudo-code that shows what happens when the number of values in a
collection is increased from 1 to 2. The 'memberOf' is a simple filter on the `id`
column: `id` IN (:items)
String hql = "select n from NewsData n";
List idList = new ArrayList();
idList.add(1);
Session s = .... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list();
// SQL: select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
s.close();
idList.add(2);
s = ... // create new session
s.enableFilter("memberOf").setParameterList("items", idList);
s.createQuery(hql).list(); // <--- error here with 3.3.2 but works with 3.3.1
// SQL (3.3.2): select .... `News` newsdata0_ where newsdata0_.`id` IN (?)
// SQL (3.3.1): select .... `News` newsdata0_ where newsdata0_.`id` IN (?, ?)
I am attaching a file with TRACE-level output from both Hibernate 3.3.2 and 3.3.1. The
relevant difference seems to be that in Hibernate 3.3.2 the query plan is cached with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (?)'
but in Hibernate 3.3.1 with:
[SQL_TOKEN] SqlFragment: 'newsdata0_.`id` IN (:memberOf.items)'
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5341
days inactive
5625
days old
hibernate-issues@lists.jboss.org
14 comments
5 participants
participants (5)
-
Anderson Teymeny (JIRA) -
Brian Blasko (JIRA)
-
Nicklas Nordborg (JIRA)
-
Steve Ebersole (JIRA)
-
Strong Liu (JIRA)