[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4689?page=c... ] Scott Marlow reassigned HHH-4689: --------------------------------- Assignee: Scott Marlow -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4689?page=c... ] Scott Marlow updated HHH-4689: ------------------------------ Attachment: CollectionBinder.patch -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4689?page=c... ] Emmanuel Bernard commented on HHH-4689: --------------------------------------- You've got the idea. But I think the drill down algorithm is more complex. Can you take a look at BinderHelper.findPropertyByName and see if you could reuse it as is or modularize it to reuse the useful bit. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4689?page=c... ] Emmanuel Bernard commented on HHH-4689: --------------------------------------- hum no you can't do that. I looked at the code a bit, it seems that your algo is indeed part of the findPropertyByName algo ** StringTokenizer st = new StringTokenizer( propertyName, ".", false ); while ( st.hasMoreElements() ) { String element = (String) st.nextElement(); if ( property == null ) { property = associatedClass.getProperty( element ); } else { if ( !property.isComposite() ) return null; property = ( (Component) property.getValue() ).getProperty( element ); } } ** so extract this method from findPropertyByName, host it on BinderHelper and use it for your case. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4689?page=c... ] Scott Marlow commented on HHH-4689: ----------------------------------- I have two questions about the attached BinderHelper.patch (contains new findPropertyByName(Component component, String propertyName)). 1. I didn't add support for obtaining the primary key columns. I assume that is needed and will work on a test case that shows the need. Do you agree that is probably needed? 2. For IdentifierMapper support, I used the component.getOwner().getIdentifierMapper() since I don't have a PersistentClass for the Component itself. I find it unlikely that the component owners identifier mapper will help with component level mapping but need to research that. I'm not sure if I should just delete the identifier mapper support or come up with a way for component level identifier mapping information to be obtained. Thoughts? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4689?page=c... ] Scott Marlow resolved HHH-4689. ------------------------------- Resolution: Fixed Fix Version/s: 3.5 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira