[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-220?page=c... ] Emmanuel Bernard commented on BVAL-220: --------------------------------------- to summarize it - we have 3 possibilities: 1) annotating the constraint 2) annotating the constraint-validator(s) 3) adding new attributes to @Constraint I think @Contraint(ignoreNull) makes sense. Is there a use case to diff between constraint validator implementation and thus favor option 2? But can you define not empty? Is that hardcoded for a few types? String is the one I can think of esp for JSF 3) is the best, less annotation is better to not scare people off. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-220?page=c... ] Peter Davis edited comment on BVAL-220 at 6/20/11 11:38 PM: ------------------------------------------------------------ Suggestion: @ReportAsSingleViolation(shortCircuit=true) /* better name? */ @NotNull /* or @NotEmpty, or @Size(min=50)... */ @Constraint(validatedBy=MyValidator) public @interface MyConstraint {} Currently Hibernate Validator invokes MyValidator even if the value is null. This is wasteful and pointless. It also makes it hard to compose cheap vs. expensive validations, or prerequisite validations in a reusable way. I don't believe this is addressed by the recent "OR" composition type addition to HVAL. was (Author: pediddle): Suggestion: @ReportAsSingleViolation(shortCircuit=true) /* better name? */ @NotNull /* or @NotEmpty, or @Size(min=50)... */ @Constraint(validatedBy=MyValidator) public @interface MyConstraint {} Currently Hibernate Validator invokes MyValidator even if the value is null. This is wasteful and pointless. It also makes it hard to compose cheap vs. expensive validations. I don't believe this is addressed by the recent "OR" composition type addition to HVAL. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-220?page=c... ] Emmanuel Bernard commented on BVAL-220: --------------------------------------- By the way, I don't thing shortCircuit=true should be an option. That should be the behavior period. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-220?page=c... ] Hardy Ferentschik commented on BVAL-220: ---------------------------------------- Is Peter's suggestion not just an extension of BVAL-259 which makes it configurable whether validation of a composed constraint stops on the first validation error. I don't really see the connection to this issue and what exactly this issue is about. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-220?page=c... ] Hardy Ferentschik edited comment on BVAL-220 at 1/27/12 5:28 AM: ----------------------------------------------------------------- Suggestion: {code} @ReportAsSingleViolation(shortCircuit=true) /* better name? */ @NotNull /* or @NotEmpty, or @Size(min=50)... */ @Constraint(validatedBy=MyValidator) public @interface MyConstraint {} {code} Currently Hibernate Validator invokes MyValidator even if the value is null. This is wasteful and pointless. It also makes it hard to compose cheap vs. expensive validations, or prerequisite validations in a reusable way. I don't believe this is addressed by the recent "OR" composition type addition to HVAL. was (Author: pediddle): Suggestion: @ReportAsSingleViolation(shortCircuit=true) /* better name? */ @NotNull /* or @NotEmpty, or @Size(min=50)... */ @Constraint(validatedBy=MyValidator) public @interface MyConstraint {} Currently Hibernate Validator invokes MyValidator even if the value is null. This is wasteful and pointless. It also makes it hard to compose cheap vs. expensive validations, or prerequisite validations in a reusable way. I don't believe this is addressed by the recent "OR" composition type addition to HVAL. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/BVAL-220?page=com.atlassian.jira.plug... ] Geert Brol commented on BVAL-220: --------------------------------- I will need to catch up on this issue, but I would already like to point out something before making more concrete comments.. have you also considered Strings that only contain blanks? Like " " or " \t " etc.. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira