[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3593?page=c... ] John Mazzitelli updated HHH-3593: --------------------------------- Attachment: HHH-3593.patch I have attached a patch that should provide this functionality. I did this work on branch_3_2 from today. Note that this does NOT introduce any JMX compile-time dependencies (due to the requirement that hibernate run in JDK 1.4). Therefore, you will not see any "javax.management.*" imports or classes being used directly (they are used via reflection). However, if you enable this JMX statistics feature, obviously, you must have JDK 1.5+ or JDK 1.4 + JMX libraries - if you do not, this code will log error messages saying what the problem is and simply disable the JMX stats capability (but otherwise, hibernate works normally). I javadoc'ed/commented most of this so hopefully it makes sense. Here's a portion of the javadoc that explains the new configuration: * <tr> * <td><tt>hibernate.generate_statistics.jmx</tt></td> * <td>If <b>true</b>, the <code>StatisticsService</code> MBean will be deployed. * If this is <code>true</code>, Hibernate must be running in a * JRE 5+ environment or JMX must be installed in classpath. * Setting this to <code>true</code> infers that you want to collect internal * statistics so <code>hibernate.generate_statistics</code> will be ignored * and assumed to have a value of <code>true</code>.</td> * </tr> * <tr> * <td><tt>hibernate.generate_statistics.jmx.object_name</tt></td> * <td>if <code>hibernate.generate_statistics.jmx</code> is <code>true</code>, * this will be the name the <code>StatisticsService</code> MBean will be * registered under within the MBeanServer.</td> * </tr> * <tr> * <td><tt>hibernate.generate_statistics.jmx.mbeanserver</tt></td> * <td>if <code>hibernate.generate_statistics.jmx</code> is <code>true</code>, * this will identify the MBeanServer where the <code>StatisticsService</code> * MBean is to be registered. If this value is <b>*platform*</b>, the * <code>ManagementFactory.getPlatformMBeanServer</code> * will be used (only supported on JRE 5 and up). Otherwise, this will be the * name of the MBeanServer's default domain name. If one does not yet exist * with that default domain name, one will be created via * <code>MBeanServerFactory.createMBeanServer</code>.</td> * </tr> -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3593?page=c... ] John Mazzitelli commented on HHH-3593: -------------------------------------- Because I did not want to introduce any JMX dependencies in the hibernate core build :) There wasn't any up until this point and I didn't want to be the one to introduce them. I wanted the build to work exactly the way it has always worked, with no additional runtime dependencies on optional libraries. In addition, what if someone was running hibernate in a JRE 1.4 environment and did NOT have JMX libraries - I wanted to avoid any possiblity of getting a NoClassDefFound exception by simply loading the JmxStatistics class (which gets loaded by the SessionFactoryImpl - and since that is a uber-important class, I did not want to entertain the thought of possibly adding JMX dependencies on that even at runtime unless JMX stats are explicitly enabled). In short, I was paranoid and wanted to maintain backward compatiblity (both build and runtime compatibliity) at all costs. That code is written in such a way that you can strip off the bottom half of JmxStatistics class, fix the trivial compile errors that occur as a result (by importing the javax.management.* classes and calling the proper JMX APIs) and it'll work - so long as you put JMX as a build dependency AND we won't run into the 1.4 runtime dependency issue I mention above. I recommend we do not do this until such time as Hibernate deprecates the 1.4 requirement (thus ensuring that javax.management is always available). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3593?page=c... ] Steve Ebersole commented on HHH-3593: ------------------------------------- Now that we base on JDK 1.5 (as of the soon final 3.6) I can take a look at this again. How about the following?: {code} /** * Service providing simplified access to JMX related features needed by Hibernate. * * @author Steve Ebersole */ public interface JmxService { /** * Registers the given {@code mBean} under the given {@code objectName} * * @param objectName The name under which to register the MBean * @param mBean The MBean to register */ public void registerMBean(ObjectName objectName, Object mBean); } /** * Standard implementation of JMX services * * @author Steve Ebersole */ public class JmxServiceImpl implements JmxService { private static final Logger log = LoggerFactory.getLogger( JmxServiceImpl.class ); public static final String JMX_PLATFORM_SERVER = "hibernate.jmx.usePlatformServer"; public static final String JMX_AGENT_ID = "hibernate.jmx.agentId"; public static final String JMX_DOMAIN_NAME = "hibernate.jmx.defaultDomain"; private final boolean usePlatformServer; private final String agentId; private final String defaultDomain; private boolean startedServer; private ArrayList<ObjectName> registeredMBeans; public JmxServiceImpl(Properties properties) { usePlatformServer = PropertiesHelper.getBoolean( JMX_PLATFORM_SERVER, properties ); agentId = properties.getProperty( JMX_AGENT_ID ); defaultDomain = properties.getProperty( JMX_DOMAIN_NAME ); } /** * {@inheritDoc} */ public void registerMBean(ObjectName objectName, Object mBean) { MBeanServer mBeanServer = findServer(); if ( mBeanServer == null ) { if ( startedServer ) { throw new HibernateException( "Could not locate previously started MBeanServer" ); } mBeanServer = startMBeanServer(); startedServer = true; } try { mBeanServer.registerMBean( mBean, objectName ); if ( registeredMBeans == null ) { registeredMBeans = new ArrayList<ObjectName>(); } registeredMBeans.add( objectName ); } catch ( Exception e ) { throw new HibernateException( "Unable to register MBean [ON=" + objectName + "]", e ); } } public void shutDown() { if ( startedServer || registeredMBeans != null ) { MBeanServer mBeanServer = findServer(); if ( mBeanServer == null ) { log.warn( "Unable to locate MBeanServer on JMX service shutdown" ); return; } if ( registeredMBeans != null ) { for ( ObjectName objectName : registeredMBeans ) { try { log.trace( "Unregistering registered MBean [ON=" + objectName + "]" ); mBeanServer.unregisterMBean( objectName ); } catch ( Exception e ) { log.debug( "Unable to unregsiter registered MBean [ON=" + objectName + "] : " + e.toString() ); } } registeredMBeans.clear(); registeredMBeans = null; } if ( startedServer ) { log.trace( "Attempting to release created MBeanServer" ); try { MBeanServerFactory.releaseMBeanServer( mBeanServer ); } catch ( Exception e ) { log.warn( "Unable to release created MBeanServer : " + e.toString() ); } } } } private MBeanServer findServer() { if ( usePlatformServer ) { return ManagementFactory.getPlatformMBeanServer(); } ArrayList<MBeanServer> mbeanServers = MBeanServerFactory.findMBeanServer( agentId ); // null agentId is ok if ( defaultDomain == null ) { return mbeanServers.get( 0 ); } for ( MBeanServer mbeanServer : mbeanServers ) { if ( defaultDomain.equals( mbeanServer.getDefaultDomain() ) ) { return mbeanServer; } } return null; } private MBeanServer startMBeanServer() { try { MBeanServer mbeanServer = MBeanServerFactory.createMBeanServer( defaultDomain ); return mbeanServer; } catch ( Exception e ) { throw new HibernateException( "Unable to start MBeanServer", e ); } } } {code} The idea is that {{JmxService}} would then be used when initializing Statistics to add stats stuff to mbean server as you outlined -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3593?page=c... ] Steve Ebersole commented on HHH-3593: ------------------------------------- Is there any issue with caching the {{MBeanServer}} reference? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3593?page=c... ] Steve Ebersole closed HHH-3593. ------------------------------- Resolution: Duplicate This will be addressed by HHH-6052 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira