2:14 p.m.
Wrong Query timeout calculation
--------------------------------
Key: HHH-6780
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6780
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 4.0.0.CR5, 4.0.0.CR4
Environment: Hibernate 4.0.0.RC5, Spring 3.1.RC1
Reporter: Ruben Garcia
Class:
org.hibernate.engine.jdbc.internal.StatementPreparerImpl.StatementPreparationTemplate
Method: setStatementTimeout
private void setStatementTimeout(PreparedStatement preparedStatement) throws SQLException
{
if ( transactionTimeOut > 0 ) {
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 )
);
if ( timeout <= 0 ) {
throw new TransactionException( "transaction timeout expired" );
} else {
preparedStatement.setQueryTimeout( timeout );
}
}
}
Test Code:
Session session = openSession();
Transaction transaction = session.getTransaction();
transaction .setTimeout(20);
This calculation will be always negative:
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 ) );
resulting TransactionException( "transaction timeout expired" ) will be throw.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:15 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-6780) Wrong Query timeout calculation
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-6780?page=c...
]
Lukasz Antoniak commented on HHH-6780:
--------------------------------------
Pull request submitted: https://github.com/hibernate/hibernate-core/pull/205
Wrong Query timeout calculation
--------------------------------
Key: HHH-6780
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6780
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 4.0.0.CR4, 4.0.0.CR5
Environment: Hibernate 4.0.0.RC5, Spring 3.1.RC1
Reporter: Ruben Garcia
Labels: hibernate
Class:
org.hibernate.engine.jdbc.internal.StatementPreparerImpl.StatementPreparationTemplate
Method: setStatementTimeout
private void setStatementTimeout(PreparedStatement preparedStatement) throws SQLException
{
if ( transactionTimeOut > 0 ) {
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 )
);
if ( timeout <= 0 ) {
throw new TransactionException( "transaction timeout expired" );
} else {
preparedStatement.setQueryTimeout( timeout );
}
}
}
Test Code:
Session session = openSession();
Transaction transaction = session.getTransaction();
transaction .setTimeout(20);
This calculation will be always negative:
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 ) );
resulting TransactionException( "transaction timeout expired" ) will be throw.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:33 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-6780) Wrong Query timeout calculation
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-6780?page=c...
]
Donnchadh O Donnabhain commented on HHH-6780:
---------------------------------------------
It would be great to get this fixed before 4.0 goes final.
Wrong Query timeout calculation
--------------------------------
Key: HHH-6780
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6780
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 4.0.0.CR4, 4.0.0.CR5
Environment: Hibernate 4.0.0.RC5, Spring 3.1.RC1
Reporter: Ruben Garcia
Labels: hibernate
Class:
org.hibernate.engine.jdbc.internal.StatementPreparerImpl.StatementPreparationTemplate
Method: setStatementTimeout
private void setStatementTimeout(PreparedStatement preparedStatement) throws SQLException
{
if ( transactionTimeOut > 0 ) {
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 )
);
if ( timeout <= 0 ) {
throw new TransactionException( "transaction timeout expired" );
} else {
preparedStatement.setQueryTimeout( timeout );
}
}
}
Test Code:
Session session = openSession();
Transaction transaction = session.getTransaction();
transaction .setTimeout(20);
This calculation will be always negative:
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 ) );
resulting TransactionException( "transaction timeout expired" ) will be throw.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:24 p.m.
New subject: [Hibernate-JIRA] Assigned: (HHH-6780) Wrong Query timeout calculation
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-6780?page=c...
]
Strong Liu reassigned HHH-6780:
-------------------------------
Assignee: Lukasz Antoniak
I will look the pull request soon
Wrong Query timeout calculation
--------------------------------
Key: HHH-6780
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6780
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 4.0.0.CR4, 4.0.0.CR5
Environment: Hibernate 4.0.0.RC5, Spring 3.1.RC1
Reporter: Ruben Garcia
Assignee: Lukasz Antoniak
Labels: hibernate
Class:
org.hibernate.engine.jdbc.internal.StatementPreparerImpl.StatementPreparationTemplate
Method: setStatementTimeout
private void setStatementTimeout(PreparedStatement preparedStatement) throws SQLException
{
if ( transactionTimeOut > 0 ) {
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 )
);
if ( timeout <= 0 ) {
throw new TransactionException( "transaction timeout expired" );
} else {
preparedStatement.setQueryTimeout( timeout );
}
}
}
Test Code:
Session session = openSession();
Transaction transaction = session.getTransaction();
transaction .setTimeout(20);
This calculation will be always negative:
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 ) );
resulting TransactionException( "transaction timeout expired" ) will be throw.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:49 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-6780) Wrong Query timeout calculation
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-6780?page=c...
]
Strong Liu updated HHH-6780:
----------------------------
Description:
{code|title=org.hibernate.engine.jdbc.internal.StatementPreparerImpl.StatementPreparationTemplate#setStatementTimeout}
private void setStatementTimeout(PreparedStatement preparedStatement) throws SQLException
{
if ( transactionTimeOut > 0 ) {
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 )
);
if ( timeout <= 0 ) {
throw new TransactionException( "transaction timeout expired" );
} else {
preparedStatement.setQueryTimeout( timeout );
}
}
}
{code}
Test Code:
Session session = openSession();
Transaction transaction = session.getTransaction();
transaction .setTimeout(20);
This calculation will be always negative:
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 ) );
resulting TransactionException( "transaction timeout expired" ) will be throw.
was:
Class:
org.hibernate.engine.jdbc.internal.StatementPreparerImpl.StatementPreparationTemplate
Method: setStatementTimeout
private void setStatementTimeout(PreparedStatement preparedStatement) throws SQLException
{
if ( transactionTimeOut > 0 ) {
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 )
);
if ( timeout <= 0 ) {
throw new TransactionException( "transaction timeout expired" );
} else {
preparedStatement.setQueryTimeout( timeout );
}
}
}
Test Code:
Session session = openSession();
Transaction transaction = session.getTransaction();
transaction .setTimeout(20);
This calculation will be always negative:
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 ) );
resulting TransactionException( "transaction timeout expired" ) will be throw.
Wrong Query timeout calculation
--------------------------------
Key: HHH-6780
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6780
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 4.0.0.CR4, 4.0.0.CR5
Environment: Hibernate 4.0.0.RC5, Spring 3.1.RC1
Reporter: Ruben Garcia
Assignee: Lukasz Antoniak
Labels: hibernate
{code|title=org.hibernate.engine.jdbc.internal.StatementPreparerImpl.StatementPreparationTemplate#setStatementTimeout}
private void setStatementTimeout(PreparedStatement preparedStatement) throws SQLException
{
if ( transactionTimeOut > 0 ) {
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 )
);
if ( timeout <= 0 ) {
throw new TransactionException( "transaction timeout expired" );
} else {
preparedStatement.setQueryTimeout( timeout );
}
}
}
{code}
Test Code:
Session session = openSession();
Transaction transaction = session.getTransaction();
transaction .setTimeout(20);
This calculation will be always negative:
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 ) );
resulting TransactionException( "transaction timeout expired" ) will be throw.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:49 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-6780) Wrong Query timeout calculation
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-6780?page=c...
]
Strong Liu updated HHH-6780:
----------------------------
Description:
{code:title=org.hibernate.engine.jdbc.internal.StatementPreparerImpl.StatementPreparationTemplate#setStatementTimeout}
private void setStatementTimeout(PreparedStatement preparedStatement) throws SQLException
{
if ( transactionTimeOut > 0 ) {
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 )
);
if ( timeout <= 0 ) {
throw new TransactionException( "transaction timeout expired" );
} else {
preparedStatement.setQueryTimeout( timeout );
}
}
}
{code}
Test Code:
Session session = openSession();
Transaction transaction = session.getTransaction();
transaction .setTimeout(20);
This calculation will be always negative:
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 ) );
resulting TransactionException( "transaction timeout expired" ) will be throw.
was:
{code|title=org.hibernate.engine.jdbc.internal.StatementPreparerImpl.StatementPreparationTemplate#setStatementTimeout}
private void setStatementTimeout(PreparedStatement preparedStatement) throws SQLException
{
if ( transactionTimeOut > 0 ) {
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 )
);
if ( timeout <= 0 ) {
throw new TransactionException( "transaction timeout expired" );
} else {
preparedStatement.setQueryTimeout( timeout );
}
}
}
{code}
Test Code:
Session session = openSession();
Transaction transaction = session.getTransaction();
transaction .setTimeout(20);
This calculation will be always negative:
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 ) );
resulting TransactionException( "transaction timeout expired" ) will be throw.
Wrong Query timeout calculation
--------------------------------
Key: HHH-6780
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6780
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 4.0.0.CR4, 4.0.0.CR5
Environment: Hibernate 4.0.0.RC5, Spring 3.1.RC1
Reporter: Ruben Garcia
Assignee: Lukasz Antoniak
Labels: hibernate
{code:title=org.hibernate.engine.jdbc.internal.StatementPreparerImpl.StatementPreparationTemplate#setStatementTimeout}
private void setStatementTimeout(PreparedStatement preparedStatement) throws SQLException
{
if ( transactionTimeOut > 0 ) {
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 )
);
if ( timeout <= 0 ) {
throw new TransactionException( "transaction timeout expired" );
} else {
preparedStatement.setQueryTimeout( timeout );
}
}
}
{code}
Test Code:
Session session = openSession();
Transaction transaction = session.getTransaction();
transaction .setTimeout(20);
This calculation will be always negative:
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 ) );
resulting TransactionException( "transaction timeout expired" ) will be throw.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:24 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-6780) Wrong Query timeout calculation
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-6780?page=c...
]
Steve Ebersole updated HHH-6780:
--------------------------------
Assignee: Steve Ebersole (was: Lukasz Antoniak)
Wrong Query timeout calculation
--------------------------------
Key: HHH-6780
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6780
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 4.0.0.CR4, 4.0.0.CR5
Environment: Hibernate 4.0.0.RC5, Spring 3.1.RC1
Reporter: Ruben Garcia
Assignee: Steve Ebersole
Labels: hibernate
{code:title=org.hibernate.engine.jdbc.internal.StatementPreparerImpl.StatementPreparationTemplate#setStatementTimeout}
private void setStatementTimeout(PreparedStatement preparedStatement) throws SQLException
{
if ( transactionTimeOut > 0 ) {
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 )
);
if ( timeout <= 0 ) {
throw new TransactionException( "transaction timeout expired" );
} else {
preparedStatement.setQueryTimeout( timeout );
}
}
}
{code}
Test Code:
Session session = openSession();
Transaction transaction = session.getTransaction();
transaction .setTimeout(20);
This calculation will be always negative:
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 ) );
resulting TransactionException( "transaction timeout expired" ) will be throw.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:41 p.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-6780) Wrong Query timeout calculation
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-6780?page=c...
]
Steve Ebersole resolved HHH-6780.
---------------------------------
Resolution: Fixed
Fix Version/s: 4.0.0.next
Wrong Query timeout calculation
--------------------------------
Key: HHH-6780
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6780
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 4.0.0.CR4, 4.0.0.CR5
Environment: Hibernate 4.0.0.RC5, Spring 3.1.RC1
Reporter: Ruben Garcia
Assignee: Steve Ebersole
Labels: hibernate
Fix For: 4.0.0.next
Time Spent: 1h 16m
{code:title=org.hibernate.engine.jdbc.internal.StatementPreparerImpl.StatementPreparationTemplate#setStatementTimeout}
private void setStatementTimeout(PreparedStatement preparedStatement) throws SQLException
{
if ( transactionTimeOut > 0 ) {
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 )
);
if ( timeout <= 0 ) {
throw new TransactionException( "transaction timeout expired" );
} else {
preparedStatement.setQueryTimeout( timeout );
}
}
}
{code}
Test Code:
Session session = openSession();
Transaction transaction = session.getTransaction();
transaction .setTimeout(20);
This calculation will be always negative:
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 ) );
resulting TransactionException( "transaction timeout expired" ) will be throw.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:20 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-6780) Wrong Query timeout calculation
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-6780?page=c...
]
Donnchadh O Donnabhain commented on HHH-6780:
---------------------------------------------
I've tested our code against the fix applied to master and we're no longer seeing
any problems related to the transaction timeout.
Wrong Query timeout calculation
--------------------------------
Key: HHH-6780
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6780
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 4.0.0.CR4, 4.0.0.CR5
Environment: Hibernate 4.0.0.RC5, Spring 3.1.RC1
Reporter: Ruben Garcia
Assignee: Steve Ebersole
Labels: hibernate
Fix For: 4.0.0.next
Time Spent: 1h 16m
{code:title=org.hibernate.engine.jdbc.internal.StatementPreparerImpl.StatementPreparationTemplate#setStatementTimeout}
private void setStatementTimeout(PreparedStatement preparedStatement) throws SQLException
{
if ( transactionTimeOut > 0 ) {
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 )
);
if ( timeout <= 0 ) {
throw new TransactionException( "transaction timeout expired" );
} else {
preparedStatement.setQueryTimeout( timeout );
}
}
}
{code}
Test Code:
Session session = openSession();
Transaction transaction = session.getTransaction();
transaction .setTimeout(20);
This calculation will be always negative:
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 ) );
resulting TransactionException( "transaction timeout expired" ) will be throw.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:25 a.m.
New subject: [Hibernate-JIRA] Closed: (HHH-6780) Wrong Query timeout calculation
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-6780?page=c...
]
Steve Ebersole closed HHH-6780.
-------------------------------
Thanks for verifying!
Wrong Query timeout calculation
--------------------------------
Key: HHH-6780
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6780
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 4.0.0.CR4, 4.0.0.CR5
Environment: Hibernate 4.0.0.RC5, Spring 3.1.RC1
Reporter: Ruben Garcia
Assignee: Steve Ebersole
Labels: hibernate
Fix For: 4.0.0.next
Time Spent: 1h 16m
{code:title=org.hibernate.engine.jdbc.internal.StatementPreparerImpl.StatementPreparationTemplate#setStatementTimeout}
private void setStatementTimeout(PreparedStatement preparedStatement) throws SQLException
{
if ( transactionTimeOut > 0 ) {
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 )
);
if ( timeout <= 0 ) {
throw new TransactionException( "transaction timeout expired" );
} else {
preparedStatement.setQueryTimeout( timeout );
}
}
}
{code}
Test Code:
Session session = openSession();
Transaction transaction = session.getTransaction();
transaction .setTimeout(20);
This calculation will be always negative:
int timeout = (int) ( transactionTimeOut - ( System.currentTimeMillis() / 1000 ) );
resulting TransactionException( "transaction timeout expired" ) will be throw.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4776
days inactive
4809
days old
hibernate-issues@lists.jboss.org
9 comments
5 participants
participants (5)
-
Donnchadh O Donnabhain (JIRA) -
Lukasz Antoniak (JIRA)
-
Ruben Garcia (JIRA)
-
Steve Ebersole (JIRA)
-
Strong Liu (JIRA)