[JBoss JIRA] Created: (WELD-233) A sub-set of events are reported to Extension classes defined in jar files that are in WEB-INF/lib
9:15 a.m.
A sub-set of events are reported to Extension classes defined in jar files that are in
WEB-INF/lib
--------------------------------------------------------------------------------------------------
Key: WELD-233
URL: https://jira.jboss.org/jira/browse/WELD-233
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.CR1
Environment: GlassFish v3 and Weld 1.0.0-CR1-SP1
Reporter: Paul Sandoz
Attachments: jcditest.zip
Only the following events are reported: BEFORE BEAN DISCOVERY, PROCESS ANNOTATED TYPE,
AFTER BEAN DISCOVERY and AFTER DEPLOYMENT VALIDATION
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:15 a.m.
New subject: [JBoss JIRA] Updated: (WELD-233) A sub-set of events are reported to Extension classes defined in jar files that are in WEB-INF/lib
[
https://jira.jboss.org/jira/browse/WELD-233?page=com.atlassian.jira.plugi...
]
Paul Sandoz updated WELD-233:
-----------------------------
Attachment: jcditest.zip
Attached is a simple maven project that can reproduce the issue.
After building deploy the war created in jcditest/webapp/target directory to the app
server with 299 support.
A sub-set of events are reported to Extension classes defined in jar
files that are in WEB-INF/lib
--------------------------------------------------------------------------------------------------
Key: WELD-233
URL: https://jira.jboss.org/jira/browse/WELD-233
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.CR1
Environment: GlassFish v3 and Weld 1.0.0-CR1-SP1
Reporter: Paul Sandoz
Attachments: jcditest.zip
Only the following events are reported: BEFORE BEAN DISCOVERY, PROCESS ANNOTATED TYPE,
AFTER BEAN DISCOVERY and AFTER DEPLOYMENT VALIDATION
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:18 a.m.
New subject: [JBoss JIRA] Updated: (WELD-233) A sub-set of events are reported to Extension classes defined in jar files that are in WEB-INF/lib
[
https://jira.jboss.org/jira/browse/WELD-233?page=com.atlassian.jira.plugi...
]
Paul Sandoz updated WELD-233:
-----------------------------
Priority: Blocker (was: Major)
A sub-set of events are reported to Extension classes defined in jar
files that are in WEB-INF/lib
--------------------------------------------------------------------------------------------------
Key: WELD-233
URL: https://jira.jboss.org/jira/browse/WELD-233
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.CR1
Environment: GlassFish v3 and Weld 1.0.0-CR1-SP1
Reporter: Paul Sandoz
Priority: Blocker
Attachments: jcditest.zip
Only the following events are reported: BEFORE BEAN DISCOVERY, PROCESS ANNOTATED TYPE,
AFTER BEAN DISCOVERY and AFTER DEPLOYMENT VALIDATION
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:35 a.m.
New subject: [JBoss JIRA] Updated: (WELD-233) A sub-set of events are reported to Extension classes defined in jar files that are in WEB-INF/lib
[
https://jira.jboss.org/jira/browse/WELD-233?page=com.atlassian.jira.plugi...
]
Pete Muir updated WELD-233:
---------------------------
Fix Version/s: 1.0.0.CR2
A sub-set of events are reported to Extension classes defined in jar
files that are in WEB-INF/lib
--------------------------------------------------------------------------------------------------
Key: WELD-233
URL: https://jira.jboss.org/jira/browse/WELD-233
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.CR1
Environment: GlassFish v3 and Weld 1.0.0-CR1-SP1
Reporter: Paul Sandoz
Priority: Blocker
Fix For: 1.0.0.CR2
Attachments: jcditest.zip
Only the following events are reported: BEFORE BEAN DISCOVERY, PROCESS ANNOTATED TYPE,
AFTER BEAN DISCOVERY and AFTER DEPLOYMENT VALIDATION
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:26 p.m.
New subject: [JBoss JIRA] Commented: (WELD-233) A sub-set of events are reported to Extension classes defined in jar files that are in WEB-INF/lib
[
https://jira.jboss.org/jira/browse/WELD-233?page=com.atlassian.jira.plugi...
]
Santiago Pericas-Geertsen commented on WELD-233:
------------------------------------------------
Let me provide some more context. There are three extension classes each one with 7
observer methods. The first class is com.sun.jersey...JCDIComponentExtension and is part
of the Jersey OSGi module. The second is foo.TestExtensionBean and is part of the
webapp.war deployed (WEB-INF/classes), and the third is
com.sun.jcditest.extinjar.TestExtensionBean and is part of a library bundled in webapp.war
(WEB-INF/lib/extinjar*.jar).
Weld deploys all the extension classes and creates 21 observers for all the methods. That
part seems fine. However, when ProcessProducer(PP), ProcessInjectionTarget(PIT) or
ProcessManagedBean(PMB) events are fired, they are only delivered to foo.TestExtensionBean
only. Other events are delivered to all three extension classes.
As far as I can tell, TypeSafeResolver is failing to match PP, PIT and PMB with the
observers created for JCDIComponentExtension and
com.sun.jcditest.extinjar.TestExtensionBean. The fact that it works for one bean and not
the other too is quite intriguing, and may suggest another class loading problem (e.g.
types failing to match when loaded by different CLs).
I'd be interesting to see if any of this is reproducible on JBoss.
A sub-set of events are reported to Extension classes defined in jar
files that are in WEB-INF/lib
--------------------------------------------------------------------------------------------------
Key: WELD-233
URL: https://jira.jboss.org/jira/browse/WELD-233
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.CR1
Environment: GlassFish v3 and Weld 1.0.0-CR1-SP1
Reporter: Paul Sandoz
Priority: Blocker
Fix For: 1.0.0.CR2
Attachments: jcditest.zip
Only the following events are reported: BEFORE BEAN DISCOVERY, PROCESS ANNOTATED TYPE,
AFTER BEAN DISCOVERY and AFTER DEPLOYMENT VALIDATION
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:07 p.m.
New subject: [JBoss JIRA] Commented: (WELD-233) A sub-set of events are reported to Extension classes defined in jar files that are in WEB-INF/lib
[
https://jira.jboss.org/jira/browse/WELD-233?page=com.atlassian.jira.plugi...
]
Pete Muir commented on WELD-233:
--------------------------------
Santiago, this is very useful and makes some sort of sense (though something is wrong
here).
We fire the PP, PIT, and PMB events on the manager for module/bean deployment archive in
which the bean is discovered, whilst we fire the BeforeBeanDiscovery, AfterBeanDiscovery
and AfterDeploymentValidation on a "virtual" manager, which just has the
extension beans deployed.
To determine whether to add an extension (and thus the observers belonging to the
extension) to the manager for a bean deployment archive, we check whether the bean class
of the extension belongs to the current BeanDeploymentArchive via
Deployment.loadBeanDeploymentArchive().
If nothing else, at this point we are running into WELD-212 - if GF is returning a new BDA
for the extensions deployed outside of BDA passed in as part of the Deployment, which it
correctly adds to the accessible BDA graph for the various modules, this change to the
accessibility graph won't be picked up, as we don't rescan and rebuild the manager
accessibility structure after AfterBeanDiscovery, but before proceeding to deploy the
beans. I'll work on getting a test to reproduce this tomorrow.
A sub-set of events are reported to Extension classes defined in jar
files that are in WEB-INF/lib
--------------------------------------------------------------------------------------------------
Key: WELD-233
URL: https://jira.jboss.org/jira/browse/WELD-233
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.CR1
Environment: GlassFish v3 and Weld 1.0.0-CR1-SP1
Reporter: Paul Sandoz
Priority: Blocker
Fix For: 1.0.0.CR2
Attachments: jcditest.zip
Only the following events are reported: BEFORE BEAN DISCOVERY, PROCESS ANNOTATED TYPE,
AFTER BEAN DISCOVERY and AFTER DEPLOYMENT VALIDATION
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:30 p.m.
New subject: [JBoss JIRA] Resolved: (WELD-233) A sub-set of events are reported to Extension classes defined in jar files that are in WEB-INF/lib
[
https://jira.jboss.org/jira/browse/WELD-233?page=com.atlassian.jira.plugi...
]
Pete Muir resolved WELD-233.
----------------------------
Resolution: Done
Assignee: Roger Kitain
Added test
org.jboss.weld.test.unit.deployment.structure.extensions.NonBDAExtensionTest.test() which
mirrors the deployment structure described by Santiago.
Roger please verify fix in GlassFish and reassign to me.
A sub-set of events are reported to Extension classes defined in jar
files that are in WEB-INF/lib
--------------------------------------------------------------------------------------------------
Key: WELD-233
URL: https://jira.jboss.org/jira/browse/WELD-233
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.CR1
Environment: GlassFish v3 and Weld 1.0.0-CR1-SP1
Reporter: Paul Sandoz
Assignee: Roger Kitain
Priority: Blocker
Fix For: 1.0.0.CR2
Attachments: jcditest.zip
Only the following events are reported: BEFORE BEAN DISCOVERY, PROCESS ANNOTATED TYPE,
AFTER BEAN DISCOVERY and AFTER DEPLOYMENT VALIDATION
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:12 p.m.
New subject: [JBoss JIRA] Closed: (WELD-233) A sub-set of events are reported to Extension classes defined in jar files that are in WEB-INF/lib
[
https://jira.jboss.org/jira/browse/WELD-233?page=com.atlassian.jira.plugi...
]
Pete Muir closed WELD-233.
--------------------------
A sub-set of events are reported to Extension classes defined in jar
files that are in WEB-INF/lib
--------------------------------------------------------------------------------------------------
Key: WELD-233
URL: https://jira.jboss.org/jira/browse/WELD-233
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.CR1
Environment: GlassFish v3 and Weld 1.0.0-CR1-SP1
Reporter: Paul Sandoz
Assignee: Roger Kitain
Priority: Blocker
Fix For: 1.0.0.CR2
Attachments: jcditest.zip
Only the following events are reported: BEFORE BEAN DISCOVERY, PROCESS ANNOTATED TYPE,
AFTER BEAN DISCOVERY and AFTER DEPLOYMENT VALIDATION
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5285
days inactive
5294
days old
7 comments
3 participants
participants (3)
-
Paul Sandoz (JIRA) -
Pete Muir (JIRA)
-
Santiago Pericas-Geertsen (JIRA)