5:45 p.m.
Weld 1.1 breaks compatibility with groovy objects
-------------------------------------------------
Key: WELD-840
URL: https://issues.jboss.org/browse/WELD-840
Project: Weld
Issue Type: Bug
Components: Proxies
Affects Versions: 1.1.0.Final
Environment: Groovy 1.7.6, tomcat 6, weld 1.1, JSF 2 (mojarra 2.0.3)
Reporter: Jeff Howard
Weld created proxies need to know how to work with groovy objects. Currently, weld is
attempting to proxy the methods from the groovy.lang.GroovyObject interface which is
confusing the groovy runtime. Groovy objects have a per-class metaclass that is getting
used with the wrong class instances.
Also, weld is using hyphen characters in the generated proxy class names, which breaks
groovy's dynamic invoke mechanism.
The referenced forum thread contains a patch that addresses the groovy incompatabilities
in weld's ProxyFactory.java
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:47 p.m.
New subject: [JBoss JIRA] Updated: (WELD-840) Weld 1.1 breaks compatibility with groovy objects
[
https://issues.jboss.org/browse/WELD-840?page=com.atlassian.jira.plugin.s...
]
Jeff Howard updated WELD-840:
-----------------------------
Attachment: weld11_partial_groovy_support.diff
Patch to fix the ProxyFactory.java file
Weld 1.1 breaks compatibility with groovy objects
-------------------------------------------------
Key: WELD-840
URL: https://issues.jboss.org/browse/WELD-840
Project: Weld
Issue Type: Bug
Components: Proxies
Affects Versions: 1.1.0.Final
Environment: Groovy 1.7.6, tomcat 6, weld 1.1, JSF 2 (mojarra 2.0.3)
Reporter: Jeff Howard
Labels: groovy
Attachments: weld11_partial_groovy_support.diff
Weld created proxies need to know how to work with groovy objects. Currently, weld is
attempting to proxy the methods from the groovy.lang.GroovyObject interface which is
confusing the groovy runtime. Groovy objects have a per-class metaclass that is getting
used with the wrong class instances.
Also, weld is using hyphen characters in the generated proxy class names, which breaks
groovy's dynamic invoke mechanism.
The referenced forum thread contains a patch that addresses the groovy incompatabilities
in weld's ProxyFactory.java
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:26 p.m.
New subject: [JBoss JIRA] Assigned: (WELD-840) Weld 1.1 breaks compatibility with groovy objects
[
https://issues.jboss.org/browse/WELD-840?page=com.atlassian.jira.plugin.s...
]
Ales Justin reassigned WELD-840:
--------------------------------
Assignee: Stuart Douglas
Weld 1.1 breaks compatibility with groovy objects
-------------------------------------------------
Key: WELD-840
URL: https://issues.jboss.org/browse/WELD-840
Project: Weld
Issue Type: Bug
Components: Proxies
Affects Versions: 1.1.0.Final
Environment: Groovy 1.7.6, tomcat 6, weld 1.1, JSF 2 (mojarra 2.0.3)
Reporter: Jeff Howard
Assignee: Stuart Douglas
Labels: groovy
Attachments: weld11_partial_groovy_support.diff
Weld created proxies need to know how to work with groovy objects. Currently, weld is
attempting to proxy the methods from the groovy.lang.GroovyObject interface which is
confusing the groovy runtime. Groovy objects have a per-class metaclass that is getting
used with the wrong class instances.
Also, weld is using hyphen characters in the generated proxy class names, which breaks
groovy's dynamic invoke mechanism.
The referenced forum thread contains a patch that addresses the groovy incompatabilities
in weld's ProxyFactory.java
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:36 p.m.
New subject: [JBoss JIRA] Updated: (WELD-840) Weld 1.1 breaks compatibility with groovy objects
[
https://issues.jboss.org/browse/WELD-840?page=com.atlassian.jira.plugin.s...
]
Jeff Howard updated WELD-840:
-----------------------------
Attachment: full_groovy_support.diff
This patch seems to restore full functionality when using weld 1.1 with Groovy 1.7.6.
There are 3 issues directly addressed in this patch.
1) weld 1.1 proxies use hyphens in auto-generated proxy class names, which breaks groovy.
2) Methods from groovy.lang.GroovyObject must be filtered out when creating the proxies
from groovy objects.
3) There is either a subtle problem with the proxy classes generated by
InterceptedSubclassFactory or Groovy's inheritance handling is bollixed. Not sure
which. Proxies generated by this factory (named *WeldSubclass) are being assigned the
metaclass from the corresponding *WeldClientProxy. Examining the actual metaclass for
*WeldSubclass shows that it thinks *WeldSubclass is derived from *WeldClientProxy instead
of the actual bean type. Hrmmm...
Weld 1.1 breaks compatibility with groovy objects
-------------------------------------------------
Key: WELD-840
URL: https://issues.jboss.org/browse/WELD-840
Project: Weld
Issue Type: Bug
Components: Proxies
Affects Versions: 1.1.0.Final
Environment: Groovy 1.7.6, tomcat 6, weld 1.1, JSF 2 (mojarra 2.0.3)
Reporter: Jeff Howard
Assignee: Stuart Douglas
Labels: groovy
Attachments: full_groovy_support.diff, weld11_partial_groovy_support.diff
Weld created proxies need to know how to work with groovy objects. Currently, weld is
attempting to proxy the methods from the groovy.lang.GroovyObject interface which is
confusing the groovy runtime. Groovy objects have a per-class metaclass that is getting
used with the wrong class instances.
Also, weld is using hyphen characters in the generated proxy class names, which breaks
groovy's dynamic invoke mechanism.
The referenced forum thread contains a patch that addresses the groovy incompatabilities
in weld's ProxyFactory.java
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:38 p.m.
New subject: [JBoss JIRA] Issue Comment Edited: (WELD-840) Weld 1.1 breaks compatibility with groovy objects
[
https://issues.jboss.org/browse/WELD-840?page=com.atlassian.jira.plugin.s...
]
Jeff Howard edited comment on WELD-840 at 1/31/11 4:37 PM:
-----------------------------------------------------------
This patch seems to restore full functionality when using weld 1.1 with Groovy 1.7.6.
There are 3 issues directly addressed in this patch.
1) weld 1.1 proxies use hyphens in auto-generated proxy class names, which breaks groovy.
2) Methods from groovy.lang.GroovyObject must be filtered out when creating the proxies
from groovy objects.
3) There is either a subtle problem with the proxy classes generated by
InterceptedSubclassFactory or Groovy's inheritance handling is bollixed. Not sure
which. Proxies generated by this factory (named *WeldSubclass) are being assigned the
metaclass from the corresponding *WeldClientProxy. Examining the actual metaclass for
*WeldSubclass shows that it thinks *WeldSubclass is derived from *WeldClientProxy instead
of the actual bean type. Hrmmm...
This patch supersedes the one above.
was (Author: jeff.howard):
This patch seems to restore full functionality when using weld 1.1 with Groovy
1.7.6.
There are 3 issues directly addressed in this patch.
1) weld 1.1 proxies use hyphens in auto-generated proxy class names, which breaks groovy.
2) Methods from groovy.lang.GroovyObject must be filtered out when creating the proxies
from groovy objects.
3) There is either a subtle problem with the proxy classes generated by
InterceptedSubclassFactory or Groovy's inheritance handling is bollixed. Not sure
which. Proxies generated by this factory (named *WeldSubclass) are being assigned the
metaclass from the corresponding *WeldClientProxy. Examining the actual metaclass for
*WeldSubclass shows that it thinks *WeldSubclass is derived from *WeldClientProxy instead
of the actual bean type. Hrmmm...
Weld 1.1 breaks compatibility with groovy objects
-------------------------------------------------
Key: WELD-840
URL: https://issues.jboss.org/browse/WELD-840
Project: Weld
Issue Type: Bug
Components: Proxies
Affects Versions: 1.1.0.Final
Environment: Groovy 1.7.6, tomcat 6, weld 1.1, JSF 2 (mojarra 2.0.3)
Reporter: Jeff Howard
Assignee: Stuart Douglas
Labels: groovy
Attachments: full_groovy_support.diff, weld11_partial_groovy_support.diff
Weld created proxies need to know how to work with groovy objects. Currently, weld is
attempting to proxy the methods from the groovy.lang.GroovyObject interface which is
confusing the groovy runtime. Groovy objects have a per-class metaclass that is getting
used with the wrong class instances.
Also, weld is using hyphen characters in the generated proxy class names, which breaks
groovy's dynamic invoke mechanism.
The referenced forum thread contains a patch that addresses the groovy incompatabilities
in weld's ProxyFactory.java
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:48 p.m.
New subject: [JBoss JIRA] Commented: (WELD-840) Weld 1.1 breaks compatibility with groovy objects
[
https://issues.jboss.org/browse/WELD-840?page=com.atlassian.jira.plugin.s...
]
Ales Justin commented on WELD-840:
----------------------------------
Although the patch seems to work, this shouldn't be handled in such a way.
By a diff way I mean a more plugable way.
Today it is Groovy which has issues with proxies, tomorrow it something else.
(e.g. some other dynamic language)
Doing this by adding more and more logic to ProxyFactory,
we'll only end up with code that nobody can read anymore.
Weld 1.1 breaks compatibility with groovy objects
-------------------------------------------------
Key: WELD-840
URL: https://issues.jboss.org/browse/WELD-840
Project: Weld
Issue Type: Bug
Components: Proxies
Affects Versions: 1.1.0.Final
Environment: Groovy 1.7.6, tomcat 6, weld 1.1, JSF 2 (mojarra 2.0.3)
Reporter: Jeff Howard
Assignee: Stuart Douglas
Labels: groovy
Attachments: full_groovy_support.diff, weld11_partial_groovy_support.diff
Weld created proxies need to know how to work with groovy objects. Currently, weld is
attempting to proxy the methods from the groovy.lang.GroovyObject interface which is
confusing the groovy runtime. Groovy objects have a per-class metaclass that is getting
used with the wrong class instances.
Also, weld is using hyphen characters in the generated proxy class names, which breaks
groovy's dynamic invoke mechanism.
The referenced forum thread contains a patch that addresses the groovy incompatabilities
in weld's ProxyFactory.java
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4 p.m.
New subject: [JBoss JIRA] Commented: (WELD-840) Weld 1.1 breaks compatibility with groovy objects
[
https://issues.jboss.org/browse/WELD-840?page=com.atlassian.jira.plugin.s...
]
Jeff Howard commented on WELD-840:
----------------------------------
Agreed. That patch is simply intended to show you (the Weld developers) where and why
things presently aren't working. It's also sufficient to keep my dev/test
environment running until you guys figure out a real fix. :)
Weld 1.1 breaks compatibility with groovy objects
-------------------------------------------------
Key: WELD-840
URL: https://issues.jboss.org/browse/WELD-840
Project: Weld
Issue Type: Bug
Components: Proxies
Affects Versions: 1.1.0.Final
Environment: Groovy 1.7.6, tomcat 6, weld 1.1, JSF 2 (mojarra 2.0.3)
Reporter: Jeff Howard
Assignee: Stuart Douglas
Labels: groovy
Attachments: full_groovy_support.diff, weld11_partial_groovy_support.diff
Weld created proxies need to know how to work with groovy objects. Currently, weld is
attempting to proxy the methods from the groovy.lang.GroovyObject interface which is
confusing the groovy runtime. Groovy objects have a per-class metaclass that is getting
used with the wrong class instances.
Also, weld is using hyphen characters in the generated proxy class names, which breaks
groovy's dynamic invoke mechanism.
The referenced forum thread contains a patch that addresses the groovy incompatabilities
in weld's ProxyFactory.java
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:24 a.m.
New subject: [JBoss JIRA] (WELD-840) Weld 1.1 breaks compatibility with groovy objects
[
https://issues.jboss.org/browse/WELD-840?page=com.atlassian.jira.plugin.s...
]
Ales Justin commented on WELD-840:
----------------------------------
Stuart, what's the status of this?
Weld 1.1 breaks compatibility with groovy objects
-------------------------------------------------
Key: WELD-840
URL: https://issues.jboss.org/browse/WELD-840
Project: Weld
Issue Type: Bug
Components: Proxies
Affects Versions: 1.1.0.Final
Environment: Groovy 1.7.6, tomcat 6, weld 1.1, JSF 2 (mojarra 2.0.3)
Reporter: Jeff Howard
Assignee: Stuart Douglas
Labels: groovy
Attachments: full_groovy_support.diff, weld11_partial_groovy_support.diff
Weld created proxies need to know how to work with groovy objects. Currently, weld is
attempting to proxy the methods from the groovy.lang.GroovyObject interface which is
confusing the groovy runtime. Groovy objects have a per-class metaclass that is getting
used with the wrong class instances.
Also, weld is using hyphen characters in the generated proxy class names, which breaks
groovy's dynamic invoke mechanism.
The referenced forum thread contains a patch that addresses the groovy incompatabilities
in weld's ProxyFactory.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4452
days inactive
4849
days old
7 comments
2 participants
participants (2)
-
Ales Justin (JIRA) -
Jeff Howard (JIRA)