[JBoss JIRA] (WELD-994) Passivating Beans do not allow Injection of non-serializable Instance injections
10:26 a.m.
Passivating Beans do not allow Injection of non-serializable Instance injections
--------------------------------------------------------------------------------
Key: WELD-994
URL: https://issues.jboss.org/browse/WELD-994
Project: Weld
Issue Type: Bug
Environment: AS 7.0.2
WELD-000900 1.1.2 (Final)
Reporter: Cody Lerum
Given the following Code
{code:java}
@ConversationScoped
@Named
public class EmailTester implements Serializable {
private static final long serialVersionUID = 1L;
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private ActiveUser activeUser;
@Inject
private Messages messages;
@Inject
private Instance<Session> session;
public void send()
{
MailMessage m = mailMessage.get();
m.from(activeUser.getUser());
m.to(activeUser.getUser());
m.subject("test");
m.bodyText("Blah blah blah");
m.send(session.get());
messages.info("Message Sent");
}
}
{code}
Weld throws
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca:
javax.faces.FacesException: #{emailTester.send()}:
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoin!
t@2146ca
Since a new instance is returned each time a get() is called it should not matter that the
javax.mail.Session is not non-serializable
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:26 a.m.
[
https://issues.jboss.org/browse/WELD-994?page=com.atlassian.jira.plugin.s...
]
Cody Lerum updated WELD-994:
----------------------------
Affects Version/s: 1.1.2.Final
Passivating Beans do not allow Injection of non-serializable Instance
injections
--------------------------------------------------------------------------------
Key: WELD-994
URL: https://issues.jboss.org/browse/WELD-994
Project: Weld
Issue Type: Bug
Affects Versions: 1.1.2.Final
Environment: AS 7.0.2
WELD-000900 1.1.2 (Final)
Reporter: Cody Lerum
Given the following Code
{code:java}
@ConversationScoped
@Named
public class EmailTester implements Serializable {
private static final long serialVersionUID = 1L;
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private ActiveUser activeUser;
@Inject
private Messages messages;
@Inject
private Instance<Session> session;
public void send()
{
MailMessage m = mailMessage.get();
m.from(activeUser.getUser());
m.to(activeUser.getUser());
m.subject("test");
m.bodyText("Blah blah blah");
m.send(session.get());
messages.info("Message Sent");
}
}
{code}
Weld throws
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca:
javax.faces.FacesException: #{emailTester.send()}:
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca
Since a new instance is returned each time a get() is called it should not matter that
the javax.mail.Session is not non-serializable
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:58 a.m.
[
https://issues.jboss.org/browse/WELD-994?page=com.atlassian.jira.plugin.s...
]
Pete Muir commented on WELD-994:
--------------------------------
Spec says "If a producer method or field of scope @Dependent returns an
unserializable object for injection into an injection point that requires a passivation
capable dependency, the container must throw an Illegal- ProductException"
In this case the Instance interposes, so the injection point is passivation capable. Just
need to upgrade the checks in AbstractProducerBean.
Passivating Beans do not allow Injection of non-serializable Instance
injections
--------------------------------------------------------------------------------
Key: WELD-994
URL: https://issues.jboss.org/browse/WELD-994
Project: Weld
Issue Type: Bug
Affects Versions: 1.1.2.Final
Environment: AS 7.0.2
WELD-000900 1.1.2 (Final)
Reporter: Cody Lerum
Given the following Code
{code:java}
@ConversationScoped
@Named
public class EmailTester implements Serializable {
private static final long serialVersionUID = 1L;
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private ActiveUser activeUser;
@Inject
private Messages messages;
@Inject
private Instance<Session> session;
public void send()
{
MailMessage m = mailMessage.get();
m.from(activeUser.getUser());
m.to(activeUser.getUser());
m.subject("test");
m.bodyText("Blah blah blah");
m.send(session.get());
messages.info("Message Sent");
}
}
{code}
Weld throws
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca:
javax.faces.FacesException: #{emailTester.send()}:
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca
Since a new instance is returned each time a get() is called it should not matter that
the javax.mail.Session is not non-serializable
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:19 a.m.
[
https://issues.jboss.org/browse/WELD-994?page=com.atlassian.jira.plugin.s...
]
Jozef Hartinger updated WELD-994:
---------------------------------
Fix Version/s: 1.2.0.Beta1
Component/s: Producers (Methods, Fields and Disposers)
Passivating Beans do not allow Injection of non-serializable Instance
injections
--------------------------------------------------------------------------------
Key: WELD-994
URL: https://issues.jboss.org/browse/WELD-994
Project: Weld
Issue Type: Bug
Components: Producers (Methods, Fields and Disposers)
Affects Versions: 1.1.2.Final
Environment: AS 7.0.2
WELD-000900 1.1.2 (Final)
Reporter: Cody Lerum
Fix For: 1.2.0.Beta1
Given the following Code
{code:java}
@ConversationScoped
@Named
public class EmailTester implements Serializable {
private static final long serialVersionUID = 1L;
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private ActiveUser activeUser;
@Inject
private Messages messages;
@Inject
private Instance<Session> session;
public void send()
{
MailMessage m = mailMessage.get();
m.from(activeUser.getUser());
m.to(activeUser.getUser());
m.subject("test");
m.bodyText("Blah blah blah");
m.send(session.get());
messages.info("Message Sent");
}
}
{code}
Weld throws
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca:
javax.faces.FacesException: #{emailTester.send()}:
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca
Since a new instance is returned each time a get() is called it should not matter that
the javax.mail.Session is not non-serializable
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:58 a.m.
[
https://issues.jboss.org/browse/WELD-994?page=com.atlassian.jira.plugin.s...
]
Ales Justin reassigned WELD-994:
--------------------------------
Assignee: Marko Lukša
Passivating Beans do not allow Injection of non-serializable Instance
injections
--------------------------------------------------------------------------------
Key: WELD-994
URL: https://issues.jboss.org/browse/WELD-994
Project: Weld
Issue Type: Bug
Components: Producers (Methods, Fields and Disposers)
Affects Versions: 1.1.2.Final
Environment: AS 7.0.2
WELD-000900 1.1.2 (Final)
Reporter: Cody Lerum
Assignee: Marko Lukša
Fix For: 1.2.0.Beta1
Given the following Code
{code:java}
@ConversationScoped
@Named
public class EmailTester implements Serializable {
private static final long serialVersionUID = 1L;
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private ActiveUser activeUser;
@Inject
private Messages messages;
@Inject
private Instance<Session> session;
public void send()
{
MailMessage m = mailMessage.get();
m.from(activeUser.getUser());
m.to(activeUser.getUser());
m.subject("test");
m.bodyText("Blah blah blah");
m.send(session.get());
messages.info("Message Sent");
}
}
{code}
Weld throws
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca:
javax.faces.FacesException: #{emailTester.send()}:
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca
Since a new instance is returned each time a get() is called it should not matter that
the javax.mail.Session is not non-serializable
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:06 p.m.
[
https://issues.jboss.org/browse/WELD-994?page=com.atlassian.jira.plugin.s...
]
Marko Lukša resolved WELD-994.
------------------------------
Resolution: Done
Passivating Beans do not allow Injection of non-serializable Instance
injections
--------------------------------------------------------------------------------
Key: WELD-994
URL: https://issues.jboss.org/browse/WELD-994
Project: Weld
Issue Type: Bug
Components: Producers (Methods, Fields and Disposers)
Affects Versions: 1.1.2.Final
Environment: AS 7.0.2
WELD-000900 1.1.2 (Final)
Reporter: Cody Lerum
Assignee: Marko Lukša
Fix For: 1.2.0.Beta1
Given the following Code
{code:java}
@ConversationScoped
@Named
public class EmailTester implements Serializable {
private static final long serialVersionUID = 1L;
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private ActiveUser activeUser;
@Inject
private Messages messages;
@Inject
private Instance<Session> session;
public void send()
{
MailMessage m = mailMessage.get();
m.from(activeUser.getUser());
m.to(activeUser.getUser());
m.subject("test");
m.bodyText("Blah blah blah");
m.send(session.get());
messages.info("Message Sent");
}
}
{code}
Weld throws
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca:
javax.faces.FacesException: #{emailTester.send()}:
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca
Since a new instance is returned each time a get() is called it should not matter that
the javax.mail.Session is not non-serializable
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:45 a.m.
[
https://issues.jboss.org/browse/WELD-994?page=com.atlassian.jira.plugin.s...
]
Marek Schmidt reopened WELD-994:
--------------------------------
I believe this new behavior is wrong,
per 6.4.1.
"An instance of a bean with scope @Dependent obtained by direct invocation of an
Instance is a dependent object of the instance of Instance."
but the "instance of Instance" is itself a dependent object of the instance of
EmailTester (in the example)
This means all of those instances created with .get() must be kept around so they can be
properly destroyed, even if the emailTester has been passivated in the mean time.
Ergo, either Weld is not spec compliant and ignores the dependent objects of Instance, or
it doesn't work and will fail during passivation.
Passivating Beans do not allow Injection of non-serializable Instance
injections
--------------------------------------------------------------------------------
Key: WELD-994
URL: https://issues.jboss.org/browse/WELD-994
Project: Weld
Issue Type: Bug
Components: Producers (Methods, Fields and Disposers)
Affects Versions: 1.1.2.Final
Environment: AS 7.0.2
WELD-000900 1.1.2 (Final)
Reporter: Cody Lerum
Assignee: Marko Lukša
Fix For: 1.2.0.Beta1
Given the following Code
{code:java}
@ConversationScoped
@Named
public class EmailTester implements Serializable {
private static final long serialVersionUID = 1L;
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private ActiveUser activeUser;
@Inject
private Messages messages;
@Inject
private Instance<Session> session;
public void send()
{
MailMessage m = mailMessage.get();
m.from(activeUser.getUser());
m.to(activeUser.getUser());
m.subject("test");
m.bodyText("Blah blah blah");
m.send(session.get());
messages.info("Message Sent");
}
}
{code}
Weld throws
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca:
javax.faces.FacesException: #{emailTester.send()}:
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca
Since a new instance is returned each time a get() is called it should not matter that
the javax.mail.Session is not non-serializable
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:37 a.m.
[
https://issues.jboss.org/browse/WELD-994?page=com.atlassian.jira.plugin.s...
]
Pete Muir commented on WELD-994:
--------------------------------
I guess we have to revert this. What a pain.
Passivating Beans do not allow Injection of non-serializable Instance
injections
--------------------------------------------------------------------------------
Key: WELD-994
URL: https://issues.jboss.org/browse/WELD-994
Project: Weld
Issue Type: Bug
Components: Producers (Methods, Fields and Disposers)
Affects Versions: 1.1.2.Final
Environment: AS 7.0.2
WELD-000900 1.1.2 (Final)
Reporter: Cody Lerum
Assignee: Marko Lukša
Fix For: 1.2.0.Beta1
Given the following Code
{code:java}
@ConversationScoped
@Named
public class EmailTester implements Serializable {
private static final long serialVersionUID = 1L;
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private ActiveUser activeUser;
@Inject
private Messages messages;
@Inject
private Instance<Session> session;
public void send()
{
MailMessage m = mailMessage.get();
m.from(activeUser.getUser());
m.to(activeUser.getUser());
m.subject("test");
m.bodyText("Blah blah blah");
m.send(session.get());
messages.info("Message Sent");
}
}
{code}
Weld throws
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca:
javax.faces.FacesException: #{emailTester.send()}:
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca
Since a new instance is returned each time a get() is called it should not matter that
the javax.mail.Session is not non-serializable
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:39 a.m.
[
https://issues.jboss.org/browse/WELD-994?page=com.atlassian.jira.plugin.s...
]
Pete Muir commented on WELD-994:
--------------------------------
This is a key use case for Instance though, so I'm not sure. Maybe we need to offer
both modes - did we ever add the option to not @PreDestroy dependent instances got via
Instance?
Passivating Beans do not allow Injection of non-serializable Instance
injections
--------------------------------------------------------------------------------
Key: WELD-994
URL: https://issues.jboss.org/browse/WELD-994
Project: Weld
Issue Type: Bug
Components: Producers (Methods, Fields and Disposers)
Affects Versions: 1.1.2.Final
Environment: AS 7.0.2
WELD-000900 1.1.2 (Final)
Reporter: Cody Lerum
Assignee: Marko Lukša
Fix For: 1.2.0.Beta1
Given the following Code
{code:java}
@ConversationScoped
@Named
public class EmailTester implements Serializable {
private static final long serialVersionUID = 1L;
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private ActiveUser activeUser;
@Inject
private Messages messages;
@Inject
private Instance<Session> session;
public void send()
{
MailMessage m = mailMessage.get();
m.from(activeUser.getUser());
m.to(activeUser.getUser());
m.subject("test");
m.bodyText("Blah blah blah");
m.send(session.get());
messages.info("Message Sent");
}
}
{code}
Weld throws
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca:
javax.faces.FacesException: #{emailTester.send()}:
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca
Since a new instance is returned each time a get() is called it should not matter that
the javax.mail.Session is not non-serializable
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:48 a.m.
[
https://issues.jboss.org/browse/WELD-994?page=com.atlassian.jira.plugin.s...
]
Marek Schmidt commented on WELD-994:
------------------------------------
Well, for me the most important point is that currently it doesn't work anyway in
weld. The above example will break on cluster as it fails during session replication, as
it keeps the references on those non-serializable instances created with Instance...
Passivating Beans do not allow Injection of non-serializable Instance
injections
--------------------------------------------------------------------------------
Key: WELD-994
URL: https://issues.jboss.org/browse/WELD-994
Project: Weld
Issue Type: Bug
Components: Producers (Methods, Fields and Disposers)
Affects Versions: 1.1.2.Final
Environment: AS 7.0.2
WELD-000900 1.1.2 (Final)
Reporter: Cody Lerum
Assignee: Marko Lukša
Fix For: 1.2.0.Beta1
Given the following Code
{code:java}
@ConversationScoped
@Named
public class EmailTester implements Serializable {
private static final long serialVersionUID = 1L;
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private ActiveUser activeUser;
@Inject
private Messages messages;
@Inject
private Instance<Session> session;
public void send()
{
MailMessage m = mailMessage.get();
m.from(activeUser.getUser());
m.to(activeUser.getUser());
m.subject("test");
m.bodyText("Blah blah blah");
m.send(session.get());
messages.info("Message Sent");
}
}
{code}
Weld throws
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca:
javax.faces.FacesException: #{emailTester.send()}:
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca
Since a new instance is returned each time a get() is called it should not matter that
the javax.mail.Session is not non-serializable
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:50 a.m.
[
https://issues.jboss.org/browse/WELD-994?page=com.atlassian.jira.plugin.s...
]
Marek Schmidt edited comment on WELD-994 at 3/9/12 10:48 AM:
-------------------------------------------------------------
Well, for me the most important point is that currently it doesn't work anyway in
weld. The above example will break on cluster as it fails during session replication, as
it keeps the references on those non-serializable instances created with Instance... (at
least it does seem to be the case on AS7.1.0.Final)
was (Author: maschmid):
Well, for me the most important point is that currently it doesn't work anyway in
weld. The above example will break on cluster as it fails during session replication, as
it keeps the references on those non-serializable instances created with Instance...
Passivating Beans do not allow Injection of non-serializable Instance
injections
--------------------------------------------------------------------------------
Key: WELD-994
URL: https://issues.jboss.org/browse/WELD-994
Project: Weld
Issue Type: Bug
Components: Producers (Methods, Fields and Disposers)
Affects Versions: 1.1.2.Final
Environment: AS 7.0.2
WELD-000900 1.1.2 (Final)
Reporter: Cody Lerum
Assignee: Marko Lukša
Fix For: 1.2.0.Beta1
Given the following Code
{code:java}
@ConversationScoped
@Named
public class EmailTester implements Serializable {
private static final long serialVersionUID = 1L;
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private ActiveUser activeUser;
@Inject
private Messages messages;
@Inject
private Instance<Session> session;
public void send()
{
MailMessage m = mailMessage.get();
m.from(activeUser.getUser());
m.to(activeUser.getUser());
m.subject("test");
m.bodyText("Blah blah blah");
m.send(session.get());
messages.info("Message Sent");
}
}
{code}
Weld throws
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca:
javax.faces.FacesException: #{emailTester.send()}:
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca
Since a new instance is returned each time a get() is called it should not matter that
the javax.mail.Session is not non-serializable
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:03 a.m.
[
https://issues.jboss.org/browse/WELD-994?page=com.atlassian.jira.plugin.s...
]
Marko Lukša resolved WELD-994.
------------------------------
Fix Version/s: (was: 1.2.0.Beta1)
Resolution: Won't Fix
Reverted.
Passivating Beans do not allow Injection of non-serializable Instance
injections
--------------------------------------------------------------------------------
Key: WELD-994
URL: https://issues.jboss.org/browse/WELD-994
Project: Weld
Issue Type: Bug
Components: Producers (Methods, Fields and Disposers)
Affects Versions: 1.1.2.Final
Environment: AS 7.0.2
WELD-000900 1.1.2 (Final)
Reporter: Cody Lerum
Assignee: Marko Lukša
Given the following Code
{code:java}
@ConversationScoped
@Named
public class EmailTester implements Serializable {
private static final long serialVersionUID = 1L;
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private ActiveUser activeUser;
@Inject
private Messages messages;
@Inject
private Instance<Session> session;
public void send()
{
MailMessage m = mailMessage.get();
m.from(activeUser.getUser());
m.to(activeUser.getUser());
m.subject("test");
m.bodyText("Blah blah blah");
m.send(session.get());
messages.info("Message Sent");
}
}
{code}
Weld throws
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca:
javax.faces.FacesException: #{emailTester.send()}:
org.jboss.weld.exceptions.IllegalProductException: WELD-000054 Producers cannot produce
non-serializable instances for injection into non-transient fields of passivating
beans\\n\\nProducer\: Producer Method [Session] with qualifiers [@Any @Default] declared
as [[method] @Produces @ExtensionManaged public
org.jboss.seam.mail.core.MailSessionProducer.getMailSession(MailConfig)]\\nInjection
Point\: org.jboss.weld.bean.builtin.InstanceImpl$InstanceInjectionPoint@2146ca
Since a new instance is returned each time a get() is called it should not matter that
the javax.mail.Session is not non-serializable
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4636
days inactive
4787
days old
11 comments
8 participants
participants (8)
-
Ales Justin (JIRA) -
Cody Lerum (Created) (JIRA)
-
Cody Lerum (Updated) (JIRA)
-
Jozef Hartinger (Updated) (JIRA)
-
Marek Schmidt (JIRA)
-
Marko Lukša (JIRA)
-
Pete Muir (Commented) (JIRA)
-
Pete Muir (JIRA)