8:34 a.m.
Conversation should work on AppEngine
-------------------------------------
Key: WELD-399
URL: https://jira.jboss.org/jira/browse/WELD-399
Project: Weld
Issue Type: Feature Request
Components: Conversations
Affects Versions: 1.0.0.GA
Environment: Google AppEngine 1.3
Reporter: Paul Bakker
Priority: Optional
Weld works pretty well on GAE, which is of course great in combination with JSF 2. The
only problem I've ran into so far is that conversations don't work. GAE
doesn't allow threading, and the cleanup scheduler in Weld brakes this rule.
The problem is in
org.jboss.weld.conversation.AbstractConversationManager.scheduleForTermination(AbstractConversationManager.java:204)
This is obviously not a bug, it's just a GAE problem. I'm not sure how this should
be solved in a clean way, disabling the cleanup task when running on GAE seems like a bad
idea (memory leaks). It might be an idea to create a GAE task queue for cleanup, but this
would require GAE specific code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:38 a.m.
New subject: [JBoss JIRA] Assigned: (WELDX-73) Conversation should work on AppEngine
[
https://jira.jboss.org/jira/browse/WELDX-73?page=com.atlassian.jira.plugi...
]
Pete Muir reassigned WELDX-73:
------------------------------
Assignee: Shane Bryzak
Conversation should work on AppEngine
-------------------------------------
Key: WELDX-73
URL: https://jira.jboss.org/jira/browse/WELDX-73
Project: Weld Extensions
Issue Type: Feature Request
Components: Servlet Containers
Environment: Google AppEngine 1.3
Reporter: Paul Bakker
Assignee: Shane Bryzak
Priority: Optional
Weld works pretty well on GAE, which is of course great in combination with JSF 2. The
only problem I've ran into so far is that conversations don't work. GAE
doesn't allow threading, and the cleanup scheduler in Weld brakes this rule.
The problem is in
org.jboss.weld.conversation.AbstractConversationManager.scheduleForTermination(AbstractConversationManager.java:204)
This is obviously not a bug, it's just a GAE problem. I'm not sure how this
should be solved in a clean way, disabling the cleanup task when running on GAE seems like
a bad idea (memory leaks). It might be an idea to create a GAE task queue for cleanup, but
this would require GAE specific code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:40 a.m.
New subject: [JBoss JIRA] Commented: (WELDX-73) Conversation should work on AppEngine
[
https://jira.jboss.org/jira/browse/WELDX-73?page=com.atlassian.jira.plugi...
]
Pete Muir commented on WELDX-73:
--------------------------------
Yes I would like to support this, by wrapping the google task queue in a
ScheduledExecutorService
Conversation should work on AppEngine
-------------------------------------
Key: WELDX-73
URL: https://jira.jboss.org/jira/browse/WELDX-73
Project: Weld Extensions
Issue Type: Feature Request
Components: Servlet Containers
Environment: Google AppEngine 1.3
Reporter: Paul Bakker
Assignee: Shane Bryzak
Priority: Optional
Weld works pretty well on GAE, which is of course great in combination with JSF 2. The
only problem I've ran into so far is that conversations don't work. GAE
doesn't allow threading, and the cleanup scheduler in Weld brakes this rule.
The problem is in
org.jboss.weld.conversation.AbstractConversationManager.scheduleForTermination(AbstractConversationManager.java:204)
This is obviously not a bug, it's just a GAE problem. I'm not sure how this
should be solved in a clean way, disabling the cleanup task when running on GAE seems like
a bad idea (memory leaks). It might be an idea to create a GAE task queue for cleanup, but
this would require GAE specific code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:11 a.m.
New subject: [JBoss JIRA] Assigned: (WELDX-73) Conversation should work on AppEngine
[
https://jira.jboss.org/jira/browse/WELDX-73?page=com.atlassian.jira.plugi...
]
Pete Muir reassigned WELDX-73:
------------------------------
Assignee: Matija Mazi (was: Shane Bryzak)
Conversation should work on AppEngine
-------------------------------------
Key: WELDX-73
URL: https://jira.jboss.org/jira/browse/WELDX-73
Project: Weld Extensions
Issue Type: Feature Request
Components: Servlet Containers
Environment: Google AppEngine 1.3
Reporter: Paul Bakker
Assignee: Matija Mazi
Priority: Optional
Weld works pretty well on GAE, which is of course great in combination with JSF 2. The
only problem I've ran into so far is that conversations don't work. GAE
doesn't allow threading, and the cleanup scheduler in Weld brakes this rule.
The problem is in
org.jboss.weld.conversation.AbstractConversationManager.scheduleForTermination(AbstractConversationManager.java:204)
This is obviously not a bug, it's just a GAE problem. I'm not sure how this
should be solved in a clean way, disabling the cleanup task when running on GAE seems like
a bad idea (memory leaks). It might be an idea to create a GAE task queue for cleanup, but
this would require GAE specific code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:15 a.m.
New subject: [JBoss JIRA] Work started: (WELDX-73) Conversation should work on AppEngine
[
https://jira.jboss.org/jira/browse/WELDX-73?page=com.atlassian.jira.plugi...
]
Work on WELDX-73 started by Matija Mazi.
Conversation should work on AppEngine
-------------------------------------
Key: WELDX-73
URL: https://jira.jboss.org/jira/browse/WELDX-73
Project: Weld Extensions
Issue Type: Feature Request
Components: Servlet Containers
Environment: Google AppEngine 1.3
Reporter: Paul Bakker
Assignee: Matija Mazi
Priority: Optional
Weld works pretty well on GAE, which is of course great in combination with JSF 2. The
only problem I've ran into so far is that conversations don't work. GAE
doesn't allow threading, and the cleanup scheduler in Weld brakes this rule.
The problem is in
org.jboss.weld.conversation.AbstractConversationManager.scheduleForTermination(AbstractConversationManager.java:204)
This is obviously not a bug, it's just a GAE problem. I'm not sure how this
should be solved in a clean way, disabling the cleanup task when running on GAE seems like
a bad idea (memory leaks). It might be an idea to create a GAE task queue for cleanup, but
this would require GAE specific code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:26 a.m.
New subject: [JBoss JIRA] Closed: (WELDX-73) Conversation should work on AppEngine
[
https://jira.jboss.org/jira/browse/WELDX-73?page=com.atlassian.jira.plugi...
]
Matija Mazi closed WELDX-73.
----------------------------
Resolution: Done
Conversations in GAE do work with Weld built from trunk, as Nicklas pointed out here:
http://relation.to/Bloggers/WeldJSF20AndGoogleAppEngineNavigatingTheMinef...
I've tried it and it works.
Conversation should work on AppEngine
-------------------------------------
Key: WELDX-73
URL: https://jira.jboss.org/jira/browse/WELDX-73
Project: Weld Extensions
Issue Type: Feature Request
Components: Servlet Containers
Environment: Google AppEngine 1.3
Reporter: Paul Bakker
Assignee: Matija Mazi
Priority: Optional
Weld works pretty well on GAE, which is of course great in combination with JSF 2. The
only problem I've ran into so far is that conversations don't work. GAE
doesn't allow threading, and the cleanup scheduler in Weld brakes this rule.
The problem is in
org.jboss.weld.conversation.AbstractConversationManager.scheduleForTermination(AbstractConversationManager.java:204)
This is obviously not a bug, it's just a GAE problem. I'm not sure how this
should be solved in a clean way, disabling the cleanup task when running on GAE seems like
a bad idea (memory leaks). It might be an idea to create a GAE task queue for cleanup, but
this would require GAE specific code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:31 a.m.
New subject: [JBoss JIRA] Commented: (WELDSERVLET-6) Conversation should work on AppEngine
[
https://jira.jboss.org/jira/browse/WELDSERVLET-6?page=com.atlassian.jira....
]
Paul Bakker commented on WELDSERVLET-6:
---------------------------------------
How did you test this? I just built Weld from the trunk but it still doesn't work
(neither on the development server and the production server). If I look at the code I
still find the following in SingleThreadScheduledExecutorServiceFactory:
*code*
this.executorService = Executors.newScheduledThreadPool(1);
*code*
and in AbstractConversationManager:
*code*
private Future<?> scheduleForTermination(String cid, long timeout)
{
Runnable terminationTask = new TerminationTask(cid);
return
Container.instance().services().get(ScheduledExecutorServiceFactory.class).get().schedule(terminationTask,
timeout, TimeUnit.MILLISECONDS);
}
*code*
Calling schedule on a ScheduledExecutorService is not possible on AppEngine as far as I
know. I tested this with the following code too in a plain servlet:
*code*
ScheduledExecutorService exec = Executors.newSingleThreadScheduledExecutor();
Runnable r = new Runnable() {
@Override
public void run() {
System.out.println("test");
}
};
//Throws exception
exec.schedule(r, 5, TimeUnit.SECONDS);
*code*
Although this code creates a single thread, it's still an extra thread, and that's
not allowed by AppEngine. I think Pete's solution is the only way (using the task
queue).
Conversation should work on AppEngine
-------------------------------------
Key: WELDSERVLET-6
URL: https://jira.jboss.org/jira/browse/WELDSERVLET-6
Project: Weld Servlet
Issue Type: Feature Request
Environment: Google AppEngine 1.3
Reporter: Paul Bakker
Assignee: Matija Mazi
Priority: Optional
Weld works pretty well on GAE, which is of course great in combination with JSF 2. The
only problem I've ran into so far is that conversations don't work. GAE
doesn't allow threading, and the cleanup scheduler in Weld brakes this rule.
The problem is in
org.jboss.weld.conversation.AbstractConversationManager.scheduleForTermination(AbstractConversationManager.java:204)
This is obviously not a bug, it's just a GAE problem. I'm not sure how this
should be solved in a clean way, disabling the cleanup task when running on GAE seems like
a bad idea (memory leaks). It might be an idea to create a GAE task queue for cleanup, but
this would require GAE specific code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:39 a.m.
New subject: [JBoss JIRA] Commented: (WELDSERVLET-6) Conversation should work on AppEngine
[
https://jira.jboss.org/jira/browse/WELDSERVLET-6?page=com.atlassian.jira....
]
Matija Mazi commented on WELDSERVLET-6:
---------------------------------------
I have an application that is configured as detailed in
http://relation.to/Bloggers/WeldJSF20AndGoogleAppEngineNavigatingTheMinef... . A
Conversation is used like this:
@ConversationScoped
@Named
public class Registerer implements Serializable
{
private User user = new User();
private Conversation conversation;
@PostConstruct
public void init()
{
conversation.begin();
}
public User getUser()
{
return user;
}
public View next()
{
// First step: user's fields have been partially populated from a web form
return register2;
}
public View saveUser()
{
// Second step: user's fields have been fully populated from a web form
conversation.end();
// save user
return home;
}
@Inject
public void setConversation(Conversation conversation)
{
this.conversation = conversation;
}
}
There are two relevant views, register and register2, both showing a form for entering a
part of user data. This works as expected with Weld from trunk, but throws an exception (a
Google's Exception complaining that threads are not allowed) with Weld 1.0.1-Final. I
tested this only in the development GAE server.
As far as I can see from code, scheduleForTermination() in AbstractConversationManager can
only be called if asynchronous has been set to true, which it is not by default. Does your
application somehow set this flag?
Implementing a ScheduledExecutorService that uses the Google task queue is probably a good
idea but I think it belongs to a separate Jira issue.
Conversation should work on AppEngine
-------------------------------------
Key: WELDSERVLET-6
URL: https://jira.jboss.org/jira/browse/WELDSERVLET-6
Project: Weld Servlet
Issue Type: Feature Request
Environment: Google AppEngine 1.3
Reporter: Paul Bakker
Assignee: Matija Mazi
Priority: Optional
Weld works pretty well on GAE, which is of course great in combination with JSF 2. The
only problem I've ran into so far is that conversations don't work. GAE
doesn't allow threading, and the cleanup scheduler in Weld brakes this rule.
The problem is in
org.jboss.weld.conversation.AbstractConversationManager.scheduleForTermination(AbstractConversationManager.java:204)
This is obviously not a bug, it's just a GAE problem. I'm not sure how this
should be solved in a clean way, disabling the cleanup task when running on GAE seems like
a bad idea (memory leaks). It might be an idea to create a GAE task queue for cleanup, but
this would require GAE specific code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:36 a.m.
New subject: [JBoss JIRA] Commented: (WELDSERVLET-6) Conversation should work on AppEngine
[
https://jira.jboss.org/jira/browse/WELDSERVLET-6?page=com.atlassian.jira....
]
Paul Bakker commented on WELDSERVLET-6:
---------------------------------------
Turns out I was looking at old source code. I checked out weld-servlet from the trunk, but
I just found in the pom.xml that there is a dependency to weld-core 1.0.1-FINAL instead of
1.0.2-SNAPSHOT. I'm not sure this is intended, but to my opinion it would be more
logical to depend on the snapshot. Anyway, this is not related to this issue.
After changing the dependency it works like you said, so I can confirm it works. Thanks
for looking at it again.
Conversation should work on AppEngine
-------------------------------------
Key: WELDSERVLET-6
URL: https://jira.jboss.org/jira/browse/WELDSERVLET-6
Project: Weld Servlet
Issue Type: Feature Request
Environment: Google AppEngine 1.3
Reporter: Paul Bakker
Assignee: Matija Mazi
Priority: Optional
Weld works pretty well on GAE, which is of course great in combination with JSF 2. The
only problem I've ran into so far is that conversations don't work. GAE
doesn't allow threading, and the cleanup scheduler in Weld brakes this rule.
The problem is in
org.jboss.weld.conversation.AbstractConversationManager.scheduleForTermination(AbstractConversationManager.java:204)
This is obviously not a bug, it's just a GAE problem. I'm not sure how this
should be solved in a clean way, disabling the cleanup task when running on GAE seems like
a bad idea (memory leaks). It might be an idea to create a GAE task queue for cleanup, but
this would require GAE specific code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5148
days inactive
5234
days old
8 comments
3 participants
participants (3)
-
Matija Mazi (JIRA) -
Paul Bakker (JIRA)
-
Pete Muir (JIRA)