6:46 a.m.
@Alternative @Specializes does not work
---------------------------------------
Key: WELD-974
URL: https://issues.jboss.org/browse/WELD-974
Project: Weld
Issue Type: Bug
Reporter: Geoffrey De Smet
Priority: Critical
See pull request with testcase.
{code}
@ApplicationScoped
@Named("namedFoo") // doesn't matter if it's @Named or not
public class NamedFoo
{
}
@Alternative @Specializes
public class SpecializesNamedFoo extends NamedFoo
{
}
@Test
public void testSpecializationWithAlternative()
{
Assert.assertEquals(NamedFoo.class,
beanManager.resolve(beanManager.getBeans(NamedFoo.class)).getBeanClass()); // FAILS WITH
NPE!
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:48 a.m.
New subject: [JBoss JIRA] Commented: (WELD-974) @Alternative @Specializes does not work
[
https://issues.jboss.org/browse/WELD-974?page=com.atlassian.jira.plugin.s...
]
Geoffrey De Smet commented on WELD-974:
---------------------------------------
Here's the pull request with the failing testcase:
https://github.com/weld/core/pull/134
@Alternative @Specializes does not work
---------------------------------------
Key: WELD-974
URL: https://issues.jboss.org/browse/WELD-974
Project: Weld
Issue Type: Bug
Reporter: Geoffrey De Smet
Priority: Critical
See pull request with testcase.
{code}
@ApplicationScoped
@Named("namedFoo") // doesn't matter if it's @Named or not
public class NamedFoo
{
}
@Alternative @Specializes
public class SpecializesNamedFoo extends NamedFoo
{
}
@Test
public void testSpecializationWithAlternative()
{
Assert.assertEquals(NamedFoo.class,
beanManager.resolve(beanManager.getBeans(NamedFoo.class)).getBeanClass()); // FAILS WITH
NPE!
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:50 a.m.
New subject: [JBoss JIRA] Updated: (WELD-974) @Alternative @Specializes does not work
[
https://issues.jboss.org/browse/WELD-974?page=com.atlassian.jira.plugin.s...
]
Geoffrey De Smet updated WELD-974:
----------------------------------
Affects Version/s: 1.1.2.Final
@Alternative @Specializes does not work
---------------------------------------
Key: WELD-974
URL: https://issues.jboss.org/browse/WELD-974
Project: Weld
Issue Type: Bug
Affects Versions: 1.1.2.Final
Reporter: Geoffrey De Smet
Priority: Critical
See pull request with testcase.
{code}
@ApplicationScoped
@Named("namedFoo") // doesn't matter if it's @Named or not
public class NamedFoo
{
}
@Alternative @Specializes
public class SpecializesNamedFoo extends NamedFoo
{
}
@Test
public void testSpecializationWithAlternative()
{
Assert.assertEquals(NamedFoo.class,
beanManager.resolve(beanManager.getBeans(NamedFoo.class)).getBeanClass()); // FAILS WITH
NPE!
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:02 a.m.
New subject: [JBoss JIRA] (WELD-974) @Alternative @Specializes does not work
[
https://issues.jboss.org/browse/WELD-974?page=com.atlassian.jira.plugin.s...
]
Jens Augustsson commented on WELD-974:
--------------------------------------
Geoffrey,
First, I assume you'd like to resolve your SpecializesNamedFoo, not NamedFoo?
{code}
@Test
public void testSpecializationWithAlternative() {
Assert.assertEquals(SpecializesNamedFoo.class, beanManager.resolve(beanManager.getBeans(NamedFoo.class)).getBeanClass());
}
{code}
Second, I believe the behavior is expected, because according to the spec, alternatives
should be by default disabled unless you enable them in beans.xml. So if I modify your
test case to reflect this, it passes the test:
{code}
@Deployment
public static Archive<?> deploy() {
return ShrinkWrap.create(BeanArchive.class)
.alternate(SpecializesNamedFoo.class)
.addPackage(SpecializationTest.class.getPackage());
}
{code}
Or?
br,
Jens
@Alternative @Specializes does not work
---------------------------------------
Key: WELD-974
URL: https://issues.jboss.org/browse/WELD-974
Project: Weld
Issue Type: Bug
Affects Versions: 1.1.2.Final
Reporter: Geoffrey De Smet
Priority: Critical
See pull request with testcase.
{code}
@ApplicationScoped
@Named("namedFoo") // doesn't matter if it's @Named or not
public class NamedFoo
{
}
@Alternative @Specializes
public class SpecializesNamedFoo extends NamedFoo
{
}
@Test
public void testSpecializationWithAlternative()
{
Assert.assertEquals(NamedFoo.class,
beanManager.resolve(beanManager.getBeans(NamedFoo.class)).getBeanClass()); // FAILS WITH
NPE!
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:27 a.m.
New subject: [JBoss JIRA] (WELD-974) @Alternative @Specializes does not work
[
https://issues.jboss.org/browse/WELD-974?page=com.atlassian.jira.plugin.s...
]
Geoffrey De Smet commented on WELD-974:
---------------------------------------
Hi Jens,
The alternative is deliberately not activated: the testcase should expect to get a
NamedFoo.class instead, not a SpecializesNamedFoo.class.
The bug is that the presence of SpecalizesNamedFoo creates an NPE on
{code}
beanManager.resolve(beanManager.getBeans(NamedFoo.class))
{code}
@Alternative @Specializes does not work
---------------------------------------
Key: WELD-974
URL: https://issues.jboss.org/browse/WELD-974
Project: Weld
Issue Type: Bug
Affects Versions: 1.1.2.Final
Reporter: Geoffrey De Smet
Priority: Critical
See pull request with testcase.
{code}
@ApplicationScoped
@Named("namedFoo") // doesn't matter if it's @Named or not
public class NamedFoo
{
}
@Alternative @Specializes
public class SpecializesNamedFoo extends NamedFoo
{
}
@Test
public void testSpecializationWithAlternative()
{
Assert.assertEquals(NamedFoo.class,
beanManager.resolve(beanManager.getBeans(NamedFoo.class)).getBeanClass()); // FAILS WITH
NPE!
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:22 a.m.
New subject: [JBoss JIRA] (WELD-974) @Alternative @Specializes does not work
[
https://issues.jboss.org/browse/WELD-974?page=com.atlassian.jira.plugin.s...
]
Jens Augustsson commented on WELD-974:
--------------------------------------
...ah, point taken!
@Alternative @Specializes does not work
---------------------------------------
Key: WELD-974
URL: https://issues.jboss.org/browse/WELD-974
Project: Weld
Issue Type: Bug
Affects Versions: 1.1.2.Final
Reporter: Geoffrey De Smet
Priority: Critical
See pull request with testcase.
{code}
@ApplicationScoped
@Named("namedFoo") // doesn't matter if it's @Named or not
public class NamedFoo
{
}
@Alternative @Specializes
public class SpecializesNamedFoo extends NamedFoo
{
}
@Test
public void testSpecializationWithAlternative()
{
Assert.assertEquals(NamedFoo.class,
beanManager.resolve(beanManager.getBeans(NamedFoo.class)).getBeanClass()); // FAILS WITH
NPE!
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:16 a.m.
New subject: [JBoss JIRA] (WELD-974) @Alternative @Specializes does not work
[
https://issues.jboss.org/browse/WELD-974?page=com.atlassian.jira.plugin.s...
]
Geoffrey De Smet resolved WELD-974.
-----------------------------------
Fix Version/s: 1.1.4.Final
Resolution: Done
This is fixed in 1.1.4.Final, probably by Ales's work.
I 'll poke him to add the regression test to weld's master if he hasn't a
similar one already.
@Alternative @Specializes does not work
---------------------------------------
Key: WELD-974
URL: https://issues.jboss.org/browse/WELD-974
Project: Weld
Issue Type: Bug
Affects Versions: 1.1.2.Final
Reporter: Geoffrey De Smet
Priority: Critical
Fix For: 1.1.4.Final
See pull request with testcase.
{code}
@ApplicationScoped
@Named("namedFoo") // doesn't matter if it's @Named or not
public class NamedFoo
{
}
@Alternative @Specializes
public class SpecializesNamedFoo extends NamedFoo
{
}
@Test
public void testSpecializationWithAlternative()
{
Assert.assertEquals(NamedFoo.class,
beanManager.resolve(beanManager.getBeans(NamedFoo.class)).getBeanClass()); // FAILS WITH
NPE!
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:46 a.m.
New subject: [JBoss JIRA] (WELD-974) @Alternative @Specializes does not work
[
https://issues.jboss.org/browse/WELD-974?page=com.atlassian.jira.plugin.s...
]
Ales Justin reassigned WELD-974:
--------------------------------
Assignee: Ales Justin
@Alternative @Specializes does not work
---------------------------------------
Key: WELD-974
URL: https://issues.jboss.org/browse/WELD-974
Project: Weld
Issue Type: Bug
Affects Versions: 1.1.2.Final
Reporter: Geoffrey De Smet
Assignee: Ales Justin
Priority: Critical
Fix For: 1.1.4.Final
See pull request with testcase.
{code}
@ApplicationScoped
@Named("namedFoo") // doesn't matter if it's @Named or not
public class NamedFoo
{
}
@Alternative @Specializes
public class SpecializesNamedFoo extends NamedFoo
{
}
@Test
public void testSpecializationWithAlternative()
{
Assert.assertEquals(NamedFoo.class,
beanManager.resolve(beanManager.getBeans(NamedFoo.class)).getBeanClass()); // FAILS WITH
NPE!
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4784
days inactive
4855
days old
7 comments
5 participants
participants (5)
-
Ales Justin (Assigned) (JIRA) -
Geoffrey De Smet (Commented) (JIRA)
-
Geoffrey De Smet (JIRA)
-
Geoffrey De Smet (Resolved) (JIRA)
-
Jens Augustsson (Commented) (JIRA)