3:21 a.m.
Weld allows for concurrent call to conversation
-----------------------------------------------
Key: WELD-865
URL: https://issues.jboss.org/browse/WELD-865
Project: Weld
Issue Type: Bug
Components: Scopes & Contexts, Web Tier integration (JSF, JSP, EL and
Servlet)
Affects Versions: 1.1.0.Final
Reporter: George Sapountzis
Concurrent calls to a @ConversationScoped component:
Thread 1:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns true
correctly proceed inside method
Thread 2:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns false but activate() does not check
result !!!
*incorrectly* proceed inside method
----
I think AbstractConversationContext.activate(String cid) should check the result of
ConversationImpl.lock(long timeout) and not allow the second thread to proceed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:43 p.m.
New subject: [JBoss JIRA] Assigned: (WELD-865) Weld allows for concurrent call to conversation
[
https://issues.jboss.org/browse/WELD-865?page=com.atlassian.jira.plugin.s...
]
Ales Justin reassigned WELD-865:
--------------------------------
Assignee: Ales Justin
Weld allows for concurrent call to conversation
-----------------------------------------------
Key: WELD-865
URL: https://issues.jboss.org/browse/WELD-865
Project: Weld
Issue Type: Bug
Components: Scopes & Contexts, Web Tier integration (JSF, JSP, EL and
Servlet)
Affects Versions: 1.1.0.Final
Reporter: George Sapountzis
Assignee: Ales Justin
Concurrent calls to a @ConversationScoped component:
Thread 1:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns true
correctly proceed inside method
Thread 2:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns false but activate() does not check
result !!!
*incorrectly* proceed inside method
----
I think AbstractConversationContext.activate(String cid) should check the result of
ConversationImpl.lock(long timeout) and not allow the second thread to proceed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:32 p.m.
New subject: [JBoss JIRA] Work started: (WELD-865) Weld allows for concurrent call to conversation
[
https://issues.jboss.org/browse/WELD-865?page=com.atlassian.jira.plugin.s...
]
Work on WELD-865 started by Ales Justin.
Weld allows for concurrent call to conversation
-----------------------------------------------
Key: WELD-865
URL: https://issues.jboss.org/browse/WELD-865
Project: Weld
Issue Type: Bug
Components: Scopes & Contexts, Web Tier integration (JSF, JSP, EL and
Servlet)
Affects Versions: 1.1.0.Final
Reporter: George Sapountzis
Assignee: Ales Justin
Concurrent calls to a @ConversationScoped component:
Thread 1:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns true
correctly proceed inside method
Thread 2:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns false but activate() does not check
result !!!
*incorrectly* proceed inside method
----
I think AbstractConversationContext.activate(String cid) should check the result of
ConversationImpl.lock(long timeout) and not allow the second thread to proceed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:06 a.m.
New subject: [JBoss JIRA] Resolved: (WELD-865) Weld allows for concurrent call to conversation
[
https://issues.jboss.org/browse/WELD-865?page=com.atlassian.jira.plugin.s...
]
Ales Justin resolved WELD-865.
------------------------------
Fix Version/s: 1.2.0.Beta1
Resolution: Done
Weld allows for concurrent call to conversation
-----------------------------------------------
Key: WELD-865
URL: https://issues.jboss.org/browse/WELD-865
Project: Weld
Issue Type: Bug
Components: Scopes & Contexts, Web Tier integration (JSF, JSP, EL and
Servlet)
Affects Versions: 1.1.0.Final
Reporter: George Sapountzis
Assignee: Ales Justin
Fix For: 1.2.0.Beta1
Concurrent calls to a @ConversationScoped component:
Thread 1:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns true
correctly proceed inside method
Thread 2:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns false but activate() does not check
result !!!
*incorrectly* proceed inside method
----
I think AbstractConversationContext.activate(String cid) should check the result of
ConversationImpl.lock(long timeout) and not allow the second thread to proceed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:06 a.m.
New subject: [JBoss JIRA] Closed: (WELD-865) Weld allows for concurrent call to conversation
[
https://issues.jboss.org/browse/WELD-865?page=com.atlassian.jira.plugin.s...
]
Ales Justin closed WELD-865.
----------------------------
Weld allows for concurrent call to conversation
-----------------------------------------------
Key: WELD-865
URL: https://issues.jboss.org/browse/WELD-865
Project: Weld
Issue Type: Bug
Components: Scopes & Contexts, Web Tier integration (JSF, JSP, EL and
Servlet)
Affects Versions: 1.1.0.Final
Reporter: George Sapountzis
Assignee: Ales Justin
Fix For: 1.2.0.Beta1
Concurrent calls to a @ConversationScoped component:
Thread 1:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns true
correctly proceed inside method
Thread 2:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns false but activate() does not check
result !!!
*incorrectly* proceed inside method
----
I think AbstractConversationContext.activate(String cid) should check the result of
ConversationImpl.lock(long timeout) and not allow the second thread to proceed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:07 a.m.
New subject: [JBoss JIRA] Reopened: (WELD-865) Weld allows for concurrent call to conversation
[
https://issues.jboss.org/browse/WELD-865?page=com.atlassian.jira.plugin.s...
]
George Sapountzis reopened WELD-865:
------------------------------------
From BusyConversationException javadoc:
Indicates that the container has rejected a request because a concurrent request is
associated with the same conversation context.
The container ensures that a long-running conversation may be associated with at most one
request at a time, by blocking or rejecting concurrent requests. If the container rejects
a request, it must associate the request with a new transient conversation and throw an
exception of type BusyConversationException from the restore view phase of the JSF
lifecycle.
So I think that AbstractConversationContext.activate() should throw
BusyConversationException which should caught, handled and re-thrown in WeldPhaseListener.
Something like:
try
{
conversationContext.activate(cid);
}
catch(BusyConversationException bce)
{
conversationContext.deactivate(); // XXX what else here ?
throw bce;
}
}
Weld allows for concurrent call to conversation
-----------------------------------------------
Key: WELD-865
URL: https://issues.jboss.org/browse/WELD-865
Project: Weld
Issue Type: Bug
Components: Scopes & Contexts, Web Tier integration (JSF, JSP, EL and
Servlet)
Affects Versions: 1.1.0.Final
Reporter: George Sapountzis
Assignee: Ales Justin
Fix For: 1.2.0.Beta1
Concurrent calls to a @ConversationScoped component:
Thread 1:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns true
correctly proceed inside method
Thread 2:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns false but activate() does not check
result !!!
*incorrectly* proceed inside method
----
I think AbstractConversationContext.activate(String cid) should check the result of
ConversationImpl.lock(long timeout) and not allow the second thread to proceed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:16 a.m.
New subject: [JBoss JIRA] Commented: (WELD-865) Weld allows for concurrent call to conversation
[
https://issues.jboss.org/browse/WELD-865?page=com.atlassian.jira.plugin.s...
]
Ales Justin commented on WELD-865:
----------------------------------
I'm now throwing BusyConversationException.
I'll think about the XXX and other things we need to handle.
Weld allows for concurrent call to conversation
-----------------------------------------------
Key: WELD-865
URL: https://issues.jboss.org/browse/WELD-865
Project: Weld
Issue Type: Bug
Components: Scopes & Contexts, Web Tier integration (JSF, JSP, EL and
Servlet)
Affects Versions: 1.1.0.Final
Reporter: George Sapountzis
Assignee: Ales Justin
Fix For: 1.2.0.Beta1
Concurrent calls to a @ConversationScoped component:
Thread 1:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns true
correctly proceed inside method
Thread 2:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns false but activate() does not check
result !!!
*incorrectly* proceed inside method
----
I think AbstractConversationContext.activate(String cid) should check the result of
ConversationImpl.lock(long timeout) and not allow the second thread to proceed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:04 a.m.
New subject: [JBoss JIRA] Updated: (WELD-865) Weld allows for concurrent call to conversation
[
https://issues.jboss.org/browse/WELD-865?page=com.atlassian.jira.plugin.s...
]
Ales Justin updated WELD-865:
-----------------------------
Fix Version/s: 1.2.0.Beta1
(was: 1.1.1.Final)
The lock check is in place,
but per-spec behavior will be implemented later.
Weld allows for concurrent call to conversation
-----------------------------------------------
Key: WELD-865
URL: https://issues.jboss.org/browse/WELD-865
Project: Weld
Issue Type: Bug
Components: Scopes & Contexts, Web Tier integration (JSF, JSP, EL and
Servlet)
Affects Versions: 1.1.0.Final
Reporter: George Sapountzis
Assignee: Ales Justin
Fix For: 1.2.0.Beta1
Concurrent calls to a @ConversationScoped component:
Thread 1:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns true
correctly proceed inside method
Thread 2:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns false but activate() does not check
result !!!
*incorrectly* proceed inside method
----
I think AbstractConversationContext.activate(String cid) should check the result of
ConversationImpl.lock(long timeout) and not allow the second thread to proceed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:51 p.m.
New subject: [JBoss JIRA] Updated: (WELD-865) Weld allows for concurrent call to conversation
[
https://issues.jboss.org/browse/WELD-865?page=com.atlassian.jira.plugin.s...
]
George Sapountzis updated WELD-865:
-----------------------------------
Attachment: untested-test-failure-condition-first.patch
What about locking first (i.e. testing the failure condition) and then deciding which
conversation to activate ?
The attached patch does this but is untested, the naming could be better or we could call
activateRequest() from WeldPhaseListener ...
Weld allows for concurrent call to conversation
-----------------------------------------------
Key: WELD-865
URL: https://issues.jboss.org/browse/WELD-865
Project: Weld
Issue Type: Bug
Components: Scopes & Contexts, Web Tier integration (JSF, JSP, EL and
Servlet)
Affects Versions: 1.1.0.Final
Reporter: George Sapountzis
Assignee: Ales Justin
Fix For: 1.2.0.Beta1
Attachments: untested-test-failure-condition-first.patch
Concurrent calls to a @ConversationScoped component:
Thread 1:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns true
correctly proceed inside method
Thread 2:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns false but activate() does not check
result !!!
*incorrectly* proceed inside method
----
I think AbstractConversationContext.activate(String cid) should check the result of
ConversationImpl.lock(long timeout) and not allow the second thread to proceed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:16 a.m.
New subject: [JBoss JIRA] Updated: (WELD-865) Weld allows for concurrent call to conversation
[
https://issues.jboss.org/browse/WELD-865?page=com.atlassian.jira.plugin.s...
]
George Sapountzis updated WELD-865:
-----------------------------------
Attachment: untested-2.patch
- slightly better naming
- move the non-existent conversation check within conversationContext.activate(cid) where
it seems to fit better with the flow
Weld allows for concurrent call to conversation
-----------------------------------------------
Key: WELD-865
URL: https://issues.jboss.org/browse/WELD-865
Project: Weld
Issue Type: Bug
Components: Scopes & Contexts, Web Tier integration (JSF, JSP, EL and
Servlet)
Affects Versions: 1.1.0.Final
Reporter: George Sapountzis
Assignee: Ales Justin
Fix For: 1.2.0.Beta1
Attachments: untested-2.patch, untested-test-failure-condition-first.patch
Concurrent calls to a @ConversationScoped component:
Thread 1:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns true
correctly proceed inside method
Thread 2:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns false but activate() does not check
result !!!
*incorrectly* proceed inside method
----
I think AbstractConversationContext.activate(String cid) should check the result of
ConversationImpl.lock(long timeout) and not allow the second thread to proceed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:40 a.m.
New subject: [JBoss JIRA] Updated: (WELD-865) Weld allows for concurrent call to conversation
[
https://issues.jboss.org/browse/WELD-865?page=com.atlassian.jira.plugin.s...
]
Ales Justin updated WELD-865:
-----------------------------
Fix Version/s: 1.2.0.Beta1
(was: 1.1.2.Final)
Weld allows for concurrent call to conversation
-----------------------------------------------
Key: WELD-865
URL: https://issues.jboss.org/browse/WELD-865
Project: Weld
Issue Type: Bug
Components: Scopes & Contexts, Web Tier integration (JSF, JSP, EL and
Servlet)
Affects Versions: 1.1.0.Final
Reporter: George Sapountzis
Assignee: Ales Justin
Fix For: 1.2.0.Beta1
Attachments: untested-2.patch, untested-test-failure-condition-first.patch
Concurrent calls to a @ConversationScoped component:
Thread 1:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns true
correctly proceed inside method
Thread 2:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns false but activate() does not check
result !!!
*incorrectly* proceed inside method
----
I think AbstractConversationContext.activate(String cid) should check the result of
ConversationImpl.lock(long timeout) and not allow the second thread to proceed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:59 p.m.
New subject: [JBoss JIRA] Updated: (WELD-865) Weld allows for concurrent call to conversation
[
https://issues.jboss.org/browse/WELD-865?page=com.atlassian.jira.plugin.s...
]
George Sapountzis updated WELD-865:
-----------------------------------
Attachment: untested-3.patch
rebase & reformat
Weld allows for concurrent call to conversation
-----------------------------------------------
Key: WELD-865
URL: https://issues.jboss.org/browse/WELD-865
Project: Weld
Issue Type: Bug
Components: Scopes & Contexts, Web Tier integration (JSF, JSP, EL and
Servlet)
Affects Versions: 1.1.0.Final
Reporter: George Sapountzis
Assignee: Ales Justin
Fix For: 1.2.0.Beta1
Attachments: untested-2.patch, untested-3.patch,
untested-test-failure-condition-first.patch
Concurrent calls to a @ConversationScoped component:
Thread 1:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns true
correctly proceed inside method
Thread 2:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns false but activate() does not check
result !!!
*incorrectly* proceed inside method
----
I think AbstractConversationContext.activate(String cid) should check the result of
ConversationImpl.lock(long timeout) and not allow the second thread to proceed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:10 a.m.
New subject: [JBoss JIRA] (WELD-865) Weld allows for concurrent call to conversation
[
https://issues.jboss.org/browse/WELD-865?page=com.atlassian.jira.plugin.s...
]
Ales Justin resolved WELD-865.
------------------------------
Resolution: Done
Patch #3 applied.
Weld allows for concurrent call to conversation
-----------------------------------------------
Key: WELD-865
URL: https://issues.jboss.org/browse/WELD-865
Project: Weld
Issue Type: Bug
Components: Scopes & Contexts, Web Tier integration (JSF, JSP, EL and
Servlet)
Affects Versions: 1.1.0.Final
Reporter: George Sapountzis
Assignee: Ales Justin
Fix For: 1.2.0.Beta1
Attachments: untested-2.patch, untested-3.patch,
untested-test-failure-condition-first.patch
Concurrent calls to a @ConversationScoped component:
Thread 1:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns true
correctly proceed inside method
Thread 2:
AbstractConversationContext.activate(String cid)
ConversationImpl.lock(long timeout) <-- returns false but activate() does not check
result !!!
*incorrectly* proceed inside method
----
I think AbstractConversationContext.activate(String cid) should check the result of
ConversationImpl.lock(long timeout) and not allow the second thread to proceed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4772
days inactive
5012
days old
12 comments
3 participants
participants (3)
-
Ales Justin (JIRA) -
Ales Justin (Resolved) (JIRA)
-
George Sapountzis (JIRA)