[ https://jira.jboss.org/browse/WELDX-185?page=com.atlassian.jira.plugin.sy... ] Dan Allen commented on WELDX-185: --------------------------------- Hm, it turns out there may have been some confusion around what makes up a ValueExpression. A ValueExpression may contain any number of inline variable expressions mixed with literal text. So for this case, we don't need an interpolator. It's just a documentation (and test case) issue. Assert.assertEquals("Cheetahs are fast", expressions.evaluateValueExpression("Cheetahs are #{cheetah.speed}", String.class)); Assert.assertEquals((Integer) 2, expressions.evaluateValueExpression("#{1 + 1}", Integer.class)); However, there are still reasons to provide an interpolator. An interpolator would additionally handle replacing positional and named parameters. Positional parameters can be handled by passing the result through MessageFormat: Assert.assertEquals("Jon has a score of 97", MessageFormat.format(expressions.evaluateValueExpression("#{person.name} has a score of {0}", String.class), 97)); In addition to encapsulating the MessageFormat usage, the interpolator can hides the cast of the evaluation result to a String. With the interpolator, this assertion simplifies to: Assert.assertEquals("Jon has a score of 97", interpolator.interpolate("#{person.name} has a score of {0}", 97)); I'm unsure whether there is value in named parameters. Though for developers familiar with JPQL and Bean Validation, the experience would be similar: Assert.assertEquals("Jon has a score of 97", InterpolatedStringBuilder.expressionString("#{person.name} has a score of {score}").setParameter("score", 97).interpolate()); This builder concept has already been prototyped in the international module, though with a slightly different focus. It's important to align. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/WELDX-185?page=com.atlassian.jira.plugin.sy... ] Pete Muir updated WELDX-185: ---------------------------- Fix Version/s: TBC (was: 1.0.0.Beta2) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/WELDX-185?page=com.atlassian.jira.plugin.sy... ] Dan Allen commented on WELDX-185: --------------------------------- In general, though, I am still seeing some overlap between Weld X and i18n in terms of interpolation and message bundles. In particular, I'm referring to the JBoss Logging stuff. I love the idea of JBoss Logging, but I'm not sure people will be comfortable with using a logging package to get message bundle functionality elsewhere in the application (just seems strange). Perhaps we can take this onto the list? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/WELDX-185?page=com.atlassian.jira.plugin.sy... ] Dan Allen commented on WELDX-185: --------------------------------- Sorry for the confusion. Yes, I agree logging should be in Weld X. I'm just suggesting that the generic message bundle facility shouldn't come from logging. Have we considered having a JBoss i18n? That seems to be the best solution to me. That way, JBoss Logging uses it, Weld X logging uses it and i18n can build on it as well. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/WELDX-185?page=com.atlassian.jira.plugin.sy... ] Pete Muir commented on WELDX-185: --------------------------------- Considered and rejected. Keeping the jar deps for logging to 1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/WELDX-185?page=com.atlassian.jira.plugin.sy... ] Pete Muir commented on WELDX-185: --------------------------------- Sugggest you raise a JBLOGGING issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira