Re: [wildfly-dev] Configuration of statistics gathering
On 12/17/13 2:09 AM, Jesper Pedersen wrote:
On 12/16/2013 03:12 PM, Brian Stansberry wrote:
> I've sent in a PR [1] that makes the changes I described for the
> messaging, transactions, resource-adapters and infinispan subsystems,
> one commit per subsystems. If the respective leads could have a look I'd
> appreciate it.
>
> [1] https://github.com/wildfly/wildfly/pull/5609
I'm ok with the code changes. HOWEVER, the default value should be true.
AFAICT, the resource-adapter commit did nothing to change any default.
So if it was true, it still is true.
Looking at it, I see the existing code doesn't state the default as part
of the metadata, so the user doesn't know. That should be fixed.
WildFly is a server which aims at ease for developers, so all
default
settings should reflect that. So, using a default value of false in this
case is wrong.
This change for the IronJacamar controlled resources is in the same
category as turning off developer mode for the web container.
Should all project leads submit pull requests that optimizes their
subsystems against production use ?
I'm not asking for that.
Earlier in this thread I threw out a suggestion for a subsystem-level
attribute that could serve as a default and could easily have a
different value in our standard configs for EAP vs WF. If anyone has a
better idea, I'd love hear it. If not, patches would be nice if someone
wants to do that.
Consider this my official -1.
Please explain how the resource-adapter commit relates to your concerns.
Best regards,
Jesper
_______________________________________________
wildfly-dev mailing list
wildfly-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/wildfly-dev
--
Brian Stansberry
Principal Software Engineer
JBoss by Red Hat