On 8/6/2013 9:36 AM, Bartosz Baranowski wrote:
----- Original Message -----
> From: "Darran Lofthouse" <darran.lofthouse(a)jboss.com>
> To: "Bartosz Baranowski" <bbaranow(a)redhat.com>
> Cc: "Darran Lofthouse" <darran.lofthouse(a)jboss.com>,
wildfly-dev(a)lists.jboss.org
> Sent: Tuesday, August 6, 2013 2:54:44 PM
> Subject: Re: [wildfly-dev] JConsole plugin - fallback and query for management
address
>
> On 06/08/13 13:37, Bartosz Baranowski wrote:
>>
>> ----- Original Message -----
>>> From: "Darran Lofthouse" <darran.lofthouse(a)jboss.com>
>>> To: wildfly-dev(a)lists.jboss.org
>>> Sent: Tuesday, August 6, 2013 2:31:22 PM
>>> Subject: Re: [wildfly-dev] JConsole plugin - fallback and query for
>>> management address
>>>
>>>
>>>
>>> On 06/08/13 13:27, Bartosz Baranowski wrote:
>>>
>>>> What is weird( I might be missing some important piece of intel here) is
>>>> why there is check against jboss remoting?
>>
>> This one:
>> if (mbeanServerConn instanceof RemotingMBeanServerConnection) {
> The purpose of that check is to see if we already have a Remoting
> connection established to the server for JMX, if so the same connection
> can be used for the management connection.
>
> That is one of the reasons I am not a fan of just opening a Remoting
> connection automatically - if they chose to use Remoting we make use of
> that same connection for two different purposes - if they choose not to
> use Remoting we open a Remoting connection anyway. But a 'Connect'
> button on the CLI tab would take care of that.
>
Ok, let me rephrase. Why there is any distinction between regular connection vs jboss
remoting connection class?
When you launch jconsole you get a dialog that shows your
local
processes. You have the option of clicking on one of those processes or
typing in a connection URL. If you type in a connection URL and it is a
remoting URL then you are all set. CLI can just use that remoting
connection.
If you click on a process then you are not using a remoting connection.
But you need a remoting connection in order to send CLI commands using
the CLI API. So if you want to use CLI in that case, a remoting
connection must be created. Right now it does this automatically, but
it would be better if the user had a little more feedback and control in
the matter.
Darran has also proposed using an MBean for executing CLI commands. In
some ways that would be the best solution because you don't need a
remoting connection. You could always use the existing connection 100%
of the time. The problem is that this solution would take a long time
to implement because you get less help from the CLI API. And, I don't
think we want an MBean to be a full management endpoint.
>>
>>> What check are you referring to?
>>> _______________________________________________
>>> wildfly-dev mailing list
>>> wildfly-dev(a)lists.jboss.org
>>>
https://lists.jboss.org/mailman/listinfo/wildfly-dev
>>>
_______________________________________________
wildfly-dev mailing list
wildfly-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/wildfly-dev