Re: [wildfly-dev] How "optional" should the NoSQL integration be for WildFly...
On 09/12/2016 11:00 AM, Brian Stansberry wrote:
> On Sep 12, 2016, at 9:31 AM, Scott Marlow <smarlow(a)redhat.com> wrote:
>
> Hi,
>
> I'm thinking that the NoSQL unit tests should be optional, since most
> WildFly developers won't have access to a local NoSQL database server.
> Currently, to run the unit tests, you have to define "nosql-tests" (e.g.
> ./integration-tests.sh -Dnosql-tests).
>
The standard pattern for this kind of switch is something like
-Dts.nosql
Thanks, we will switch over to -Dts.nosql
So please stick with that pattern.
How does this related to -DallTests, which right now turns on all tests except the mixed
domain ones.
I don't think -DallTests should include the NoSQL tests, since many
developers will not have (local) access to all of the NoSQL databases.
I did a -DallTests run and the NoSQL tests were included.
That “allTests” is an unfortunate name as it’s not all any more, but it’s widely known
and used as the simple way to execute the vast bulk of the testsuite.
> As we work towards our first (NoSQL integration) pull requests for
> WildFly master (and some small wildfly-core changes to the Phase class),
> does anything else need to be optional?
>
> Currently we are building WildFly to include the NoSQL driver artifacts,
> for the specific versions of the drivers that we support. We also allow
> other versions of the NoSQL drivers to be brought into WildFly, as long
> as they are (API) compatible with the version that we (loosely)
> integrate with.
>
> Thanks for the feedback!
>
> Scott
> _______________________________________________
> wildfly-dev mailing list
> wildfly-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/wildfly-dev