12:46 a.m.
Does the commit check run against all commits in the PR?
Not currently, I've added additional checks to verify there is only one
commit in the PR :) But this should be possible to do, however, force
pushing your way through commit history will not be an easy task.
What happens if it is down? I figure nothing really, i.e. the check
just
isn't performed, which is a quite reasonable failure mode. :)
AIUI this also has no impact on ability to merge PRs; i.e. we can
ignore
the result same as we can ignore CI job results. Also good.
Absolutely right. There will be only one additional status in the list.
Everything can be ignored.
We can run it in CI somewhere if we need to, I'll need to review
the docs
and see whats required to run it.
Ken, I will take this with you offline when it's decided that we can set it
up.
Martin
On Mon, Apr 8, 2019 at 4:15 PM Ken Wills <kwills(a)redhat.com> wrote:
>
> On Mon, Apr 8, 2019 at 7:32 AM Martin Stefanko <mstefank(a)redhat.com>
> wrote:
>
>> Yes, understandable. Maybe it can be run where pull-player is being run
>> then? CC Ken.
>>
>
We can run it in CI somewhere if we need to, I'll need to review
the docs
> and see whats required to run it.
>
> For the initial version, I think we should just try it in OS though, then
> we can move it at some point in the future.
>
> Ken
>
>
>
>>
>> Martin
>>
>>
>> On Mon, Apr 8, 2019 at 12:27 PM Darran Lofthouse <
>> darran.lofthouse(a)jboss.com> wrote:
>>
>>> I think if we were to add something to the PR process is should not rely
>>> on a single individual to maintain it, if that person is busy, asleep, sick
>>> or on holiday then there will be no one to deal with down time and other
>>> issues,
>>>
>>> On Mon, Apr 8, 2019 at 11:25 AM Martin Stefanko <mstefank(a)redhat.com>
>>> wrote:
>>>
>>>> I can run it my openshift online instance so uptime would be maintained
>>>> by me for the time being. I have already several instances running like
>>>> this for some time. During F2F we've also discussed possibility to
use Prow
>>>> project
<https://github.com/kubernetes/test-infra/tree/master/prow>
>>>> for wildlfy which would require a platform to run (my openshift cannot
>>>> cover this) and Tyr would nicely integrate with Prow (already tested).
>>>> However, I am not aware if there has been any movement with Prow setup
for
>>>> wildfly repository recently.
>>>>
>>>> Martin
>>>>
>>>>
>>>> On Mon, Apr 8, 2019 at 11:26 AM Darran Lofthouse <
>>>> darran.lofthouse(a)jboss.com> wrote:
>>>>
>>>>> Couple of questions.
>>>>>
>>>>> Where does this need to run?
>>>>>
>>>>> How does this get maintained regarding things like uptime?
>>>>>
>>>>>
>>>>> On Mon, Apr 8, 2019 at 9:52 AM Martin Stefanko
<mstefank(a)redhat.com>
>>>>> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I would like to present my side project Tyr [1] which is a tool
that
>>>>>> can verify GitHub pull request structure by a YAML definition
(example in
>>>>>> [2]) provided by a user. The PR author sees the violations
immediately in
>>>>>> the PR status which allows to correct mistakes right away when
the PR is
>>>>>> created.
>>>>>>
>>>>>> I've recorded a short demo available at [3].
>>>>>>
>>>>>> The validation is fully configurable and can be extended with
for
>>>>>> instance analysis document links and similar.
>>>>>>
>>>>>> I would like to include this functionality in wildfly
repository.
>>>>>> Thoughts?
>>>>>>
>>>>>> [1] https://github.com/xstefank/tyr
>>>>>> [2]
https://gist.github.com/xstefank/3a79f2f199ee1e449a44c607120a9d30
>>>>>> [3] https://youtu.be/qZRcMQ6qIpg
>>>>>>
>>>>>> Martin Stefanko
>>>>>>
>>>>>> Software Engineer
>>>>>> Middleware Runtimes Sustaining Engineering Team
>>>>>> Red Hat
>>>>>> _______________________________________________
>>>>>> wildfly-dev mailing list
>>>>>> wildfly-dev(a)lists.jboss.org
>>>>>> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>>>>>
>>>>>