7:35 p.m.
It is missing, but the attribute is persisted in xml. The XSD should
validate it in and not persist the attribute, is that correct ?
--
Claudio Miranda
claudio(a)claudius.com.br
http://www.claudius.com.br
8:05 p.m.
On 11/6/14, 7:35 PM, Claudio Miranda wrote:
It is missing, but the attribute is persisted in xml. The XSD should
validate it in and not persist the attribute, is that correct ?
I don't understand this question.
The xsd declares the attribute, the management metadata says it's
persistent, and the parser reads it, so I think it's just a matter of
not being marshalled. Adding
Attributes.STATISTICS_ENABLED.marshallAsAttribute(subsystem, writer);
after
https://github.com/wildfly/wildfly/blob/master/webservices/server-integra...
will fix it.
Adding statistics-enabled="false" at the end of the element at
https://github.com/wildfly/wildfly/blob/master/webservices/server-integra...
will ensure that the subsystem test verifies the marshalling.
--
Brian Stansberry
Senior Principal Software Engineer
JBoss by Red Hat
8:09 p.m.
Ah, sorry, I see this is "undertow" you're asking about.
I'll have a look.
On 11/6/14, 8:05 PM, Brian Stansberry wrote:
On 11/6/14, 7:35 PM, Claudio Miranda wrote:
> It is missing, but the attribute is persisted in xml. The XSD should
> validate it in and not persist the attribute, is that correct ?
>
I don't understand this question.
The xsd declares the attribute, the management metadata says it's
persistent, and the parser reads it, so I think it's just a matter of
not being marshalled. Adding
Attributes.STATISTICS_ENABLED.marshallAsAttribute(subsystem, writer);
after
https://github.com/wildfly/wildfly/blob/master/webservices/server-integra...
will fix it.
Adding statistics-enabled="false" at the end of the element at
https://github.com/wildfly/wildfly/blob/master/webservices/server-integra...
will ensure that the subsystem test verifies the marshalling.
--
Brian Stansberry
Senior Principal Software Engineer
JBoss by Red Hat
8:16 p.m.
Looks like it's just missing from the XSD and from the test case file at
https://github.com/wildfly/wildfly/blob/master/undertow/src/test/resource...
The test passes if that's added, so that shows that the parsing and
marshalling bits work, and it's just the XSD that is wrong.
On 11/6/14, 8:09 PM, Brian Stansberry wrote:
Ah, sorry, I see this is "undertow" you're asking
about.
I'll have a look.
On 11/6/14, 8:05 PM, Brian Stansberry wrote:
> On 11/6/14, 7:35 PM, Claudio Miranda wrote:
>> It is missing, but the attribute is persisted in xml. The XSD should
>> validate it in and not persist the attribute, is that correct ?
>>
>
> I don't understand this question.
>
> The xsd declares the attribute, the management metadata says it's
> persistent, and the parser reads it, so I think it's just a matter of
> not being marshalled. Adding
>
> Attributes.STATISTICS_ENABLED.marshallAsAttribute(subsystem, writer);
>
> after
>
>
https://github.com/wildfly/wildfly/blob/master/webservices/server-integra...
>
> will fix it.
>
> Adding statistics-enabled="false" at the end of the element at
>
>
https://github.com/wildfly/wildfly/blob/master/webservices/server-integra...
>
> will ensure that the subsystem test verifies the marshalling.
>
--
Brian Stansberry
Senior Principal Software Engineer
JBoss by Red Hat
8:34 p.m.
On Fri, Nov 7, 2014 at 12:16 AM, Brian Stansberry
<brian.stansberry(a)redhat.com> wrote:
The test passes if that's added, so that shows that the parsing
and
marshalling bits work, and it's just the XSD that is wrong.
Also, the attribute definition below validates the xml. I will fix the
XSD and submit PR.
https://github.com/wildfly/wildfly/blob/master/undertow/src/main/java/org...
Thanks for your valuable input Brian.
--
Claudio Miranda
claudio(a)claudius.com.br
http://www.claudius.com.br
3702
days inactive
3702
days old
4 comments
2 participants
participants (2)
-
Brian Stansberry -
Claudio Miranda