Hi Frank,
that looks great!
Thank you for the PR.
--
tomaz
On Fri, Jun 27, 2014 at 3:29 PM, Frank Langelage <frank.langelage(a)osnanet.de
wrote:
> Hi Tomaz,
>
> Okay, I modified download-maven.sh script to modify the faulty line in
> maven/bin/mvn.
> This now works for me.
> See pull-request #6447.
>
> Frank
>
>
>
> On 27.06.14 10:59, Tomaž Cerar wrote:
>
> Frank,
>
> I had in mind that download-maven.sh script could "patch" the bug in the
> maven executable after the download.
>
> Other option is that we just go back to 3.2.1 maven.
> as looking at
http://maven.apache.org/docs/3.2.2/release-notes.html
> there are no real benefits that our build would need.
>
> --
> tomaz
>
>
> On Fri, Jun 27, 2014 at 9:27 AM, Frank Langelage <
> frank.langelage(a)osnanet.de
wrote:
>
>> It's definitely a maven problem. Introduced in Apache Maven 3.2.2.
>> So I not understood Tomaz request for a PR. Too fast reading?
>> This would be a work around in WF to fix a problem in Maven.
>>
http://jira.codehaus.org/browse/MNG-5658
>>
>> We might go back to Maven 3.2.1 for now waiting for 3.2.3 becoming
>> available with this problem hopefully fixed, if there a re not other
>> drawbacks from this downgrade.
>>
>> Regards, Frank
>>
>>
>> On 27.06.14 04:14, Stuart Douglas wrote:
>>
>>> So is this an issue with the download script or with the Maven version
>>> upgrade?
>>>
>>> Stuart
>>>
>>> Tomaž Cerar wrote:
>>>
>>>> Frank,
>>>>
>>>> can you send PR with a fix to download-maven.sh script?
>>>> given that you have solaris at hand it will be probably the easiest.
>>>>
>>>> Thank you,
>>>> tomaz
>>>>
>>>>
>>>> On Thu, Jun 26, 2014 at 11:24 PM, Frank Langelage
>>>> <frank.langelage(a)osnanet.de
<mailto:frank.langelage@osnanet.de>
wrote:
>>>>
>>>> for those who might want to build current 9.0.0-SNAPSHOT from github
>>>> sources on Solaris:
>>>> after commit of checking / downloading maven if needed this
>>>> currently
>>>> fails with a syntax error in tools/maven/bin/mvn after downloading
>>>> the
>>>> latest version 3.2.2.
>>>> Maven 3.2.2 's bin/mvn contains incompatible syntax for Solaris
>>>> /bin/sh
>>>> and perhaps others:
>>>> if [[ -z "$JAVA_HOME" && -x
/usr/libexec/java_home ]] ;
>>>> then
>>>> #
>>>> # Apple JDKs
>>>> #
>>>> export JAVA_HOME=$(/usr/libexec/java_home) // here it
>>>> fails
>>>> fi
>>>> ;;
>>>>
>>>> I created a JIRA fpr Apache Maven to change this line to
>>>> export JAVA_HOME=/usr/libexec/java_home
>>>>
>>>> Doing this change after download / unzip in my local repo make the
>>>> build
>>>> working again for me.
>>>>
>>>> Regards, Frank
>>>>
>>>> _______________________________________________
>>>> wildfly-dev mailing list
>>>> wildfly-dev(a)lists.jboss.org
<mailto:wildfly-dev@lists.jboss.org>
>>>>
https://lists.jboss.org/mailman/listinfo/wildfly-dev
>>>>
>>>>
>>>> _______________________________________________
>>>> wildfly-dev mailing list
>>>> wildfly-dev(a)lists.jboss.org
>>>>
https://lists.jboss.org/mailman/listinfo/wildfly-dev
>>>>
>>>
>>>
>>>
>>
>
>