[JBoss JIRA] (ARQGRA-264) Create possibility to "inject" elements from frames
by Aliaksei Lahachou (JIRA)
[ https://issues.jboss.org/browse/ARQGRA-264?page=com.atlassian.jira.plugin... ]
Aliaksei Lahachou commented on ARQGRA-264:
------------------------------------------
I didn't mean nested iframes. What I meant is that currently, some of my tests have calls to {{browser.switchTo().frame(...)}}. I wonder, if these tests will break now. May be I just have to try and see if it works.
> Create possibility to "inject" elements from frames
> ---------------------------------------------------
>
> Key: ARQGRA-264
> URL: https://issues.jboss.org/browse/ARQGRA-264
> Project: Arquillian Graphene
> Issue Type: Feature Request
> Affects Versions: 2.0.0.Alpha3
> Reporter: Aliaksei Lahachou
> Assignee: Juraj Húska
> Fix For: 2.0.0.Alpha5
>
> Original Estimate: 6 hours
> Remaining Estimate: 6 hours
>
> I don't like how WebDriver works with frames. I have to constantly switch between frames, I cannot simply "inject" element from a specific frame. I would love to have something like the following:
> {code:java}
> @FindBy(id = "menuBar")
> @InFrame(id = "header")
> private MenuBarFragment menuBar;
> {code}
> In this case Graphene should switch to frame "header" before any operation on menuBar and switch back to previous frame after (today, I have to do it manually). It seems to me that it is not too complex to do it with Arquillian/Graphene - you only need one more interceptor.
> Elements not annotated with @InFrame should work on current frame just as today.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years
[JBoss JIRA] (ARQGRA-264) Create possibility to "inject" elements from frames
by Juraj Húska (JIRA)
[ https://issues.jboss.org/browse/ARQGRA-264?page=com.atlassian.jira.plugin... ]
Juraj Húska edited comment on ARQGRA-264 at 6/18/13 4:50 AM:
-------------------------------------------------------------
You are right Aliaksei, it would not work for all cases. It is not supporting nested structure of iframes, only one level of iframes. The nested functionality if needed can be IMHO implemented as I described [here|https://github.com/arquillian/arquillian-graphene/pull/81#discussion...]. Is there a real life scenario where this multiple iframe levels are needed ? Otherwise, well documented feature would be sufficient IMHO.
The {{@InFrame}} annotation can not be used to switch to the default iframe. IMHO the legacy tests should be rewritten to use this annotation. Another option is to implement such {{@InFrame}} which would be capable doing so. What do you think Lukas ?
was (Author: jhuska):
You are right Aliaksei, it would not work for all cases. It is not supporting nested structure of iframes, only one level of iframes. The nested functionality if needed can be IMHO implemented as I described [here|https://github.com/arquillian/arquillian-graphene/pull/81#discussion...]. Is there a real life scenario where this multiple iframe levels are needed ?
The {{@InFrame}} annotation can not be used to switch to the default iframe. IMHO the legacy tests should be rewritten to use this annotation. Another option is to implement such {@InFrame}} which would be capable doing so. What do you think Lukas ?
> Create possibility to "inject" elements from frames
> ---------------------------------------------------
>
> Key: ARQGRA-264
> URL: https://issues.jboss.org/browse/ARQGRA-264
> Project: Arquillian Graphene
> Issue Type: Feature Request
> Affects Versions: 2.0.0.Alpha3
> Reporter: Aliaksei Lahachou
> Assignee: Juraj Húska
> Fix For: 2.0.0.Alpha5
>
> Original Estimate: 6 hours
> Remaining Estimate: 6 hours
>
> I don't like how WebDriver works with frames. I have to constantly switch between frames, I cannot simply "inject" element from a specific frame. I would love to have something like the following:
> {code:java}
> @FindBy(id = "menuBar")
> @InFrame(id = "header")
> private MenuBarFragment menuBar;
> {code}
> In this case Graphene should switch to frame "header" before any operation on menuBar and switch back to previous frame after (today, I have to do it manually). It seems to me that it is not too complex to do it with Arquillian/Graphene - you only need one more interceptor.
> Elements not annotated with @InFrame should work on current frame just as today.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years
[JBoss JIRA] (ARQGRA-264) Create possibility to "inject" elements from frames
by Juraj Húska (JIRA)
[ https://issues.jboss.org/browse/ARQGRA-264?page=com.atlassian.jira.plugin... ]
Juraj Húska commented on ARQGRA-264:
------------------------------------
You are right Aliaksei, it would not work for all cases. It is not supporting nested structure of iframes, only one level of iframes. The nested functionality if needed can be IMHO implemented as I described [here|https://github.com/arquillian/arquillian-graphene/pull/81#discussion...]. Is there a real life scenario where this multiple iframe levels are needed ?
The {{@InFrame}} annotation can not be used to switch to the default iframe. IMHO the legacy tests should be rewritten to use this annotation. Another option is to implement such {@InFrame}} which would be capable doing so. What do you think Lukas ?
> Create possibility to "inject" elements from frames
> ---------------------------------------------------
>
> Key: ARQGRA-264
> URL: https://issues.jboss.org/browse/ARQGRA-264
> Project: Arquillian Graphene
> Issue Type: Feature Request
> Affects Versions: 2.0.0.Alpha3
> Reporter: Aliaksei Lahachou
> Assignee: Juraj Húska
> Fix For: 2.0.0.Alpha5
>
> Original Estimate: 6 hours
> Remaining Estimate: 6 hours
>
> I don't like how WebDriver works with frames. I have to constantly switch between frames, I cannot simply "inject" element from a specific frame. I would love to have something like the following:
> {code:java}
> @FindBy(id = "menuBar")
> @InFrame(id = "header")
> private MenuBarFragment menuBar;
> {code}
> In this case Graphene should switch to frame "header" before any operation on menuBar and switch back to previous frame after (today, I have to do it manually). It seems to me that it is not too complex to do it with Arquillian/Graphene - you only need one more interceptor.
> Elements not annotated with @InFrame should work on current frame just as today.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years