[JBoss JIRA] (ARQGRA-472) TestCases are copy-pasted
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/ARQGRA-472?page=com.atlassian.jira.plugin... ]
Lukáš Fryč updated ARQGRA-472:
------------------------------
Fix Version/s: 2.1.0.Beta1
(was: 2.1-Tracking)
> TestCases are copy-pasted
> -------------------------
>
> Key: ARQGRA-472
> URL: https://issues.jboss.org/browse/ARQGRA-472
> Project: Arquillian Graphene
> Issue Type: Bug
> Components: unit-test
> Affects Versions: 2.1-Tracking
> Reporter: Vitalii Grygoryuk
> Assignee: Matous Jobanek
> Fix For: 2.1.0.Beta1
>
>
> TestHandlingOfStaleElements.testDeletion() and TestHandlingOfStaleElements.testReplacement() are both testing deletion, so there is no test case for node replacement logic:
> {code}
> @Test
> public void testDeletion() {
> rootElement.isDisplayed();
> executor.executeScript("return arguments[0].parentNode.removeChild(arguments[0])", rootElement);
> try {
> rootElement.isDisplayed();
> fail("rootElement should not be found");
> } catch (NoSuchElementException e) {
> }
> }
> @Test
> public void testReplacement() {
> rootElement.isDisplayed();
> executor.executeScript("return arguments[0].parentNode.removeChild(arguments[0])", rootElement);
> try {
> rootElement.isDisplayed();
> fail("rootElement should not be found");
> } catch (NoSuchElementException e) {
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 2 months
[JBoss JIRA] (ARQGRA-472) TestCases are copy-pasted
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/ARQGRA-472?page=com.atlassian.jira.plugin... ]
Lukáš Fryč updated ARQGRA-472:
------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> TestCases are copy-pasted
> -------------------------
>
> Key: ARQGRA-472
> URL: https://issues.jboss.org/browse/ARQGRA-472
> Project: Arquillian Graphene
> Issue Type: Bug
> Components: unit-test
> Affects Versions: 2.1-Tracking
> Reporter: Vitalii Grygoryuk
> Assignee: Matous Jobanek
> Fix For: 2.1.0.Beta1
>
>
> TestHandlingOfStaleElements.testDeletion() and TestHandlingOfStaleElements.testReplacement() are both testing deletion, so there is no test case for node replacement logic:
> {code}
> @Test
> public void testDeletion() {
> rootElement.isDisplayed();
> executor.executeScript("return arguments[0].parentNode.removeChild(arguments[0])", rootElement);
> try {
> rootElement.isDisplayed();
> fail("rootElement should not be found");
> } catch (NoSuchElementException e) {
> }
> }
> @Test
> public void testReplacement() {
> rootElement.isDisplayed();
> executor.executeScript("return arguments[0].parentNode.removeChild(arguments[0])", rootElement);
> try {
> rootElement.isDisplayed();
> fail("rootElement should not be found");
> } catch (NoSuchElementException e) {
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 2 months
[JBoss JIRA] (ARQGRA-483) @Location might use the Wrong URL when used with Warp
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/ARQGRA-483?page=com.atlassian.jira.plugin... ]
Lukáš Fryč updated ARQGRA-483:
------------------------------
Fix Version/s: 2.1.0.Beta1
(was: 2.1-Tracking)
> @Location might use the Wrong URL when used with Warp
> ------------------------------------------------------
>
> Key: ARQGRA-483
> URL: https://issues.jboss.org/browse/ARQGRA-483
> Project: Arquillian Graphene
> Issue Type: Bug
> Components: integration
> Affects Versions: 2.1.0.Alpha2
> Reporter: Aslak Knutsen
> Fix For: 2.1.0.Beta1
>
>
> Both Graphene and Warp attempt to override the default Core URLResourceProvider.
> Warp has the ProxyURLProvider and Graphene the CustomizableURLResourceProvider.
> When both Graphene and Warp is on classpath it becomes unpredictable who will actually win.
> Technically the two URLs used here could be different:
> {code}
> @ArquillianResource
> private URL baseURL;
>
> @Test @RunAsClient
> public void shouldBeAbleToStoreConference(@InitialPage ConferencePage page) throws Exception {
> }
> {code}
> BaseURL could be proxied and the URL used by InitialPage not, or the other way around.
> Graphene sets up it's ContextRootStore with which ever URL was provided last;
> https://github.com/arquillian/arquillian-graphene/blob/master/impl/src/ma...
> Core will do the opposite, which ever comes first.
> When Graphene resolves the 'non-proxied' URL, Warp will eventually time out waiting for a reply as it never got to setup and sync.
> This seems to be a good test case currently:
> {code}
> @Drone
> private WebDriver driver;
>
> @ArquillianResource
> private URL baseURL;
>
> @Test @RunAsClient
> public void shouldBeAbleToStoreConference(@InitialPage ConferencePage page) throws Exception {
> Assert.assertEquals(baseURL.getPort(), new URL(driver.getCurrentUrl()).getPort());
> }
> {code}
> Currently one will show 'proxy-port' and the other '8080'.
> This has to do with the dependency order. If you place Graphene before Warp in the POM then Graphene will work because Warp's ProxyURLProvider is the last provider, if you place Warp before Graphene you should see this issue.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 2 months
[JBoss JIRA] (ARQGRA-483) @Location might use the Wrong URL when used with Warp
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/ARQGRA-483?page=com.atlassian.jira.plugin... ]
Lukáš Fryč updated ARQGRA-483:
------------------------------
Status: Resolved (was: Pull Request Sent)
Assignee: Matous Jobanek
Resolution: Done
> @Location might use the Wrong URL when used with Warp
> ------------------------------------------------------
>
> Key: ARQGRA-483
> URL: https://issues.jboss.org/browse/ARQGRA-483
> Project: Arquillian Graphene
> Issue Type: Bug
> Components: integration
> Affects Versions: 2.1.0.Alpha2
> Reporter: Aslak Knutsen
> Assignee: Matous Jobanek
> Fix For: 2.1.0.Beta1
>
>
> Both Graphene and Warp attempt to override the default Core URLResourceProvider.
> Warp has the ProxyURLProvider and Graphene the CustomizableURLResourceProvider.
> When both Graphene and Warp is on classpath it becomes unpredictable who will actually win.
> Technically the two URLs used here could be different:
> {code}
> @ArquillianResource
> private URL baseURL;
>
> @Test @RunAsClient
> public void shouldBeAbleToStoreConference(@InitialPage ConferencePage page) throws Exception {
> }
> {code}
> BaseURL could be proxied and the URL used by InitialPage not, or the other way around.
> Graphene sets up it's ContextRootStore with which ever URL was provided last;
> https://github.com/arquillian/arquillian-graphene/blob/master/impl/src/ma...
> Core will do the opposite, which ever comes first.
> When Graphene resolves the 'non-proxied' URL, Warp will eventually time out waiting for a reply as it never got to setup and sync.
> This seems to be a good test case currently:
> {code}
> @Drone
> private WebDriver driver;
>
> @ArquillianResource
> private URL baseURL;
>
> @Test @RunAsClient
> public void shouldBeAbleToStoreConference(@InitialPage ConferencePage page) throws Exception {
> Assert.assertEquals(baseURL.getPort(), new URL(driver.getCurrentUrl()).getPort());
> }
> {code}
> Currently one will show 'proxy-port' and the other '8080'.
> This has to do with the dependency order. If you place Graphene before Warp in the POM then Graphene will work because Warp's ProxyURLProvider is the last provider, if you place Warp before Graphene you should see this issue.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 2 months