[JBoss JIRA] (ARQ-2152) Add support for setting 'apiTypeVisibility' in Websphere Liberty Application Server Container
by Gordon Hutchison (JIRA)
[ https://issues.jboss.org/browse/ARQ-2152?page=com.atlassian.jira.plugin.s... ]
Gordon Hutchison edited comment on ARQ-2152 at 11/15/17 11:45 AM:
------------------------------------------------------------------
The patch is on a slightly backlevel base but has in WLPManagedContainer::createApplication
{code:java}
+ if (this.containerConfiguration.getApiTypeVisibility() != null) {
+ classLoader.setAttribute("apiTypeVisibility", this.containerConfiguration.getApiTypeVisibility());
+ }
{code}
and WLPManagedContainerConfiguration.java gets a
{code:java}
private String apiTypeVisibility;
{code}
and a getter and setter:
{code:java}
+ public void setApiTypeVisibility(String apiTypeVisibility) {
+ this.apiTypeVisibility = apiTypeVisibility;
+ }
+
+ public String getApiTypeVisibility() {
+ return apiTypeVisibility;
+ }
{code}
was (Author: hutchig):
The patch is on a slightly backlevel base but has in WLPManagedContainer::createApplication
{code:java}
+ if (this.containerConfiguration.getApiTypeVisibility() != null) {
+ classLoader.setAttribute("apiTypeVisibility", this.containerConfiguration.getApiTypeVisibility());
+ }
{code}
and WLPManagedContainerConfiguration.java gets a
private String apiTypeVisibility;
and a getter and setter:
{code:java}
+ public void setApiTypeVisibility(String apiTypeVisibility) {
+ this.apiTypeVisibility = apiTypeVisibility;
+ }
+
+ public String getApiTypeVisibility() {
+ return apiTypeVisibility;
+ }
{code}
> Add support for setting 'apiTypeVisibility' in Websphere Liberty Application Server Container
> ----------------------------------------------------------------------------------------------
>
> Key: ARQ-2152
> URL: https://issues.jboss.org/browse/ARQ-2152
> Project: Arquillian
> Issue Type: Feature Request
> Components: WebSphere Containers
> Affects Versions: was_1.0.0.next
> Environment: Testing Microprofile TCKs on WebSphere Liberty
> (Apologies for setting the priority.)
> (Apologies if the version is incorrect for https://github.com/arquillian/arquillian-container-was/tree/master/wlp-ma...
> Reporter: Gordon Hutchison
> Assignee: Gerhard Poul
> Priority: Minor
>
> (I have to thank my colleague Kevin Grigorenko for this patch which I integrated into
> my local clone. The text below is pasted from text written by him: )
> "Added support for injecting a Tracer into the TCK: For the CDI injection to work, the TCK application's classloader must be configured with apiTypeVisibility="spec, ibm-api, third-party". The WAS Arquillian container's default deployType is dropins and I couldn't find a way to configure the classloader for that. The WAS Arquiallian container also supports deployType=xml which puts the WAR into apps and dynamically adds configuration to Liberty's server.xml with the <application /> element and some sub-elements. I forked that code to also add support for apiTypeVisibility and also submitted a pull request. Now, running with that fork and specifying <property name="deployType">xml</property> and <property name="apiTypeVisibility">spec, ibm-api, third-party</property> in mpOpentracingTckRunner/tck/src/test/resources/arquillian.xml allows the TCK to inject the Tracer."
> This WLP feature is discussed here:
> https://www.ibm.com/support/knowledgecenter/en/SSEQTP_8.5.5/com.ibm.websp...
> I have Kevin's code patch that does this and am only raising this issue
> in order to reference it in a pull request I am going to make
> at
> https://github.com/arquillian/arquillian-container-was/tree/master/wlp-ma...
> I have checked with Kevin that he is happy for me to do this:
> (On IBM Sametime)
> gordon_hutchison(a)uk.ibm.com - Gordon Hutchison/UK/IBM:
> 4:17:28 PM: Hi Kevin, is it OK with you if I create an issue and then a PR to integrate the 'apiTypeVisibility' change you did to the public upstream repo?
> Kevin GRIGORENKO:
> 4:17:54 PM: Yes, absolutely. Thanks very much!
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 5 months
[JBoss JIRA] (ARQ-2152) Add support for setting 'apiTypeVisibility' in Websphere Liberty Application Server Container
by Gordon Hutchison (JIRA)
[ https://issues.jboss.org/browse/ARQ-2152?page=com.atlassian.jira.plugin.s... ]
Gordon Hutchison edited comment on ARQ-2152 at 11/15/17 11:44 AM:
------------------------------------------------------------------
The patch is on a slightly backlevel base but has in WLPManagedContainer::createApplication
{code:java}
+ if (this.containerConfiguration.getApiTypeVisibility() != null) {
+ classLoader.setAttribute("apiTypeVisibility", this.containerConfiguration.getApiTypeVisibility());
+ }
{code}
and WLPManagedContainerConfiguration.java gets a
private String apiTypeVisibility;
and a getter and setter:
{code:java}
+ public void setApiTypeVisibility(String apiTypeVisibility) {
+ this.apiTypeVisibility = apiTypeVisibility;
+ }
+
+ public String getApiTypeVisibility() {
+ return apiTypeVisibility;
+ }
{code}
was (Author: hutchig):
The patch is on a slightly backlevel base but has in WLPManagedContainer::createApplication
''' java
+ if (this.containerConfiguration.getApiTypeVisibility() != null) {
+ classLoader.setAttribute("apiTypeVisibility", this.containerConfiguration.getApiTypeVisibility());
+ }
'''
and WLPManagedContainerConfiguration.java gets a
''' java
private String apiTypeVisibility;
```
and a getter and setter:
``` java
+ public void setApiTypeVisibility(String apiTypeVisibility) {
+ this.apiTypeVisibility = apiTypeVisibility;
+ }
+
+ public String getApiTypeVisibility() {
+ return apiTypeVisibility;
+ }
'''
> Add support for setting 'apiTypeVisibility' in Websphere Liberty Application Server Container
> ----------------------------------------------------------------------------------------------
>
> Key: ARQ-2152
> URL: https://issues.jboss.org/browse/ARQ-2152
> Project: Arquillian
> Issue Type: Feature Request
> Components: WebSphere Containers
> Affects Versions: was_1.0.0.next
> Environment: Testing Microprofile TCKs on WebSphere Liberty
> (Apologies for setting the priority.)
> (Apologies if the version is incorrect for https://github.com/arquillian/arquillian-container-was/tree/master/wlp-ma...
> Reporter: Gordon Hutchison
> Assignee: Gerhard Poul
> Priority: Minor
>
> (I have to thank my colleague Kevin Grigorenko for this patch which I integrated into
> my local clone. The text below is pasted from text written by him: )
> "Added support for injecting a Tracer into the TCK: For the CDI injection to work, the TCK application's classloader must be configured with apiTypeVisibility="spec, ibm-api, third-party". The WAS Arquillian container's default deployType is dropins and I couldn't find a way to configure the classloader for that. The WAS Arquiallian container also supports deployType=xml which puts the WAR into apps and dynamically adds configuration to Liberty's server.xml with the <application /> element and some sub-elements. I forked that code to also add support for apiTypeVisibility and also submitted a pull request. Now, running with that fork and specifying <property name="deployType">xml</property> and <property name="apiTypeVisibility">spec, ibm-api, third-party</property> in mpOpentracingTckRunner/tck/src/test/resources/arquillian.xml allows the TCK to inject the Tracer."
> This WLP feature is discussed here:
> https://www.ibm.com/support/knowledgecenter/en/SSEQTP_8.5.5/com.ibm.websp...
> I have Kevin's code patch that does this and am only raising this issue
> in order to reference it in a pull request I am going to make
> at
> https://github.com/arquillian/arquillian-container-was/tree/master/wlp-ma...
> I have checked with Kevin that he is happy for me to do this:
> (On IBM Sametime)
> gordon_hutchison(a)uk.ibm.com - Gordon Hutchison/UK/IBM:
> 4:17:28 PM: Hi Kevin, is it OK with you if I create an issue and then a PR to integrate the 'apiTypeVisibility' change you did to the public upstream repo?
> Kevin GRIGORENKO:
> 4:17:54 PM: Yes, absolutely. Thanks very much!
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 5 months
[JBoss JIRA] (ARQ-2152) Add support for setting 'apiTypeVisibility' in Websphere Liberty Application Server Container
by Gordon Hutchison (JIRA)
[ https://issues.jboss.org/browse/ARQ-2152?page=com.atlassian.jira.plugin.s... ]
Gordon Hutchison edited comment on ARQ-2152 at 11/15/17 11:43 AM:
------------------------------------------------------------------
The patch is on a slightly backlevel base but has in WLPManagedContainer::createApplication
''' java
+ if (this.containerConfiguration.getApiTypeVisibility() != null) {
+ classLoader.setAttribute("apiTypeVisibility", this.containerConfiguration.getApiTypeVisibility());
+ }
'''
and WLPManagedContainerConfiguration.java gets a
''' java
private String apiTypeVisibility;
```
and a getter and setter:
``` java
+ public void setApiTypeVisibility(String apiTypeVisibility) {
+ this.apiTypeVisibility = apiTypeVisibility;
+ }
+
+ public String getApiTypeVisibility() {
+ return apiTypeVisibility;
+ }
'''
was (Author: hutchig):
The patch is on a slightly backlevel base but has in WLPManagedContainer::createApplication
``` java
+ if (this.containerConfiguration.getApiTypeVisibility() != null) {
+ classLoader.setAttribute("apiTypeVisibility", this.containerConfiguration.getApiTypeVisibility());
+ }
```
and WLPManagedContainerConfiguration.java gets a
``` java
private String apiTypeVisibility;
```
and a getter and setter:
``` java
+ public void setApiTypeVisibility(String apiTypeVisibility) {
+ this.apiTypeVisibility = apiTypeVisibility;
+ }
+
+ public String getApiTypeVisibility() {
+ return apiTypeVisibility;
+ }
```
> Add support for setting 'apiTypeVisibility' in Websphere Liberty Application Server Container
> ----------------------------------------------------------------------------------------------
>
> Key: ARQ-2152
> URL: https://issues.jboss.org/browse/ARQ-2152
> Project: Arquillian
> Issue Type: Feature Request
> Components: WebSphere Containers
> Affects Versions: was_1.0.0.next
> Environment: Testing Microprofile TCKs on WebSphere Liberty
> (Apologies for setting the priority.)
> (Apologies if the version is incorrect for https://github.com/arquillian/arquillian-container-was/tree/master/wlp-ma...
> Reporter: Gordon Hutchison
> Assignee: Gerhard Poul
> Priority: Minor
>
> (I have to thank my colleague Kevin Grigorenko for this patch which I integrated into
> my local clone. The text below is pasted from text written by him: )
> "Added support for injecting a Tracer into the TCK: For the CDI injection to work, the TCK application's classloader must be configured with apiTypeVisibility="spec, ibm-api, third-party". The WAS Arquillian container's default deployType is dropins and I couldn't find a way to configure the classloader for that. The WAS Arquiallian container also supports deployType=xml which puts the WAR into apps and dynamically adds configuration to Liberty's server.xml with the <application /> element and some sub-elements. I forked that code to also add support for apiTypeVisibility and also submitted a pull request. Now, running with that fork and specifying <property name="deployType">xml</property> and <property name="apiTypeVisibility">spec, ibm-api, third-party</property> in mpOpentracingTckRunner/tck/src/test/resources/arquillian.xml allows the TCK to inject the Tracer."
> This WLP feature is discussed here:
> https://www.ibm.com/support/knowledgecenter/en/SSEQTP_8.5.5/com.ibm.websp...
> I have Kevin's code patch that does this and am only raising this issue
> in order to reference it in a pull request I am going to make
> at
> https://github.com/arquillian/arquillian-container-was/tree/master/wlp-ma...
> I have checked with Kevin that he is happy for me to do this:
> (On IBM Sametime)
> gordon_hutchison(a)uk.ibm.com - Gordon Hutchison/UK/IBM:
> 4:17:28 PM: Hi Kevin, is it OK with you if I create an issue and then a PR to integrate the 'apiTypeVisibility' change you did to the public upstream repo?
> Kevin GRIGORENKO:
> 4:17:54 PM: Yes, absolutely. Thanks very much!
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 5 months
[JBoss JIRA] (ARQ-2152) Add support for setting 'apiTypeVisibility' in Websphere Liberty Application Server Container
by Gordon Hutchison (JIRA)
[ https://issues.jboss.org/browse/ARQ-2152?page=com.atlassian.jira.plugin.s... ]
Gordon Hutchison commented on ARQ-2152:
---------------------------------------
The patch is on a slightly backlevel base but has in WLPManagedContainer::createApplication
``` java
+ if (this.containerConfiguration.getApiTypeVisibility() != null) {
+ classLoader.setAttribute("apiTypeVisibility", this.containerConfiguration.getApiTypeVisibility());
+ }
```
and WLPManagedContainerConfiguration.java gets a
``` java
private String apiTypeVisibility;
```
and a getter and setter:
``` java
+ public void setApiTypeVisibility(String apiTypeVisibility) {
+ this.apiTypeVisibility = apiTypeVisibility;
+ }
+
+ public String getApiTypeVisibility() {
+ return apiTypeVisibility;
+ }
```
> Add support for setting 'apiTypeVisibility' in Websphere Liberty Application Server Container
> ----------------------------------------------------------------------------------------------
>
> Key: ARQ-2152
> URL: https://issues.jboss.org/browse/ARQ-2152
> Project: Arquillian
> Issue Type: Feature Request
> Components: WebSphere Containers
> Affects Versions: was_1.0.0.next
> Environment: Testing Microprofile TCKs on WebSphere Liberty
> (Apologies for setting the priority.)
> (Apologies if the version is incorrect for https://github.com/arquillian/arquillian-container-was/tree/master/wlp-ma...
> Reporter: Gordon Hutchison
> Assignee: Gerhard Poul
> Priority: Minor
>
> (I have to thank my colleague Kevin Grigorenko for this patch which I integrated into
> my local clone. The text below is pasted from text written by him: )
> "Added support for injecting a Tracer into the TCK: For the CDI injection to work, the TCK application's classloader must be configured with apiTypeVisibility="spec, ibm-api, third-party". The WAS Arquillian container's default deployType is dropins and I couldn't find a way to configure the classloader for that. The WAS Arquiallian container also supports deployType=xml which puts the WAR into apps and dynamically adds configuration to Liberty's server.xml with the <application /> element and some sub-elements. I forked that code to also add support for apiTypeVisibility and also submitted a pull request. Now, running with that fork and specifying <property name="deployType">xml</property> and <property name="apiTypeVisibility">spec, ibm-api, third-party</property> in mpOpentracingTckRunner/tck/src/test/resources/arquillian.xml allows the TCK to inject the Tracer."
> This WLP feature is discussed here:
> https://www.ibm.com/support/knowledgecenter/en/SSEQTP_8.5.5/com.ibm.websp...
> I have Kevin's code patch that does this and am only raising this issue
> in order to reference it in a pull request I am going to make
> at
> https://github.com/arquillian/arquillian-container-was/tree/master/wlp-ma...
> I have checked with Kevin that he is happy for me to do this:
> (On IBM Sametime)
> gordon_hutchison(a)uk.ibm.com - Gordon Hutchison/UK/IBM:
> 4:17:28 PM: Hi Kevin, is it OK with you if I create an issue and then a PR to integrate the 'apiTypeVisibility' change you did to the public upstream repo?
> Kevin GRIGORENKO:
> 4:17:54 PM: Yes, absolutely. Thanks very much!
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 5 months
[JBoss JIRA] (ARQ-2152) Add support for setting 'apiTypeVisibility' in Websphere Liberty Application Server Container
by Gordon Hutchison (JIRA)
Gordon Hutchison created ARQ-2152:
-------------------------------------
Summary: Add support for setting 'apiTypeVisibility' in Websphere Liberty Application Server Container
Key: ARQ-2152
URL: https://issues.jboss.org/browse/ARQ-2152
Project: Arquillian
Issue Type: Feature Request
Components: WebSphere Containers
Affects Versions: was_1.0.0.next
Environment: Testing Microprofile TCKs on WebSphere Liberty
(Apologies for setting the priority.)
(Apologies if the version is incorrect for https://github.com/arquillian/arquillian-container-was/tree/master/wlp-ma...
Reporter: Gordon Hutchison
Assignee: Gerhard Poul
Priority: Minor
(I have to thank my colleague Kevin Grigorenko for this patch which I integrated into
my local clone. The text below is pasted from text written by him: )
"Added support for injecting a Tracer into the TCK: For the CDI injection to work, the TCK application's classloader must be configured with apiTypeVisibility="spec, ibm-api, third-party". The WAS Arquillian container's default deployType is dropins and I couldn't find a way to configure the classloader for that. The WAS Arquiallian container also supports deployType=xml which puts the WAR into apps and dynamically adds configuration to Liberty's server.xml with the <application /> element and some sub-elements. I forked that code to also add support for apiTypeVisibility and also submitted a pull request. Now, running with that fork and specifying <property name="deployType">xml</property> and <property name="apiTypeVisibility">spec, ibm-api, third-party</property> in mpOpentracingTckRunner/tck/src/test/resources/arquillian.xml allows the TCK to inject the Tracer."
This WLP feature is discussed here:
https://www.ibm.com/support/knowledgecenter/en/SSEQTP_8.5.5/com.ibm.websp...
I have Kevin's code patch that does this and am only raising this issue
in order to reference it in a pull request I am going to make
at
https://github.com/arquillian/arquillian-container-was/tree/master/wlp-ma...
I have checked with Kevin that he is happy for me to do this:
(On IBM Sametime)
gordon_hutchison(a)uk.ibm.com - Gordon Hutchison/UK/IBM:
4:17:28 PM: Hi Kevin, is it OK with you if I create an issue and then a PR to integrate the 'apiTypeVisibility' change you did to the public upstream repo?
Kevin GRIGORENKO:
4:17:54 PM: Yes, absolutely. Thanks very much!
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 5 months
[JBoss JIRA] (ARQ-2151) Cannot set useAutomationExtension option for chrome
by Matous Jobanek (JIRA)
[ https://issues.jboss.org/browse/ARQ-2151?page=com.atlassian.jira.plugin.s... ]
Matous Jobanek reopened ARQ-2151:
---------------------------------
I'm reopening this issue as the fix doesn't cover cases when the value is a primitive type but not a string - can be also either a boolean or a number:
{code:xml}
<property name="chromeExperimentalOption">
{
"useAutomationExtension": false
}
</property>
{code}
> Cannot set useAutomationExtension option for chrome
> ----------------------------------------------------
>
> Key: ARQ-2151
> URL: https://issues.jboss.org/browse/ARQ-2151
> Project: Arquillian
> Issue Type: Bug
> Components: Extension - Drone
> Affects Versions: drone_2.4.3
> Reporter: Matous Jobanek
> Assignee: Matous Jobanek
> Fix For: drone_2.4.4
>
>
> There is ISE thrown when this configuration is used:
> {code:xml}
> <extension qualifier="webdriver">
> <property name="chromeExperimentalOption">
> {
> "useAutomationExtension": "false"
> }
> </property>
> </extension>
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 5 months