9:32 a.m.
Jiří Štefek created ARQGRA-230:
----------------------------------
Summary: Override a toString method in BooleanConditionWrapper
Key: ARQGRA-230
URL: https://issues.jboss.org/browse/ARQGRA-230
Project: Arquillian Graphene
Issue Type: Enhancement
Reporter: Jiří Štefek
Priority: Trivial
It would be great if BooleanConditionWrapper had its own toString() method, so the logs
from selenium could be more readable than:
{code}org.openqa.selenium.TimeoutException: Timed out after 5 seconds waiting for
org.jboss.arquillian.graphene.condition.BooleanConditionWrapper@198de25e{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:28 p.m.
[
https://issues.jboss.org/browse/ARQGRA-230?page=com.atlassian.jira.plugin...
]
Lukáš Fryč commented on ARQGRA-230:
-----------------------------------
Great idea, let's discuss it with [~jpapouse]
Override a toString method in BooleanConditionWrapper
-----------------------------------------------------
Key: ARQGRA-230
URL: https://issues.jboss.org/browse/ARQGRA-230
Project: Arquillian Graphene
Issue Type: Enhancement
Reporter: Jiří Štefek
Priority: Trivial
It would be great if BooleanConditionWrapper had its own toString() method, so the logs
from selenium could be more readable than:
{code}org.openqa.selenium.TimeoutException: Timed out after 5 seconds waiting for
org.jboss.arquillian.graphene.condition.BooleanConditionWrapper@198de25e{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:30 p.m.
[
https://issues.jboss.org/browse/ARQGRA-230?page=com.atlassian.jira.plugin...
]
Lukáš Fryč updated ARQGRA-230:
------------------------------
Assignee: Jan Papousek
Override a toString method in BooleanConditionWrapper
-----------------------------------------------------
Key: ARQGRA-230
URL: https://issues.jboss.org/browse/ARQGRA-230
Project: Arquillian Graphene
Issue Type: Enhancement
Reporter: Jiří Štefek
Assignee: Jan Papousek
Priority: Trivial
It would be great if BooleanConditionWrapper had its own toString() method, so the logs
from selenium could be more readable than:
{code}org.openqa.selenium.TimeoutException: Timed out after 5 seconds waiting for
org.jboss.arquillian.graphene.condition.BooleanConditionWrapper@198de25e{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:49 p.m.
[
https://issues.jboss.org/browse/ARQGRA-230?page=com.atlassian.jira.plugin...
]
Jan Papousek commented on ARQGRA-230:
-------------------------------------
+1, I'll implement it.
On the other side, it's a good practice to define a fail message with
WebDriverWait#failWith() method.
Override a toString method in BooleanConditionWrapper
-----------------------------------------------------
Key: ARQGRA-230
URL: https://issues.jboss.org/browse/ARQGRA-230
Project: Arquillian Graphene
Issue Type: Enhancement
Reporter: Jiří Štefek
Assignee: Jan Papousek
Priority: Trivial
It would be great if BooleanConditionWrapper had its own toString() method, so the logs
from selenium could be more readable than:
{code}org.openqa.selenium.TimeoutException: Timed out after 5 seconds waiting for
org.jboss.arquillian.graphene.condition.BooleanConditionWrapper@198de25e{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:35 a.m.
[
https://issues.jboss.org/browse/ARQGRA-230?page=com.atlassian.jira.plugin...
]
Jan Papousek updated ARQGRA-230:
--------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/arquillian/arquillian-graphene/pull/65
Override a toString method in BooleanConditionWrapper
-----------------------------------------------------
Key: ARQGRA-230
URL: https://issues.jboss.org/browse/ARQGRA-230
Project: Arquillian Graphene
Issue Type: Enhancement
Reporter: Jiří Štefek
Assignee: Jan Papousek
Priority: Trivial
Fix For: 2.0.0.Alpha3
It would be great if BooleanConditionWrapper had its own toString() method, so the logs
from selenium could be more readable than:
{code}org.openqa.selenium.TimeoutException: Timed out after 5 seconds waiting for
org.jboss.arquillian.graphene.condition.BooleanConditionWrapper@198de25e{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:35 a.m.
[
https://issues.jboss.org/browse/ARQGRA-230?page=com.atlassian.jira.plugin...
]
Jan Papousek updated ARQGRA-230:
--------------------------------
Fix Version/s: 2.0.0.Alpha3
Override a toString method in BooleanConditionWrapper
-----------------------------------------------------
Key: ARQGRA-230
URL: https://issues.jboss.org/browse/ARQGRA-230
Project: Arquillian Graphene
Issue Type: Enhancement
Reporter: Jiří Štefek
Assignee: Jan Papousek
Priority: Trivial
Fix For: 2.0.0.Alpha3
It would be great if BooleanConditionWrapper had its own toString() method, so the logs
from selenium could be more readable than:
{code}org.openqa.selenium.TimeoutException: Timed out after 5 seconds waiting for
org.jboss.arquillian.graphene.condition.BooleanConditionWrapper@198de25e{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:35 a.m.
[
https://issues.jboss.org/browse/ARQGRA-230?page=com.atlassian.jira.plugin...
]
Jan Papousek updated ARQGRA-230:
--------------------------------
Sprint: Sprint 1
Override a toString method in BooleanConditionWrapper
-----------------------------------------------------
Key: ARQGRA-230
URL: https://issues.jboss.org/browse/ARQGRA-230
Project: Arquillian Graphene
Issue Type: Enhancement
Reporter: Jiří Štefek
Assignee: Jan Papousek
Priority: Trivial
Fix For: 2.0.0.Alpha3
It would be great if BooleanConditionWrapper had its own toString() method, so the logs
from selenium could be more readable than:
{code}org.openqa.selenium.TimeoutException: Timed out after 5 seconds waiting for
org.jboss.arquillian.graphene.condition.BooleanConditionWrapper@198de25e{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:04 p.m.
[
https://issues.jboss.org/browse/ARQGRA-230?page=com.atlassian.jira.plugin...
]
Lukáš Fryč commented on ARQGRA-230:
-----------------------------------
As much work on user's side we can do is great benefit.
Btw user-defined failure message could be provided together with original
Graphene-provided one!
Override a toString method in BooleanConditionWrapper
-----------------------------------------------------
Key: ARQGRA-230
URL: https://issues.jboss.org/browse/ARQGRA-230
Project: Arquillian Graphene
Issue Type: Enhancement
Reporter: Jiří Štefek
Assignee: Jan Papousek
Priority: Trivial
Fix For: 2.0.0.Alpha3
It would be great if BooleanConditionWrapper had its own toString() method, so the logs
from selenium could be more readable than:
{code}org.openqa.selenium.TimeoutException: Timed out after 5 seconds waiting for
org.jboss.arquillian.graphene.condition.BooleanConditionWrapper@198de25e{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:04 p.m.
[
https://issues.jboss.org/browse/ARQGRA-230?page=com.atlassian.jira.plugin...
]
Lukáš Fryč edited comment on ARQGRA-230 at 11/28/12 4:04 PM:
-------------------------------------------------------------
As much work on user's side we can do is great benefit.
Btw user-defined failure message could be provided together with original
Graphene-provided one.
was (Author: lfryc):
As much work on user's side we can do is great benefit.
Btw user-defined failure message could be provided together with original
Graphene-provided one!
Override a toString method in BooleanConditionWrapper
-----------------------------------------------------
Key: ARQGRA-230
URL: https://issues.jboss.org/browse/ARQGRA-230
Project: Arquillian Graphene
Issue Type: Enhancement
Reporter: Jiří Štefek
Assignee: Jan Papousek
Priority: Trivial
Fix For: 2.0.0.Alpha3
It would be great if BooleanConditionWrapper had its own toString() method, so the logs
from selenium could be more readable than:
{code}org.openqa.selenium.TimeoutException: Timed out after 5 seconds waiting for
org.jboss.arquillian.graphene.condition.BooleanConditionWrapper@198de25e{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:58 p.m.
[
https://issues.jboss.org/browse/ARQGRA-230?page=com.atlassian.jira.plugin...
]
Jan Papousek edited comment on ARQGRA-230 at 11/29/12 6:58 AM:
---------------------------------------------------------------
+1, I'll implement it.
On the other side, it's a good practice to define a fail message with
WebDriverWait#withMessage() method.
was (Author: jpapouse):
+1, I'll implement it.
On the other side, it's a good practice to define a fail message with
WebDriverWait#failWith() method.
Override a toString method in BooleanConditionWrapper
-----------------------------------------------------
Key: ARQGRA-230
URL: https://issues.jboss.org/browse/ARQGRA-230
Project: Arquillian Graphene
Issue Type: Enhancement
Reporter: Jiří Štefek
Assignee: Jan Papousek
Priority: Trivial
Fix For: 2.0.0.Alpha3
It would be great if BooleanConditionWrapper had its own toString() method, so the logs
from selenium could be more readable than:
{code}org.openqa.selenium.TimeoutException: Timed out after 5 seconds waiting for
org.jboss.arquillian.graphene.condition.BooleanConditionWrapper@198de25e{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1 p.m.
[
https://issues.jboss.org/browse/ARQGRA-230?page=com.atlassian.jira.plugin...
]
Jan Papousek commented on ARQGRA-230:
-------------------------------------
Yes, I've added own implementation of toString() methods into all condition defined in
Graphene. When no fail message is defined, the toString() method is called.
Override a toString method in BooleanConditionWrapper
-----------------------------------------------------
Key: ARQGRA-230
URL: https://issues.jboss.org/browse/ARQGRA-230
Project: Arquillian Graphene
Issue Type: Enhancement
Reporter: Jiří Štefek
Assignee: Jan Papousek
Priority: Trivial
Fix For: 2.0.0.Alpha3
It would be great if BooleanConditionWrapper had its own toString() method, so the logs
from selenium could be more readable than:
{code}org.openqa.selenium.TimeoutException: Timed out after 5 seconds waiting for
org.jboss.arquillian.graphene.condition.BooleanConditionWrapper@198de25e{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:09 p.m.
[
https://issues.jboss.org/browse/ARQGRA-230?page=com.atlassian.jira.plugin...
]
Jan Papousek updated ARQGRA-230:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
Override a toString method in BooleanConditionWrapper
-----------------------------------------------------
Key: ARQGRA-230
URL: https://issues.jboss.org/browse/ARQGRA-230
Project: Arquillian Graphene
Issue Type: Enhancement
Reporter: Jiří Štefek
Assignee: Jan Papousek
Priority: Trivial
Fix For: 2.0.0.Alpha3
It would be great if BooleanConditionWrapper had its own toString() method, so the logs
from selenium could be more readable than:
{code}org.openqa.selenium.TimeoutException: Timed out after 5 seconds waiting for
org.jboss.arquillian.graphene.condition.BooleanConditionWrapper@198de25e{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 a.m.
[
https://issues.jboss.org/browse/ARQGRA-230?page=com.atlassian.jira.plugin...
]
Lukáš Fryč reopened ARQGRA-230:
-------------------------------
Hey Jan, just one small improvement:
{code}
org.openqa.selenium.TimeoutException: Timed out after 2 seconds waiting for text
('xyz') to be equal to text in element [[ReusableRemoteWebDriver: chrome on ANY
(1354698635905)] -> id: form:output]
Build info: version: '2.25.0', revision: '17482', time: '2012-07-18
22:18:01'
System info: os.name: 'Linux', os.arch: 'amd64', os.version:
'3.6.8-2.fc17.x86_64', java.version: '1.6.0_33'
{code}
What about the exception would be read: {{Timed out after 2 seconds waiting for text
('xyz') to be equal to text in element id: form:output but it was 'xy'}}
Override a toString method in BooleanConditionWrapper
-----------------------------------------------------
Key: ARQGRA-230
URL: https://issues.jboss.org/browse/ARQGRA-230
Project: Arquillian Graphene
Issue Type: Enhancement
Reporter: Jiří Štefek
Assignee: Jan Papousek
Priority: Trivial
Fix For: 2.0.0.Alpha3
It would be great if BooleanConditionWrapper had its own toString() method, so the logs
from selenium could be more readable than:
{code}org.openqa.selenium.TimeoutException: Timed out after 5 seconds waiting for
org.jboss.arquillian.graphene.condition.BooleanConditionWrapper@198de25e{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 a.m.
[
https://issues.jboss.org/browse/ARQGRA-230?page=com.atlassian.jira.plugin...
]
Lukáš Fryč edited comment on ARQGRA-230 at 12/5/12 4:59 AM:
------------------------------------------------------------
Hey Jan, just one small improvement:
{code}
org.openqa.selenium.TimeoutException: Timed out after 2 seconds waiting for text
('xyz') to be equal to text in element [[ReusableRemoteWebDriver: chrome on ANY
(1354698635905)] -> id: form:output]
Build info: version: '2.25.0', revision: '17482', time: '2012-07-18
22:18:01'
System info: os.name: 'Linux', os.arch: 'amd64', os.version:
'3.6.8-2.fc17.x86_64', java.version: '1.6.0_33'
{code}
What about the exception would be read: {{Timed out after 2 seconds waiting for text
('xyz') to be equal to text in element 'id: form:output' but it was
'xy'}}
was (Author: lfryc):
Hey Jan, just one small improvement:
{code}
org.openqa.selenium.TimeoutException: Timed out after 2 seconds waiting for text
('xyz') to be equal to text in element [[ReusableRemoteWebDriver: chrome on ANY
(1354698635905)] -> id: form:output]
Build info: version: '2.25.0', revision: '17482', time: '2012-07-18
22:18:01'
System info: os.name: 'Linux', os.arch: 'amd64', os.version:
'3.6.8-2.fc17.x86_64', java.version: '1.6.0_33'
{code}
What about the exception would be read: {{Timed out after 2 seconds waiting for text
('xyz') to be equal to text in element id: form:output but it was 'xy'}}
Override a toString method in BooleanConditionWrapper
-----------------------------------------------------
Key: ARQGRA-230
URL: https://issues.jboss.org/browse/ARQGRA-230
Project: Arquillian Graphene
Issue Type: Enhancement
Reporter: Jiří Štefek
Assignee: Jan Papousek
Priority: Trivial
Fix For: 2.0.0.Alpha3
It would be great if BooleanConditionWrapper had its own toString() method, so the logs
from selenium could be more readable than:
{code}org.openqa.selenium.TimeoutException: Timed out after 5 seconds waiting for
org.jboss.arquillian.graphene.condition.BooleanConditionWrapper@198de25e{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:38 a.m.
[
https://issues.jboss.org/browse/ARQGRA-230?page=com.atlassian.jira.plugin...
]
Jan Papousek commented on ARQGRA-230:
-------------------------------------
It's a good idea, but...
The toString() method should somehow describe the current instance and I don't think
it should be {code}waiting for text ('xyz') to be equal to text in element
'id: form:output' but it was 'xy'{code} It doean't make sense without
the context of waiting message. I propose to change your text to:
{code}
waiting for text ('xyz') to be equal to text ('xy') in element 'id:
form:output'
{code}
Override a toString method in BooleanConditionWrapper
-----------------------------------------------------
Key: ARQGRA-230
URL: https://issues.jboss.org/browse/ARQGRA-230
Project: Arquillian Graphene
Issue Type: Enhancement
Reporter: Jiří Štefek
Assignee: Jan Papousek
Priority: Trivial
Fix For: 2.0.0.Alpha3
It would be great if BooleanConditionWrapper had its own toString() method, so the logs
from selenium could be more readable than:
{code}org.openqa.selenium.TimeoutException: Timed out after 5 seconds waiting for
org.jboss.arquillian.graphene.condition.BooleanConditionWrapper@198de25e{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4168
days inactive
4177
days old
arquillian-issues@lists.jboss.org
14 comments
3 participants
participants (3)
-
Jan Papousek (JIRA) -
Jiří Štefek (JIRA)
-
Lukáš Fryč (JIRA)