[ https://jira.jboss.org/browse/ARQ-336?page=com.atlassian.jira.plugin.syst... ] Aslak Knutsen commented on ARQ-336: ----------------------------------- how to hard kill a embedded server ? -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQ-336?page=com.atlassian.jira.plugin.sy... ] Martin Gencur reassigned ARQ-336: --------------------------------- Assignee: Martin Gencur (was: Aslak Knutsen) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQ-336?page=com.atlassian.jira.plugin.sy... ] Martin Gencur commented on ARQ-336: ----------------------------------- I guess in such a case when I can start/stop/kill server instances all the tests will need to run in Client mode (@RunAsClient) since the test will stop/kill its own container in which it runs so it would fail anyway. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQ-336?page=com.atlassian.jira.plugin.sy... ] Martin Gencur commented on ARQ-336: ----------------------------------- OK, there are usecases where it is usable to run incontainer. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQ-336?page=com.atlassian.jira.plugin.sy... ] Martin Gencur edited comment on ARQ-336 at 7/1/11 5:05 AM: ----------------------------------------------------------- All the functionality is implemented already but not yet pushed. A user will be able to inject a ContainerController: {code:java} @ArquillianResource ContainerController controller; {code} and start/stop/kill server instances like this: {code:java} @Test public void killTest() throws Exception { //CONTAINER2 variable corresponds to container's name specified via qualifier arquillian.xml // ... <container qualifier="container2" managed="false"> controller.start(CONTAINER2); //do some test controller.stop(CONTAINER2); //do some test controller.start(CONTAINER2); //do some test controller.kill(CONTAINER2); //do some test } {code} The kill method has a default implementation called DefaultServerKillProcessor (implements org.jboss.arquillian.container.spi.ServerKillProcessor) which is used if no other impls are available. These can be shipped with DeployableContainer implementations or directly within a test. The default implementation does the same as stop() so when there is a need to hard kill a server instance, the concrete implementation for the target container has to be supplied. There are certain limitations, though. When running in a Client mode (@RunAsClient), all servers can be started/stopped/killed. To run in InContainer mode only containers other than the one running the test can be stopped/killed. was (Author: mgencur): All the functionality is implemented already but not yet pushed. A user will be able to inject a ContainerController: {code:java} @ArquillianResource ContainerController container; {code} and start/stop/kill server instances like this: {code:java} @Test public void killTest() throws Exception { //CONTAINER2 variable corresponds to container's name specified via qualifier arquillian.xml // ... <container qualifier="container2" managed="false"> controller.start(CONTAINER2); //do some test controller.stop(CONTAINER2); //do some test controller.start(CONTAINER2); //do some test controller.kill(CONTAINER2); //do some test } {code} The kill method has a default implementation called DefaultServerKillProcessor (implements org.jboss.arquillian.container.spi.ServerKillProcessor) which is used if no other impls are available. These can be shipped with DeployableContainer implementations or directly within a test. The default implementation does the same as stop() so when there is a need to hard kill a server instance, the concrete implementation for the target container has to be supplied. There are certain limitations, though. When running in a Client mode (@RunAsClient), all servers can be started/stopped/killed. To run in InContainer mode only containers other than the one running the test can be stopped/killed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQ-336?page=com.atlassian.jira.plugin.sy... ] Radoslav Husar commented on ARQ-336: ------------------------------------ If I got the point correctly, my suggestion was: autostart="true|false" -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQ-336?page=com.atlassian.jira.plugin.sy... ] Karel Piwko commented on ARQ-336: --------------------------------- We already had a two state logic in Arquillian - RunAs(CLIENT, INCONTAINER) and it was replaced in Alpha5. Couldn't we move this to the class directly? Something like: {code} @ContainerSuiteLifecycle class FooTest { ... } {code} @ContainerManualLifecycle("jboss1") @ContainerClassLifecycle("jboss2", "jboss3") class Foo2Test { @Deployment @TargetsContainer("jboss1") ... } {code} In XML/XSD, this mapping would correspond rather to an element than attribute, so user can easily provide his own implementation and not depend on suite/class/manual possibilities, similar to protocols. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQ-336?page=com.atlassian.jira.plugin.sy... ] Aslak Knutsen commented on ARQ-336: ----------------------------------- What happens when: @ContainerSuiteLifecycle public class Foo1Test {} and @ContainerClassLifecycle public class Foo2Test {} exist in the same Suite ? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQ-336?page=com.atlassian.jira.plugin.sy... ] Ivo Studensky commented on ARQ-336: ----------------------------------- Could this be pushed to Arquillian and then to AS7 soon? We (QE) really need such functionality for our test development. Thanks. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQ-336?page=com.atlassian.jira.plugin.sy... ] Martin Gencur commented on ARQ-336: ----------------------------------- I just remind that this already implemented, for quite some time, with the flag being "managed=true|false" (https://github.com/mgencur/arquillian-core/commits/ARQ-336_clean [last 2 commits]) and after I do rebase on current master, it can be merged there. Aslak, do you really want to change the flag to "mode"/"controlmode" where possible values are suite|class|manual ? If this is true, than this issue is dependent on the ARQ-236 and will need rework. Otherwise, it's ready to be merged into master. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQ-336?page=com.atlassian.jira.plugin.sy... ] Martin Gencur commented on ARQ-336: ----------------------------------- I had a conversation with Aslak. This JIRA is going to be merged into master once 1.0.0.Final is out (only bug fixes will be merged before Final is out). Until that moment, I have time to rework this solution a bit to be using mode="suite|class|manual" instead of managed="true|false". ARQ-236 can be solved after this JIRA. Furthermore, there will be an option to start a server with modifications to the default/template configuration. Something like controller.start("CONTAINER1", Config.add("port", "8180").add("ip", "192.1.1.1")) or controller.start("CONTAINER1", propertiesOverrideMap)) where the map is of type Map<String,String> . -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQ-336?page=com.atlassian.jira.plugin.sy... ] Martin Gencur commented on ARQ-336: ----------------------------------- I implemented proposed changes: https://github.com/mgencur/arquillian-core/commit/9603075003454ef47265183.... When someone wants to try it they can use https://github.com/mgencur/edg-tests/tree/master/failover example. Current usage looks like this: {code:java} @ArquillianResource ContainerController controller; @Test public void killTest() throws Exception { //CONTAINER2 variable corresponds to container's name specified via qualifier arquillian.xml // ... <container qualifier="container2" mode="manual"> //other values are mode="suite|class" , "suite" is default, "class" not implemented yet, that will be in ARQ-236 controller.start(CONTAINER2); //do some test controller.stop(CONTAINER2); //do some test //the second parameter is of type Map<String, String>, the Config class is just a thing of convenience controller.start(CONTAINER2, new Config().add("managementPort", "19999").add("xx","yy").map()); //do some test controller.kill(CONTAINER2); //do some test } {code} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQ-336?page=com.atlassian.jira.plugin.sy... ] Aslak Knutsen updated ARQ-336: ------------------------------ Fix Version/s: 1.0.0.Final (was: 1.1.0.Beta1) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQ-336?page=com.atlassian.jira.plugin.sy... ] Paul Robinson commented on ARQ-336: ----------------------------------- Martin, Thanks for the info. Looks like writing our own impl of ServerKillProcesor shouldn't be too difficult. We should be able to use the example in edg-tests to figure out how to specify our own impl of ServerKillProcesor. Does this make sense? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQ-336?page=com.atlassian.jira.plugin.sy... ] Paul Robinson commented on ARQ-336: ----------------------------------- Thanks Martin, Sounds nice and simple. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQ-336?page=com.atlassian.jira.plugin.sy... ] Martin Gencur commented on ARQ-336: ----------------------------------- I would just add a comment on various combinations of container mode (mode=managed|suite) and deployment (managed=true|false). 1) container mode==suite, deployment managed==true --> container start/stop - automatic (in before/after suite phase), deployment - automatic (in before/after class phase) 2) container mode==suite, deployment managed==false --> container start/stop - automatic (in before/after suite phase), deployment - manual (via Deployer API) 3) container mode==manual, deployment managed==true --> container start/stop - manual (via ContainerController API), deployment - automatic (right after the container is started and before the container is stopped) 4) container mode==manual, deployment managed==false --> container start/stop - manual (via ContainerController API), deployment - manual (via Deployer API) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQ-336?page=com.atlassian.jira.plugin.sy... ] Aslak Knutsen closed ARQ-336. ----------------------------- -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira