1 p.m.
TransactionalWrapper.afterTest() ignores SessionContext.setRollbackOnly()
-------------------------------------------------------------------------
Key: ARQ-723
URL: https://issues.jboss.org/browse/ARQ-723
Project: Arquillian
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: Extension - Persistence
Affects Versions: persistence_1.0.0.Alpha3
Reporter: Juergen Zimmermann
Assignee: Bartosz Majsak
If a method is being tested that invokes SessionContext.setRollbackOnly(), then the commit
mode doesn't work correctly, because doing a commit() after setRollbackOnly() will
fail. Therefore, the method TransactionalWrapper.afterTest() should be implemented as
follows:
final TransactionMode mode = metadataProvider.get().getTransactionalMode();
final UserTransaction trans;
if (TransactionMode.COMMIT.equals(mode)) {
if (Status.STATUS_MARKED_ROLLBACK.equals(trans.getStatus())) {
trans.rollback();
}
else {
trans.commit();
}
}
else {
trans.rollback();
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:03 p.m.
[
https://issues.jboss.org/browse/ARQ-723?page=com.atlassian.jira.plugin.sy...
]
Juergen Zimmermann updated ARQ-723:
-----------------------------------
Description:
If a method is being tested that invokes SessionContext.setRollbackOnly(), then the commit
mode doesn't work correctly, because doing a commit() after setRollbackOnly() will
fail. Therefore, the method TransactionalWrapper.afterTest() should be implemented as
follows:
final TransactionMode mode = metadataProvider.get().getTransactionalMode();
final UserTransaction trans = obtainTransaction();
if (TransactionMode.COMMIT.equals(mode)) {
if (Status.STATUS_MARKED_ROLLBACK.equals(trans.getStatus())) {
trans.rollback();
}
else {
trans.commit();
}
}
else {
trans.rollback();
}
was:
If a method is being tested that invokes SessionContext.setRollbackOnly(), then the commit
mode doesn't work correctly, because doing a commit() after setRollbackOnly() will
fail. Therefore, the method TransactionalWrapper.afterTest() should be implemented as
follows:
final TransactionMode mode = metadataProvider.get().getTransactionalMode();
final UserTransaction trans;
if (TransactionMode.COMMIT.equals(mode)) {
if (Status.STATUS_MARKED_ROLLBACK.equals(trans.getStatus())) {
trans.rollback();
}
else {
trans.commit();
}
}
else {
trans.rollback();
}
TransactionalWrapper.afterTest() ignores
SessionContext.setRollbackOnly()
-------------------------------------------------------------------------
Key: ARQ-723
URL: https://issues.jboss.org/browse/ARQ-723
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Extension - Persistence
Affects Versions: persistence_1.0.0.Alpha3
Reporter: Juergen Zimmermann
Assignee: Bartosz Majsak
If a method is being tested that invokes SessionContext.setRollbackOnly(), then the
commit mode doesn't work correctly, because doing a commit() after setRollbackOnly()
will fail. Therefore, the method TransactionalWrapper.afterTest() should be implemented as
follows:
final TransactionMode mode = metadataProvider.get().getTransactionalMode();
final UserTransaction trans = obtainTransaction();
if (TransactionMode.COMMIT.equals(mode)) {
if (Status.STATUS_MARKED_ROLLBACK.equals(trans.getStatus())) {
trans.rollback();
}
else {
trans.commit();
}
}
else {
trans.rollback();
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:42 p.m.
[
https://issues.jboss.org/browse/ARQ-723?page=com.atlassian.jira.plugin.sy...
]
Bartosz Majsak commented on ARQ-723:
------------------------------------
Excellent! Thanks a lot for spotting this problem. Would you mind to file a pull request?
Cheers,
Bartosz
TransactionalWrapper.afterTest() ignores
SessionContext.setRollbackOnly()
-------------------------------------------------------------------------
Key: ARQ-723
URL: https://issues.jboss.org/browse/ARQ-723
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Extension - Persistence
Affects Versions: persistence_1.0.0.Alpha3
Reporter: Juergen Zimmermann
Assignee: Bartosz Majsak
If a method is being tested that invokes SessionContext.setRollbackOnly(), then the
commit mode doesn't work correctly, because doing a commit() after setRollbackOnly()
will fail. Therefore, the method TransactionalWrapper.afterTest() should be implemented as
follows:
final TransactionMode mode = metadataProvider.get().getTransactionalMode();
final UserTransaction trans = obtainTransaction();
if (TransactionMode.COMMIT.equals(mode)) {
if (Status.STATUS_MARKED_ROLLBACK.equals(trans.getStatus())) {
trans.rollback();
}
else {
trans.commit();
}
}
else {
trans.rollback();
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:08 p.m.
[
https://issues.jboss.org/browse/ARQ-723?page=com.atlassian.jira.plugin.sy...
]
Juergen Zimmermann commented on ARQ-723:
----------------------------------------
How should I do that? Can you give me a hint please?
TransactionalWrapper.afterTest() ignores
SessionContext.setRollbackOnly()
-------------------------------------------------------------------------
Key: ARQ-723
URL: https://issues.jboss.org/browse/ARQ-723
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Extension - Persistence
Affects Versions: persistence_1.0.0.Alpha3
Reporter: Juergen Zimmermann
Assignee: Bartosz Majsak
If a method is being tested that invokes SessionContext.setRollbackOnly(), then the
commit mode doesn't work correctly, because doing a commit() after setRollbackOnly()
will fail. Therefore, the method TransactionalWrapper.afterTest() should be implemented as
follows:
final TransactionMode mode = metadataProvider.get().getTransactionalMode();
final UserTransaction trans = obtainTransaction();
if (TransactionMode.COMMIT.equals(mode)) {
if (Status.STATUS_MARKED_ROLLBACK.equals(trans.getStatus())) {
trans.rollback();
}
else {
trans.commit();
}
}
else {
trans.rollback();
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:30 a.m.
[
https://issues.jboss.org/browse/ARQ-723?page=com.atlassian.jira.plugin.sy...
]
Bartosz Majsak commented on ARQ-723:
------------------------------------
Sure, with pleasure :)
There are only few things needed to move on:
* Sign [Contributor License Agreement|https://cla.jboss.org] for Arquillian project.
* Create [GitHub|https://github.com/] account (if you don't have one already).
* [Fork repository|http://help.github.com/fork-a-repo/] of [Arquillian Persistence
Extension|https://github.com/arquillian/arquillian-extension-persistence].
* Create branch for issue which you would like to work on.
* Assign yourself to this Jira issue and start hacking :)
Once you are done just create a [pull request|http://help.github.com/send-pull-requests/]
and I will take care of pushing it upstream.
There is also handy [Git
guideline|http://community.jboss.org/wiki/ShrinkWrapDevelopmentAndContrib...] from
Shrinkwrap project which describes a workflow used by Arquillian as well.
If you have any questions just drop me a line! I will be more than happy to help.
TransactionalWrapper.afterTest() ignores
SessionContext.setRollbackOnly()
-------------------------------------------------------------------------
Key: ARQ-723
URL: https://issues.jboss.org/browse/ARQ-723
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Extension - Persistence
Affects Versions: persistence_1.0.0.Alpha3
Reporter: Juergen Zimmermann
Assignee: Bartosz Majsak
If a method is being tested that invokes SessionContext.setRollbackOnly(), then the
commit mode doesn't work correctly, because doing a commit() after setRollbackOnly()
will fail. Therefore, the method TransactionalWrapper.afterTest() should be implemented as
follows:
final TransactionMode mode = metadataProvider.get().getTransactionalMode();
final UserTransaction trans = obtainTransaction();
if (TransactionMode.COMMIT.equals(mode)) {
if (Status.STATUS_MARKED_ROLLBACK.equals(trans.getStatus())) {
trans.rollback();
}
else {
trans.commit();
}
}
else {
trans.rollback();
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:16 a.m.
[
https://issues.jboss.org/browse/ARQ-723?page=com.atlassian.jira.plugin.sy...
]
Bartosz Majsak commented on ARQ-723:
------------------------------------
I've recently created [Arquillian contribution and development
guideline|http://community.jboss.org/wiki/ArquillianDevelopmentAndContrib...]. Are you
still willing to work on this issue? :)
TransactionalWrapper.afterTest() ignores
SessionContext.setRollbackOnly()
-------------------------------------------------------------------------
Key: ARQ-723
URL: https://issues.jboss.org/browse/ARQ-723
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Extension - Persistence
Affects Versions: persistence_1.0.0.Alpha3
Reporter: Juergen Zimmermann
Assignee: Bartosz Majsak
If a method is being tested that invokes SessionContext.setRollbackOnly(), then the
commit mode doesn't work correctly, because doing a commit() after setRollbackOnly()
will fail. Therefore, the method TransactionalWrapper.afterTest() should be implemented as
follows:
final TransactionMode mode = metadataProvider.get().getTransactionalMode();
final UserTransaction trans = obtainTransaction();
if (TransactionMode.COMMIT.equals(mode)) {
if (Status.STATUS_MARKED_ROLLBACK.equals(trans.getStatus())) {
trans.rollback();
}
else {
trans.commit();
}
}
else {
trans.rollback();
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:56 a.m.
[
https://issues.jboss.org/browse/ARQ-723?page=com.atlassian.jira.plugin.sy...
]
Juergen Zimmermann commented on ARQ-723:
----------------------------------------
Bartosz, sorry, but I'm to busy to set up a GIT environment just for adding a few
lines to Arquillian Persistence.
TransactionalWrapper.afterTest() ignores
SessionContext.setRollbackOnly()
-------------------------------------------------------------------------
Key: ARQ-723
URL: https://issues.jboss.org/browse/ARQ-723
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Extension - Persistence
Affects Versions: persistence_1.0.0.Alpha3
Reporter: Juergen Zimmermann
Assignee: Bartosz Majsak
If a method is being tested that invokes SessionContext.setRollbackOnly(), then the
commit mode doesn't work correctly, because doing a commit() after setRollbackOnly()
will fail. Therefore, the method TransactionalWrapper.afterTest() should be implemented as
follows:
final TransactionMode mode = metadataProvider.get().getTransactionalMode();
final UserTransaction trans = obtainTransaction();
if (TransactionMode.COMMIT.equals(mode)) {
if (Status.STATUS_MARKED_ROLLBACK.equals(trans.getStatus())) {
trans.rollback();
}
else {
trans.commit();
}
}
else {
trans.rollback();
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:26 a.m.
[
https://issues.jboss.org/browse/ARQ-723?page=com.atlassian.jira.plugin.sy...
]
Bartosz Majsak commented on ARQ-723:
------------------------------------
I understand, no problem. I will take care of it.
Thanks for reporting!
TransactionalWrapper.afterTest() ignores
SessionContext.setRollbackOnly()
-------------------------------------------------------------------------
Key: ARQ-723
URL: https://issues.jboss.org/browse/ARQ-723
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Extension - Persistence
Affects Versions: persistence_1.0.0.Alpha3
Reporter: Juergen Zimmermann
Assignee: Bartosz Majsak
If a method is being tested that invokes SessionContext.setRollbackOnly(), then the
commit mode doesn't work correctly, because doing a commit() after setRollbackOnly()
will fail. Therefore, the method TransactionalWrapper.afterTest() should be implemented as
follows:
final TransactionMode mode = metadataProvider.get().getTransactionalMode();
final UserTransaction trans = obtainTransaction();
if (TransactionMode.COMMIT.equals(mode)) {
if (Status.STATUS_MARKED_ROLLBACK.equals(trans.getStatus())) {
trans.rollback();
}
else {
trans.commit();
}
}
else {
trans.rollback();
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:51 a.m.
[
https://issues.jboss.org/browse/ARQ-723?page=com.atlassian.jira.plugin.sy...
]
Bartosz Majsak updated ARQ-723:
-------------------------------
Fix Version/s: performance_1.0.0.next
TransactionalWrapper.afterTest() ignores
SessionContext.setRollbackOnly()
-------------------------------------------------------------------------
Key: ARQ-723
URL: https://issues.jboss.org/browse/ARQ-723
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Extension - Persistence
Affects Versions: persistence_1.0.0.Alpha3
Reporter: Juergen Zimmermann
Assignee: Bartosz Majsak
Fix For: performance_1.0.0.next
If a method is being tested that invokes SessionContext.setRollbackOnly(), then the
commit mode doesn't work correctly, because doing a commit() after setRollbackOnly()
will fail. Therefore, the method TransactionalWrapper.afterTest() should be implemented as
follows:
final TransactionMode mode = metadataProvider.get().getTransactionalMode();
final UserTransaction trans = obtainTransaction();
if (TransactionMode.COMMIT.equals(mode)) {
if (Status.STATUS_MARKED_ROLLBACK.equals(trans.getStatus())) {
trans.rollback();
}
else {
trans.commit();
}
}
else {
trans.rollback();
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:51 a.m.
[
https://issues.jboss.org/browse/ARQ-723?page=com.atlassian.jira.plugin.sy...
]
Bartosz Majsak updated ARQ-723:
-------------------------------
Fix Version/s: persistence_1.0.0.next
(was: performance_1.0.0.next)
TransactionalWrapper.afterTest() ignores
SessionContext.setRollbackOnly()
-------------------------------------------------------------------------
Key: ARQ-723
URL: https://issues.jboss.org/browse/ARQ-723
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Extension - Persistence
Affects Versions: persistence_1.0.0.Alpha3
Reporter: Juergen Zimmermann
Assignee: Bartosz Majsak
Fix For: persistence_1.0.0.next
If a method is being tested that invokes SessionContext.setRollbackOnly(), then the
commit mode doesn't work correctly, because doing a commit() after setRollbackOnly()
will fail. Therefore, the method TransactionalWrapper.afterTest() should be implemented as
follows:
final TransactionMode mode = metadataProvider.get().getTransactionalMode();
final UserTransaction trans = obtainTransaction();
if (TransactionMode.COMMIT.equals(mode)) {
if (Status.STATUS_MARKED_ROLLBACK.equals(trans.getStatus())) {
trans.rollback();
}
else {
trans.commit();
}
}
else {
trans.rollback();
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:29 a.m.
[
https://issues.jboss.org/browse/ARQ-723?page=com.atlassian.jira.plugin.sy...
]
Work on ARQ-723 started by Bartosz Majsak.
TransactionalWrapper.afterTest() ignores
SessionContext.setRollbackOnly()
-------------------------------------------------------------------------
Key: ARQ-723
URL: https://issues.jboss.org/browse/ARQ-723
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Extension - Persistence
Affects Versions: persistence_1.0.0.Alpha3
Reporter: Juergen Zimmermann
Assignee: Bartosz Majsak
Fix For: persistence_1.0.0.next
If a method is being tested that invokes SessionContext.setRollbackOnly(), then the
commit mode doesn't work correctly, because doing a commit() after setRollbackOnly()
will fail. Therefore, the method TransactionalWrapper.afterTest() should be implemented as
follows:
final TransactionMode mode = metadataProvider.get().getTransactionalMode();
final UserTransaction trans = obtainTransaction();
if (TransactionMode.COMMIT.equals(mode)) {
if (Status.STATUS_MARKED_ROLLBACK.equals(trans.getStatus())) {
trans.rollback();
}
else {
trans.commit();
}
}
else {
trans.rollback();
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:56 a.m.
[
https://issues.jboss.org/browse/ARQ-723?page=com.atlassian.jira.plugin.sy...
]
Bartosz Majsak resolved ARQ-723.
--------------------------------
Resolution: Done
TransactionalWrapper.afterTest() ignores
SessionContext.setRollbackOnly()
-------------------------------------------------------------------------
Key: ARQ-723
URL: https://issues.jboss.org/browse/ARQ-723
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Extension - Persistence
Affects Versions: persistence_1.0.0.Alpha3
Reporter: Juergen Zimmermann
Assignee: Bartosz Majsak
Fix For: persistence_1.0.0.next
If a method is being tested that invokes SessionContext.setRollbackOnly(), then the
commit mode doesn't work correctly, because doing a commit() after setRollbackOnly()
will fail. Therefore, the method TransactionalWrapper.afterTest() should be implemented as
follows:
final TransactionMode mode = metadataProvider.get().getTransactionalMode();
final UserTransaction trans = obtainTransaction();
if (TransactionMode.COMMIT.equals(mode)) {
if (Status.STATUS_MARKED_ROLLBACK.equals(trans.getStatus())) {
trans.rollback();
}
else {
trans.commit();
}
}
else {
trans.rollback();
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:06 p.m.
[
https://issues.jboss.org/browse/ARQ-723?page=com.atlassian.jira.plugin.sy...
]
Aslak Knutsen updated ARQ-723:
------------------------------
Fix Version/s: persistence_1.0.0.Alpha4
(was: persistence_1.0.0.next)
TransactionalWrapper.afterTest() ignores
SessionContext.setRollbackOnly()
-------------------------------------------------------------------------
Key: ARQ-723
URL: https://issues.jboss.org/browse/ARQ-723
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Extension - Persistence
Affects Versions: persistence_1.0.0.Alpha3
Reporter: Juergen Zimmermann
Assignee: Bartosz Majsak
Fix For: persistence_1.0.0.Alpha4
If a method is being tested that invokes SessionContext.setRollbackOnly(), then the
commit mode doesn't work correctly, because doing a commit() after setRollbackOnly()
will fail. Therefore, the method TransactionalWrapper.afterTest() should be implemented as
follows:
final TransactionMode mode = metadataProvider.get().getTransactionalMode();
final UserTransaction trans = obtainTransaction();
if (TransactionMode.COMMIT.equals(mode)) {
if (Status.STATUS_MARKED_ROLLBACK.equals(trans.getStatus())) {
trans.rollback();
}
else {
trans.commit();
}
}
else {
trans.rollback();
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:40 p.m.
[
https://issues.jboss.org/browse/ARQ-723?page=com.atlassian.jira.plugin.sy...
]
Aslak Knutsen closed ARQ-723.
-----------------------------
TransactionalWrapper.afterTest() ignores
SessionContext.setRollbackOnly()
-------------------------------------------------------------------------
Key: ARQ-723
URL: https://issues.jboss.org/browse/ARQ-723
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Extension - Persistence
Affects Versions: persistence_1.0.0.Alpha3
Reporter: Juergen Zimmermann
Assignee: Bartosz Majsak
Fix For: persistence_1.0.0.Alpha4
If a method is being tested that invokes SessionContext.setRollbackOnly(), then the
commit mode doesn't work correctly, because doing a commit() after setRollbackOnly()
will fail. Therefore, the method TransactionalWrapper.afterTest() should be implemented as
follows:
final TransactionMode mode = metadataProvider.get().getTransactionalMode();
final UserTransaction trans = obtainTransaction();
if (TransactionMode.COMMIT.equals(mode)) {
if (Status.STATUS_MARKED_ROLLBACK.equals(trans.getStatus())) {
trans.rollback();
}
else {
trans.commit();
}
}
else {
trans.rollback();
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4553
days inactive
4647
days old
arquillian-issues@lists.jboss.org
13 comments
7 participants
participants (7)
-
Aslak Knutsen (JIRA) -
Bartosz Majsak (Commented) (JIRA)
-
Bartosz Majsak (JIRA)
-
Juergen Zimmermann (Commented) (JIRA)
-
Juergen Zimmermann (Created) (JIRA)
-
Juergen Zimmermann (JIRA)
-
Juergen Zimmermann (Updated) (JIRA)