On Jul 21, 2015, at 12:12 PM, John Mazzitelli <mazz(a)redhat.com>
wrote:
OK, folks... how do we solve the following?
There are now two independent enums to define metric data type - one in inventory and one
in metrics.
org.hawkular.inventory.api.model.MetricDataType
org.hawkular.metrics.client.common.MetricType
> From an agent or feed perspective, I now have to decide which one I want. Pretty
annoying, but OK I can translate between the two if I need to (if the agent is talking to
inventory, it will use their enum; if talking to metrics, use their enum). In the agent
configuration, <metric-dmr> will need to use the common values between the two in
order to support both. But this leads to a more difficult problem to come to grips with -
inventory and metric enums for metric type have different values!
Inventory has GAUGE, AVAILABILITY, COUNTER, COUNTER_RATE.
Metrics API has GAUGE, COUNTER, TIMING, SIMPLE.
Right now, the wildfly agent only supports gauge and counter (and inventory
availability).
I do not know what TIMING and SIMPLE are. The metrics-core-api module has the class
org.hawkular.metrics.api.MetricType whose values are the same as those in the Inventory
enum. In this particular case, I think Inventory should reuse
org.hawkular.metrics.api.MetricType since that is what ultimately defines the recognized
and supported types.