2:56 p.m.
Hi Thomas, inline...
On 2015-05-11 12:56, Thomas Segismont wrote:
Hi Peter,
I suppose the last part of the PR is not related to the recent Kettle
issues.
To me failing the build if local changes are present sounds like a good
idea.
But we must make sure that no plugin generates files outside of
the "target" directory. Until recently the Swagger Maven plugin was
writing doc files to the REST project base directory, for example.
Ah, it is a good idea to check this in all hk projects. I only added
that so that we can be sure that the sha1 in manifest mirrors 100% of
the current project's state.
If this is true then the PR looks good to me and it can be merged.
Thanks,
Peter
Cheers,
Thomas
Le 11/05/2015 10:44, Peter Palaga a écrit :
> Hi *,
>
> citing from https://issues.jboss.org/browse/HAWKULAR-176 :
>
> == Motivation
>
> The proposed changes should improve the traceability of the components
> delivered with kettle. Because we use SNAPSHOTs to build kettle ATM,
> there is no way to find out which state of the individual component's
> git repos underlie the given kettle distribution.
>
> In a situation when Lukáš has a working kettle distro and Thomas H.
> cannot succeed to build one, they can go through the SHA1 hashes listed
> in the manifest.mf files of the kettle components to find out where is
> the difference.
>
> This proposal is not a proper solution of the problem that kettle builds
> are not reproducible. It just picks some low hanging fruits to soften
> the possible negative impact of our irreproducible builds.
>
> == Changes
>
> Maven should be configured in such a way that .jar, .war and *.ear files
> will have the following new entries added to their manifest.mf files:
> Built-From-Git-SHA1 - the last git commit's hash
> Built-On - the time when the build has started
> Built-From-Git-Branch - the git branch being built from
>
> Further, when the release profile is active, the build should fail, in
> case there are uncommitted local changes.
>
> See https://github.com/hawkular/hawkular-parent-pom/pull/21
>
>
> Best,
>
> Peter
> _______________________________________________
> hawkular-dev mailing list
> hawkular-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hawkular-dev
>
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev