6:59 p.m.
Le 24/07/2015 18:37, Peter Palaga a écrit :
I was quite undecided about this change, but because it impacts all
consumers of Hawkular Parent (and implies some work in all consumers) I
hoped to hear about some specific module where the change is inevitable,
because the current state is dysfunctional due to the import of WF BoM.
You have not seem to have provided such one.
I told you already where the forced scopes were harmful.
Note that we could have vetoed the upgrade to parent version 16 because
applying it was breaking our build. See your PR, which I couldn't merge:
https://github.com/hawkular/hawkular-metrics/pull/260
But to keep things going, we've fixed the issue as we could, see my PR:
https://github.com/hawkular/hawkular-metrics/pull/268
I'll think about vetoing next time.
I am making my best to understand the background of your proposal. So to
paraphrase your position, the WF BoM import in Parent is not causing
anything bad directly, you just do not find it good that in non-WF
related modules (ptrans, REST tests) one may easily overlook that one
actually makes use of a version managed in WF BoM. When one is aware of
the fact that the given artifact is managed in WF BoM and one does not
want that, one is free to put one's own explicit version on the
dependency and the problem is solved (at least at the physical class
path level).
Already answered that. My position is I don't want to do this again.
I agree that your proposal is in some sense cleaner, than what we
have
now, but I do not think it is worth of the effort.
The effort is a few lines removed in the parent and re-added in the
components where relevant. We should be able to manage.
To name a situation where removing the WF BoM import would make
sense
to me (Stefan asked about that): E.g. if we decided to target additional
platforms that support APIs conflicting with those of WF.
Yes we'll soon need to do this in Metrics, for an EAP6.4 deployment.
Funny how the situation came up so quickly.
I prefer not to adopt this proposal, but I am far from being strongly
against it. Is there anybody else who wants to veto?
Read this sentence again. Then facepalm or ROFL.