Re: [Hawkular-dev] Property passing into Hawkular(-metrics)
On 16/06/15 04:29 AM, Heiko W.Rupp wrote:
Hey,
currently one can pass properties/options like the C* to use
via -Dkey=value pairs to standalone.sh/bat
This is a bit cumbersome and also does not work in cases, where
the command line is set at "compile time" like in a Dockerfile,
but the property needs to be set at run time (when docker run
a pre-made image).
You can specify the default start options in the dockerfile, which
allows for a simple install of that image.
But you can also pass your own options when you go to first start your
docker image, as well as overwrite them in the kubernetes configuration.
Setting the options via a command line option is the easiest option when
dealing with docker images and kubernetes, otherwise you need to jump
through a bunch of hoops. I would really like to keep this option
available if possible.
There would be the option to set JAVA_OPTS before starting
the script, but JAVA_OPTS is
a) something that may apply to multiple java programs on a machine
and is thus not specific
b) inside standalone.conf not additive, so one has to repeat all the
options from standalone.conf on JAVA_OPTS
So I propose hat we add (similar to RHQ) some HAWKULAR_OPTS
that are additive to JAVA_OPTS.
We need to modify standalone.sh/bat to source them (and keep the
modified versions in our git repo.
Alternatives could be
- create wrapper scripts that set JAVA_OPTS and call standalone.sh,
but that only indirectly solves [1]
- as the WildFly team to add some WF_LOCAL_OPTS in upcoming releases.
I fear that may take too long.
Opinions?
[1] https://issues.jboss.org/browse/HAWKULAR-288
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev