On 12/05/15 01:45 PM, Thomas Segismont wrote:
Le 12/05/2015 15:17, Stefan Negrea a écrit :
> ----- Original Message -----
>>> From: "Thomas Segismont"<tsegismo(a)redhat.com>
>>> To:hawkular-dev@lists.jboss.org
>>> Sent: Tuesday, May 12, 2015 8:08:36 AM
>>> Subject: Re: [Hawkular-dev] Tenant Id - Not Part of URL
>>>
>>> You mean use_hawkularTenant_ instead of the_tenant_ query param? That
>>> makes less sense to me.
> I would use an identical query parameter so consumers that do not want/have the
option to use headers can just append an identical query parameter. The hyphen is not
reserved, therefore it can be used as part of the query parameter name or value without
encoding. Correct me if I am wrong about the hyphen.
>
>
http://tools.ietf.org/html/rfc3986#section-2.3
>
>
Please do not switch from top to bottom posting, or I might start to get
sick :p
What is the correct convention for posting to the list? :) Top, bottom,
inline?
For the query parameter, is there any reason why we are using a query
parameter and not a matrix parameter?
Personally I think a matrix parameter makes a lot more sense
http://hawkular/metrics;tenant=foo/gauges/....
versus
http://hawkular/metrics/gauges/....?tenant=foo
Always having to specify tenant at the end of the url seems strange to
be. Logically I would think that it should be applied to the metrics
resource itself and not to all the child resources.
Something like this would normally mean that the parameter 'a' is to be
applied to the 'foo/bar' resource:
http://foo/bar;a=b/baz
While, something like this would normally mean that the parameter 'a' is
to be applied to the 'foo/bar/baz' resource:
http://foo/bar/baz?a=b
Yes, "Hawkular-Tenant" is valid, but I'd prefer to pick something short
("tenant") for the query parameter fallback.
In fact, I'd prefer to have short names for all out-of-band query
parameters, like "pretty" to get a formatted JSON output.
_______________________________________________