2:47 a.m.
Hi,
There is a small upcoming change in the Inventory REST API which consists
in removing a deprecated field, as explained in this JIRA:
https://issues.jboss.org/browse/HWKINVENT-200
Basically, "type" has been replaced with "metricDataType" a while ago
and
made deprecated, now it's going to be removed. Probably not for the next
release, but for the one after. Meanwhile I'd like to check any existing
usage. What are the potential usages?
- Ruby client: I've already made changes to it
- Java client: it uses the inventory API code, so it should not require any
change
- Go client: does not use inventory (?)
- Python client: does not use inventory (?)
- I'm now having a look at WF & openshift agents
Do you see anything else?
Joel
2:49 a.m.
New subject: Future change in Inventory REST API - impacted clients?
I think that ruby test suite should be enough.
But just in case, before to submit the change it could be good if ManageIQ tests are
passing.
Some ManageIQ code use the wrapped json code brought by the ruby client.
I guess that if the middleware_*.spec are passing we are fine.
Lucas
----- Mensaje original -----
De: "Joel Takvorian" <jtakvori(a)redhat.com>
Para: "Discussions around Hawkular development"
<hawkular-dev(a)lists.jboss.org>
Enviados: Martes, 22 de Noviembre 2016 9:47:22
Asunto: [Hawkular-dev] Future change in Inventory REST API - impacted clients?
Hi,
There is a small upcoming change in the Inventory REST API which consists in
removing a deprecated field, as explained in this JIRA:
https://issues.jboss.org/browse/HWKINVENT-200
Basically, "type" has been replaced with "metricDataType" a while ago
and
made deprecated, now it's going to be removed. Probably not for the next
release, but for the one after. Meanwhile I'd like to check any existing
usage. What are the potential usages?
- Ruby client: I've already made changes to it
- Java client: it uses the inventory API code, so it should not require any
change
- Go client: does not use inventory (?)
- Python client: does not use inventory (?)
- I'm now having a look at WF & openshift agents
Do you see anything else?
Joel
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev
2:50 a.m.
New subject: Future change in Inventory REST API - impacted clients?
Also, I mean a *live* test from middleware_*.spec to the new changes.
ManageIQ uses recorded cassettes with old versions of Hawkular Services.
Lucas
----- Mensaje original -----
De: "Lucas Ponce" <lponce(a)redhat.com>
Para: "Discussions around Hawkular development"
<hawkular-dev(a)lists.jboss.org>
Enviados: Martes, 22 de Noviembre 2016 9:49:21
Asunto: Re: [Hawkular-dev] Future change in Inventory REST API - impacted clients?
I think that ruby test suite should be enough.
But just in case, before to submit the change it could be good if ManageIQ
tests are passing.
Some ManageIQ code use the wrapped json code brought by the ruby client.
I guess that if the middleware_*.spec are passing we are fine.
Lucas
----- Mensaje original -----
> De: "Joel Takvorian" <jtakvori(a)redhat.com>
> Para: "Discussions around Hawkular development"
> <hawkular-dev(a)lists.jboss.org>
> Enviados: Martes, 22 de Noviembre 2016 9:47:22
> Asunto: [Hawkular-dev] Future change in Inventory REST API - impacted
> clients?
>
> Hi,
>
> There is a small upcoming change in the Inventory REST API which consists
> in
> removing a deprecated field, as explained in this JIRA:
> https://issues.jboss.org/browse/HWKINVENT-200
>
> Basically, "type" has been replaced with "metricDataType" a
while ago and
> made deprecated, now it's going to be removed. Probably not for the next
> release, but for the one after. Meanwhile I'd like to check any existing
> usage. What are the potential usages?
>
> - Ruby client: I've already made changes to it
> - Java client: it uses the inventory API code, so it should not require any
> change
> - Go client: does not use inventory (?)
> - Python client: does not use inventory (?)
> - I'm now having a look at WF & openshift agents
>
> Do you see anything else?
>
> Joel
>
> _______________________________________________
> hawkular-dev mailing list
> hawkular-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hawkular-dev
>
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev
3:26 a.m.
Gracias Lucas
I'm going to try testing manageiq's middleware spec... will probably ask
for some help :)
On Tue, Nov 22, 2016 at 9:50 AM, Lucas Ponce <lponce(a)redhat.com> wrote:
Also, I mean a *live* test from middleware_*.spec to the new
changes.
ManageIQ uses recorded cassettes with old versions of Hawkular Services.
Lucas
----- Mensaje original -----
> De: "Lucas Ponce" <lponce(a)redhat.com>
> Para: "Discussions around Hawkular development" <
hawkular-dev(a)lists.jboss.org>
> Enviados: Martes, 22 de Noviembre 2016 9:49:21
> Asunto: Re: [Hawkular-dev] Future change in Inventory REST API -
impacted clients?
>
> I think that ruby test suite should be enough.
>
> But just in case, before to submit the change it could be good if
ManageIQ
> tests are passing.
>
> Some ManageIQ code use the wrapped json code brought by the ruby client.
>
> I guess that if the middleware_*.spec are passing we are fine.
>
> Lucas
>
> ----- Mensaje original -----
> > De: "Joel Takvorian" <jtakvori(a)redhat.com>
> > Para: "Discussions around Hawkular development"
> > <hawkular-dev(a)lists.jboss.org>
> > Enviados: Martes, 22 de Noviembre 2016 9:47:22
> > Asunto: [Hawkular-dev] Future change in Inventory REST API - impacted
> > clients?
> >
> > Hi,
> >
> > There is a small upcoming change in the Inventory REST API which
consists
> > in
> > removing a deprecated field, as explained in this JIRA:
> > https://issues.jboss.org/browse/HWKINVENT-200
> >
> > Basically, "type" has been replaced with "metricDataType" a
while ago
and
> > made deprecated, now it's going to be removed. Probably not for the
next
> > release, but for the one after. Meanwhile I'd like to check any
existing
> > usage. What are the potential usages?
> >
> > - Ruby client: I've already made changes to it
> > - Java client: it uses the inventory API code, so it should not
require any
> > change
> > - Go client: does not use inventory (?)
> > - Python client: does not use inventory (?)
> > - I'm now having a look at WF & openshift agents
> >
> > Do you see anything else?
> >
> > Joel
> >
> > _______________________________________________
> > hawkular-dev mailing list
> > hawkular-dev(a)lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/hawkular-dev
> >
> _______________________________________________
> hawkular-dev mailing list
> hawkular-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hawkular-dev
>
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev
7:15 a.m.
Hi Joel,
There are a couple of listeners in the services code that use
inventory. I took a look and I think they are OK but you may want to
make sure this like is OK:
https://github.com/hawkular/hawkular-services/blob/master/hawkular-rest/h...
On 11/22/2016 4:26 AM, Joel Takvorian wrote:
Gracias Lucas
I'm going to try testing manageiq's middleware spec... will probably
ask for some help :)
On Tue, Nov 22, 2016 at 9:50 AM, Lucas Ponce <lponce(a)redhat.com
<mailto:lponce@redhat.com>> wrote:
Also, I mean a *live* test from middleware_*.spec to the new changes.
ManageIQ uses recorded cassettes with old versions of Hawkular
Services.
Lucas
----- Mensaje original -----
> De: "Lucas Ponce" <lponce(a)redhat.com
<mailto:lponce@redhat.com>>
> Para: "Discussions around Hawkular development"
<hawkular-dev(a)lists.jboss.org
<mailto:hawkular-dev@lists.jboss.org>>
> Enviados: Martes, 22 de Noviembre 2016 9:49:21
> Asunto: Re: [Hawkular-dev] Future change in Inventory REST API
- impacted clients?
>
> I think that ruby test suite should be enough.
>
> But just in case, before to submit the change it could be good
if ManageIQ
> tests are passing.
>
> Some ManageIQ code use the wrapped json code brought by the ruby
client.
>
> I guess that if the middleware_*.spec are passing we are fine.
>
> Lucas
>
> ----- Mensaje original -----
> > De: "Joel Takvorian" <jtakvori(a)redhat.com
<mailto:jtakvori@redhat.com>>
> > Para: "Discussions around Hawkular development"
> > <hawkular-dev(a)lists.jboss.org
<mailto:hawkular-dev@lists.jboss.org>>
> > Enviados: Martes, 22 de Noviembre 2016 9:47:22
> > Asunto: [Hawkular-dev] Future change in Inventory REST API -
impacted
> > clients?
> >
> > Hi,
> >
> > There is a small upcoming change in the Inventory REST API
which consists
> > in
> > removing a deprecated field, as explained in this JIRA:
> > https://issues.jboss.org/browse/HWKINVENT-200
<https://issues.jboss.org/browse/HWKINVENT-200>
> >
> > Basically, "type" has been replaced with
"metricDataType" a
while ago and
> > made deprecated, now it's going to be removed. Probably not
for the next
> > release, but for the one after. Meanwhile I'd like to check
any existing
> > usage. What are the potential usages?
> >
> > - Ruby client: I've already made changes to it
> > - Java client: it uses the inventory API code, so it should
not require any
> > change
> > - Go client: does not use inventory (?)
> > - Python client: does not use inventory (?)
> > - I'm now having a look at WF & openshift agents
> >
> > Do you see anything else?
> >
> > Joel
> >
> > _______________________________________________
> > hawkular-dev mailing list
> > hawkular-dev(a)lists.jboss.org <mailto:hawkular-dev@lists.jboss.org>
> > https://lists.jboss.org/mailman/listinfo/hawkular-dev
<https://lists.jboss.org/mailman/listinfo/hawkular-dev>
> >
> _______________________________________________
> hawkular-dev mailing list
> hawkular-dev(a)lists.jboss.org <mailto:hawkular-dev@lists.jboss.org>
> https://lists.jboss.org/mailman/listinfo/hawkular-dev
<https://lists.jboss.org/mailman/listinfo/hawkular-dev>
>
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org <mailto:hawkular-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/hawkular-dev
<https://lists.jboss.org/mailman/listinfo/hawkular-dev>
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev
7:47 a.m.
It looks good, too. As long as it's using the java api, it should be fine.
On Tue, Nov 22, 2016 at 2:15 PM, Jay Shaughnessy <jshaughn(a)redhat.com>
wrote:
Hi Joel,
There are a couple of listeners in the services code that use inventory.
I took a look and I think they are OK but you may want to make sure this
like is OK:
https://github.com/hawkular/hawkular-services/blob/master/
hawkular-rest/hawkular-listener/src/main/java/org/hawkular/listener/cache/
BackfillCacheManager.java#L397
On 11/22/2016 4:26 AM, Joel Takvorian wrote:
Gracias Lucas
I'm going to try testing manageiq's middleware spec... will probably ask
for some help :)
On Tue, Nov 22, 2016 at 9:50 AM, Lucas Ponce <lponce(a)redhat.com> wrote:
> Also, I mean a *live* test from middleware_*.spec to the new changes.
>
> ManageIQ uses recorded cassettes with old versions of Hawkular Services.
>
> Lucas
>
> ----- Mensaje original -----
> > De: "Lucas Ponce" <lponce(a)redhat.com>
> > Para: "Discussions around Hawkular development" <
> hawkular-dev(a)lists.jboss.org>
> > Enviados: Martes, 22 de Noviembre 2016 9:49:21
> > Asunto: Re: [Hawkular-dev] Future change in Inventory REST API -
> impacted clients?
> >
> > I think that ruby test suite should be enough.
> >
> > But just in case, before to submit the change it could be good if
> ManageIQ
> > tests are passing.
> >
> > Some ManageIQ code use the wrapped json code brought by the ruby client.
> >
> > I guess that if the middleware_*.spec are passing we are fine.
> >
> > Lucas
> >
> > ----- Mensaje original -----
> > > De: "Joel Takvorian" <jtakvori(a)redhat.com>
> > > Para: "Discussions around Hawkular development"
> > > <hawkular-dev(a)lists.jboss.org>
> > > Enviados: Martes, 22 de Noviembre 2016 9:47:22
> > > Asunto: [Hawkular-dev] Future change in Inventory REST API - impacted
> > > clients?
> > >
> > > Hi,
> > >
> > > There is a small upcoming change in the Inventory REST API which
> consists
> > > in
> > > removing a deprecated field, as explained in this JIRA:
> > > https://issues.jboss.org/browse/HWKINVENT-200
> > >
> > > Basically, "type" has been replaced with
"metricDataType" a while ago
> and
> > > made deprecated, now it's going to be removed. Probably not for the
> next
> > > release, but for the one after. Meanwhile I'd like to check any
> existing
> > > usage. What are the potential usages?
> > >
> > > - Ruby client: I've already made changes to it
> > > - Java client: it uses the inventory API code, so it should not
> require any
> > > change
> > > - Go client: does not use inventory (?)
> > > - Python client: does not use inventory (?)
> > > - I'm now having a look at WF & openshift agents
> > >
> > > Do you see anything else?
> > >
> > > Joel
> > >
> > > _______________________________________________
> > > hawkular-dev mailing list
> > > hawkular-dev(a)lists.jboss.org
> > > https://lists.jboss.org/mailman/listinfo/hawkular-dev
> > >
> > _______________________________________________
> > hawkular-dev mailing list
> > hawkular-dev(a)lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/hawkular-dev
> >
> _______________________________________________
> hawkular-dev mailing list
> hawkular-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hawkular-dev
>
_______________________________________________
hawkular-dev mailing
listhawkular-dev@lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/hawkular-dev
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev
2726
days inactive
2726
days old
5 comments
3 participants
participants (3)
-
Jay Shaughnessy -
Joel Takvorian -
Lucas Ponce